p15670423
/
monkey
1
0
Fork 5
Code Issues Pull Requests 3 Projects Releases Wiki Activity

Island: Add note to fix duplication of Credentials in database

This commit is contained in:
Ilija Lazoroski 2022-07-08 17:50:18 +02:00
parent 45a6693263
commit c808d50948
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
monkey/monkey_island/cc/repository/mongo_credentials_repository.py
View File

@ -30,6 +30,7 @@ class MongoCredentialsRepository(ICredentialsRepository):
for c in list_stolen_credentials: for c in list_stolen_credentials:
del c["_id"] del c["_id"]
stolen_credentials.append(Credentials.from_mapping(c)) stolen_credentials.append(Credentials.from_mapping(c))
return stolen_credentials return stolen_credentials
except Exception as err: except Exception as err:
raise RetrievalError(err) raise RetrievalError(err)
@ -44,6 +45,7 @@ class MongoCredentialsRepository(ICredentialsRepository):
raise err raise err
def save_configured_credentials(self, credentials: Sequence[Credentials]): def save_configured_credentials(self, credentials: Sequence[Credentials]):
# TODO: Fix deduplication of Credentials in mongo
try: try:
for c in credentials: for c in credentials:
mongo.db.configured_credentials.insert_one(Credentials.to_mapping(c)) mongo.db.configured_credentials.insert_one(Credentials.to_mapping(c))
@ -51,6 +53,7 @@ class MongoCredentialsRepository(ICredentialsRepository):
raise StorageError(err) raise StorageError(err)
def save_stolen_credentials(self, credentials: Sequence[Credentials]): def save_stolen_credentials(self, credentials: Sequence[Credentials]):
# TODO: Fix deduplication of Credentials in mongo
try: try:
for c in credentials: for c in credentials:
mongo.db.stolen_credentials.insert_one(Credentials.to_mapping(c)) mongo.db.stolen_credentials.insert_one(Credentials.to_mapping(c))

3
monkey/tests/unit_tests/monkey_island/cc/repository/test_mongo_credentials_repository.py
View File

@ -78,7 +78,6 @@ def test_mongo_repository_configured(fake_mongo):
] ]
mongo_repository = MongoCredentialsRepository() mongo_repository = MongoCredentialsRepository()
mongo_repository.save_configured_credentials(credentials) mongo_repository.save_configured_credentials(credentials)
actual_configured_credentials = mongo_repository.get_configured_credentials() actual_configured_credentials = mongo_repository.get_configured_credentials()
@ -99,7 +98,6 @@ def test_mongo_repository_stolen(fake_mongo):
configured_credentials = [Credentials.from_mapping(CREDENTIALS_DICT_2)] configured_credentials = [Credentials.from_mapping(CREDENTIALS_DICT_2)]
mongo_repository = MongoCredentialsRepository() mongo_repository = MongoCredentialsRepository()
mongo_repository.save_configured_credentials(configured_credentials) mongo_repository.save_configured_credentials(configured_credentials)
mongo_repository.save_stolen_credentials(stolen_credentials) mongo_repository.save_stolen_credentials(stolen_credentials)
@ -127,7 +125,6 @@ def test_mongo_repository_all(fake_mongo):
] ]
mongo_repository = MongoCredentialsRepository() mongo_repository = MongoCredentialsRepository()
mongo_repository.save_configured_credentials(configured_credentials) mongo_repository.save_configured_credentials(configured_credentials)
mongo_repository.save_stolen_credentials(stolen_credentials) mongo_repository.save_stolen_credentials(stolen_credentials)