From 197dd4b8f12164f6acebb3b959f9ac2040a40400 Mon Sep 17 00:00:00 2001 From: Tim Graham Date: Tue, 10 Feb 2015 12:02:47 -0500 Subject: [PATCH] Prevented some test commands from needlessly running system checks. This is a performance optimization and also fixes test errors with the upcoming merge of contrib tests into tests/. The tests failed on MySQL because the models with GeometryField were being checked but the non-GIS MySQL backend didn't know how to handle them. --- django/contrib/auth/tests/test_management.py | 2 ++ tests/admin_scripts/tests.py | 1 + tests/user_commands/tests.py | 10 +++++++++- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/django/contrib/auth/tests/test_management.py b/django/contrib/auth/tests/test_management.py index 6a395bbe7b..cb785ba8fd 100644 --- a/django/contrib/auth/tests/test_management.py +++ b/django/contrib/auth/tests/test_management.py @@ -334,6 +334,7 @@ class CreatesuperuserManagementCommandTestCase(TestCase): """ sentinel = object() command = createsuperuser.Command() + command.check = lambda: [] command.execute( stdin=sentinel, stdout=six.StringIO(), @@ -346,6 +347,7 @@ class CreatesuperuserManagementCommandTestCase(TestCase): self.assertIs(command.stdin, sentinel) command = createsuperuser.Command() + command.check = lambda: [] command.execute( stdout=six.StringIO(), stderr=six.StringIO(), diff --git a/tests/admin_scripts/tests.py b/tests/admin_scripts/tests.py index 319bd47407..151498cc26 100644 --- a/tests/admin_scripts/tests.py +++ b/tests/admin_scripts/tests.py @@ -1577,6 +1577,7 @@ class CommandTypes(AdminScriptTestCase): being executed (#21255). """ command = BaseCommand(stderr=StringIO()) + command.check = lambda: [] command.handle = lambda *args, **kwargs: args with mock.patch('django.core.management.base.connections') as mock_connections: command.run_from_argv(['', '']) diff --git a/tests/user_commands/tests.py b/tests/user_commands/tests.py index 35de5367ca..eb3b86bd38 100644 --- a/tests/user_commands/tests.py +++ b/tests/user_commands/tests.py @@ -5,7 +5,7 @@ from django.core import management from django.core.management import BaseCommand, CommandError, find_commands from django.core.management.utils import find_command, popen_wrapper from django.db import connection -from django.test import SimpleTestCase, ignore_warnings +from django.test import SimpleTestCase, ignore_warnings, override_settings from django.test.utils import captured_stderr, captured_stdout, extend_sys_path from django.utils import translation from django.utils._os import upath @@ -13,6 +13,14 @@ from django.utils.deprecation import RemovedInDjango20Warning from django.utils.six import StringIO +# A minimal set of apps to avoid system checks running on all apps. +@override_settings( + INSTALLED_APPS=[ + 'django.contrib.auth', + 'django.contrib.contenttypes', + 'user_commands', + ], +) class CommandTests(SimpleTestCase): def test_command(self): out = StringIO()