From 1eb2ff3ff75b0f08276e0c3e10c99ed111572d8c Mon Sep 17 00:00:00 2001 From: Tim Graham Date: Thu, 29 Oct 2015 17:12:28 -0400 Subject: [PATCH] [1.9.x] Fixed #25290 -- Warned against modifying objects created in setUpTestData() in tests. Backport of 81006b9657534a21c3eadb2bc4a87c46db54c099 from master --- docs/topics/testing/tools.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/topics/testing/tools.txt b/docs/topics/testing/tools.txt index 8c502d6c2e..f1667f757e 100644 --- a/docs/topics/testing/tools.txt +++ b/docs/topics/testing/tools.txt @@ -806,6 +806,12 @@ additions, including: (for instance, MySQL with the MyISAM engine), ``setUpTestData()`` will be called before each test, negating the speed benefits. + Be careful not to modify any objects created in ``setUpTestData()`` in + your test methods. Modifications to in-memory objects from setup work done + at the class level will persist between test methods. If you do need to + modify them, you could reload them in the ``setUp()`` method with + :meth:`~django.db.models.Model.refresh_from_db`, for example. + .. warning:: If you want to test some specific database transaction behavior, you should