p15693087
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Removed unused ForeignObjectRel.get_choices() limit_to_currently_related argument. 

Unused since its introduction in dc334a2ba8.
This commit is contained in:
Tim Graham 2016-04-14 21:26:11 -04:00
parent 5e1d45b1ca
commit 2da7f5afcf
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
django/db/models/fields/reverse_related.py
View File

@ -130,8 +130,7 @@ class ForeignObjectRel(object):
self.related_model._meta.model_name,
)
def get_choices(self, include_blank=True, blank_choice=BLANK_CHOICE_DASH,
limit_to_currently_related=False):
def get_choices(self, include_blank=True, blank_choice=BLANK_CHOICE_DASH):
"""
Return choices with a default blank choices included, for use as
SelectField choices for this field.
@ -139,14 +138,9 @@ class ForeignObjectRel(object):
Analog of django.db.models.fields.Field.get_choices(), provided
initially for utilization by RelatedFieldListFilter.
"""
first_choice = blank_choice if include_blank else []
queryset = self.related_model._default_manager.all()
if limit_to_currently_related:
queryset = queryset.complex_filter(
{'%s__isnull' % self.related_model._meta.model_name: False}
)
lst = [(x._get_pk_val(), smart_text(x)) for x in queryset]
return first_choice + lst
return (blank_choice if include_blank else []) + [
(x._get_pk_val(), smart_text(x)) for x in self.related_model._default_manager.all()
]
def get_db_prep_lookup(self, lookup_type, value, connection, prepared=False):
# Defer to the actual field definition for db prep