Refs #29198 -- Fixed migrate --plan crash if RunSQL uses a list or tuple.
Also fixed test failures if sqlparse isn't installed.
This commit is contained in:
parent
c99d379f53
commit
495abe0095
|
@ -344,7 +344,7 @@ class Command(BaseCommand):
|
|||
action = 'IRREVERSIBLE'
|
||||
is_error = True
|
||||
else:
|
||||
action = action.replace('\n', '')
|
||||
action = str(action).replace('\n', '')
|
||||
is_error = False
|
||||
if action:
|
||||
action = ' -> ' + action
|
||||
|
|
|
@ -20,6 +20,11 @@ from .models import UnicodeModel, UnserializableModel
|
|||
from .routers import TestRouter
|
||||
from .test_base import MigrationTestBase
|
||||
|
||||
try:
|
||||
import sqlparse
|
||||
except ImportError:
|
||||
sqlparse = None
|
||||
|
||||
|
||||
class MigrateTests(MigrationTestBase):
|
||||
"""
|
||||
|
@ -311,10 +316,10 @@ class MigrateTests(MigrationTestBase):
|
|||
' Raw Python operation -> Grow salamander tail.\n'
|
||||
'migrations.0002_second\n'
|
||||
' Create model Book\n'
|
||||
' Raw SQL operation -> SELECT * FROM migrations_book\n'
|
||||
" Raw SQL operation -> ['SELECT * FROM migrations_book']\n"
|
||||
'migrations.0003_third\n'
|
||||
' Create model Author\n'
|
||||
' Raw SQL operation -> SELECT * FROM migrations_author\n',
|
||||
" Raw SQL operation -> ['SELECT * FROM migrations_author']\n",
|
||||
out.getvalue()
|
||||
)
|
||||
# Migrate to the third migration.
|
||||
|
@ -334,10 +339,10 @@ class MigrateTests(MigrationTestBase):
|
|||
'Planned operations:\n'
|
||||
'migrations.0003_third\n'
|
||||
' Undo Create model Author\n'
|
||||
' Raw SQL operation -> SELECT * FROM migrations_book\n'
|
||||
" Raw SQL operation -> ['SELECT * FROM migrations_book']\n"
|
||||
'migrations.0002_second\n'
|
||||
' Undo Create model Book\n'
|
||||
' Raw SQL operation -> SELECT * FROM migrations_salamander\n',
|
||||
" Raw SQL operation -> ['SELECT * FROM migrations_salamand…\n",
|
||||
out.getvalue()
|
||||
)
|
||||
out = io.StringIO()
|
||||
|
@ -349,10 +354,13 @@ class MigrateTests(MigrationTestBase):
|
|||
' Raw SQL operation -> SELECT * FROM migrations_author WHE…\n',
|
||||
out.getvalue()
|
||||
)
|
||||
# Show the plan when an operation is irreversible.
|
||||
# Migration 0004's RunSQL uses a SQL string instead of a list, so
|
||||
# sqlparse may be required for splitting.
|
||||
if sqlparse or not connection.features.requires_sqlparse_for_splitting:
|
||||
# Migrate to the fourth migration.
|
||||
call_command('migrate', 'migrations', '0004', verbosity=0)
|
||||
out = io.StringIO()
|
||||
# Show the plan when an operation is irreversible.
|
||||
call_command('migrate', 'migrations', '0003', plan=True, stdout=out, no_color=True)
|
||||
self.assertEqual(
|
||||
'Planned operations:\n'
|
||||
|
|
|
@ -15,6 +15,6 @@ class Migration(migrations.Migration):
|
|||
('id', models.AutoField(primary_key=True)),
|
||||
],
|
||||
),
|
||||
migrations.RunSQL('SELECT * FROM migrations_book', 'SELECT * FROM migrations_salamander')
|
||||
migrations.RunSQL(['SELECT * FROM migrations_book'], ['SELECT * FROM migrations_salamander'])
|
||||
|
||||
]
|
||||
|
|
|
@ -15,5 +15,5 @@ class Migration(migrations.Migration):
|
|||
('id', models.AutoField(primary_key=True)),
|
||||
],
|
||||
),
|
||||
migrations.RunSQL('SELECT * FROM migrations_author', 'SELECT * FROM migrations_book')
|
||||
migrations.RunSQL(['SELECT * FROM migrations_author'], ['SELECT * FROM migrations_book'])
|
||||
]
|
||||
|
|
Loading…
Reference in New Issue