From 5f456408a0f52dc16f627d4a89ced5f52c36ad2f Mon Sep 17 00:00:00 2001 From: Tim Graham Date: Tue, 2 Jan 2018 10:11:48 -0500 Subject: [PATCH] Refs #28930 -- Simplified schemas test with any(). --- tests/schema/tests.py | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tests/schema/tests.py b/tests/schema/tests.py index fd66bf20ba..cc2d5384f8 100644 --- a/tests/schema/tests.py +++ b/tests/schema/tests.py @@ -1469,10 +1469,7 @@ class SchemaTests(TransactionTestCase): editor.create_model(Author) # Ensure the constraint exists constraints = self.get_constraints(Author._meta.db_table) - for details in constraints.values(): - if details['columns'] == ["height"] and details['check']: - break - else: + if not any(details['columns'] == ['height'] and details['check'] for details in constraints.values()): self.fail("No check constraint for height found") # Alter the column to remove it old_field = Author._meta.get_field("height") @@ -1489,10 +1486,7 @@ class SchemaTests(TransactionTestCase): with connection.schema_editor() as editor: editor.alter_field(Author, new_field, new_field2, strict=True) constraints = self.get_constraints(Author._meta.db_table) - for details in constraints.values(): - if details['columns'] == ["height"] and details['check']: - break - else: + if not any(details['columns'] == ['height'] and details['check'] for details in constraints.values()): self.fail("No check constraint for height found") def test_unique(self):