From 909015a51b98749cabb0d13f8ea0bf58ec707fa3 Mon Sep 17 00:00:00 2001 From: Claude Paroz Date: Fri, 29 Aug 2014 10:22:59 +0200 Subject: [PATCH] Fixed #22786 -- Documented value_from_datadict caveat Thanks blueyed for the report and Tim Graham for the review. --- docs/ref/forms/widgets.txt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/ref/forms/widgets.txt b/docs/ref/forms/widgets.txt index a2245a5ffa..242a77110f 100644 --- a/docs/ref/forms/widgets.txt +++ b/docs/ref/forms/widgets.txt @@ -230,7 +230,12 @@ foundation for custom widgets. .. method:: value_from_datadict(data, files, name) Given a dictionary of data and this widget's name, returns the value - of this widget. Returns ``None`` if a value wasn't provided. + of this widget. ``files`` may contain data coming from + :attr:`request.FILES `. Returns ``None`` + if a value wasn't provided. Note also that ``value_from_datadict`` may + be called more than once during handling of form data, so if you + customize it and add expensive processing, you should implement some + caching mechanism yourself. .. class:: MultiWidget(widgets, attrs=None)