From a9be1dc5515e99ed96a2c640f5495af419c85b93 Mon Sep 17 00:00:00 2001 From: Simon Charette Date: Wed, 17 Aug 2022 19:21:10 -0400 Subject: [PATCH] Refs #33928 -- Removed unnecessary attribute assignment on on-delete updates. Model instances retrieved for bulk field update purposes are not exposed to the outside world and thus are not required to be kept update to date. --- django/db/models/deletion.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/django/db/models/deletion.py b/django/db/models/deletion.py index 2cb3c88444..631b455aa3 100644 --- a/django/db/models/deletion.py +++ b/django/db/models/deletion.py @@ -497,11 +497,6 @@ class Collector: origin=self.origin, ) - # update collected instances - for instances_for_fieldvalues in self.field_updates.values(): - for (field, value), instances in instances_for_fieldvalues.items(): - for obj in instances: - setattr(obj, field.attname, value) for model, instances in self.data.items(): for instance in instances: setattr(instance, model._meta.pk.attname, None)