From aba8f2b5017a95c84bdf4bae9d2e889fc53a9c34 Mon Sep 17 00:00:00 2001
From: Tim Graham <timograham@gmail.com>
Date: Thu, 13 Oct 2016 11:02:02 -0400
Subject: [PATCH] [1.8.x] Fixed #27342 -- Corrected QuerySet.update_or_create()
example.
Backport of 51b83d9e5113ea5b81d04f4d117bd5acd3c1b822 from master
---
docs/ref/models/querysets.txt | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/docs/ref/models/querysets.txt b/docs/ref/models/querysets.txt
index 0eee8fcc48..9d45f0193f 100644
--- a/docs/ref/models/querysets.txt
+++ b/docs/ref/models/querysets.txt
@@ -1795,21 +1795,25 @@ the given ``kwargs``. If a match is found, it updates the fields passed in the
This is meant as a shortcut to boilerplatish code. For example::
+ defaults = {'first_name': 'Bob'}
try:
obj = Person.objects.get(first_name='John', last_name='Lennon')
- for key, value in updated_values.iteritems():
+ for key, value in defaults.items():
setattr(obj, key, value)
obj.save()
except Person.DoesNotExist:
- updated_values.update({'first_name': 'John', 'last_name': 'Lennon'})
- obj = Person(**updated_values)
+ new_values = {'first_name': 'John', 'last_name': 'Lennon'}
+ new_values.update(defaults)
+ obj = Person(**new_values)
obj.save()
This pattern gets quite unwieldy as the number of fields in a model goes up.
The above example can be rewritten using ``update_or_create()`` like so::
obj, created = Person.objects.update_or_create(
- first_name='John', last_name='Lennon', defaults=updated_values)
+ first_name='John', last_name='Lennon',
+ defaults={'first_name': 'Bob'},
+ )
For detailed description how names passed in ``kwargs`` are resolved see
:meth:`get_or_create`.