p15693087
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Removed DatabaseFeatures.validates_explain_options. 

Always True since 6723a26e59.
This commit is contained in:
Mariusz Felisiak 2022-04-11 12:58:01 +02:00 committed by GitHub
parent b54fd0e36e
commit b8759093d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
django/db/backends/base/features.py
View File

@ -263,10 +263,6 @@ class BaseDatabaseFeatures:
# What formats does the backend EXPLAIN syntax support? # What formats does the backend EXPLAIN syntax support?
supported_explain_formats = set() supported_explain_formats = set()
# Does DatabaseOperations.explain_query_prefix() raise ValueError if
# unknown kwargs are passed to QuerySet.explain()?
validates_explain_options = True
# Does the backend support the default parameter in lead() and lag()? # Does the backend support the default parameter in lead() and lag()?
supports_default_in_lead_lag = True supports_default_in_lead_lag = True

1
tests/queries/test_explain.py
View File

@ -57,7 +57,6 @@ class ExplainTests(TestCase):
f"QuerySet.explain() result is not valid JSON: {e}" f"QuerySet.explain() result is not valid JSON: {e}"
) )
@skipUnlessDBFeature("validates_explain_options")
def test_unknown_options(self): def test_unknown_options(self):
with self.assertRaisesMessage(ValueError, "Unknown options: TEST, TEST2"): with self.assertRaisesMessage(ValueError, "Unknown options: TEST, TEST2"):
Tag.objects.explain(**{"TEST": 1, "TEST2": 1}) Tag.objects.explain(**{"TEST": 1, "TEST2": 1})