p15693087
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed #8963 -- Use the require_POST decorator instead of doing things manually in one of the comment views. Thanks, zgoda. 

git-svn-id: http://code.djangoproject.com/svn/django/trunk@9121 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Malcolm Tredinnick 2008-10-05 05:10:35 +00:00
parent 645029accb
commit cff78c60ac
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
django/contrib/comments/views/comments.py
View File

@ -7,6 +7,7 @@ from django.shortcuts import render_to_response
from django.template import RequestContext from django.template import RequestContext
from django.template.loader import render_to_string from django.template.loader import render_to_string
from django.utils.html import escape from django.utils.html import escape
from django.views.decorators.http import require_POST
from django.contrib import comments from django.contrib import comments
from django.contrib.comments import signals from django.contrib.comments import signals
@ -28,11 +29,6 @@ def post_comment(request, next=None):
HTTP POST is required. If ``POST['submit'] == "preview"`` or if there are HTTP POST is required. If ``POST['submit'] == "preview"`` or if there are
errors a preview template, ``comments/preview.html``, will be rendered. errors a preview template, ``comments/preview.html``, will be rendered.
""" """
# Require POST
if request.method != 'POST':
return http.HttpResponseNotAllowed(["POST"])
# Fill out some initial data fields from an authenticated user, if present # Fill out some initial data fields from an authenticated user, if present
data = request.POST.copy() data = request.POST.copy()
if request.user.is_authenticated(): if request.user.is_authenticated():
@ -116,6 +112,8 @@ def post_comment(request, next=None):
return next_redirect(data, next, comment_done, c=comment._get_pk_val()) return next_redirect(data, next, comment_done, c=comment._get_pk_val())
post_comment = require_POST(post_comment)
comment_done = confirmation_view( comment_done = confirmation_view(
template = "comments/posted.html", template = "comments/posted.html",
doc = """Display a "comment was posted" success page.""" doc = """Display a "comment was posted" success page."""