p15693087
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed #27417 -- Made RenameField operation a noop for field name case changes on Oracle. 

Field names are always uppercased in the Oracle backend. Changing case
should be a noop to avoid database errors: "ORA-00957: duplicate column
name".
This commit is contained in:
Mariusz Felisiak 2020-09-04 20:27:23 +02:00 committed by GitHub
parent 17407eca59
commit e6b5108acc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django/db/backends/base/schema.py
View File

@ -1045,7 +1045,7 @@ class BaseDatabaseSchemaEditor:
old_kwargs.pop('db_column', None) old_kwargs.pop('db_column', None)
new_kwargs.pop('db_column', None) new_kwargs.pop('db_column', None)
return ( return (
old_field.column != new_field.column or self.quote_name(old_field.column) != self.quote_name(new_field.column) or
(old_path, old_args, old_kwargs) != (new_path, new_args, new_kwargs) (old_path, old_args, old_kwargs) != (new_path, new_args, new_kwargs)
) )

22
tests/migrations/test_operations.py
View File

@ -1727,6 +1727,28 @@ class OperationTests(OperationTestBase):
operation.database_backwards('test_rfwdbc', editor, new_state, project_state) operation.database_backwards('test_rfwdbc', editor, new_state, project_state)
self.assertColumnExists('test_rfwdbc_pony', 'db_fk_field') self.assertColumnExists('test_rfwdbc_pony', 'db_fk_field')
def test_rename_field_case(self):
project_state = self.apply_operations('test_rfmx', ProjectState(), operations=[
migrations.CreateModel('Pony', fields=[
('id', models.AutoField(primary_key=True)),
('field', models.IntegerField()),
]),
])
new_state = project_state.clone()
operation = migrations.RenameField('Pony', 'field', 'FiElD')
operation.state_forwards('test_rfmx', new_state)
self.assertIn('FiElD', new_state.models['test_rfmx', 'pony'].fields)
self.assertColumnExists('test_rfmx_pony', 'field')
with connection.schema_editor() as editor:
operation.database_forwards('test_rfmx', editor, project_state, new_state)
self.assertColumnExists(
'test_rfmx_pony',
connection.introspection.identifier_converter('FiElD'),
)
with connection.schema_editor() as editor:
operation.database_backwards('test_rfmx', editor, new_state, project_state)
self.assertColumnExists('test_rfmx_pony', 'field')
def test_rename_missing_field(self): def test_rename_missing_field(self):
state = ProjectState() state = ProjectState()
state.add_model(ModelState('app', 'model', [])) state.add_model(ModelState('app', 'model', []))