[3.0.x] Fixed #30776 -- Restored max length validation on AuthenticationForm.UsernameField.
Regression in5ceaf14686
. Thanks gopackgo90 for the report and Mariusz Felisiak for tests. Backport of6c9778a58e
from master
This commit is contained in:
parent
6c761a25fb
commit
e74ca0226a
|
@ -191,7 +191,9 @@ class AuthenticationForm(forms.Form):
|
|||
|
||||
# Set the max length and label for the "username" field.
|
||||
self.username_field = UserModel._meta.get_field(UserModel.USERNAME_FIELD)
|
||||
self.fields['username'].max_length = self.username_field.max_length or 254
|
||||
username_max_length = self.username_field.max_length or 254
|
||||
self.fields['username'].max_length = username_max_length
|
||||
self.fields['username'].widget.attrs['maxlength'] = username_max_length
|
||||
if self.fields['username'].label is None:
|
||||
self.fields['username'].label = capfirst(self.username_field.verbose_name)
|
||||
|
||||
|
|
|
@ -423,6 +423,7 @@ class AuthenticationFormTest(TestDataMixin, TestCase):
|
|||
CustomEmailField.objects.create_user(**data)
|
||||
form = AuthenticationForm(None, data)
|
||||
self.assertEqual(form.fields['username'].max_length, 255)
|
||||
self.assertEqual(form.fields['username'].widget.attrs.get('maxlength'), 255)
|
||||
self.assertEqual(form.errors, {})
|
||||
|
||||
@override_settings(AUTH_USER_MODEL='auth_tests.IntegerUsernameUser')
|
||||
|
@ -435,6 +436,7 @@ class AuthenticationFormTest(TestDataMixin, TestCase):
|
|||
IntegerUsernameUser.objects.create_user(**data)
|
||||
form = AuthenticationForm(None, data)
|
||||
self.assertEqual(form.fields['username'].max_length, 254)
|
||||
self.assertEqual(form.fields['username'].widget.attrs.get('maxlength'), 254)
|
||||
self.assertEqual(form.errors, {})
|
||||
|
||||
def test_username_field_label(self):
|
||||
|
|
Loading…
Reference in New Issue