From e7d7d47b93d23c8a17ab297d68ec23fa2c543955 Mon Sep 17 00:00:00 2001 From: Jon Dufresne Date: Tue, 10 Jul 2018 03:26:19 -0700 Subject: [PATCH] Fixed ResourceWarning from unclosed test files. When running Django tests with Python warnings enabled. --- tests/file_storage/tests.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/file_storage/tests.py b/tests/file_storage/tests.py index 3a21ca9046..6253036679 100644 --- a/tests/file_storage/tests.py +++ b/tests/file_storage/tests.py @@ -595,12 +595,14 @@ class OverwritingStorageTests(FileStorageTests): self.assertEqual(stored_name_1, name) self.assertTrue(self.storage.exists(name)) self.assertTrue(os.path.exists(os.path.join(self.temp_dir, name))) - self.assertEqual(self.storage.open(name).read(), content_1) + with self.storage.open(name) as fp: + self.assertEqual(fp.read(), content_1) stored_name_2 = self.storage.save(name, f_2) self.assertEqual(stored_name_2, name) self.assertTrue(self.storage.exists(name)) self.assertTrue(os.path.exists(os.path.join(self.temp_dir, name))) - self.assertEqual(self.storage.open(name).read(), content_2) + with self.storage.open(name) as fp: + self.assertEqual(fp.read(), content_2) finally: self.storage.delete(name)