p15693087
/
django
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Added guidelines for assertIs() usage.

This commit is contained in:
Mads Jensen 2019-12-22 11:23:46 +01:00 committed by Mariusz Felisiak
parent 9e14bc2135
commit ea44d86ed4
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docs/internals/contributing/writing-code/coding-style.txt
View File

@ -71,6 +71,11 @@ Python style
and :meth:`~unittest.TestCase.assertWarnsRegex` only if you need regular and :meth:`~unittest.TestCase.assertWarnsRegex` only if you need regular
expression matching. expression matching.
Use :meth:`assertIs(…, True/False)<unittest.TestCase.assertIs>` for testing
boolean values, rather than :meth:`~unittest.TestCase.assertTrue` and
:meth:`~unittest.TestCase.assertFalse`, so you can check the actual boolean
value, not the truthiness of the expression.
* In test docstrings, state the expected behavior that each test demonstrates. * In test docstrings, state the expected behavior that each test demonstrates.
Don't include preambles such as "Tests that" or "Ensures that". Don't include preambles such as "Tests that" or "Ensures that".