Jon Dufresne
7785e03ba8
Fixed #30137 -- Replaced OSError aliases with the canonical OSError.
...
Used more specific errors (e.g. FileExistsError) as appropriate.
2019-01-28 11:15:06 -05:00
Tim Graham
7444f32527
Refs #30055 -- Added a helpful error when SQLite is too old.
2019-01-28 11:14:45 -05:00
Jon Dufresne
7e3bf2662b
Removed default mode='r' argument from calls to open().
2019-01-27 17:41:43 -05:00
Jon Dufresne
ce7293bc91
Refs #23919 -- Replaced codecs.open() with open().
...
On Python 3, open() handles encodings.
2019-01-27 17:39:57 -05:00
Jon Dufresne
00b2e4b67c
Added missing assert in FileBasedCacheTests.test_creates_cache_dir_if_nonexistent().
2019-01-26 16:38:46 -05:00
Jon Dufresne
ac956dae1d
Fixed grammar in FakePayload exception message.
2019-01-25 08:43:21 -08:00
Hasan Ramezani
7e978fdc42
Completed test coverage for utils.text._replace_entity().
2019-01-23 19:33:21 -05:00
Nick Pope
0ef9979669
Fixed #30123 -- Removed tuple support in DatabaseIntrospection.get_field_type().
...
Support for returning tuples was undocumented and error prone.
2019-01-23 13:18:03 -05:00
Tim Graham
2de7eb6f4d
Refs #30111 -- Fixed test cleanup in postgres_tests/test_integration.py.
...
Fixed "ERROR: Step ‘Publish JUnit test result report’ failed: No test report
files were found. Configuration error?" on Jenkins because report files were
put in tests/postgres_tests.
2019-01-23 11:34:55 -05:00
Nasir Hussain
2804b8d215
Fixed #30111 -- Fixed AppRegistryNotReady error with django.contrib.postgres in INSTALLED_APPS.
...
Regression in e192223ed9
.
2019-01-22 17:49:30 -05:00
Vytis Banaitis
d02b2aa11e
Made assertOptimizesTo() more strict in migrations tests.
...
A recursive deconstruction is needed because comparing deconstructed
operations doesn't check field attributes. Fixed typo in failing test.
2019-01-21 17:29:46 -05:00
Tim Graham
2110b17924
Tested Model.set_FOO_order() with an unrelated object.
2019-01-21 17:02:15 -05:00
Jon Dufresne
d15c61cabb
Fixed #30121 -- Fixed assertURLEqual() crash with reverse_lazy() URLs.
...
Regression in 24959e48d9
.
2019-01-21 09:31:33 -05:00
Simon Charette
65858119d2
Fixed #30120 -- Fixed invalid SQL in distinct aggregate.
...
Regression in bc05547cd8
(refs #28658 ).
2019-01-21 09:24:32 -05:00
Hasan Ramezani
838e432e3e
Completed test coverage for utils.text.Truncator.chars().
2019-01-19 18:45:41 -05:00
Mariusz Felisiak
f05c02c4b8
Fixed #30117 -- Fixed SchemaEditor.quote_value() test for mysqlclient 1.4.0+.
2019-01-19 13:31:15 +01:00
Tim Graham
06670015f7
Increased the default PBKDF2 iterations for Django 3.0.
2019-01-17 11:15:27 -05:00
Tim Graham
f5060a1385
Advanced deprecation warnings for Django 3.0.
2019-01-17 11:15:27 -05:00
Tim Graham
da1de1615c
Refs #28750 -- Removed suppport for model Meta.manager_inheritance_from_future.
2019-01-17 11:15:27 -05:00
Tim Graham
6079ed82f4
Refs #27991 -- Made obj a required argument of InlineModelAdmin.has_add_permission().
...
Per deprecation timeline.
2019-01-17 11:14:07 -05:00
Tim Graham
92d4d0859a
Refs #21221 -- Removed staticfiles and admin_static template tag libraries.
...
Per deprecation timeline.
2019-01-17 10:52:19 -05:00
Tim Graham
958a7b4ca6
Refs #28965 -- Removed utils.http.cookie_date() per deprecation timeline.
2019-01-17 10:52:19 -05:00
Tim Graham
6f23996a59
Refs #28841 -- Removed ForceRHR function per deprecation timeline.
2019-01-17 10:52:19 -05:00
Tim Graham
1fecde6be9
Refs #11557 -- Removed the field_name keyword argument to QuerySet.earliest() and latest().
...
Per deprecation timeline.
2019-01-17 10:52:19 -05:00
Tim Graham
da5eb3d56c
Refs #28370 -- Removed support for the context arg of Field.from_db_value() and Expression.convert_value().
...
Per deprecation timeline.
2019-01-17 10:52:19 -05:00
Tim Graham
8045dff98c
Refs #27829 -- Removed settings.DEFAULT_CONTENT_TYPE per deprecation timeline.
2019-01-17 10:50:25 -05:00
Tim Graham
573ec714e5
Refs #25978 -- Removed shortcuts.render_to_response() per deprecation timeline.
2019-01-17 10:50:25 -05:00
Simon Charette
f84ad16ba4
Refs #17198 -- Detected existing total ordering in admin changelist.
...
Appending pk is not necessary when a subset of the ordering expressions is
contained in a non-nullable unique contraint.
Related field ordering through lookups and related ordering introspection is
omitted for simplicitly purpose.
2019-01-17 16:22:14 +01:00
Simon Charette
9e5e5a657b
Fixed #30044 -- Raised a FieldError on inherited field update attempts.
2019-01-16 14:09:51 -05:00
Santiago Basulto
4fc35a9c3e
Fixed #20147 -- Added HttpRequest.headers.
2019-01-16 13:38:47 -05:00
Simon Charette
aa5d0a5a90
Removed unnecessary transaction wrapping in expressions test.
2019-01-16 13:23:55 -05:00
Arthur Rio
181fb60159
Fixed #11154 , #22270 -- Made proxy model permissions use correct content type.
...
Co-Authored-By: Simon Charette <charette.s@gmail.com>
Co-Authored-By: Antoine Catton <acatton@fusionbox.com>
2019-01-16 10:07:28 -05:00
Collin Anderson
769355c765
Fixed #9475 -- Allowed RelatedManager.add(), create(), etc. for m2m with a through model.
2019-01-15 11:12:17 -05:00
Nasir Hussain
f021c110d0
Fixed #30099 -- Fixed invalid SQL when filtering a Subquery by an aggregate.
2019-01-15 07:22:59 -05:00
Mariusz Felisiak
1508e71c5b
Relaxed assertions to fix GIS test failures on Oracle 18c.
2019-01-14 18:32:42 -05:00
Simon Charette
b181aba7dd
Refs #28478 -- Prevented database feature based skipping on tests disallowing queries.
...
Database features may require a connection to be established to determine
whether or not they are enabled.
2019-01-14 16:16:30 -05:00
Simon Charette
f5b635086a
Refs #28478 -- Prevented connection attempts against disallowed databases in tests.
...
Mocking connect as well as cursor methods makes sure an appropriate error
message is surfaced when running a subset of test attempting to access a
a disallowed database.
2019-01-14 16:05:00 -05:00
Nick Pope
6d4efa8e6a
Refs #28643 -- Changed Variance() to use NumericOutputFieldMixin.
...
Keeps precision instead of forcing DecimalField to FloatField.
2019-01-14 14:39:46 -05:00
Nick Pope
e85afa5943
Refs #28643 -- Changed StdDev() to use NumericOutputFieldMixin.
...
Keeps precision instead of forcing DecimalField to FloatField.
2019-01-14 14:38:00 -05:00
Nick Pope
c690afb873
Refs #28643 -- Changed Avg() to use NumericOutputFieldMixin.
...
Keeps precision instead of forcing DecimalField to FloatField.
2019-01-14 14:35:41 -05:00
Sergey Fedoseev
b86bb47818
Fixed #30093 -- Fixed ordering of combined queryset ordered by F expressions.
2019-01-14 10:28:11 -05:00
Simon Charette
b2c598e30d
Removed unnecessary skipUnlessDBFeature.
...
None of the tests interact with the database.
2019-01-13 21:48:40 -05:00
Tom Forbes
c8720e7696
Fixed #27685 -- Added watchman support to the autoreloader.
...
Removed support for pyinotify (refs #9722 ).
2019-01-13 20:33:47 -05:00
Simon Charette
a02a6fd580
Refs #28478 -- Prevented connection creation in model_indexes tests.
...
Entering a SchemaEditor instance creates a connection but it isn't needed
for this test.
2019-01-13 13:47:08 -05:00
orlnub123
573f44d62f
Fixed #30057 -- Fixed diffsettings ignoring custom configured settings.
...
Regression in 49b679371f
.
2019-01-12 11:07:03 -05:00
Nick Pope
abf8e390a4
Refs #28643 -- Added Reverse database function.
...
Thanks Mariusz Felisiak for Oracle advice and review.
2019-01-12 10:45:48 -05:00
Paveł Tyślacki
b69f8eb04c
Fixed #30062 -- Added support for unique conditional constraints.
2019-01-12 09:50:20 -05:00
Paveł Tyślacki
f4c0c0b0aa
Added tests for Check/UniqueConstraint.__eq__().
2019-01-12 09:24:22 -05:00
can
e192223ed9
Fixed #29738 -- Allowed serializing psycopg2 range types in migrations.
2019-01-11 19:32:26 -05:00
can
7d3b3897c1
Refs #29738 -- Allowed registering serializers with MigrationWriter.
2019-01-11 18:13:16 -05:00
MaximZemskov
3c01fe30f3
Fixed #30097 -- Made 'obj' arg of InlineModelAdmin.has_add_permission() optional.
...
Restored backwards compatibility after refs #27991 .
Regression in be6ca89396
.
2019-01-11 18:02:43 -05:00
Tim Graham
8f4eee1777
Moved django.db.migrations.writer.SettingsReference to django.conf.
...
Reduces the possibility of circular imports.
2019-01-11 15:28:22 -05:00
Sanyam Khurana
76d31be2d0
Refs #23829 -- Made ping_google command/function use https for the sitemap URL.
2019-01-11 10:32:22 -05:00
Simon Charette
41e73de39d
Fixed #28478 -- Make DiscoverRunner skip creating unused test databases.
...
SimpleTestCase.databases makes it possible to determine the set of
databases required to run the discovered tests.
2019-01-10 19:11:21 -05:00
Simon Charette
8c775391b7
Refs #28478 -- Deprecated TestCase's allow_database_queries and multi_db in favor of databases.
2019-01-10 19:11:21 -05:00
Paveł Tyślacki
647be06538
Renamed variables after generalization of constraints.
...
Follow up to 8eae094638
.
2019-01-10 18:54:41 -05:00
Mads Jensen
4b9d72210f
Refs #28643 -- Added NullIf database function.
...
Thanks Nick Pope, Mariusz Felisiak, and Tim Graham for reviews.
2019-01-10 12:10:12 -05:00
Joshua Cannon
db1b10ef0d
Fixed #30037 -- Added request arg to RemoteUserBackend.configure_user().
2019-01-09 20:01:04 -05:00
Simon Charette
bc05547cd8
Fixed #28658 -- Added DISTINCT handling to the Aggregate class.
2019-01-09 17:52:36 -05:00
Benjy Weinberger
222caab68a
Fixed #30071 -- Fixed error message when a 'default' database isn't provided.
2019-01-09 10:58:37 -05:00
Benjy Weinberger
c2c85663e2
Fixed #30087 -- Tested error handling for empty 'default' database.
2019-01-09 10:58:25 -05:00
Nick Pope
a35d2a4510
Refs #23748 -- Added AutoField introspection for SQLite.
2019-01-09 09:59:15 -05:00
Tom Hacohen
1ecc0a395b
Fixed #30070 , CVE-2019-3498 -- Fixed content spoofing possiblity in the default 404 page.
...
Co-Authored-By: Tim Graham <timograham@gmail.com>
2019-01-03 21:21:55 -05:00
Mariusz Felisiak
e49ab72637
Refs #29851 -- Fixed test_subquery_row_range_rank() crash on MariaDB 10.2+.
...
Thanks Tom Forbes for the report.
2019-01-03 20:18:45 +01:00
Tim Graham
b5fe97a34e
Added __init__.py for db_utils tests.
2019-01-02 18:19:45 -05:00
Tim Graham
0004daa536
Used 4 space hanging indent for dictionaries.
...
Thanks Mariusz Felisiak for auditing.
2019-01-02 18:18:19 -05:00
Tim Graham
e4a714b259
Pinned Pillow != 5.4.0 in test requirements.
...
There's a bug that causes a test failure in forms_tests:
https://github.com/python-pillow/Pillow/pull/3501/files#r244651761 .
2019-01-02 17:15:39 -05:00
Patrik Sletmo
14e2b1b065
Fixed #29981 -- Fixed inline formsets with a OnetoOneField primary key that uses to_field.
2019-01-01 10:40:22 -05:00
Tim Graham
02c07be95c
Fixed #30050 -- Fixed InlineModelAdmin.has_change_permission() called with non-None obj during add.
...
Thanks andreage for the report and suggested fix.
2019-01-01 09:42:14 -05:00
Paveł Tyślacki
0123b67f6b
Fixed #30060 -- Moved SQL generation for indexes and constraints to SchemaEditor.
2019-01-01 09:39:58 -05:00
Tim Graham
043bd70942
Updated test URL patterns to use path() and re_path().
2018-12-31 10:47:32 -05:00
Tim Graham
1136d57f01
Updated a test to reflect the fact that "import *" isn't used in URLconfs anymore (refs #14675 ).
2018-12-31 10:24:28 -05:00
Matt Wiens
e817ae74da
Followed style guide for model attribute ordering.
2018-12-27 19:34:14 -05:00
Mariusz Felisiak
dd8ed64113
Fixed #29851 -- Fixed crash of annotations with window expressions in Subquery.
2018-12-27 20:21:57 +01:00
Jon Dufresne
6fe9c45b72
Fixed #30024 -- Made urlencode() and Client raise TypeError when None is passed as data.
2018-12-27 11:19:55 -05:00
CHI Cheng
b7dbd5ff68
Fixed broken links to PyYAML page.
2018-12-27 10:48:37 +01:00
Denis Stebunov
277de22984
Fixed #30058 -- Made SMTP EmailBackend.send_messages() return 0 for empty/error cases.
2018-12-26 13:33:08 -05:00
Tim Graham
0b54ab0675
Refs #30033 -- Fixed schema's test_m2m_rename_field_in_target_model test failure on SQLite < 3.20.
...
Mixing local test models with non-local models resulted in a referential
integrity error during tear down since the models are removed in separate
schema editor instances which each check constraints.
Failure appeared after 7289874adc
.
2018-12-26 11:26:51 -05:00
Tim Graham
b74b6736d0
Refs #29547 -- Skipped an unsupported partial index test on older versions of SQLite.
...
Follow up to e5b8626c0e
.
2018-12-26 11:20:11 -05:00
Simon Charette
64f9776bc4
Refs #29004 -- Prevented inspectdb tests from flushing all tables data.
...
This is a costly operation on most database backends.
2018-12-24 15:32:39 -05:00
Simon Charette
f6d8b0c47e
Refs #26840 -- Corrected SQLite connection mocking in a setup_databases() test.
...
The test was expecting connections used by DiscoverRunner.setup_databases()
to be the ones defined in django.test.runner but this doesn't hold true
since this method was made a proxy of django.test.utils.setup_databases.
This broke the TransactionTestCase.serialized_rollback feature in the test
suite because calls to create_db_test() cleared the test data persisted on
connections objects.
Added an assertions to prevent this from happening again.
2018-12-24 15:32:27 -05:00
Nick Pope
83677faf86
Fixed #30056 -- Added SQLite support for StdDev and Variance functions.
2018-12-24 11:14:58 -05:00
Sanyam Khurana
5d25804eaf
Fixed #20098 -- Added a check for model Meta.db_table collisions.
2018-12-24 10:40:11 -05:00
Nick Pope
e626a3f993
Renamed Sqlite and Sqlite3 references to SQLite.
2018-12-22 18:52:54 -05:00
Nick Pope
7534e43497
Refs #14204 -- Removed obsolete referential integrity comment for SQLite.
2018-12-22 18:44:21 -05:00
Sergey Fedoseev
a68ea23101
Fixed #29970 , #30041 -- Made ModelBase.__new__() pass attrs without contribute_to_class() to type.__new__().
2018-12-22 18:11:24 -05:00
Simon Charette
25a0781a16
Refs #29182 -- Corrected SQLite's supports_atomic_references_rename feature flag.
2018-12-22 14:58:08 -05:00
Simon Charette
e5b8626c0e
Refs #29547 -- Corrected SQLite's supports_partial_indexes feature flag.
2018-12-22 14:51:59 -05:00
Simon Charette
20f6f9eaa1
Renamed SQLite3 references to to SQLite.
...
The version suffix isn't part of the product name.
2018-12-22 14:20:43 -05:00
François Freitag
e671337e8b
Fixed #29750 -- Added View.setup() hook for class-based views.
2018-12-21 19:01:11 -05:00
jtiai
5a77190e66
Fixed #29792 -- Made GeometryField.deconstruct() handle 'extent' and 'tolerance' args.
2018-12-21 17:44:45 -05:00
jtiai
7b9f8e38bb
Added tests for GeometryField.deconstruct().
2018-12-21 17:41:39 -05:00
Tim Graham
194a4b526c
Added tests for ContentType/Group/Permission.__str__().
2018-12-21 12:45:02 -05:00
Dakota Hawkins
8d3147e130
Fixed #30031 -- Added --no-header option to makemigrations/squashmigrations.
2018-12-19 12:41:31 +01:00
Konstantin Alekseev
b514dc14f4
Fixed #30015 -- Ensured request body is properly consumed for keep-alive connections.
2018-12-19 11:27:08 +01:00
Simon Charette
894cb13779
Refs #29182 -- Stopped relying on legacy alter table semantic on SQLite 3.26+.
...
SQLite 3.26 changed the behavior of table and column renaming operations to
repoint foreign key references even if foreign key checks are disabled.
This makes the workarounds in place to simulate this behavior unnecessary on
SQLite 3.26+. Refs #30033 .
2018-12-17 10:44:05 +01:00
Simon Charette
315357ad25
Fixed #30023 -- Prevented SQLite schema alterations while foreign key checks are enabled.
...
Prior to this change foreign key constraint references could be left pointing
at tables dropped during operations simulating unsupported table alterations
because of an unexpected failure to disable foreign key constraint checks.
SQLite3 does not allow disabling such checks while in a transaction so they
must be disabled beforehand.
Thanks ezaquarii for the report and Carlton and Tim for the review.
2018-12-15 18:51:59 -05:00
Manan
3a4558b84f
Moved choices inside of test models per coding style.
2018-12-10 09:28:49 -05:00
Benjamin Wohlwend
79c196cfb2
Fixed #28766 -- Added ResolverMatch.route.
...
Co-Authored-By: Xavier Fernandez <xavier.fernandez@polyconseil.fr>
2018-12-06 18:05:40 -05:00
Mariusz Felisiak
f9a33e3c3f
Fixed #29932 -- Fixed combining compound queries with sub-compound queries on SQLite and Oracle.
2018-12-06 15:31:33 -05:00