Commit Graph

7254 Commits

Author SHA1 Message Date
Simon Charette 946e7679f3 [1.9.x] Fixed #25730 -- Made Model.__str__() always return str instances.
Thanks to Kevin Turner for the report and Tim for the review.

Backport of 4cd5d846d4 from master
2015-11-11 12:19:34 -05:00
Marti Raudsepp 1eed16b9db [1.9.x] Fixed #25720 -- Made gettext() return bytestring on Python 2 if input is bytestring.
This is consistent with the behavior of Django 1.7.x and earlier.

Backport of d3e3703a15 from master
2015-11-11 08:57:41 -05:00
Ian Foote f9a08eb897 [1.9.x] Fixed #25693 -- Prevented data loss with Prefetch and ManyToManyField.
Thanks to Jamie Matthews for finding and explaining the bug.

Backport of 4608573788 from master
2015-11-10 12:12:45 -05:00
Marti Raudsepp 8db5122d69 [1.9.x] Fixed #25683 -- Allowed ModelChoiceField(queryset=...) to accept Managers.
This fixes a regression from refs #25496.

Backport of 1155843a41 from master
2015-11-09 12:44:34 -05:00
Aymeric Augustin ca0278f496 [1.9.x] Fixed debug view crash during autumn DST change.
This only happens if USE_TZ = False and pytz is installed (perhaps not
the most logical combination, but who am I to jugde?)

Refs #23714 which essentially fixed the same problem when USE_TZ = True.

Thanks Florian and Carl for insisting until I wrote a complete patch.

Backport of 1014ba026e from master
2015-11-09 06:56:44 -05:00
Claude Paroz 194f893f02 [1.9.x] Removed ability to pass a geometry string to GIS functions
This was a possible confusion source with column name arguments.
Thanks Sergey Fedoseev for the suggestion.
2015-11-07 16:06:08 +01:00
Ville Skyttä a3bbc38d54 [1.9.x] Fixed #25668 -- Misc spelling errors
Backport of 3ee18400ae from master
2015-11-03 10:33:05 +00:00
Sergey Fedoseev 306efc8e45 [1.9.x] Fixed #25661 -- Fixed checking number of points during list assignment for `LinearRing`.
Backport of 1b598b4b4 from master.
2015-11-02 22:42:10 +01:00
Tim Graham 703369fb25 [1.9.x] Refs #24499 -- Removed an obsolete test check for PostGIS 1.5.
Backport of ab873e7a68 from master
2015-10-30 11:30:08 -04:00
Simon Charette 6eaf43a244 [1.9.x] Fixed #25622 -- Accounted for generic relations in the admin to field validation
Thanks to Jonathan Liuti for the report and Tim Graham for the review.

Backport of 9dcfecb7c6 from master
2015-10-29 13:15:40 -04:00
Dheerendra Rathor 6bb9f51ab8 [1.9.x] Fixed #25620 -- Made URLValidator prohibit URLs with consecutive dots in the domain section.
Backport of 96fe90f535 from master
2015-10-29 11:14:20 -04:00
Tim Graham 46850e2c85 [1.9.x] Ignored docutils deprecation warnings in runtests.py.
Backport of dbe79d9660 from master
2015-10-28 14:07:22 -04:00
Ian Foote 32e804cdb7 [1.9.x] Fixed #25609 -- Fixed regression in related field nested lookup error.
Backport of 32ef48aa56 from master
2015-10-27 13:57:52 -04:00
Simon Charette da9e9484f2 [1.9.x] Revert "Fixed #25417 -- Added a field check for invalid default values."
This reverts commit 71ebcb85b9.

Backport of 976bd519a8 from master
2015-10-27 11:17:02 -04:00
Tim Graham 1c0f598764 [1.9.x] Removed unnecessary app_label='auth' on auth_tests models.
This is a relic of when the tests were stored in contrib.auth.tests.

Backport of 590b8c1c57 from master
2015-10-27 08:38:19 -04:00
Tim Graham 0b4d11e175 [1.9.x] Fixed #25596 -- Fixed regression in password change view with custom user model.
The reverse() added in 50aa1a790c
crashed on a custom user model.

Backport of 5acf203db2 from master
2015-10-27 08:38:12 -04:00
Tim Graham 64a9115bce [1.9.x] Fixed #25597 -- Fixed crash with SplitArrayField and IntegerField on invalid value.
Backport of 1f07da3e29 from master
2015-10-27 08:13:21 -04:00
Tim Graham ca46dc323b [1.9.x] Fixed "URLconf" spelling in code comments.
Backport of 37ea3cb03e from master
2015-10-22 14:47:15 -04:00
Claude Paroz e241444ef5 [1.9.x] Fixed #25592 -- Fixed misnamed strictly_above PostGIS lookup
Fixes a regression from 2bd1bbc42. Thanks Daniel Wiesmann for the report
and Tim Graham for the review.
Backport of c08f85fd54 from master.
2015-10-22 20:33:55 +02:00
John Vandenberg 614ba3ad2d [1.9.x] Fixed quad quoted ("""") docstring starts.
Backport of 9e3f6c7483 from master
2015-10-20 12:20:11 -04:00
Tim Graham 994e7661a8 [1.9.x] Fixed #25562 -- Skipped a time dependent admin_filters test on Windows.
Backport of 4a50daf6b3 from master
2015-10-19 20:27:36 -04:00
Simon Charette 522b0bc91f [1.9.x] Fixed #25563 -- Cached deferred models in their proxied model's _meta.apps.
Thanks to Andriy Sokolovskiy for the report and Tim Graham for the review.

Backport of 3db3ab71e9 from master
2015-10-19 20:13:16 -04:00
Simon Charette 3aeb84df25 [1.9.x] Fixed #25560 -- Made empty string related_name invalid.
Thanks to Ali Lotfi for the initial report and patch
and Tim Graham for the review.

Backport of c1b6a8a98b from master
2015-10-19 10:11:36 -04:00
Josh Smeaton 7a3b486ccd [1.9.x] Fixed #25517 -- Made Concat function idempotent on SQLite.
Backport of 6c95b134e9 from master
2015-10-17 15:56:00 -04:00
Yusuke Miyazaki 9039ff60e3 [1.9.x] Fixed #25346 -- Allowed collectstatic to delete broken symlinks.
Backport of 0922bbf18d from master
2015-10-17 14:14:29 -04:00
Tim Graham faafd55722 [1.9.x] Used SchemaEditor.delete_model() for teardown in schema tests.
Some third-party database backends (MSSQL) have custom
delete_model() requirements that must be executed.

Thanks Michael Manfre for the initial patch and review.

Backport of 4dcc2a1955 from master
2015-10-16 09:12:20 -07:00
Antoine Catton 36e7d275ec [1.9.x] Fixed #25506 -- Allowed filtering over a RawSQL annotation.
Co-Authored-By: Gavin Wahl <gwahl@fusionbox.com>

Backport of b971c1cd78 from master
2015-10-14 11:24:12 -07:00
Antoine Catton 38d6e1e2ad [1.9.x] Fixed #25535 -- Made ForeignObject checks less strict.
Check that the foreign object `from_fields` are a subset of any unique
constraints on the foreign model.

Backport of 80dac8c33e and
c7aff31397 from master
2015-10-14 05:26:42 -07:00
Tim Graham 7cd299584d [1.9.x] Fixed #22705 -- Fixed QuerySet.bulk_create() on models without any fields on Oracle.
Fixed on other backends by 134ca4d438.

Thanks Mariusz Felisiak for the solution.

Backport of 7a5b7e35bf from master
2015-10-09 14:42:31 -04:00
Tim Graham b646fbe4a7 [1.9.x] Fixed #14368 -- Allowed setting a reverse OneToOne relation to None.
Backport of 384ddbec1b from master
2015-10-09 10:59:57 -04:00
Daniel Wiesmann 4326ac687e [1.9.x] Fixed #25533 -- Changed datatype mapping for GDALRasters
Backport of 5d8985005e from master.
2015-10-09 16:03:42 +02:00
Mariusz Felisiak fbe8930745 [1.9.x] Fixed #25503 -- Fixed system check crash on ForeignKey to abstract model.
Backport of 914167abf1 from master
2015-10-06 19:23:53 -04:00
Riccardo Magliocchetti 6f653f759a [1.9.x] Refs #12118 -- Allowed "mode=memory" in SQLite test database names.
Backport of 3543fec3b7 from master
2015-10-06 12:33:21 -04:00
Tim Graham 6bc8bdf55a [1.9.x] Fixed #25496 -- Made ModelChoiceField respect prefetch_related().
Backport of 6afa6818fc from master
2015-10-05 19:19:09 -04:00
Pindi Albert 3429dfe11d [1.9.x] Fixed #25423 -- Made error message for unknown template tag more helpful.
Backport of 9f2881deb1 from master
2015-10-05 17:33:18 -04:00
Ben Kraft 63a1e912a7 [1.9.x] Fixed #25389 -- Fixed pickling a SimpleLazyObject wrapping a model.
Pickling a `SimpleLazyObject` wrapping a model did not work correctly; in
particular it did not add the `_django_version` attribute added in 42736ac8.
Now it will handle this and other custom `__reduce__` methods correctly.

Backport of 35355a4ffe from master
2015-10-03 13:01:08 -04:00
Tim Graham 59027a4cae [1.9.x] Fixed #25466 -- Added backwards compatibility aliases for LoaderOrigin and StringOrigin.
Thanks Simon Charette for the DeprecationInstanceCheck class.

Backport of 8d1a001ef6 from master
2015-09-29 19:20:11 -04:00
Antoine Catton db88e40312 [1.9.x] Refs #16860 -- Fixed password help text when there aren't any validators.
This avoids creating an empty list which is invalid HTML 4.

Backport of 53ccffdb8c from master
2015-09-28 15:31:18 -04:00
Claude Paroz fb901c82bf [1.9.x] Made tests/serializers/models.py a models package
Thanks Tim Graham for the patch series review.
Backport of 50acbf3ff6 from master.
2015-09-26 20:05:23 +02:00
Claude Paroz df87de345d [1.9.x] Moved remaining of serializers_regress to serializers tests
Backport of 4908222ac from master.
2015-09-26 20:04:51 +02:00
Claude Paroz b58f88f96d [1.9.x] Moved more serializers_regress to serializers tests
Backport of ddd6a530e from master.
2015-09-26 20:04:21 +02:00
Claude Paroz a74728b36d [1.9.x] Separated natural key serialization tests
Backport of d59d3caf3 from master.
2015-09-26 20:03:54 +02:00
Claude Paroz d31c38cddd [1.9.x] Separated JSON serialization tests
Backport of 6dc7af3e01 from master.
2015-09-26 20:03:26 +02:00
Claude Paroz 4eeec2031e [1.9.x] Separated XML serialization tests
Backport of d3cfdfb508 from master.
2015-09-26 20:03:00 +02:00
Claude Paroz 5452d39e01 [1.9.x] Separated YAML serialization tests
Backport of febd5aeec from master.
2015-09-26 20:02:25 +02:00
Tim Graham ffcf81969b [1.9.x] Removed redundancy in admin_changelist tests.
Backport of c42123adb1 from master
2015-09-25 10:41:08 -04:00
Tzu-ping Chung 9581ac39a8 [1.9.x] Fixed #25457 -- Improved formatting of password validation errors in management command output.
Backport of 7372cdebed from master
2015-09-24 19:45:48 -04:00
Simon Charette 8e8c0792c0 Refs #18081 -- Asserted db constraints are created for fk to proxy models. 2015-09-23 14:59:05 -04:00
Anton Baklanov d0ed01cef0 Fixed #25407 -- Removed network dependency in GeoIP tests. 2015-09-23 13:11:57 -04:00
Tim Graham 6b37719616 Refs #24526 -- Made the django logger handle INFO messages.
Without an explicit 'level', only messages at WARNING or higher
are handled. This makes the config consistent with the docs
which say, "The django catch-all logger sends all messages at
the INFO level or higher to the console."
2015-09-23 11:33:49 -04:00
Tim Graham 7cb3a48843 Fixed #25410 -- Fixed empty ClearableFileInput crash on Python 2.
Reverted "Fixes #24727 -- Prevented ClearableFileInput from masking
exceptions on Python 2" and added a regression test.

This reverts commit 5c412dd8a7.
2015-09-23 10:26:19 -04:00
Alex Hill 134ca4d438 Fixed #24509 -- Added Expression support to SQLInsertCompiler 2015-09-22 23:35:24 +10:00
Alasdair Nicol f2975c021d Refs #23813 -- Moved URLconfs into module and tidied docstrings. 2015-09-21 20:10:33 -04:00
Nick Johnson 392f64842f Fixed #25373 -- Added warning logging for exceptions during {% include %} tag rendering. 2015-09-21 19:57:12 -04:00
Nick Johnson 85c52743f7 Refs #18773 -- Improved template variable exception logging message. 2015-09-21 19:27:01 -04:00
Aymeric Augustin 8bcff10b5a Fix import sorting problem. 2015-09-21 22:55:18 +02:00
Aymeric Augustin 91e9f1c972 Fixed #24921 -- set_autocommit(False) + ORM queries.
This commits lifts the restriction that the outermost atomic block must
be declared with savepoint=False. This restriction was overly cautious.

The logic that makes it safe not to create savepoints for inner blocks
also applies to the outermost block when autocommit is disabled and a
transaction is already active.

This makes it possible to use the ORM after set_autocommit(False).
Previously it didn't work because ORM write operations are protected
with atomic(savepoint=False).
2015-09-21 22:21:53 +02:00
Aymeric Augustin e542e81b39 Renamed descriptor classes for related objects.
The old names were downright confusing. Some seemed to mean the opposite
of what the class actually did.

The new names follow a consistent nomenclature:

    (Forward|Reverse)(ManyToOne|OneToOne|ManyToMany)Descriptor.

I mentioned combinations that do not exist in the docstring in order to
help people who would search for them in the code base.
2015-09-21 22:20:42 +02:00
Claude Paroz 65a1055a36 Fixed #25431 -- Readded inline foreign keys to modelformset instances
Too much field exclusions in form's construct_instance() in _post_clean()
could lead to some unexpected missing ForeignKey values.
Fixes a regression from 45e049937. Refs #13776.
2015-09-21 21:30:49 +02:00
Jani Tiainen fcf494b48f Fixed #24688 -- Added Oracle support for new-style GIS functions. 2015-09-21 13:52:14 -04:00
Alasdair Nicol fe3fc5210f Fixed #23813 -- Added checks for common URL pattern errors
Thanks jwa and lamby for the suggestions, and timgraham and jarshwah
for their reviews.
2015-09-21 23:46:21 +10:00
Josh Smeaton 534aaf56f4 Fixed #24629 -- Unified Transform and Expression APIs 2015-09-21 19:56:24 +10:00
Claude Paroz 8dc3ba5ceb Removed obsolete supports_* auth backend attributes in tests 2015-09-20 12:16:28 +02:00
Raphael Merx f5a33e4840 Fixed #25296 -- Prevented model related object cache pollution when create() fails due to an unsaved object. 2015-09-19 20:49:13 -04:00
Tim Graham c21410aeeb Fixed typo in "pbkdf2" test names. 2015-09-19 20:44:37 -04:00
Alasdair Nicol 15ce1a735c Used more specific assertion in check_framework tests. 2015-09-19 18:35:05 -04:00
Aymeric Augustin c3904deb91 Fixed #25160 (again) -- Moved data loss check on reverse relations.
Moved data loss check when assigning to a reverse one-to-one relation on
an unsaved instance to Model.save(). This is exactly the same change as
e4b813c but for reverse relations.
2015-09-19 20:27:53 +02:00
Unai Zalakain a4b80e2421 Refs #13110 -- Fixed mistakes in the new multiple enclosure feed tests 2015-09-19 15:54:33 +02:00
Travis Jensen 1a09b3c398 Fixed #25424 -- Use force_str for test client URLs.
urlparse() fails with an AttributeError ("'__proxy__' object has no
attribute 'decode'") if reverse_lazy is used to look up the URL
(this is exactly the same problem that caused ticket #18776). The
solution is to use force_str() on the path before handing it to
urlparse().
2015-09-19 15:05:54 +02:00
Markus Holtermann 43f2eb7ef3 Fixed #25390 -- Allowed specifying a start migration in squashmigrations
Thanks Tim Graham for the review.
2015-09-19 14:55:34 +10:00
Markus Holtermann 5aa55038ca Fixed #24743, #24745 -- Optimized migration plan handling
The change partly goes back to the old behavior for forwards migrations
which should reduce the amount of memory consumption (#24745). However,
by the way the current state computation is done (there is no
`state_backwards` on a migration class) this change cannot be applied to
backwards migrations. Hence rolling back migrations still requires the
precomputation and storage of the intermediate migration states.

This improvement also implies that Django does not handle mixed
migration plans anymore. Mixed plans consist of a list of migrations
where some are being applied and others are being unapplied.

Thanks Andrew Godwin, Josh Smeaton and Tim Graham for the review as well
as everybody involved on the ticket that kept me looking into the issue.
2015-09-19 14:54:53 +10:00
fabrizio ettore messina 186eb21dc1 Fixed #25269 -- Allowed method_decorator() to accept a list/tuple of decorators. 2015-09-18 19:04:29 -04:00
sujayskumar d8d853378b Fixed #24944 -- Added extra_email_context parameter to password_reset() view. 2015-09-18 18:56:04 -04:00
Unai Zalakain aac2a2d2ae Fixed #13110 -- Added support for multiple enclosures in Atom feeds.
The ``item_enclosures`` hook returns a list of ``Enclosure`` objects which is
then used by the feed builder. If the feed is a RSS feed, an exception is
raised as RSS feeds don't allow multiple enclosures per feed item.

The ``item_enclosures`` hook defaults to an empty list or, if the
``item_enclosure_url`` hook is defined, to a list with a single ``Enclosure``
built from the ``item_enclosure_url``, ``item_enclosure_length``, and
``item_enclosure_mime_type`` hooks.
2015-09-18 18:31:58 -04:00
Simon Charette 71ebcb85b9 Fixed #25417 -- Added a field check for invalid default values. 2015-09-18 14:31:36 -04:00
Iulia Chiriac 75ed590032 Fixed #24636 -- Added model field validation for decimal places and max digits. 2015-09-18 14:30:20 -04:00
Thomas Orozco d49667ef26 Refs #25422 -- Added a test for a template tag with type annotations.
This doesn't work in Django 1.8 but was fixed in Django 1.9 as a
side effect of another change.
2015-09-18 08:10:38 -04:00
Tom Christie b02f08e02c Fixed #25034 -- Converted caches ImproperlyConfigured error to a system check. 2015-09-18 07:44:39 -04:00
Aric Coady f33b3ebd53 Refs #20625 -- Forwardported tests and release notes for queryset chaining fix.
The issue was fixed on master due to the removal of ValuesQuerySet.

Partial forwardport of 7d471fe662 from stable/1.8.x
2015-09-17 19:22:53 -04:00
Aymeric Augustin 4f6a7663bc Refs #14091 -- Fixed connection.queries on SQLite. 2015-09-17 23:01:33 +02:00
Tim Graham fc8a6a9b00 Added a version requirement to mysqlclient in test requirements. 2015-09-17 15:07:26 -04:00
Tim Graham 12a62e7e4b Added a version requirement to python-memcached in test requirements. 2015-09-17 15:07:11 -04:00
Daniel Hahler da5747f8e4 Fixed #25400 -- Fixed regression in nonexistent features on gis backends. 2015-09-17 09:30:46 -04:00
Moritz Sichert 8550161e53 Refs #25294 -- Moved BoundField to django.forms.boundfield. 2015-09-16 14:43:38 -04:00
Gavin Wahl 0603f09318 Refs #25149 -- Fixed regression in admin datetime widget for timezones on the negative side of UTC. 2015-09-16 13:16:21 -04:00
Matt Robenolt b0c56b895f Fixed #24496 -- Added CSRF Referer checking against CSRF_COOKIE_DOMAIN.
Thanks Seth Gottlieb for help with the documentation and
Carl Meyer and Joshua Kehn for reviews.
2015-09-16 12:21:50 -04:00
Moritz Sichert 535809e121 Fixed #25294 -- Allowed custom BoundFields on forms. 2015-09-16 10:18:07 -04:00
Dave Smith b53b4d5c10 Fixed #25404 -- Added line numbers to TemplateSyntaxError strings.
This makes it much easier to diagnose a test failure when all
you have is the stack trace from an uncaught TemplateSyntaxError.
2015-09-15 12:25:13 -04:00
Aymeric Augustin 7673759321 Fixed runtests.py message about parallel processes.
It didn't work anymore since the commit that enabled test
parallelization by default because parallel was equal to 0
at that point.
2015-09-14 22:52:04 +02:00
Aymeric Augustin 2425f6fda0 Prevented --parallel from crashing on Windows.
Since --parallel is documented not to work on Windows, it's better to
ignore it and run without parallelization than to crash. For example
this could simplify cross-platform test scripts.
2015-09-14 22:52:04 +02:00
Adam Chainz 3fe3887a2e Fixed #25377 -- Changed Count queries to execute COUNT(*) instead of COUNT('*'). 2015-09-14 13:41:35 -04:00
Ville Skyttä 4d933ad418 Fixed #25393 -- Fixed MySQL crash when adding text/blob field with unhashable default. 2015-09-14 12:25:08 -04:00
Dražen Odobašić b1e33ceced Fixed #23395 -- Limited line lengths to 119 characters. 2015-09-12 11:40:50 -04:00
Markus Holtermann f45ee19746 Refs #24919 -- Raised more helpful error message for disabled migrations 2015-09-12 10:38:15 +10:00
Markus Holtermann a3c01b0dd8 Fixed #24919 -- Allowed disabling of migrations on a per app basis 2015-09-12 10:38:15 +10:00
Buddy Lindsey, Jr ec704371e3 Fixed #24765 -- Allowed template context updates to flatten a Context. 2015-09-11 14:52:13 -04:00
Renato Oliveira e3720b990a Fixed #25382 -- Removed obsolete references to DateQuerySet. 2015-09-11 12:16:06 -04:00
Malcolm Box 1d8eb0cae5 Fixed #25374 -- Made ModelAdmin checks work on instances instead of classes.
This allows dynamically-generated attributes to be specified in
checked ModelAdmin attributes without triggering errors.
2015-09-11 09:28:34 -04:00
Adam Chainz b2f6e421a3 Fixed #25329 -- Prevented _nodb_connection from being left open 2015-09-11 08:40:43 +02:00
Tim Graham d3c92afe42 Fixed a GeoIP2 test failure with the latest GeoIP2 database.
Düsseldorf now appears as Dusseldorf in the latest version
of the GeoIP2 database.
2015-09-10 20:54:25 -04:00