0c7633178f
Fixed #24020 -- Refactored SQL compiler to use expressions
...
Refactored compiler SELECT, GROUP BY and ORDER BY generation.
While there, also refactored select_related() implementation
(get_cached_row() and get_klass_info() are now gone!).
Made get_db_converters() method work on expressions instead of
internal_type. This allows the backend converters to target
specific expressions if need be.
Added query.context, this can be used to set per-query state.
Also changed the signature of database converters. They now accept
context as an argument.
2015-01-08 14:07:54 -05:00
b8abfe141b
Fixed #24101 -- Fixed flaky admin_views selenium tests; refs #7361 .
2015-01-08 13:17:00 -05:00
5c43fd4825
Isolated some cache tests; refs #23947 .
...
This reverts a change made in 40c60efecc
2015-01-08 13:14:45 -05:00
543df07720
Fixed #24073 -- Returned None for get_language when translations are deactivated
...
This fixes a regression caused by f7c287fca9
2015-01-08 17:43:07 +01:00
ade9859996
Fixed #24095 -- Prevented WarningLoggerTests from leaking a warnings filter.
2015-01-08 08:49:54 -05:00
862ea825b5
Fixed #24093 -- Prevented MigrationWriter to write operation kwargs that are not explicitly deconstructed
2015-01-07 17:29:20 -07:00
f487a3275e
Avoided a deprecated alias on Python 3 in file_uploads test.
2015-01-07 19:12:37 -05:00
8713ea7568
Fixed null handling in Value expression
2015-01-07 19:07:49 -05:00
1f03d2d924
Refs #23822 -- Made MigrationOptimizer aware of model managers
2015-01-07 17:33:04 -05:00
127f9e073d
Restored support for multiple template names in render(_to_response).
...
This possibility was documented but not tested.
It had been broken during the multiple template engines refactor.
2015-01-07 21:54:22 +01:00
eaa1a22341
Added a request argument to render_to_string.
...
This is for consistency with Template.render.
It adds a little bit of knowledge about HTTP requests in
django.template.loader but I think consistency trumps purity.
2015-01-07 21:54:22 +01:00
f7c287fca9
Fixed #24073 -- Deactivated translations when leave_locale_alone is False
...
Thanks Tim Graham and Markus Holtermann for the reviews.
2015-01-07 20:11:24 +01:00
ee86e59051
Refs #2443 -- Allowed creation of objects with NULL DurationFields
2015-01-07 08:33:26 -05:00
5a4ac4ead9
Fixed #24078 -- Removed empty strings from GenericIPAddressField
2015-01-07 08:08:36 -05:00
fb48eb0581
Fixed #12663 -- Formalized the Model._meta API for retrieving fields.
...
Thanks to Russell Keith-Magee for mentoring this Google Summer of
Code 2014 project and everyone else who helped with the patch!
2015-01-06 19:25:12 -05:00
749d23251b
Removed warning handling that should have been removed in refs #23891 .
2015-01-06 18:33:55 -05:00
0cdb09d489
Made context take priority over context processors.
...
This is the expected behavior, but given RequestContext's tortuous
implementation, a straightforward use of its API results in the
opposite.
This commits fixes a regression that must have happened at different
points in the multiple templates engine refactor for different features.
2015-01-06 22:02:27 +01:00
2e65d56156
Fixed #20003 -- Improved and extended URLValidator
...
This adds support for authentication data (`user:password`) in URLs,
IPv6 addresses, and unicode domains.
The test suite has been improved by adding test URLs from
http://mathiasbynens.be/demo/url-regex (with a few adjustments,
like allowing local and reserved IPs).
The previous URL validation regex failed this test suite on 13
occasions, the validator was updated based on
https://gist.github.com/dperini/729294 .
2015-01-06 14:04:25 -05:00
011f21b4fa
Used None-related assertions in CSRF tests
...
Thanks Markus Holtermann for spotting this.
2015-01-06 08:48:01 +01:00
27dd7e7271
Fixed #23815 -- Prevented UnicodeDecodeError in CSRF middleware
...
Thanks codeitloadit for the report, living180 for investigations
and Tim Graham for the review.
2015-01-06 08:42:58 +01:00
de9ebdd39c
Fixed #24022 -- Deprecated the ssi tag.
2015-01-05 19:35:02 -05:00
e08318b4ef
Refs #23359 -- Removed double newline from output of migrate --list
...
Thanks Berker Peksag for the review.
2015-01-05 14:52:54 -05:00
789baf9c3a
Fixed test failures introduced in refs #23861 .
2015-01-05 14:35:30 -05:00
c87ee41954
Fixed #23861 -- Added an API to deprecate model fields.
...
Thanks Markus Holterman and Berker Peksag for review.
2015-01-05 11:35:36 -05:00
6e1c9c6568
Fixed #8280 -- Allowed management command discovery for eggs
...
Thanks jdetaeye for the report, bhuztez and jdetaeye for the
initial patches, Tim Graham and Berker Peksag for the reviews.
2015-01-05 17:19:35 +01:00
3d2cae0896
Fixed #24072 -- Added FileResponse for streaming binary files.
2015-01-05 10:51:52 -05:00
23f1a8dad2
Added return value to Signal.disconnect().
2015-01-02 12:00:41 -05:00
937fab030d
Renamed an assertion in the dispatch tests.
2015-01-02 11:29:06 -05:00
8958170755
Fixed #9104 -- Moved FieldDoesNotExist to core.exceptions
2015-01-02 10:46:04 -05:00
1aa3e09c20
Fixed #23745 -- Reused states as much as possible in migrations
...
Thanks Tim Graham and Markus Holtermann for the reviews.
2015-01-02 15:37:10 +01:00
2a9c4b4901
Passed around the state between migrations
...
Refs #23745 .
2015-01-02 15:37:10 +01:00
a159b1facd
Replaced migration state render() by apps cached property
...
Refs #23745 .
2015-01-02 15:19:36 +01:00
40ccef16cb
Silenced an ImportWarning in the template_backends tests.
2015-01-01 14:28:53 -05:00
b9feec959b
Fixed #23700 -- Fixed non-deterministic static files test failures on Windows.
...
This partially reverts commit 949ee521fa#21230 .
2015-01-01 13:57:52 -05:00
40a8504357
Fixed #23891 -- Moved deprecation of IPAddressField to system check framework.
...
Thanks Markus Holtermann for review.
2015-01-01 13:30:52 -05:00
46068d850d
Fixed #22295 -- Replaced permission check for displaying admin user-tools
2014-12-31 16:31:59 -05:00
7a878ca5cb
Fixed #24008 -- Fixed ValidationError crash with list of dicts.
2014-12-31 14:43:13 -05:00
a1487deebf
Fixed #23359 -- Added showmigrations command to list migrations and plan.
...
Thanks to Collin Anderson, Tim Graham, Gabe Jackson, and Marc Tamlyn
for their input, ideas, and review.
2014-12-31 14:14:28 -05:00
8952757698
Refs #18586 -- Split up tests.defer.DeferTests.test_defer
2014-12-31 11:56:06 -05:00
8a9b0c15a6
Renamed tests for util -> utils moves; refs #17627 .
2014-12-31 11:26:27 -05:00
837fc2d8cd
Fixed a queries test on Python 2 broken after importing six.moves.range().
2014-12-31 09:50:47 -05:00
63dee96cc7
Fixed test from refs #23758 .
2014-12-31 09:19:04 -05:00
41fc1c0b5e
Fixed #23758 -- Allowed more than 5 levels of subqueries
...
Refactored bump_prefix() to avoid infinite loop and allow more than
than 5 subquires by extending the alphabet to use multi-letters.
2014-12-31 08:48:28 -05:00
93d73dac91
Moved DatabaseCreation.data_types properties to DatabaseWrapper.
...
refs #22340 .
2014-12-31 08:29:17 -05:00
32ca159c96
Ignored warnings correctly in test_get_formsets_with_inlines_returns_tuples().
...
The subclass check in ModelAdmin.get_formsets_with_inlines() wasn't
tested correctly because of the super() call in
EpisodeAdmin.get_formsets().
2014-12-31 08:24:09 -05:00
51890ce889
Applied ignore_warnings to Django tests
2014-12-30 18:16:25 +01:00
df3cc53fda
Fixed #23450 -- Fixed transient failure of requests...test_far_expiration.
2014-12-30 10:23:42 -05:00
c6b12bc995
Removed unused import.
2014-12-30 10:23:29 -05:00
8c99b7920e
Fixed #12118 -- Added shared cache support to SQLite in-memory testing.
2014-12-30 10:14:33 -05:00
fca866763a
Added test for an intermediate swappable model change in migration state.
...
refs #22563
2014-12-30 10:01:25 -05:00
ab4f709da4
Fixed #23581 -- Prevented extraneous DROP DEFAULT statements.
...
Thanks john_scott for the report and Markus Holtermann for review.
2014-12-30 07:54:05 -05:00
623ccdd598
Fixed #23938 -- Added migration support for m2m to concrete fields and vice versa
...
Thanks to Michael D. Hoyle for the report and Tim Graham for the review.
2014-12-29 13:41:12 -05:00
3c5d1edb39
Fixed #22279 -- Prevented dummy backend going through DatabaseErrorWrapper
...
Thanks Daniel Hahler for the report and Tim Graham for the review.
2014-12-29 19:06:28 +01:00
1d24f073e6
Fixed #21255 -- Closed connections after management command ran
...
Thanks kabakov.as@gmail.com for the report, and Aymeric Augustin,
Simon Charette for the reviews.
2014-12-29 19:02:45 +01:00
bae404dea3
Converted middleware tests to use RequestFactory.
2014-12-29 19:36:18 +02:00
6fb9dee470
Fixed #23271 -- Don't corrupt PO files on Windows when updating them.
...
Make sure PO catalog text fetched from gettext programs via standard
output isn't corrupted by mismatch between assumed (UTF-8) and real
(CP1252) encodings. This can cause mojibake to be written when creating
or updating PO files.
Also fixes #23311 .
Thanks to contributor with Trac nick 'danielmenzel' for the report,
excellent research and fix.
2014-12-29 12:24:50 -03:00
1cdfbde4db
Fixed #23753 -- Oracle failure with Coalesce
2014-12-29 19:44:13 +11:00
b7282db833
Raised a warning when using the legacy TEMPLATE_* settings.
...
All tests now rely on TEMPLATES.
2014-12-28 17:02:31 +01:00
9eb4f28e89
Deprecated TEMPLATE_CONTEXT_PROCESSORS.
2014-12-28 17:02:31 +01:00
d3205e3e2e
Deprecated TEMPLATE_DIRS.
2014-12-28 17:02:30 +01:00
cf0fd65ed4
Deprecated TEMPLATE_LOADERS.
2014-12-28 17:02:30 +01:00
d3a982556d
Deprecated TEMPLATE_STRING_IF_INVALID.
2014-12-28 17:02:30 +01:00
3dc01aaaaf
Deprecated ALLOWED_INCLUDE_ROOTS.
2014-12-28 17:02:30 +01:00
cf1f36bb6e
Deprecated current_app in TemplateResponse and render(_to_response).
2014-12-28 17:02:29 +01:00
fdbfc98003
Deprecated some arguments of django.shortcuts.render(_to_response).
...
dictionary and context_instance and superseded by context.
Refactored tests that relied context_instance with more modern idioms.
2014-12-28 17:02:29 +01:00
92e8f1f302
Moved context_processors from django.core to django.template.
2014-12-28 17:00:07 +01:00
969e082858
Added tests for django.template.loader.
...
Deprecated features aren't tested.
2014-12-28 17:00:07 +01:00
90805b240f
Supported multiple template engines in render_to_string.
...
Adjusted its API through a deprecation path according to the DEP.
2014-12-28 16:23:02 +01:00
5523e4cdbb
Removed private API find_template.
...
It wasn't documented and it wasn't used anywhere, except in a few tests
that don't test it specifically and can be rewritten with get_template.
2014-12-28 16:23:01 +01:00
4ea43ac915
Supported multiple template engines in get_template and select_template.
...
This commit changes the return type of these two functions. Instead of
returning a django.template.Template they return a backend-specific
Template class that must implement render(self, context).
2014-12-28 16:23:01 +01:00
92a2d049a2
Isolated template tests from Django settings.
2014-12-28 16:23:01 +01:00
332154e726
Added basic tests for template backends.
2014-12-28 16:23:00 +01:00
7eefdbf7ab
Cleaned up the django.template namespace.
...
Since this package is going to hold both the implementation of the Django
Template Language and the infrastructure for Multiple Template Engines,
it should be untied from the DTL as much as possible within our
backwards-compatibility policy.
Only public APIs (i.e. APIs mentioned in the documentation) were left.
2014-12-28 14:47:31 +01:00
6d52f6f8e6
Fixed #23831 -- Supported strings escaped by third-party libs in Django.
...
Refs #7261 -- Made strings escaped by Django usable in third-party libs.
The changes in mark_safe and mark_for_escaping are straightforward. The
more tricky part is to handle correctly objects that implement __html__.
Historically escape() has escaped SafeData. Even if that doesn't seem a
good behavior, changing it would create security concerns. Therefore
support for __html__() was only added to conditional_escape() where this
concern doesn't exist.
Then using conditional_escape() instead of escape() in the Django
template engine makes it understand data escaped by other libraries.
Template filter |escape accounts for __html__() when it's available.
|force_escape forces the use of Django's HTML escaping implementation.
Here's why the change in render_value_in_context() is safe. Before Django
1.7 conditional_escape() was implemented as follows:
if isinstance(text, SafeData):
return text
else:
return escape(text)
render_value_in_context() never called escape() on SafeData. Therefore
replacing escape() with conditional_escape() doesn't change the
autoescaping logic as it was originally intended.
This change should be backported to Django 1.7 because it corrects a
feature added in Django 1.7.
Thanks mitsuhiko for the report.
2014-12-27 18:02:34 +01:00
5c5eb5fea4
Fixed an inconsistency introduced in 547b1810.
...
mark_safe and mark_for_escaping should have been kept similar.
On Python 2 this change has no effect. On Python 3 it fixes the use case
shown in the regression test for mark_for_escaping, which used to raise
a TypeError. The regression test for mark_safe is just for completeness.
2014-12-27 17:44:54 +01:00
2ceb10f3b0
Fixed #14180 -- Prevented unneeded index creation on MySQL-InnoDB
...
Thanks zimnyx for the report and Simon Charette, Tim Graham for
the reviews.
2014-12-27 12:52:44 +01:00
4718296546
Fixed #23753 -- Added a suite of SQL Functions
...
Added functions and tests
Added docs and more tests
Added TextField converter to mysql backend
Aliased Value as V in example docs and tests
Removed unicode_compatible in example
Fixed console emulation in examples
2014-12-27 15:27:27 +11:00
7c07612e90
Removed an unnecessary models file in the admin_scripts tests.
2014-12-26 19:31:54 -05:00
75bbcfa332
Replaced sqlall in some bash_completion/admin_scripts tests.
...
sqlall will be removed in Django 1.9, so now's a good time to remove
its usage where it's not important.
2014-12-26 18:52:26 -05:00
b4e76f30d1
Fixed #23346 -- Fixed lazy() to lookup methods on the real object, not resultclasses.
...
Co-Authored-By: Rocky Meza <rmeza@fusionbox.com>
2014-12-26 11:30:34 -05:00
3daa9d60be
Fixed #10414 -- Made select_related() fail on invalid field names.
2014-12-24 14:54:30 -05:00
b27db97b23
Fixed #22461 -- Added if-unmodified-since support to the condition decorator.
2014-12-24 12:33:57 -05:00
fae551d765
Complemented pickle test for ValuesQuerySet with related field
...
Refs #14515 .
2014-12-24 14:58:32 +01:00
7ce9644d93
Added a test to ensure bad assignation to M2M doesn't clear data
...
Refs #14394 .
2014-12-24 14:18:00 +01:00
c5c235cd4f
Fixed typo in test_utils comment.
2014-12-24 07:10:34 -05:00
b3ebcb22a9
Ignored deprecation warnings for CreationIndexesTests
2014-12-24 10:45:53 +01:00
9699d8446e
Moved test correction from 5b1fb0a75
2014-12-24 10:42:24 +01:00
061caa5b38
Fixed #24037 -- Prevented data loss possibility when changing Meta.managed.
...
The migrations autodetector now issues AlterModelOptions operations for
Meta.managed changes instead of DeleteModel + CreateModel.
Thanks iambibhas for the report and Simon and Markus for review.
2014-12-23 14:25:31 -05:00
30cbd5d360
Replaced DatabaseCreation sql methods by schema editor equivalents
...
Also used schema editor in migrate to sync unmigrated apps (sync_apps).
Refs #22340 . Thanks Tim Graham for the review.
2014-12-23 19:35:01 +01:00
15ba0d166f
Added migration for site test app depending on contrib.sites
2014-12-23 19:01:33 +01:00
750dbb1133
Removed unneeded null param to ManyToManyField
2014-12-23 19:01:03 +01:00
90720d549a
Removed admin_util test dependency on contrib.sites
2014-12-23 18:43:55 +01:00
f05b03f3d7
Removed model_package test dependency on contrib.sites
2014-12-23 18:10:07 +01:00
f233bf47dd
Fixed #21414 -- Removed RelatedObject and deprecated Field.related.
2014-12-23 10:54:25 -05:00
9fecb86a52
Fixed #17946 -- Fixed deserialization of self-referencing M2M fields
...
Thanks Philip Mountifield for the report and excellent analysis, and
Simon Charette for the review.
2014-12-23 16:01:39 +01:00
994d6137a2
Fixed #23792 -- Added test.utils.freeze_time() context manager.
2014-12-22 07:46:40 -05:00
54085b0f9b
Fixed #23998 -- Added datetime.time support to migrations questioner.
2014-12-22 07:24:54 -05:00
936e87c97b
Merge pull request #3765 from wlanslovenija/ticket_24034
...
Fixed #24034 -- Don't always overwrite deconstruct path.
2014-12-22 00:41:13 +00:00
9a23470072
Fixed #24017 -- Added python_2_unicode_compatible in db/migrations
2014-12-21 16:10:43 -05:00
7c50e7eecc
Fixed #24034 -- Don't always overwrite deconstruct path.
...
Made deconstruct path overwriting for ArrayField conditional,
so it only occurs when the deconstructed field is an instance
of ArrayField itself and not a subclass.
2014-12-21 17:31:50 +01:00
57554442fe
Fixed #2443 -- Added DurationField.
...
A field for storing periods of time - modeled in Python by timedelta. It
is stored in the native interval data type on PostgreSQL and as a bigint
of microseconds on other backends.
Also includes significant changes to the internals of time related maths
in expressions, including the removal of DateModifierNode.
Thanks to Tim and Josh in particular for reviews.
2014-12-20 18:28:29 +00:00
995be4a137
Fixed refs #24007 test on Windows.
2014-12-19 14:11:17 -05:00
1d9fc5caa9
Made model_regress unpickling test CWD-independent
...
Refs #24007 . Thanks Tim Graham for his help with the patch.
2014-12-19 18:37:32 +01:00
5b1fb0a75d
Forward-ported test and release note from f46a16614
...
Refs #24015 .
2014-12-18 21:17:17 +01:00
9bcd4d812c
Fixed #23788 (2) -- Improved gettext version checker
...
Thanks Tim Graham for the report and initial patch.
2014-12-18 16:06:33 +01:00
4fb38b7307
Allowed Python executable names other than python in test from refs #24007 .
2014-12-17 20:09:24 -05:00
108b8bf852
Fixed #24007 -- Ensure apps registry's ready before unpickling models
...
This prevents AppRegistryNotReady errors when unpickling Django
models from an external script.
2014-12-17 18:33:32 +01:00
b7219c7ba5
Fixed #23497 -- Made admin system checks run for custom AdminSites.
2014-12-17 09:11:46 -05:00
1c5cbf5e5d
Fixed #24002 -- GenericRelation filtering targets related model's pk
...
Previously Publisher.objects.filter(book=val) would target
book.object_id if book is a GenericRelation. This is inconsistent to
filtering over reverse foreign key relations, where the target is the
related model's primary key.
2014-12-17 10:04:52 +02:00
d2ff8a7241
Fixed #23975 -- Restored pre_migrate signal if all apps have migrations.
...
Thanks kmmbvnr for the report.
2014-12-16 18:34:25 -05:00
f91d7366e0
Fixed #16028 -- Moved defaultfilters tests into template_tests.
2014-12-16 14:45:19 -05:00
3dbbb8a89c
Fixed #23983 -- Fixed a crash in migrations when adding order_with_respect_to to non-empty table.
2014-12-16 10:48:49 -05:00
ca013e652f
Fixed #23995 -- Removed unnecessary calls to self.client.logout() in tests.
2014-12-16 09:12:46 -05:00
4fada6f1c9
Fixed #23893 : Added tzinfo to constant datetime in unit test
...
Added tzinfo to y2k constant (01/01/2000) in
custom_lookups.tests.DateTimeLookupTests.test_datetime_output_field
to fix warning message regarding naive datetimes.
2014-12-16 02:54:59 -07:00
c17d821fa7
Refs #23947 -- Improved migrations tests table cleanup.
...
Copied technique from schema tests.
2014-12-15 19:05:19 -05:00
ac5f2a4ef7
Fixed refs #23987 test on Oracle.
2014-12-15 18:15:55 -05:00
3ef50a772b
Fixed reverse test execution for migration manager tests
...
Thanks to Tim Graham for reporting the issue; refs #23822
2014-12-15 17:54:40 -05:00
d8f3b86a76
Fixed #23405 -- Fixed makemigrations prompt when adding Text/CharField.
...
A default is no longer required.
2014-12-15 14:41:52 -05:00
089047331d
Fixed #23987 -- Made SQLite SchemaEditor always use effective_default().
2014-12-15 13:40:24 -05:00
222699d224
Refs #23947 -- Fixed queries test execution order dependency.
...
Specify an id to avoid conflict with objects created in setUpTestData.
2014-12-15 12:25:55 -05:00
e8223b889a
Corrected test assertion from refs #21403 .
2014-12-15 12:04:07 -05:00
d8182f294a
Refs #23947 -- Fixed admin_views test execution order dependency.
2014-12-15 10:48:42 -05:00
aa5ef0d4fc
Fixed #23822 -- Added support for serializing model managers in migration
...
Thanks to Shai Berger, Loïc Bistuer, Simon Charette, Andrew Godwin,
Tim Graham, Carl Meyer, and others for their review and input.
2014-12-15 08:34:15 -05:00
71a559e771
Removed obsolete code for running test_loaders.py.
...
Running this file as a standalone script doesn't work anyway.
2014-12-13 22:51:57 +01:00
895dc880eb
Fixed #23812 -- Changed django.utils.six.moves.xrange imports to range
2014-12-13 12:45:58 -05:00
df9f2e41fa
Refs #23943 -- Removed an invalid generic_views test.
...
Using PUT as a method for the form element is no longer supported
as described in the ticket.
2014-12-12 16:14:10 -05:00
c72eb80d11
Fixed #23455 -- Accept either bytes or text for related_name, convert to text.
2014-12-12 12:50:39 -07:00
8aaf51f94c
Revert "Fixed #23455 -- Forced related_name to be a unicode string during deconstruction."
...
This reverts commit 45bd7b3bd9
2014-12-12 12:50:39 -07:00
c7a19f4203
Fixed #23857 -- Fixed admin crash with "save as new" and deleting inline.
...
Thanks amarandon for the report.
2014-12-12 10:24:39 -05:00
267a1dcd9b
Fixed #23941 -- Removed implicit decimal formatting from expressions.
2014-12-12 10:17:48 -05:00
e2868308bf
Fixed template tag braces spacing.
2014-12-12 09:34:18 -05:00
0dea81cd6d
Fixed #23674 -- Fixed a crash when a MultiValueField has invalid data.
2014-12-12 08:47:21 -05:00
43041ee48c
Refs #18586 -- Refactored expressions tests.
2014-12-11 18:24:23 -05:00
079ee1ff5d
Readded test inadvertently removed in last commit.
2014-12-11 18:01:34 -05:00
6db122c7ab
Refs #18586 -- Split custom manager tests.
2014-12-11 17:47:36 -05:00
f66d9a2300
Refs #18586 -- Split custom_pk test.
2014-12-11 17:13:24 -05:00
3bb78c5e7a
Cleanup cache in contrib.sites to prevent test interference -- refs #11505
2014-12-11 15:56:54 -05:00
059c9ab24c
Fixed #23977 -- Added setdefault() method to HttpResponse
2014-12-11 13:56:56 -05:00
44927ba817
Fixed #23956 -- Fixed migration creation for multiple table inheritance
2014-12-11 13:28:21 -05:00
fd60e6c887
Refs #23947 -- Prevented staticfiles tests from having side effects.
2014-12-09 11:17:05 -05:00
4468c08d70
Fixed #23968 -- Replaced list comprehension with generators and dict comprehension
2014-12-08 07:58:23 -05:00
9f427617e4
Refs #23947 -- Worked around a bug in Python that prevents deprecation warnings from appearing in tests.
2014-12-06 14:46:01 -05:00
1917017b8d
Moved misplaced comment.
2014-12-06 20:40:55 +01:00
40c60efecc
Refs #23947 -- Isolated some cache tests.
...
Thanks Diego Guimarãesi and Florian Apolloner.
2014-12-06 13:59:49 -05:00
106dde91e4
Refs #23947 -- Fixed introspection test that had a side effect.
2014-12-06 13:00:25 -05:00
e32a8a99d9
Refs #23947 -- Isolated a mail test.
2014-12-06 12:06:06 -05:00
3bb52c5019
Refs #23890 -- Restored silencing of numpy DeprecationWarnings in template tests.
2014-12-06 11:27:15 -05:00
5c68870169
Fixed #23958 -- Rewrote filter tests as unit tests.
2014-12-06 10:57:46 -05:00
d05709821c
Refs #23947 -- Made a modeladmin test cleanup after itself.
2014-12-05 16:19:59 -05:00
b6ea059b4a
Fixed #23957 -- Started deprecation toward requiring session verification.
...
Thanks Carl Meyer for review.
2014-12-05 07:37:34 -05:00
8d7a48027e
Fixed #23954 -- Added special text/varchar PostgreSQL indexes in migrations
...
Thanks adityagupta104 for the report and Tim Graham for the review.
2014-12-04 21:27:42 +01:00
ce2eff7e48
Converted a SimpleTestCase that creates data to TestCase.
2014-12-04 13:24:41 -05:00
7daf00679d
Refs #18586 -- Split up order_with_respect_to tests
2014-12-04 11:05:26 -05:00
765fa36d57
Fixed #23920 -- Fixed MySQL crash when adding blank=True to TextField.
...
Thanks wkornewald for the report and Markus Holtermann for review.
2014-12-04 10:57:10 -05:00
018d110ef5
Fixed #23911 -- Added support for buffer file uploads in the test client
2014-12-04 07:42:03 -05:00
16f26defa7
Converted recently refactored templates tests to SimpleTestCase.
...
These test methods don't need DB setup/teardown.
Refs #23768 and b872134b
2014-12-03 18:56:46 -05:00
2cd19f3738
Refs #18586 -- Split up model_inheritance.ModelInheritanceTest
2014-12-03 18:54:47 -05:00
560b4207b1
Removed redundant numbered parameters from str.format().
...
Since Python 2.7 and 3.1, "{0} {1}" is equivalent to "{} {}".
2014-12-03 14:27:38 -05:00
50c1d8f24b
Added a test to verify headers set by default middleware; refs #23939 .
2014-12-03 13:47:23 -05:00
26dd518b5c
Refactored some tests to take advantage of refs #20392 .
2014-12-03 10:37:12 -05:00
da9fe5c717
Fixed #20392 -- Added TestCase.setUpTestData()
...
Each TestCase is also now wrapped in a class-wide transaction.
2014-12-03 10:37:04 -05:00
dee4d23f7e
Fixed #23950 -- Prevented calling deconstruct on classes in MigrationWriter.
2014-12-03 08:22:29 -05:00
9d1a69579b
Fixed #23935 -- Converted decimals to fixed point in utils.numberformat.format
2014-12-03 07:49:06 -05:00
adacbd64a0
Fixed "no such test method" error in template_tests.
...
Without this patch, you couldn't run an individual test
case in template_tests.
Refs #23768
2014-12-03 13:04:23 +01:00
b872134bfc
Fixed #23768 -- Rewrote template tests as unit tests.
2014-12-02 19:18:35 -05:00
4a4ad27712
Marked some tests as expected failures on Oracle/cx_Oracle<=5.1.3/Python3
...
Refs #23843 which is really a cx_Oracle bug
2014-12-03 00:53:27 +02:00
0623f4dea4
Fixed #23934 -- Fixed regression in admin views obj parameter.
2014-12-02 08:42:17 -05:00
1da1fe8e16
Ensured foreign_object tests reset language properly.
2014-12-02 07:31:52 -05:00
1739ae9edc
Fixed #23807 -- Ignored non-digits in psycopg2 version
2014-12-01 18:42:08 -05:00
b8cc5f3cd4
Fixed selenium test failure of JavascriptI18nTests.
...
The failure was introduced in dd1ea70779
2014-12-01 16:42:48 -05:00
82e4f956e3
Fixed #23289 -- Added mock as a test dependency.
2014-12-01 16:08:25 -05:00
43fcf3505e
Fixed admin_views test from refs #7361 (name was too long).
2014-12-01 15:47:41 -05:00
e11c6fd218
Fixed #23909 -- Prevented crash when collecting SQL for RunSQL
...
Thanks James Rivett-Carnac for the report and Markus Holtermann
for the review.
2014-12-01 20:26:40 +01:00
e1513a7960
Fixed #18586 -- Split up model_package.ModelPackageTests.
2014-12-01 12:49:45 -05:00
b481c85697
Corrected a docstring in tests/migrations/test_operations.py.
2014-12-01 11:37:51 -05:00
3a8799c8a4
Removed an incorrect docstring in tests/multiple_database/tests.py.
2014-12-01 11:37:08 -05:00
fce2890e92
Removed a no-op statement in tests/multiple_database/tests.py.
2014-12-01 11:36:54 -05:00
9136ceb6fb
Replaced router.routers usage with override_settings(DATABASE_ROUTERS); refs #23933 .
2014-12-01 11:34:15 -05:00
e6f19ec322
Fixed #23933 -- Made override_settings(DATABASE_ROUTERS) affect the master router.
2014-12-01 11:30:50 -05:00
d2202ec2d4
Fixed #23880 -- Added missing index_together handling for SQLite
2014-12-01 11:30:33 +07:00
6dbe979b4d
Fixed #23930 -- Added copies of captured_std* managers from CPython's test.support.
...
StringIO import was adapted for compatibility with Python 2.
2014-11-29 11:21:58 -05:00
c8dcded930
Fixed #17890 -- Added an extra_context parameter to AdminSite.password_change().
2014-11-29 10:31:09 -05:00
3131e9cef5
Fixed #23923 -- Promoted Django's deprecation warnings to errors in runtests.py
2014-11-29 10:27:04 -05:00
8402909876
Silenced all admin validation warnings.
...
Warnings could escape depending on the order in which tests were run.
2014-11-28 19:00:08 -05:00
17fe0bd808
Fixed #23423 -- Added unaccent lookup in django.contrib.postgres
2014-11-28 18:22:20 -05:00
47789410db
Corrected deprecation warnings for RedirectView; refs #21587 .
2014-11-28 17:59:55 -05:00
deb607648e
Fixed #23728 -- Added the --exit option to makemigrations.
...
If no changes that need migrations are found, `makemigrations --exit`
exits with error code 1.
2014-11-28 07:48:39 -05:00
ab89414f40
Fixed #23853 -- Added Join class to replace JoinInfo
...
Also removed Query.join_map. This structure was used to speed up join
reuse calculation. Initial benchmarking shows that this isn't actually
needed. If there are use cases where the removal has real-world
performance implications, it should be relatively straightforward to
reintroduce it as map {alias: [Join-like objects]}.
2014-11-28 07:30:26 -05:00
c7175fcdfe
Fixed #901 -- Added Model.refresh_from_db() method
...
Thanks to github aliases dbrgn, carljm, slurms, dfunckt, and timgraham
for reviews.
2014-11-28 06:54:00 -05:00
912ad03226
Fixed #23894 -- Made deconstruct methods favor kwargs over args
2014-11-28 06:05:56 -05:00
e023ceb453
Fixed #23910 -- Added reply_to parameter to EmailMessage
...
Thanks to Berker Peksag and Tim Graham for the review and suggestions.
2014-11-28 06:00:06 -05:00
6b5d82749c
Fixed #16731 -- Made pattern lookups work properly with F() expressions
2014-11-28 12:50:42 +02:00
f39b0421b4
Fixed #23338 -- Added warning when unique=True on ForeigKey
...
Thanks Jonathan Lindén for the initial patch, and Tim Graham
and Gabe Jackson for the suggestions.
2014-11-27 19:42:30 -05:00
abf87333a1
Fixed #23924 -- Made EmailMessage raise TypeError for type checks
2014-11-27 18:43:45 -05:00
7cd3f1c295
Fixed cache state dependence for assertNumQueries in test_group_permission_performance.
...
Refs #20432 and #23746 .
2014-11-27 13:02:21 -05:00
093e6c68b9
Fixed #14664 -- Logged a warning if MiddlewareNotUsed is raised in DEBUG mode.
2014-11-27 07:55:07 -05:00
bd337184f1
Fixed #23877 -- aggregation's subquery missed target col
...
Aggregation over subquery produced syntactically incorrect queries in
some cases as Django didn't ensure that source expressions of the
aggregation were present in the subquery.
2014-11-27 06:50:08 -05:00
e9d1f1182a
Fixed #23801 -- Added warning when max_length is used with IntegerField
2014-11-26 18:41:54 -05:00
cbb5cdd155
Fixed #23867 -- removed DateQuerySet hacks
...
The .dates() queries were implemented by using custom Query, QuerySet,
and Compiler classes. Instead implement them by using expressions and
database converters APIs.
2014-11-26 17:49:25 -05:00
c335c0fee9
Fixed #23914 -- Improved {% now %} to allow storing its result in the context.
...
Thanks to Tim for the review.
2014-11-25 22:11:35 +01:00
3a9aa155e2
Fixed #23915 -- Made sure m2m fields through non-pk to_field are allowed in the admin.
...
refs #23754 , #23862
2014-11-25 15:28:21 -05:00
f9c4e14aec
Fixed #23754 -- Always allowed reference to the primary key in the admin
...
This change allows dynamically created inlines "Add related" button to work
correcly as long as their associated foreign key is pointing to the primary
key of the related model.
Thanks to amorce for the report, Julien Phalip for the initial patch,
and Collin Anderson for the review.
2014-11-25 13:26:50 -05:00
8e7b384d89
Fixed #23898 -- Added missing context to admin's deleted_selected view.
...
Thanks Redouane Zait for the report.
2014-11-25 11:22:15 -05:00
392e11945f
Fixed flake8 warnings.
2014-11-25 11:20:40 -05:00
ff3d746e8d
Fixed bug in circular dependency algo for migration dependencies.
...
Previous algo only worked if the first item was a part of the loop,
and you would get an infinite loop otherwise (see test).
To fix this, it was much easier to do a pre-pass.
A bonus is that you now get an error message that actually helps you debug
the dependency problem.
2014-11-25 15:37:34 +00:00
056a3c6c37
Fixed #23682 -- Enhanced circular redirects detection in tests.
...
When the test client detects a redirect to a URL seen in the
currently followed chain it will now raise a RedirectCycleError
instead of just returning the first repeated response.
It will also complain when a single chain of redirects is longer
than 20, as this often means a redirect loop with varying URLs,
and even if it's not actually one, such long chains are likely
to be treated as loops by browsers.
Thanks Preston Timmons, Berker Peksag, and Tim Graham for reviews.
2014-11-25 10:12:28 -05:00
a973fb2d68
Fixed and restored assertions in OneToOneTests.test_foreign_key.
...
These assertions had been removed in 34ba86706f7fe554b2a3
2014-11-25 09:47:32 -05:00
9a30acad8a
Fixed #21587 -- Added a warning for changing default of RedirectView.permanent.
2014-11-25 09:22:18 -05:00
d43dd03ca3
Fixed #23890 -- Silenced numpy DeprecationWarnings in template tests.
2014-11-25 09:09:13 -05:00
e22c64dfc0
Fixed #23742 -- Added an option to reverse tests order.
...
This is useful for debugging side effects affecting tests that
are usually executed before a given test. Full suite and pair
tests sort cases more or less deterministically, thus some test
cross-dependencies are easier to reveal by reversing the order.
Thanks Preston Timmons for the review.
2014-11-24 19:24:11 -05:00
31f85bae1e
Changed test_runner imports to name objects imported from test.runner.
2014-11-24 17:31:39 -05:00
1e9ac504e4
Fixed #23888 -- Fixed crash in File.__repr__() when name contains unicode.
2014-11-24 15:54:57 -05:00
47a131b944
Encapsulated TEMPLATE_STRING_IF_INVALID in Engine.
2014-11-23 11:53:53 +01:00
29a977ab14
Moved template loaders management in Engine.
...
Passed the engine instance to loaders. This is a prerequisite for
looking up configuration on the engine instance instead of global
settings.
This is backwards incompatible for custom template loaders that override
__init__. However the documentation doesn't talk about __init__ and the
way to pass arguments to custom template loaders isn't specified. I'm
considering it a private API.
2014-11-23 11:52:12 +01:00
17012b6936
Deprecated dirs argument to override TEMPLATE_DIRS.
...
Cancels 2f0566fa#4278 .
2014-11-23 09:29:33 +01:00
da2a35cf9e
Silenced a flake8 warning.
...
../tests/shortcuts/views.py:45:1: E302 expected 2 blank lines, found 1
2014-11-22 21:39:06 +02:00
7331788300
Avoided rewrapping Contexts in render_to_response.
...
This change preserves backwards-compatibility for a very common misuse
of render_to_response which even occurred in the official documentation.
It fixes that misuse wherever it happened in the code base and docs.
Context.__init__ is documented as accepting a dict and nothing else.
Since Context is dict-like, Context(Context({})) could work to some
extent. However, things get complicated with RequestContext and that
gets in the way of refactoring the template engine. This is the real
rationale for this change.
2014-11-22 17:58:38 +01:00
bf1bd0fbc9
Moved tests for render shortcuts to their own app.
2014-11-22 17:52:43 +01:00
b38637d581
Fixed #23887 -- Returned Bad Request for multipart parsing fails
...
Thanks Antti Häyrynen and Tim Graham for the report, and Aymeric
Augustin for the review.
2014-11-22 14:23:37 +01:00
c7087bc777
Fixed #23862 -- Made ManyToManyRel.get_related_field() respect to_field.
2014-11-21 16:02:31 -05:00
343162410f
Fixed #21753 -- Raised exception when both `form_class` and `fields` are specified.
2014-11-21 14:23:17 -05:00
5b26a014a8
Fixed #23865 -- documented how to assign errors to a field in Model.clean()
...
Also added a unit test wit the simpler syntax which we have documented,
where the dictionary values are strings.
2014-11-21 13:01:28 -05:00
8330b50c85
Fixed #23863 -- Made runtests accept the keepdb option.
...
refs #20550
2014-11-21 11:41:13 -05:00
72729f844e
Fixed #23794 -- Fixed migrations crash when removing a field that's part of index/unique_together.
2014-11-21 10:55:19 -05:00
f957e2b04c
Added a test for model pre/post_init signals.
2014-11-21 10:39:37 -05:00
5b17dcd8ef
Fixed #23883 -- Stopped flatatt modifying its argument
2014-11-21 09:45:08 +01:00
d8f00e1918
Added a comment for test of refs #20278 .
2014-11-20 16:26:25 -05:00
4c709cc0ef
Fixed duplicate index error on Oracle; refs #23859 .
...
Refers to regression introduced in 7b4a994599
2014-11-20 14:42:39 -05:00
cfa26f29bd
Reduced reduce() usage; refs #23796 .
...
django.core.exceptions.ValidationError.messages() and
django.db.backends.schema.BaseDatabaseSchemaEditor._alter_field():
Replaced reduce(operator.add, ...) w/uncoupled, explicit sum()
2014-11-20 14:31:14 -05:00
f273cedc76
Added test for ValidationError.messages
2014-11-20 14:31:14 -05:00
5c481db295
Fixed #23605 -- Fixed nested subquery regression
...
Added relabeled_clone() method to sql.Query to fix the problem. It
manifested itself in rare cases where at least double nested subquery's
filter condition might target non-existing alias.
Thanks to Trac alias ris for reporting the problem.
2014-11-20 13:38:08 -05:00
21e21c7bc2
Fixed #23844 -- Used topological sort for migration operation dependency resolution.
...
This removes the concept of equality between operations to guarantee
compatilibity with Python 3.
Python 3 requires equality to result in identical object hashes. It's
impossible to implement a unique hash that preserves equality as
operations such as field creation depend on being able to accept
arbitrary dicts that cannot be hashed reliably.
Thanks Klaas van Schelven for the original patch in
13d613f800
2014-11-20 12:49:49 -05:00
788fa9fffa
Fixed #12098 -- Simplified HttpRequest.__repr__().
2014-11-20 08:45:11 -05:00
51f2de1530
Added another migration-executor test to avoid regressions.
2014-11-19 19:43:12 -07:00
ab2819aa7b
Fixed #23410 -- Avoided unnecessary rollbacks in related apps when migrating backwards.
2014-11-19 16:11:44 -07:00
47b7f601ee
Fixed #23872 -- Removed sensitivity of migrations tests to CWD.
2014-11-19 15:03:47 -07:00
b69b4008d1
Removed usage of a global variable.
2014-11-19 21:35:40 +01:00
f88ad710fa
Simplified caching of template context processors.
2014-11-19 21:35:39 +01:00
a97e72aaab
Simplified caching of templatetags modules.
2014-11-19 21:35:39 +01:00
2331650835
Cleaned up and reformatted autodetector tests
2014-11-19 11:09:38 -05:00
f17acd5930
Formatted model states in autodetector tests
2014-11-19 11:09:38 -05:00
cf7a2a000e
Fixed #22248 -- Made RenameModel reversible
2014-11-19 14:11:35 +02:00
5617508fb9
Removed nonexistent module django.test._doctest from coveragerc.
2014-11-19 06:01:39 -05:00
d63703f1cd
Fixed #18714 -- Added 'fuzzy' compilemessages option
2014-11-18 22:44:16 +01:00
d188101319
Fixed #23799 -- Made makemigrations respect --no-optimize.
...
Thanks to yamila-moreno for the idea of a skip message.
2014-11-18 07:37:06 +01:00
87f187b960
Adjusted tests for previous commit.
...
The test was testing a use case that doesn't happen in real world
projects: developers don't assign settings at run time (and Django
explicitly doesn't support it).
2014-11-17 23:26:04 +01:00
a37f452513
Removed superfluous newline.
2014-11-17 22:27:00 +01:00
7b4a994599
Fixed #23859 -- Fixed a migration crash when a field is renamed that is part of an index_together
2014-11-17 19:15:07 +01:00
bb4a92d784
Fixed #23840 -- Fixed makemessages find_files method
...
Changed the handling of extensions to be used for gettext. Now
obeying the --extension argument. find_files now only find the
given or default extensions and puts only these in the
TranslatableFiles. As a result there are no more confusing messages
for filetypes (extension) not handled by makemessages.
2014-11-17 09:21:24 +01:00
580e9d0045
Fixed a test to correctly calculate a fixture's relative path.
2014-11-17 02:32:04 +01:00
9eeb788cfb
Refactored getting the list of template loaders.
...
This provides the opportunity to move utility functions specific to the
Django Template Language outside of django.template.loader.
2014-11-16 21:41:44 +01:00
b503fee7ec
Removed override_template_loaders and override_with_test_loader.
...
They can be replaced with override_settings and that makes the
corresponding tests much more obvious.
2014-11-16 21:40:50 +01:00
2577ae6a08
Moved all template loaders under django.template.loaders.
...
Reformatted the code of base.Loader according to modern standards.
Turned the test template loader into a regular locmem.Loader -- but
didn't document it.
Added a normal deprecation path for BaseLoader which is a public API.
Added an accelerated deprecation path for TestTemplateLoader which is
a private API.
2014-11-16 21:28:26 +01:00
dec93d8991
Fixed #21612 -- Made QuerySet.update() respect to_field
2014-11-16 15:44:13 +01:00
f61256da3a
Renamed qn to compiler
2014-11-16 13:19:34 +01:00
68ef44c565
Removed references to the deprecated assertRaisesRegexp method.
2014-11-16 02:12:36 +01:00
013b5eacea
Added tests/README.rst
2014-11-15 19:47:05 +01:00
d2d6c0c097
Fixed #21363 -- Added datetime.timedelta support to TimestampSigner.unsign().
2014-11-15 19:36:33 +01:00
35dac5070b
Added a new GeoJSON serialization format for GeoDjango
...
Thanks Reinout van Rees for the review.
2014-11-15 18:07:18 +01:00
c5def493d0
Fixed #23835 : Changed circular dependency in DFS to be less infinite
2014-11-15 17:39:02 +01:00
9a5a4361c5
Merge pull request #3531 from ddaan/ticket_23834
...
fixed #23834 -- added test and fix to check for default null on ArrayField
2014-11-15 15:37:03 +00:00
a7c58eaca4
added test and fix to check for default null on ArrayField
2014-11-15 15:20:11 +00:00
83d104d61a
Revert "Use topological sort for migration operation dependency resolution"
...
This commit broke the tests on Python 3.
This reverts commit 13d613f800
2014-11-15 15:28:04 +01:00
f59fd15c49
Fixed #14030 -- Allowed annotations to accept all expressions
2014-11-15 14:00:43 +00:00
13d613f800
Use topological sort for migration operation dependency resolution
...
rather than an ad-hoc algorithm
2014-11-15 14:45:42 +01:00
d552da1f8d
Fixed #22407 -- Added AdminEmailHandler.send_mail().
2014-11-15 09:38:19 +01:00
a305695f28
Merge pull request #3481 from manfre/ticket-16358
...
Fixed #16358 - Made memcache backend delete old value on a failure to set.
2014-11-13 22:10:22 -05:00
c24a2e6cbd
Fixed #23765 -- Removed BooleanField default check which often yielded false positives.
2014-11-13 20:12:29 +01:00
e118e3af37
Fixed #23761 -- Added test for MySQL validator and db_type is None.
...
The issue was fixed on master in e9103402c02d12a59938
2014-11-13 11:06:59 +01:00
dec7da3c4c
Fixed flake8 warning.
2014-11-13 10:07:44 +01:00
311feae8ba
Fixed #23806 -- Added a test case for settings.DISALLOWED_USER_AGENTS.
2014-11-13 09:45:14 +01:00
bc8abe36ba
Fixed #16358 - Made memcache backend delete old value on a failure to set.
...
Default Memcached configuration allows for a maximum object of 1MB and
will fail to set the key if it is too large. The key will be deleted from
memcached if it fails to be set. This is needed to avoid an issue with
cache_db session backend using the old value stored in memcached, instead
of the newer value stored in the database.
2014-11-13 00:46:03 -05:00
bfb11b9562
Fixed #23795 -- Fixed a regression in custom form fields
...
Custom form fields having a `queryset` attribute but no
`limit_choices_to` could no longer be used in ModelForms.
Refs #2445 .
Thanks to artscoop for the report.
2014-11-12 22:38:18 +01:00
42b5e4feea
Fixed #23730 -- Moved support for SimpleCookie HIGHEST_PROTOCOL pickling to http.cookie.
...
This fix is necessary for Python 3.5 compatibility (refs #23763 ).
Thanks Berker Peksag for review.
2014-11-12 19:04:45 +01:00
c56c42b5c0
Fixed #22967 -- Made Model._do_update consistent
...
Made _do_update behave more strictly according to its docs,
including a corner case when specific concurent updates are
executed and select_on_save is set.
2014-11-12 12:53:30 +02:00
5ec367ccdd
Fixed #23788 -- Used new JavaScript support in recent gettext
...
JavaScript string extraction support has been added in gettext
0.18.3.
Thanks Aymeric Augustin for the review.
2014-11-11 22:52:30 +01:00
b8ba73cd0c
Raised SuspiciousFileOperation in safe_join.
...
Added a test for the condition safe_join is designed to prevent.
Previously, a generic ValueError was raised. It was impossible to tell
an intentional exception raised to implement safe_join's contract from
an unintentional exception caused by incorrect inputs or unexpected
conditions. That resulted in bizarre exception catching patterns, which
this patch removes.
Since safe_join is a private API and since the change is unlikely to
create security issues for users who use it anyway -- at worst, an
uncaught SuspiciousFileOperation exception will bubble up -- it isn't
documented.
2014-11-11 19:05:14 +01:00
b7a5b6ab86
Fixed #23750 -- Allowed core.checks.register to be used as a function
2014-11-11 16:29:32 +01:00
b748a8bc67
Fixed #23789 -- TemplateResponse handles context differently from render
2014-11-10 14:47:45 +00:00
c7c098cf97
Fixed #23770 -- Changed serialization strategy for floats with respect to NaN and Inf
...
Thanks to w0rp for the report
2014-11-06 15:30:30 +01:00
df0523debc
Fixed #23531 -- Added CommonMiddleware.response_redirect_class.
2014-11-04 17:56:57 -05:00
ca48cef3b4
Removed unused import.
2014-11-04 11:27:35 -05:00
74e1980cf9
Fixed #13181 -- Added support for callable choices to forms.ChoiceField
...
Thanks vanschelven and expleo for the initial patch.
2014-11-04 11:23:58 -05:00
36f514f065
Added HStoreField.
...
Thanks to `django-hstore` for inspiration in some areas, and many people
for reviews.
2014-11-04 09:26:40 +00:00
a71a2ea756
Fixed typos using https://github.com/vlajos/misspell_fixer
2014-11-03 20:59:30 -05:00
7b42036752
Fixed #5405 -- Added admindocs support for reStructured text in model docstrings
...
Thanks elvard and gkmngrgn for work on the patch and Markus H. for review.
2014-11-03 15:30:46 -05:00
2d06e3155a
Fixed #23300 -- Made assertTemplateUsed throw an error on responses not fetched using the test client.
...
Thanks zags for the report and bmispelon for the patch.
2014-11-03 14:31:23 -05:00
d89f56dc4d
Fixed #21281 -- Made override_settings act at class level when used as a TestCase decorator.
2014-11-03 14:14:39 -05:00
8b77b64f1c
Refactored URLValidator tests by moving URLs to text files.
2014-11-03 13:02:11 -05:00
ebc8e79cf3
Fixed #18523 -- Added stream-like API to HttpResponse.
...
Added getvalue() to HttpResponse to return the content of the response,
along with a few other methods to partially match io.IOBase.
Thanks Claude Paroz for the suggestion and Nick Sanford for review.
2014-11-03 12:29:19 -05:00
f7969b0920
Fixed #23620 -- Used more specific assertions in the Django test suite.
2014-11-03 11:56:37 -05:00
ceb1ffcc8d
Fixed #23420 - broken warning for unbound naive datetime objects
...
Fixed issue with warning message displayed for unbound naive datetime
objects when USE_TZ is True. Adds unit test that demonstrates the issue
(discoverable when using a custom lookup in MySQL).
2014-11-03 15:51:48 +02:00
c548c8d0d1
Fixed #18456 -- Added path escaping to HttpRequest.get_full_path().
2014-11-03 07:59:19 -05:00
934a16dc93
Fixed #23468 -- Added checks for duplicate fixtures directories in loaddata.
...
If settings.FIXTURE_DIRS contains duplicates or a default fixture
directory (app_name/fixtures), ImproperlyConfigured is raised.
Thanks to Berker Peksag and Tim Graham for review.
2014-10-31 18:21:54 -04:00
715ccfde24
Fixed #23738 -- Allowed migrating from NULL to NOT NULL with the same default value
...
Thanks to Andrey Antukh for the report.
2014-10-31 13:30:30 -04:00
ed2f96819c
Fixed #23715 -- Prevented urlize from treating a trailing ! as part of an URL
...
Thanks to 57even for the report.
2014-10-31 08:06:40 -04:00
98da408964
Fixed #23670 -- Prevented partial import state during module autodiscovery
...
Thanks kostko for the report.
2014-10-31 08:01:47 -04:00
c0c1bb9e64
Avoided using private API get_template_from_string.
2014-10-31 11:38:53 +01:00
f2ddc439b1
Fixed #23656 -- Made FormMixin.get_form's form_class argument optional.
...
Thanks Tim Graham for the review.
2014-10-30 19:10:52 -04:00
fd061b6591
Fixed #23733 -- Fixed squashing migrations that depend on multiple apps.
2014-10-30 14:39:11 -04:00
eb4f6de980
Fixed #8149 -- Made File.__iter__() support universal newlines.
...
The following are recognized as ending a line: the Unix end-of-line
convention '\n', the Windows convention '\r\n', and the old
Macintosh convention '\r'.
http://www.python.org/dev/peps/pep-0278
Thanks tchaumeny for review.
2014-10-30 11:52:59 -04:00
85086c8158
Fixed #23556 -- Raised a more meaningful error message when migrations refer to an unavailable node
2014-10-30 00:17:29 +01:00
5c9c1e029d
Fixed #23614 -- Changed the way the migration autodetector orders unique/index_together
...
Thanks to Naddiseo for the report and Tim Graham for the review
2014-10-29 13:05:42 -04:00
1e64a1e7b1
Fixed flake8 warnings.
2014-10-28 10:12:10 -04:00
28634394f5
Fixed #23606 -- Implemented Client and RequestFactory trace() methods.
...
Thanks KevinEtienne for the suggestion.
2014-10-28 10:11:12 -04:00
ae7cb992bc
Fixed #23721 -- check_related_objects without calling __iter__
...
Refs #14334
2014-10-28 10:13:50 +02:00
00aa562884
Fixed #23493 -- Added bilateral attribute to Transform
2014-10-28 10:02:10 +02:00
528c9af543
Fixed #23717 -- Fixed makemessages crash when STATIC_ROOT=None
2014-10-27 13:56:25 +01:00
dd1ea70779
Fixed #23699 -- Prevented flush from loading initial data for apps with migrations.
2014-10-27 06:56:44 -04:00
7f089ac2e3
Fixed #23446 -- Officially recommended mysqlclient as MySQL driver
...
Thanks Corey Farwell for the report and Tim Graham for the review.
Thanks also to Inada Naoki for creating and maintaining mysqlclient.
2014-10-27 09:11:33 +01:00
45db842c9b
Fixed #23652 -- Restored database name after destroying test database
...
Thanks Bjarkias for the report.
2014-10-24 17:04:43 +02:00
2c9a03d487
Fixed #23707 -- Prevented discovery of duplicated tests
2014-10-23 21:03:57 +02:00
92269b7b53
Fixed #23702 -- Fixed adding an explicit id field on SQLite.
...
Thanks gavinwahl for the report.
2014-10-23 12:24:34 -04:00
2d75515a4c
Fixed #23444 -- Deprecated django.contrib.admin.helpers.InlineAdminForm.original_content_type_id
2014-10-23 09:49:24 -04:00
70428902c0
Added missing available app in migrations test case
...
In some test combinations, having contrib.auth available but not
contrib.contenttypes can produce failures while creating permissions.
2014-10-23 15:39:26 +02:00
41b337efa0
Fixed #23630 -- Made AlterModelTable rename auto-created M2M tables.
...
Thanks Naddiseo for the report, Andrew Godwin for guidance,
and Shai Berger for review.
2014-10-23 08:05:39 -04:00
bc6caa5d45
Made a doctest compatible with Python 2
...
That test might not always execute, but can be executed when the
parent test label is explicitely given.
2014-10-23 11:16:17 +02:00
ef9e3c5ed8
Fixed flake8 warning.
2014-10-22 21:21:02 -04:00
28da093ae2
Allowed test from refs #23612 to be run from a directory other than tests.
2014-10-22 15:24:33 -04:00
b62f72498a
Improved warning message when reloading models. Refs #23621 .
...
Thanks dfunckt and Tim Graham.
2014-10-23 01:46:04 +07:00
8c4ca16c65
Fixed #23621 -- Warn for duplicate models when a module is reloaded.
...
Previously a RuntimeError was raised every time two models clashed
in the app registry. This prevented reloading a module in a REPL;
while it's not recommended to do so, we decided not to forbid this
use-case by turning the error into a warning.
Thanks @dfunckt and Sergey Pashinin for the initial patches.
2014-10-23 00:55:02 +07:00
eb82fb0a9d
Refactored color_style() and no_style() to improve testability. Refs #23663 .
...
This includes the following improvements:
- The type of the style object is now called 'Style' rather than 'dummy'.
- The new make_style() function allows generating a Style object directly
from a config string. Before the only way to get a style object was
through the environ and it also required that the terminal supported
colors which isn't necessarily the case when testing.
- The output of no_style() is now cached with @lru_cache.
- The output of no_style() now has the same set of attributes as the
other Style objects. Previously it allowed anything to pass through
with __getattr__.
2014-10-22 11:27:00 +07:00
bdb4118b1a
Fixed #23686 -- Tweak color output of the system check framework.
...
Thanks Tim Graham for the review.
2014-10-22 11:27:00 +07:00
494ba051bb
Made testing of stdout and stderr more consistent.
...
Refs #23663 .
2014-10-22 09:25:50 +07:00
533532302a
Fixed #23663 -- Initialize output streams for BaseCommand in __init__().
...
This helps with testability of management commands.
Thanks to trac username daveoncode for the report and to
Tim Graham and Claude Paroz for the reviews.
2014-10-22 09:25:50 +07:00
494cd857c8
Fixed #23653 -- Fixed Windows failure of a logging test added in refs #23569 .
2014-10-21 18:32:46 -04:00
bbc3505ef8
Removed unneeded override_system_checks
...
Refs #23685 .
2014-10-21 20:54:32 +02:00
8b4cc9df9c
Fixed #23583 -- More selectively ignored static/media roots
...
Fixed a regression introduced by 28efafa24c
2014-10-21 20:18:21 +02:00
c34e13e17c
Fixed #23107 -- Made runserver output respect --no-color.
...
This commit reverts 67d7da5fb9
2014-10-22 01:03:15 +07:00
9f1202c166
Fixed #23695 -- Made condition decorator work for HEAD requests without ETag.
2014-10-21 11:13:29 -04:00
0e16c3e3cd
Fixed #23396 -- Ensured ValueQuerySets are not checked by check_related_objects.
2014-10-21 10:02:51 -04:00
f0bb3c98cc
Fixed #21740 -- Allowed test client data to be an empty string
...
This fixes a regression introduced by 2a31d00933
2014-10-21 09:16:57 +02:00
edcb33c92e
Fix SettingsCustomLoggingTest on Windows when path contains \u
2014-10-20 21:49:44 -04:00
dbf7a3df45
Fixed #23688 -- Updated cached_property to preserve docstring of original function
2014-10-20 17:59:07 -04:00
54e695331b
Fixed #20221 -- Allowed some functions that use mark_safe() to result in SafeText.
...
Thanks Baptiste Mispelon for the report.
2014-10-20 17:08:29 -04:00
4fe6824ffd
Fixed #23679 -- Fixed null introspection for char/text fields
...
Thanks Paul Dejean for the report.
2014-10-20 22:37:19 +02:00
5732424bee
Fixed #23629 -- Allowed autodetector to detect changes in Meta.db_table.
...
Thanks Naddiseo for reporting.
2014-10-20 13:14:44 -04:00
6d11bb102d
Revert "Fixed #23650 -- Prevented migrate from calling checks 3 times"
...
This reverts commit 8d6e1afe0b
2014-10-20 17:26:00 +02:00
685edab9da
Fixed #23685 -- Made call_command skip checks by default
...
Thanks Loic Bistuer for the report/review and Tim Graham for the
review.
2014-10-20 17:26:00 +02:00
968510e5d7
Moved a test case that caused deprecation warnings.
...
`cache.tests.TestEtagWithAdmin` loaded views from the `admin_views` test
package. This is problematic because when the `cache` test package is
run in isolation, `admin_views` isn't in INSTALLED_APPS, and therefore
loading its models isn't allowed since the app loading refactor.
2014-10-20 00:22:48 +07:00
6c79d32977
Fixed #23684 -- Used correct package name for Pillow in Error hint.
2014-10-19 13:46:46 +07:00
825ea83858
Fixed #21196 -- Removed index on test field causing MySQL specific warning.
2014-10-19 13:44:39 +07:00
8d6e1afe0b
Fixed #23650 -- Prevented migrate from calling checks 3 times
...
Thanks Ilya Baryshev for the report and Tim Graham for the review.
2014-10-17 20:20:56 +02:00
7ae03204ac
Fixed #23469 -- Removed test runner compatibility check which often yielded false positives.
2014-10-17 10:31:49 -04:00
a5c77417a6
Fixed #23615 -- Validate that a Model instance's "check" attribute is a method.
...
The "check" name is a reserved word used by Django's check framework,
and cannot be redefined as something else other than a method, or the check
framework will raise an error.
This change amends the django.core.checks.model_check.check_all_models()
function, so that it verifies that a model instance's attribute "check"
is actually a method. This new check is assigned the id "models.E020".
2014-10-16 23:49:21 +07:00
157f9cf240
Minor cleanup in the check_framework test package.
2014-10-16 23:49:21 +07:00
b962653060
Fixed #23664 -- Provided a consistent definition for OrderedSet.__bool__
...
This also defines QuerySet.__bool__ for consistency though this should not have any consequence as bool(qs) used to fallback on QuerySet.__len__ in Py3.
2014-10-16 14:16:24 +02:00
374c14b7fd
Fixed #23659 -- Kept annotate() args ordering
...
Thanks Loic Bistuer and Simon Charette for the review.
2014-10-16 09:27:20 +02:00
f6c208d95c
Fixed a flake8 warning.
2014-10-15 16:36:11 -04:00
a6a8268d19
Fixed #23660 -- Moved sort_dependencies to core.
2014-10-16 03:04:13 +07:00
10b17a22be
Fixed #19508 -- Implemented uri_to_iri as per RFC.
...
Thanks Loic Bistuer for helping in shaping the patch and Claude Paroz
for the review.
2014-10-16 02:31:17 +07:00
3af5af1a61
Fixed remaining test failure in jslex tests.
2014-10-15 17:36:19 +02:00
2ccbaba1f2
Added unicode_literals to the jslexer.
...
This ensure that ''.join(c) in jslex.py always returns text.
2014-10-15 15:09:35 +02:00
7a893ee771
Fixed #23651 -- Isolated non-existent fixture tests
...
Previous versions of the tests were buggy, as initial_data.json
did exist and the test wasn't failing. It was finally failing on
Python 3.4.2.
Thanks Raphaël Hertzog for the report (and Debian bug #765117
contributors).
2014-10-15 09:17:44 +02:00
7131efa154
Adapted invalid cookie test to all Python versions
...
Refs #23638 . Older Python versions are less strict when parsing
invalid cookie content. The test just has to ensure Django doesn't
crash.
2014-10-14 09:30:26 +02:00
59d487e7fc
Fixed #23638 -- Prevented crash while parsing invalid cookie content
...
Thanks Philip Gatt for the report and Tim Graham for the review.
2014-10-13 17:37:58 +02:00
8d789449c7
Fixed #23063 -- Convert \n and \r to \r\n when using the SMTP backend as per RFC.
2014-10-12 22:01:24 +02:00
06b11b617e
Fixed #23616 - Fixed generic relations in ModelAdmin.list_filter.
...
Thanks ranjur for reporting bug, timgraham for review,
and collinanderson for contributing tips.
2014-10-10 12:10:32 -04:00
115c307184
Fixed #23613 -- Deprecated django.utils.checksums
2014-10-10 09:22:20 -04:00
4ef9618e12
Avoided requiring sqlparse for a test.
...
Refs #23426 . Thanks Markus Holtermann for the suggestion.
2014-10-09 14:59:33 -04:00
16ed35fafc
Fixed #23612 -- Normalized fixuture paths to allow referencing relative paths on Windows.
2014-10-09 14:58:20 -04:00
92a17eaae0
Fixed #23627 -- Allowed register_lookup to work as a decorator.
2014-10-09 18:44:58 +01:00
d6a87eefd8
Skip another test if sqlparse is not available
...
Refs #23426
2014-10-09 11:54:42 -04:00
f633ba778d
Fixed #23609 -- Fixed IntegrityError that prevented altering a NULL column into a NOT NULL one due to existing rows
...
Thanks to Simon Charette, Loic Bistuer and Tim Graham for the review.
2014-10-09 21:32:06 +07:00
30b44cea38
Fixed flake8 warning.
2014-10-08 18:10:50 -04:00
88b6cf4ae4
Fixed #23600 -- Made default_storage aware of more settings changes.
...
Added MEDIA_URL, FILE_UPLOAD_PERMISSIONS, and
FILE_UPLOAD_DIRECTORY_PERMISSIONS to the list of settings.
2014-10-08 18:10:47 -04:00
ca61195827
Fixed #23555 -- Avoided suppressing IndexError in QuerySet.first() and .last()
2014-10-08 14:28:38 -04:00
0eccf8fbea
Fixed misplaced test case.
2014-10-08 05:11:09 +07:00
ed37f7e979
Fixed #23611 -- update_or_create failing from a related manager
...
Added update_or_create to RelatedManager, ManyRelatedManager and
GenericRelatedObjectManager.
Added missing get_or_create to GenericRelatedObjectManager.
2014-10-08 03:27:31 +07:00
c1ef234e31
Fixed #23522 -- Changed reverse() to return a Unicode string; not bytes
2014-10-07 13:06:39 -04:00
d1e87aebf7
Refactored model lookup tests; refs #18586 .
2014-10-07 12:04:56 -04:00
9dff5ce7c7
Fixed #23593 -- Fixed crash in AdminEmailHandler with non-ASCII characters in request.
...
Thanks edevil for the report and Simon Charette for review.
2014-10-06 17:35:53 -04:00
6f6e7d01dc
Merge pull request #3308 from aericson/ticket_22064
...
Fixed #22064 -- Add check for related_name
2014-10-06 14:06:33 -06:00
ec2fd02bb3
Fixed #23594 -- Fixed deepcopy on ErrorList.
...
Thanks Troy Grosfield for the report and Tim Graham for the tests.
2014-10-07 00:09:55 +07:00
2f16ff5a6c
Fixed #23601 -- Ensured view exists in URLconf before importing it in admindocs.
2014-10-06 09:31:39 -04:00
a24cf21722
Fixed #23604 -- Allowed related m2m fields to be references in the admin.
...
Thanks Simon Charette for review.
2014-10-06 08:35:16 -04:00
1e5e2a4707
Fixed #22064 -- Add check for related_name
...
Validates that related_name is a valid Python id or ends with a '+' and
it's not a keyword. Without a check it passed silently leading to
unpredictable problems.
Thanks Konrad Świat for the initial work.
2014-10-04 20:47:26 -03:00
8c581ff394
Fixed #23482 -- Added SingleObjectMixin.query_pk_and_slug
...
Enabling the attribute causes get_object() to perform its lookup
using both the primary key and the slug.
2014-10-02 15:42:30 -04:00
85f6d89313
Fixed #23426 -- Allowed parameters in migrations.RunSQL
...
Thanks tchaumeny and Loic for reviews.
2014-10-02 11:52:40 -04:00
fe2afcd318
Fixed #23569 -- Allowed using configs besides dictConfig in LOGGING_CONFIG.
2014-09-30 17:13:27 -04:00
c7b5883c78
Fixed flake8 warnings.
2014-09-30 13:24:20 -04:00
f5cfd09c25
Fixed #7361 -- Added cancel link to admin delete views.
2014-09-30 08:45:04 -04:00
a407b846b4
Fixed #23365 -- Added support for timezone-aware datetimes to migrations.
2014-09-29 20:45:43 -04:00
311b3ad9db
Fixed #23567 -- Made assertQuerysetEqual check Counter equality when ordered=False
2014-09-29 12:00:14 -04:00
4b257cf261
Fixed flake8 warnings.
2014-09-29 08:13:40 -04:00
b2aad7b836
Replaced set([foo, ...]) by {foo, ...} literals. Refs PR 3282.
...
Thanks Collin Anderson for the review.
2014-09-29 00:01:38 +07:00
c1ae0621ba
Fixed #22738 -- made finer distinctions for when Boolean is not detected on Oracle
...
Thanks Claude Paroz for partial fix and Simon Charrette for review
2014-09-27 09:49:50 +03:00
dbdae3a755
Fixed #22738 -- Abstracted boolean field type introspection
...
Thanks maxi for the report, Shai Berger for his help with the patch
and Tim Graham for the review.
2014-09-26 20:03:44 +02:00
b23d47412c
Fixed #23560 -- Fixed MigrationWrite to handle builtin types without imports.
...
Thanks Tim Graham for the review.
2014-09-27 00:36:28 +07:00
ef5f9b6ae8
Fixed #23460 -- Added literal `%s` support to extra() QuerySets.
2014-09-26 13:01:27 -04:00
17557d068c
Fixed #8408 -- Added ModelAdmin.show_full_result_count to avoid COUNT() query.
...
Thanks lidaobing for the suggestion.
2014-09-26 12:12:40 -04:00
45bd7b3bd9
Fixed #23455 -- Forced related_name to be a unicode string during deconstruction.
2014-09-25 17:49:44 -04:00
d8e157d5ab
Refactored m2m_through tests. Refs #18586
...
Refactored old tests that were rewritten 1:1 from doctests.
2014-09-26 01:28:32 +07:00
215aa4f53b
Fixed #23415 -- Added fields for unmanaged and proxy model migrations.
...
Thanks sky-chen for the report.
2014-09-25 10:25:03 -04:00
e077c29155
Fixed #23551 -- Fixed bash autocompletion crash on Python 3.
2014-09-25 07:44:22 -04:00
d7ab2cefb7
Revert "Fixed #23474 -- Prevented migrating backwards from unapplying the wrong migrations."
...
This reverts commit abcf28a076
2014-09-24 15:49:30 -04:00
a4f23eba2e
Fixed #23421 -- Corrected TEST SERIALIZE setting.
...
Thanks gkoller for the report.
2014-09-24 14:46:10 -04:00
b9a670b227
Fixed #23426 -- Don't require double percent sign in RunSQL without parameters
2014-09-24 07:20:57 -04:00
0aca91cf7f
Fixed flake8 warnings.
2014-09-24 06:32:42 -04:00
cf43a1ee90
Fixed #23539 -- Added get_extra(), get_max_num(), and get_min_num() hooks to GenericInlineModelAdmin.
2014-09-24 06:32:42 -04:00
Anssi Kääriäinen
Tim Graham
Claude Paroz
Markus Holtermann
Josh Smeaton
Aymeric Augustin
Michał Modzelewski
Daniel Pyrathon
Danilo Bargen
Preston Timmons
Collin Anderson
Andriy Sokolovskiy
Thomas Tanner
Andrey Maslov
Will Earp
Piotr Pawlaczek
Berker Peksag
Ramiro Morales
Gavin Wahl
Niclas Olofsson
Thomas Chaumeny
Oscar Ramirez
Marc Tamlyn
Josh Schneier
Jernej Kos
Mosson, Andrew
Diego Guimarães
Michael Hall
Carl Meyer
Kevin Marsh
Grzegorz Slusarek
Shabda Raaj
Sergey Parkhomenko
Jon Dufresne
Thomas Chaumeny
Helen ST
Ramiro Morales
Alexander Shchapov
Eric Rouleau
Shai Berger
Kamil Braun
wrwrwr
Tim Heap
Martin Blech
MattBlack85
Baptiste Mispelon
Simon Charette
Redouane Zait
Luke Plant
Adam Alton
Sergey Fedoseev
Alasdair Nicol
Andrzej Pragacz
Jay
Brad Walker
Patryk Zawadzki
Stratos Moros
Anton Baklanov
Tillmann Karras
Ilja Maas
Julien Phalip
Karen Tracey
Andrew Godwin
Daan Vielen
Klaas van Schelven
Michael Manfre
Adam DePue
Sean Wang
Jozef Knaperek
averybigant
Peter Inglesby
Veres Lajos
Zan Anderle
Davide Ceretti
Michael Kelly
Andy Chosak
Unai Zalakain
Konrad Świat
twidi
Rigel Di Scala
Tony Zhu
a1tus
Loic Bistuer
Anton Novosyolov
Gabe Jackson
John-Scott Atlakson
Tianyi Wang
Nicholas Serra
Anubhav Joshi
Florian Apolloner
Jaap Roes
Brandon Taylor
Duncan Parkes
Artem Rizhov
Browniebroke
Emmanuelle Delescolle
André Ericson
Seth Hill
Nick Sandford
Rudy Mutter
Matt Robenolt
Davide Ceretti
Marco Buttu
Justin Caratzas