7c08f26bf0
Fixed #32260 -- Made View.as_view() do not use update_wrapper().
...
View.as_view() should not use update_wrapper() for copying attributes
it's unintended and have side-effects such as adding `self` to the
signature.
This also fixes system check for arguments of custom error handler
views with class-based views.
Co-authored-by: Nick Pope <nick.pope@flightdataservices.com>
2021-03-30 07:58:09 +02:00
3f7b327562
Fixed #31235 -- Made assertQuerysetEqual() compare querysets directly.
...
This also replaces assertQuerysetEqual() to
assertSequenceEqual()/assertCountEqual() where appropriate.
Co-authored-by: Peter Inglesby <peter.inglesby@gmail.com>
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2020-11-06 09:24:50 +01:00
bcc2befd0e
Fixed #31789 -- Added a new headers interface to HttpResponse.
2020-09-14 08:41:59 +02:00
bb8f66934d
Fixed #31877 -- Reverted "Fixed #19878 -- Deprecated TemplateView passing URL kwargs into context."
...
This reverts commit 4ed534758c
2020-08-24 11:37:59 +02:00
04e87e79a0
Refs #31877 -- Reverted "Fixes #31877 -- Used lazy() for TemplateView kwarg deprecation warning."
...
This reverts commit 20799cc0a6
2020-08-24 11:37:59 +02:00
20799cc0a6
Fixes #31877 -- Used lazy() for TemplateView kwarg deprecation warning.
...
SimpleLazyObjects cause a crash when filtering.
Thanks Tim L. White for the report.
Regression in 4ed534758c
2020-08-13 07:26:10 +02:00
8984cab8a8
Fixed #31620 -- Added support for %V format to WeekMixin/WeekArchiveView.
...
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2020-06-26 11:12:57 +02:00
4ed534758c
Fixed #19878 -- Deprecated TemplateView passing URL kwargs into context.
2020-03-23 08:11:14 +01:00
2ea3fb3e63
Removed "Don't do that" from docs and error messages.
...
It's slightly aggressive and doesn't explain itself.
2020-01-06 13:50:43 +01:00
c2c27867ef
Refs #20456 -- Moved initialization of HEAD method based on GET to the View.setup() for generic views.
...
This will ease unit testing of views since setup will essentially do
everything needed to set the view instance up (other than instantiating
it). Credit for idea goes to Vincent Prouillet.
2019-10-30 14:43:52 +01:00
31d1822532
Refs #20456 -- Added test for initialization of request/args/kwargs attributes in View.Setup().
2019-10-30 14:43:47 +01:00
b916c27f9a
Fixed typo in tests/generic_views/test_base.py.
2019-06-04 20:09:07 -04:00
e671337e8b
Fixed #29750 -- Added View.setup() hook for class-based views.
2018-12-21 19:01:11 -05:00
fbc7e41389
Tested exception messages in generic_views tests.
2018-12-04 22:52:19 -05:00
0f212db29d
Made reused RequestFactory instances class attributes.
2018-11-27 09:49:02 -05:00
d0af5de122
Moved duplicate author declarations to setUpTestData() in DeleteViewTests.
2018-11-13 17:27:24 -05:00
9b110f0a84
Moved duplicate author declarations to setUpTestData() in UpdateViewTests.
2018-11-09 15:26:52 +01:00
c1c68d1ac0
Increased test coverage of django/views/generic/dates.py.
2018-10-30 14:27:48 -04:00
4f8f1b2f24
Fixed #29903 -- Added error message for invalid WeekArchiveView week_format.
2018-10-29 14:22:42 -04:00
4c13b90702
Added test coverage for views.generic.dates.MonthMixin.get_month() KeyError branch.
2018-10-27 18:37:44 -04:00
fcd431c6c3
Improved generic detail view error message for when pk or slug is missing.
2018-01-17 10:58:05 -05:00
ac6a4eb9f9
Fixed #28719 -- Added a helpful exception if MultipleObjectTemplateResponseMixin doesn't generate any template names.
2017-11-07 18:46:52 -05:00
df41b5a05d
Fixed #28593 -- Added a simplified URL routing syntax per DEP 0201.
...
Thanks Aymeric Augustin for shepherding the DEP and patch review.
Thanks Marten Kenbeek and Tim Graham for contributing to the code.
Thanks Tom Christie, Shai Berger, and Tim Graham for the docs.
2017-09-20 18:04:42 -04:00
5848305218
Fixed #28082 -- Made BaseDateListView pass context from get_dated_items() to subclasses.
...
Thanks leon-matthews for the report and fix.
2017-09-04 10:55:18 -04:00
a51c4de194
Used assertRaisesMessage() to test Django's error messages.
2017-07-29 19:07:23 -04:00
604341c85f
Fixed #28331 -- Added ContextMixin.extra_context to allowing passing context in as_view().
2017-07-06 10:34:54 -04:00
2c69824e5a
Refs #23968 -- Removed unnecessary lists, generators, and tuple calls.
2017-06-01 19:08:59 -04:00
c2eea61dff
Fixed #28209 -- Made date-based generic views return a 404 rather than crash when given an out of range date.
2017-05-30 13:20:35 -04:00
d611a89238
Decreased max_length for char fields unless absolutely needed. ( #8485 )
2017-05-10 17:33:46 +02:00
fede65260a
Fixed #26911 -- Removed NoReverseMatch silencing in RedirectView.
2017-03-01 15:56:39 -05:00
d6eaf7c018
Refs #23919 -- Replaced super(ClassName, self) with super().
2017-01-25 12:23:46 -05:00
dc8834cad4
Refs #23919 -- Removed unneeded force_str calls
2017-01-20 08:44:31 +01:00
cecc079168
Refs #23919 -- Stopped inheriting from object to define new style classes.
2017-01-19 08:39:46 +01:00
f3c43ad1fd
Refs #23919 -- Removed python_2_unicode_compatible decorator usage
2017-01-18 13:44:34 +01:00
d7b9aaa366
Refs #23919 -- Removed encoding preambles and future imports
2017-01-18 09:55:19 +01:00
e744c7e459
Imported specific models in a few tests that didn't.
2016-12-08 11:14:15 -05:00
967be82443
Fixed E305 flake8 warnings.
2016-11-14 12:30:46 -05:00
321e94fa41
Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings.
2016-11-10 21:30:21 -05:00
c9ae09addf
Replaced use of TestCase.fail() with assertRaises().
...
Also removed try/except/fail antipattern that hides exceptions.
2016-06-28 11:21:26 -04:00
78963495d0
Refs #17209 -- Added LoginView and LogoutView class-based views
...
Thanks Tim Graham for the review.
2016-06-24 10:45:13 +02:00
4f336f6652
Fixed #26747 -- Used more specific assertions in the Django test suite.
2016-06-16 14:19:18 -04:00
92053acbb9
Fixed E128 flake8 warnings in tests/.
2016-04-08 10:12:33 -04:00
3d0dcd7f5a
Refs #26022 -- Used context manager version of assertRaises in tests.
2016-01-29 12:32:18 -05:00
16411b8400
Fixed #26013 -- Moved django.core.urlresolvers to django.urls.
...
Thanks to Tim Graham for the review.
2015-12-31 14:21:29 -05:00
e429c5186c
Fixed #26018 -- Prevented unecessary get_form() call in FormMixin.get_context_data().
...
Changed "dict.setdefault" to "if x in dict" pattern so that get_form() would not
be called unnecessarily, specifically in the case where FormMixin.form_invalid()
calls get_context_data() with the current form.
2015-12-30 17:29:39 -05:00
4b2dcfe04f
Fixed #26006 -- Fixed incorrect object reference in SingleObjectMixin.get_context_object_name().
2015-12-30 09:56:45 -05:00
13dba4dba3
Fixed #25780 -- Removed redundant status code assertions from tests
2015-11-21 18:12:33 +01:00
e171a83b15
Fixed #25548 -- Prevented FormView.form_invalid() from discarding its form argument.
2015-11-11 13:28:34 -05:00
7a48f9abf2
Renamed a test file that has no tests.
2015-11-07 21:28:13 +01:00
491de4f07c
Refs #23656 -- Required FormMixin.get_form() form_class parameter to be optional.
...
Per deprecation timeline.
2015-09-23 19:31:10 -04:00
Daniyal
Hasan Ramezani
Tom Carrick
Mariusz Felisiak
Adam Johnson
Felipe Lee
Tim Graham
François Freitag
Simon Charette
oliver
Vincent Poulailleau
Bjorn Kristinsson
Sjoerd Job Postmus
Sebastian Sassi
Mads Jensen
Bruno Alla
Jon Dufresne
Adit Biswas
Florian Apolloner
Grzegorz Tężycki
chillaranand
Claude Paroz
Simon Charette
Ramin Farajpour Cami
za
Marten Kenbeek
Chris Cogdon
Alex Morozov
lobziik