Commit Graph

10044 Commits

Author SHA1 Message Date
Simone Pellizzari 268ed9cd8a [2.2.x] Fixed #30332 -- Fixed crash of ordering by expressions with params in ArrayAgg and StringAgg.
Backport of d0315584b5 from master.
2019-04-06 15:15:40 +02:00
Nick Pope 9da25fb832 [2.2.x] Fixed #30324 -- Forced utf-8 encoding when loading the template for the technical 500 debug page.
Regression in 50b8493.
Related to ea542a9.

Backport of efb257a017 from master
2019-04-05 16:37:22 +02:00
msg 1279fb4a00 [2.2.x] Fixed #30307 -- Fixed incorrect quoting of database user password when using dbshell on Oracle.
Regression in acfc650f2a.

Backport of 755673e1bc from master
2019-04-04 10:07:57 +02:00
Tim Graham 917aa556a9 [2.2.x] Fixed #30289 -- Prevented admin inlines for a ManyToManyField's implicit through model from being editable if the user only has the view permission.
Backport of 8335d59200 from master.
2019-03-30 17:44:58 -04:00
sage 4a6d3f2580 [2.2.x] Fixed #30295 -- Fixed max_lengths.tests.MaxLengthORMTests when run in isolation.
Backport of 5a92bb0725 from master.
2019-03-28 12:05:57 -04:00
Matthias Kestenholz a86ffb3e0f [2.2.x] Fixed #30280 -- Restored Model.get_FIELD_display()'s coercion of lazy strings.
Reverted cc79c7ee63.

Backport of ea071870f9 from master.
2019-03-22 13:01:15 -04:00
oliver 8cff329802 [2.2.x] Used QuerySet.bulk_create() in a couple of postgres tests.
Follow up to 0ce2ad9ca4.
Backport of 2aaabe2004 from master.
2019-03-21 18:05:42 -04:00
Nick Pope cb36ca4a0f [2.2.x] Corrected settings names in SecurityMiddleware tests.
Backport of 413d50b5ff from master.
2019-03-20 20:15:59 -04:00
Tim Graham abd6fb1656 [2.2.x] Fixed serializers test crash if PyYAML isn't installed.
Follow up to a57c783dd4.

Backport of 55490ac746 from master
2019-03-20 16:07:36 +01:00
Mariusz Felisiak 505785a71d
[2.2.x] Fixed #30264 -- Fixed crash of test_parsing_year_less_than_70() on 32-bit systems.
Thanks Andreas Beckmann and Chris Lamb for the report.
Backport of c9888bc8ec from master
2019-03-20 13:46:31 +01:00
Simon Charette 883d87074d [2.2.x] Fixed #30258 -- Adjusted postgres schema value quoting of ranges.
Thanks Tilman Koschnick for the report and patch.

Backport of 386d89ab55 from master
2019-03-18 09:32:09 +01:00
Paveł Tyślacki 2a92e2e3c1 [2.2.x] Refs #30172 -- Prevented removing a model Meta's index/unique_together from removing Meta constraints/indexes.
Backport of 5c17c273ae from master.
2019-03-17 21:28:49 -04:00
Paveł Tyślacki 3dd5e71752 [2.2.x] Refs #30172 -- Prevented removing a field's check or unique constraint from removing Meta constraints.
Backport of 4bb859e246 from master.
2019-03-17 21:28:36 -04:00
Paveł Tyślacki 40b0a58f5f [2.2.x] Fixed #30183 -- Added introspection of inline SQLite constraints.
Backport of 782d85b6df from master.
2019-03-15 20:01:36 -04:00
Jon Dufresne 87fad5a392 [2.2.x] Cleaned up exception message checking in some tests.
Backport of 95b7699ffc from master.
2019-03-15 19:28:13 -04:00
Matt Westcott 985e6c224b [2.2.x] Fixed #30254 -- Allowed model metaclasses to access the attribute dict in __init__().
Regression in a68ea23101.

Backport of 58ad030d05 from master.
2019-03-14 21:23:19 -04:00
Herman S d8704a4d4f [2.2.x] Fixed #30237 -- Made Authentication/SessionMiddleware and ModelBackend admin checks allow subclasses.
Backport of f976ab1b11 from master.
2019-03-14 20:36:11 -04:00
Mariusz Felisiak b150d99460 [2.2.x] Simplified test_transform()s in db_functions.math.
Backport of 258110d6cd from master.
2019-03-14 19:42:21 -04:00
Mariusz Felisiak a9ce7e2bcd
[2.2.x] Fixed serializers tests for PyYAML 5.1+.
Backport of a57c783dd4 from master
2019-03-14 18:37:46 +01:00
Mariusz Felisiak cf903c4c0b
[2.2.x] Reverted "Fixed relative paths imports per isort 4.3.5."
This reverts commit 463fe11bc8 due to
restore of relative paths sorting from isort < 4.3.5 in isort 4.3.10.
Backport of b435f82939 from master
2019-03-03 19:35:37 +01:00
Matthias Kestenholz 459f7c804d [2.2.x] Fixed #30179 -- Fixed form Media merging when pairwise merging is insufficient.
Thanks gasman for the tests, and codingjoe and timgraham for the review.

Backport of 231b513926 from master.
2019-02-27 17:16:58 -05:00
Matthias Kestenholz 77e53da127 [2.2.x] Refs #30179 -- Moved topological sort functions to django.utils.
Backport of e04209e181 from master.
2019-02-27 17:16:48 -05:00
shiningfm 4dac17ac93 [2.2.x] Fixed #30215 -- Fixed autoreloader crash for modules without __spec__.
Regression in c8720e7696.
Backport of 99cfb28e99 from master.
2019-02-27 10:35:45 -05:00
Mariusz Felisiak 370a145996
[2.2.x] Fixed relative paths imports per isort 4.3.5.
Backport of 463fe11bc8 from master
2019-02-25 19:50:12 +01:00
Tim Graham 9a5f87a69c [2.2.x] Fixed a failure when running tests on systems with SQLite < 3.8.3.
Backport of 36300ef336 from master.
2019-02-21 16:39:42 -05:00
Simon Charette 7f25344c2e [2.2.x] Fixed #30193, Refs #28478 -- Avoided PostgreSQL connection health checks on initialization.
This addressed a regression introduced by a96b901932 as identified by Ran Benita.
Backport of 7071f8f272 from master
2019-02-20 11:01:03 +01:00
Jon Dufresne 37cc6a9dce [2.2.x] Fixed #30171 -- Fixed DatabaseError in servers tests.
Made DatabaseWrapper thread sharing logic reentrant. Used a reference
counting like scheme to allow nested uses.

The error appeared after 8c775391b7.
Backport of 76990cbbda from master.
2019-02-14 10:05:13 -05:00
Tim Graham 6cdc7ae23f [2.2.x] Refs #25175 -- Renamed test file referencing the old postgresql_psycopg2 engine.
Backport of ddb2936852 from master
2019-02-13 17:27:27 -05:00
Dan Davis 5e94c817ee [2.2.x] Fixed #30184 -- Removed ellipsis characters from shell output strings.
Partially reverted 50b8493581 (refs #29654)
to avoid a crash when the user shell doesn't support non-ASCII characters.
Backport of 2bd8df243a from master.
2019-02-13 14:00:53 -05:00
Semen Zhydenko a536cf1f9f [2.2.x] Fixed spelling mistakes in comments and tests.
Backport of 255d6a26a8 from master.
2019-02-11 08:56:10 -05:00
Carlton Gibson 83ab3e2664 [2.2.x] Fixed CVE-2019-6975 -- Fixed memory exhaustion in utils.numberformat.format().
Thanks Sjoerd Job Postmus for the report and initial patch.
Thanks Michael Manfre, Tim Graham, and Florian Apolloner for review.

Backport of 402c0caa85 from master
2019-02-11 11:10:38 +01:00
Matthias Kestenholz e1bd94496b [2.2.x] Fixed #30153 -- Fixed incorrect form Media asset ordering after three way merge.
Delaying merging assets as long as possible avoids introducing
incorrect relative orderings that cause a broken final result.
Backport of 959d0c078a from master.
2019-02-09 09:39:15 -05:00
Claude Paroz caaa01142d [2.2.x] Fixed #29825 -- Fixed JS ngettext if the string is a non-plural msgid in the catalog.
Backport of 16454ac35f from master.
2019-01-28 18:17:52 -05:00
Tom Forbes 728358c5cf [2.2.x] Fixed #25624 -- Fixed autoreload crash with jinja2.ModuleLoader.
Backport of 1e92407f83 from master.
2019-01-28 14:42:46 -05:00
Paveł Tyślacki 2ca200a7c3 [2.2.x] Made test table cleanup in OperationTestBase more robust.
Some non-unique constraint names were added in
b69f8eb04c which resulted in failures
depending on the order in which tests were run.

Backport of 62b8596616 from master.
2019-01-28 13:48:04 -05:00
Tim Graham d3b4f4b962 [2.2.x] Refs #30055 -- Added a helpful error when SQLite is too old.
Backport of 7444f32527 from master.
2019-01-28 11:21:47 -05:00
Tim Graham 710052fee9 [2.2.x] Refs #30111 -- Fixed test cleanup in postgres_tests/test_integration.py.
Fixed "ERROR: Step ‘Publish JUnit test result report’ failed: No test report
files were found. Configuration error?" on Jenkins because report files were
put in tests/postgres_tests.

Backport of 2de7eb6f4d from master.
2019-01-23 13:17:29 -05:00
Nasir Hussain 6ce7887f13 [2.2.x] Fixed #30111 -- Fixed AppRegistryNotReady error with django.contrib.postgres in INSTALLED_APPS.
Regression in e192223ed9.
Backport of 2804b8d215 from master.
2019-01-22 17:50:00 -05:00
Jon Dufresne 28fb4ed5d9 [2.2.x] Fixed #30121 -- Fixed assertURLEqual() crash with reverse_lazy() URLs.
Regression in 24959e48d9.
Backport of d15c61cabb from master.
2019-01-21 09:31:45 -05:00
Simon Charette 6516e49262 [2.2.x] Fixed #30120 -- Fixed invalid SQL in distinct aggregate.
Regression in bc05547cd8 (refs #28658).
Backport of 65858119d2 from master.
2019-01-21 09:24:47 -05:00
Mariusz Felisiak 70aeb6ab01 [2.2.x] Fixed #30117 -- Fixed SchemaEditor.quote_value() test for mysqlclient 1.4.0+.
Backport of f05c02c4b8 from master
2019-01-19 13:33:28 +01:00
Tim Graham ee9bd8c310 [2.2.x] Refs #30097 -- Fixed typos in InlineModelAdmin.has_add_permission() deprecation comments. 2019-01-17 18:40:11 -05:00
Simon Charette f84ad16ba4 Refs #17198 -- Detected existing total ordering in admin changelist.
Appending pk is not necessary when a subset of the ordering expressions is
contained in a non-nullable unique contraint.

Related field ordering through lookups and related ordering introspection is
omitted for simplicitly purpose.
2019-01-17 16:22:14 +01:00
Simon Charette 9e5e5a657b Fixed #30044 -- Raised a FieldError on inherited field update attempts. 2019-01-16 14:09:51 -05:00
Santiago Basulto 4fc35a9c3e Fixed #20147 -- Added HttpRequest.headers. 2019-01-16 13:38:47 -05:00
Simon Charette aa5d0a5a90 Removed unnecessary transaction wrapping in expressions test. 2019-01-16 13:23:55 -05:00
Arthur Rio 181fb60159 Fixed #11154, #22270 -- Made proxy model permissions use correct content type.
Co-Authored-By: Simon Charette <charette.s@gmail.com>
Co-Authored-By: Antoine Catton <acatton@fusionbox.com>
2019-01-16 10:07:28 -05:00
Collin Anderson 769355c765 Fixed #9475 -- Allowed RelatedManager.add(), create(), etc. for m2m with a through model. 2019-01-15 11:12:17 -05:00
Nasir Hussain f021c110d0 Fixed #30099 -- Fixed invalid SQL when filtering a Subquery by an aggregate. 2019-01-15 07:22:59 -05:00
Mariusz Felisiak 1508e71c5b Relaxed assertions to fix GIS test failures on Oracle 18c. 2019-01-14 18:32:42 -05:00
Simon Charette b181aba7dd Refs #28478 -- Prevented database feature based skipping on tests disallowing queries.
Database features may require a connection to be established to determine
whether or not they are enabled.
2019-01-14 16:16:30 -05:00
Simon Charette f5b635086a Refs #28478 -- Prevented connection attempts against disallowed databases in tests.
Mocking connect as well as cursor methods makes sure an appropriate error
message is surfaced when running a subset of test attempting to access a
a disallowed database.
2019-01-14 16:05:00 -05:00
Nick Pope 6d4efa8e6a Refs #28643 -- Changed Variance() to use NumericOutputFieldMixin.
Keeps precision instead of forcing DecimalField to FloatField.
2019-01-14 14:39:46 -05:00
Nick Pope e85afa5943 Refs #28643 -- Changed StdDev() to use NumericOutputFieldMixin.
Keeps precision instead of forcing DecimalField to FloatField.
2019-01-14 14:38:00 -05:00
Nick Pope c690afb873 Refs #28643 -- Changed Avg() to use NumericOutputFieldMixin.
Keeps precision instead of forcing DecimalField to FloatField.
2019-01-14 14:35:41 -05:00
Sergey Fedoseev b86bb47818 Fixed #30093 -- Fixed ordering of combined queryset ordered by F expressions. 2019-01-14 10:28:11 -05:00
Simon Charette b2c598e30d Removed unnecessary skipUnlessDBFeature.
None of the tests interact with the database.
2019-01-13 21:48:40 -05:00
Tom Forbes c8720e7696 Fixed #27685 -- Added watchman support to the autoreloader.
Removed support for pyinotify (refs #9722).
2019-01-13 20:33:47 -05:00
Simon Charette a02a6fd580 Refs #28478 -- Prevented connection creation in model_indexes tests.
Entering a SchemaEditor instance creates a connection but it isn't needed
for this test.
2019-01-13 13:47:08 -05:00
orlnub123 573f44d62f Fixed #30057 -- Fixed diffsettings ignoring custom configured settings.
Regression in 49b679371f.
2019-01-12 11:07:03 -05:00
Nick Pope abf8e390a4 Refs #28643 -- Added Reverse database function.
Thanks Mariusz Felisiak for Oracle advice and review.
2019-01-12 10:45:48 -05:00
Paveł Tyślacki b69f8eb04c Fixed #30062 -- Added support for unique conditional constraints. 2019-01-12 09:50:20 -05:00
Paveł Tyślacki f4c0c0b0aa Added tests for Check/UniqueConstraint.__eq__(). 2019-01-12 09:24:22 -05:00
can e192223ed9 Fixed #29738 -- Allowed serializing psycopg2 range types in migrations. 2019-01-11 19:32:26 -05:00
can 7d3b3897c1 Refs #29738 -- Allowed registering serializers with MigrationWriter. 2019-01-11 18:13:16 -05:00
MaximZemskov 3c01fe30f3 Fixed #30097 -- Made 'obj' arg of InlineModelAdmin.has_add_permission() optional.
Restored backwards compatibility after refs #27991.
Regression in be6ca89396.
2019-01-11 18:02:43 -05:00
Tim Graham 8f4eee1777
Moved django.db.migrations.writer.SettingsReference to django.conf.
Reduces the possibility of circular imports.
2019-01-11 15:28:22 -05:00
Sanyam Khurana 76d31be2d0 Refs #23829 -- Made ping_google command/function use https for the sitemap URL. 2019-01-11 10:32:22 -05:00
Simon Charette 41e73de39d Fixed #28478 -- Make DiscoverRunner skip creating unused test databases.
SimpleTestCase.databases makes it possible to determine the set of
databases required to run the discovered tests.
2019-01-10 19:11:21 -05:00
Simon Charette 8c775391b7 Refs #28478 -- Deprecated TestCase's allow_database_queries and multi_db in favor of databases. 2019-01-10 19:11:21 -05:00
Paveł Tyślacki 647be06538 Renamed variables after generalization of constraints.
Follow up to 8eae094638.
2019-01-10 18:54:41 -05:00
Mads Jensen 4b9d72210f Refs #28643 -- Added NullIf database function.
Thanks Nick Pope, Mariusz Felisiak, and Tim Graham for reviews.
2019-01-10 12:10:12 -05:00
Joshua Cannon db1b10ef0d Fixed #30037 -- Added request arg to RemoteUserBackend.configure_user(). 2019-01-09 20:01:04 -05:00
Simon Charette bc05547cd8 Fixed #28658 -- Added DISTINCT handling to the Aggregate class. 2019-01-09 17:52:36 -05:00
Benjy Weinberger 222caab68a Fixed #30071 -- Fixed error message when a 'default' database isn't provided. 2019-01-09 10:58:37 -05:00
Benjy Weinberger c2c85663e2 Fixed #30087 -- Tested error handling for empty 'default' database. 2019-01-09 10:58:25 -05:00
Nick Pope a35d2a4510 Refs #23748 -- Added AutoField introspection for SQLite. 2019-01-09 09:59:15 -05:00
Tom Hacohen 1ecc0a395b Fixed #30070, CVE-2019-3498 -- Fixed content spoofing possiblity in the default 404 page.
Co-Authored-By: Tim Graham <timograham@gmail.com>
2019-01-03 21:21:55 -05:00
Mariusz Felisiak e49ab72637
Refs #29851 -- Fixed test_subquery_row_range_rank() crash on MariaDB 10.2+.
Thanks Tom Forbes for the report.
2019-01-03 20:18:45 +01:00
Tim Graham b5fe97a34e Added __init__.py for db_utils tests. 2019-01-02 18:19:45 -05:00
Tim Graham 0004daa536
Used 4 space hanging indent for dictionaries.
Thanks Mariusz Felisiak for auditing.
2019-01-02 18:18:19 -05:00
Tim Graham e4a714b259 Pinned Pillow != 5.4.0 in test requirements.
There's a bug that causes a test failure in forms_tests:
https://github.com/python-pillow/Pillow/pull/3501/files#r244651761.
2019-01-02 17:15:39 -05:00
Patrik Sletmo 14e2b1b065 Fixed #29981 -- Fixed inline formsets with a OnetoOneField primary key that uses to_field. 2019-01-01 10:40:22 -05:00
Tim Graham 02c07be95c Fixed #30050 -- Fixed InlineModelAdmin.has_change_permission() called with non-None obj during add.
Thanks andreage for the report and suggested fix.
2019-01-01 09:42:14 -05:00
Paveł Tyślacki 0123b67f6b Fixed #30060 -- Moved SQL generation for indexes and constraints to SchemaEditor. 2019-01-01 09:39:58 -05:00
Tim Graham 043bd70942 Updated test URL patterns to use path() and re_path(). 2018-12-31 10:47:32 -05:00
Tim Graham 1136d57f01
Updated a test to reflect the fact that "import *" isn't used in URLconfs anymore (refs #14675). 2018-12-31 10:24:28 -05:00
Matt Wiens e817ae74da Followed style guide for model attribute ordering. 2018-12-27 19:34:14 -05:00
Mariusz Felisiak dd8ed64113
Fixed #29851 -- Fixed crash of annotations with window expressions in Subquery. 2018-12-27 20:21:57 +01:00
Jon Dufresne 6fe9c45b72 Fixed #30024 -- Made urlencode() and Client raise TypeError when None is passed as data. 2018-12-27 11:19:55 -05:00
CHI Cheng b7dbd5ff68 Fixed broken links to PyYAML page. 2018-12-27 10:48:37 +01:00
Denis Stebunov 277de22984 Fixed #30058 -- Made SMTP EmailBackend.send_messages() return 0 for empty/error cases. 2018-12-26 13:33:08 -05:00
Tim Graham 0b54ab0675 Refs #30033 -- Fixed schema's test_m2m_rename_field_in_target_model test failure on SQLite < 3.20.
Mixing local test models with non-local models resulted in a referential
integrity error during tear down since the models are removed in separate
schema editor instances which each check constraints.

Failure appeared after 7289874adc.
2018-12-26 11:26:51 -05:00
Tim Graham b74b6736d0
Refs #29547 -- Skipped an unsupported partial index test on older versions of SQLite.
Follow up to e5b8626c0e.
2018-12-26 11:20:11 -05:00
Simon Charette 64f9776bc4 Refs #29004 -- Prevented inspectdb tests from flushing all tables data.
This is a costly operation on most database backends.
2018-12-24 15:32:39 -05:00
Simon Charette f6d8b0c47e Refs #26840 -- Corrected SQLite connection mocking in a setup_databases() test.
The test was expecting connections used by DiscoverRunner.setup_databases()
to be the ones defined in django.test.runner but this doesn't hold true
since this method was made a proxy of django.test.utils.setup_databases.

This broke the TransactionTestCase.serialized_rollback feature in the test
suite because calls to create_db_test() cleared the test data persisted on
connections objects.

Added an assertions to prevent this from happening again.
2018-12-24 15:32:27 -05:00
Nick Pope 83677faf86 Fixed #30056 -- Added SQLite support for StdDev and Variance functions. 2018-12-24 11:14:58 -05:00
Sanyam Khurana 5d25804eaf Fixed #20098 -- Added a check for model Meta.db_table collisions. 2018-12-24 10:40:11 -05:00
Nick Pope e626a3f993 Renamed Sqlite and Sqlite3 references to SQLite. 2018-12-22 18:52:54 -05:00
Nick Pope 7534e43497 Refs #14204 -- Removed obsolete referential integrity comment for SQLite. 2018-12-22 18:44:21 -05:00