Andrew Gorcester
f9ab543720
Fixed #20084 -- Provided option to validate formset max_num on server.
...
This is provided as a new "validate_max" formset_factory option defaulting to
False, since the non-validating behavior of max_num is longstanding, and there
is certainly code relying on it. (In fact, even the Django admin relies on it
for the case where there are more existing inlines than the given max_num). It
may be that at some point we want to deprecate validate_max=False and
eventually remove the option, but this commit takes no steps in that direction.
This also fixes the DoS-prevention absolute_max enforcement so that it causes a
form validation error rather than an IndexError, and ensures that absolute_max
is always 1000 more than max_num, to prevent surprising changes in behavior
with max_num close to absolute_max.
Lastly, this commit fixes the previous inconsistency between a regular formset
and a model formset in the precedence of max_num and initial data. Previously
in a regular formset, if the provided initial data was longer than max_num, it
was truncated; in a model formset, all initial forms would be displayed
regardless of max_num. Now regular formsets are the same as model formsets; all
initial forms are displayed, even if more than max_num. (But if validate_max is
True, submitting these forms will result in a "too many forms" validation
error!) This combination of behaviors was chosen to keep the max_num validation
simple and consistent, and avoid silent data loss due to truncation of initial
data.
Thanks to Preston for discussion of the design choices.
2013-03-21 01:27:24 -07:00
Claude Paroz
2f121dfe63
Fixed #17051 -- Removed some 'invalid' field error messages
...
When the 'invalid' error message is set at field level, it masks
the error message raised by the validator, if any.
2013-03-14 17:03:43 +01:00
Tim Graham
8e5fbebe02
Fixed #19801 - Added brackets to input_formats.
...
Thanks leandron85@ for the suggestion.
2013-02-25 12:22:02 -05:00
Claude Paroz
7ec2a21be1
Fixed #19686 -- Added HTML5 number input type
...
Thanks Simon Charette for his help on the patch. Refs #16630 .
2013-02-23 10:18:08 +01:00
Tim Graham
7a80904b00
Fixed #19812 - Removed a duplicate phrase in the widget docs.
...
Thanks diegueus9 for the report and itsallvoodoo for the draft patch.
2013-02-16 18:23:39 -05:00
Claude Paroz
f7394d2c32
Added HTML5 url input type
...
Refs #16630 .
2013-01-28 22:11:00 +01:00
Claude Paroz
4f16376274
Added HTML5 email input type
...
Refs #16630 .
2013-01-28 22:10:50 +01:00
Nick Sandford
93e79b45bc
Fixed #17416 -- Added widgets argument to inlineformset_factory and modelformset_factory
2013-01-24 08:58:17 +01:00
Tim Graham
0de2645c00
Fixed #19610 - Added enctype note to forms topics doc.
...
Thanks will@ for the suggestion.
2013-01-23 04:49:48 -05:00
Tim Graham
5b2d9bacd2
Fixed #19640 - Added inlineformset_factory to reference docs.
...
Thanks wim@ for the suggestion.
2013-01-22 07:55:34 -05:00
Tim Graham
71d76ec011
Fixed #10239 - Added docs for modelform_factory
...
Thanks ingenieroariel for the suggestion and slurms for the review.
2013-01-11 06:00:19 -05:00
Tim Graham
9b5f64cc6e
Fixed #19516 - Fixed remaining broken links.
...
Added -n to sphinx builds to catch issues going forward.
2013-01-02 18:32:57 -05:00
Aymeric Augustin
7ee7599ab3
Removed versionadded/changed annotations dating back to 1.4.
2012-12-29 21:59:08 +01:00
Claude Paroz
2d0b35d2bb
Added links to default widget in forms.fields documentation
2012-12-29 11:30:12 +01:00
Tim Graham
b3a8c9dab8
Fixed broken links, round 3. refs #19516
2012-12-26 19:07:22 -05:00
Tim Graham
04775b4598
Fixed #13997 - Added an example of constructing a MultiWidget and documented the value_from_datadict method.
2012-11-17 17:54:09 -05:00
Danilo Bargen
b0c72d0a30
Fixed invalid ipv4 mapped ipv6 addresses in docs
2012-11-07 17:13:06 +01:00
Claude Paroz
22742e4ac4
Added ref to format localization in Date[Time]Field docs
...
Thanks henrik@aisti.fi for the suggestion in #19119 .
2012-10-13 11:17:25 +02:00
Claude Paroz
10dc4797ea
Fixed #19119 -- Corrected default date input formats in docs
...
Thanks henrik@aisti.fi for the report.
2012-10-13 11:02:18 +02:00
Stephen Burrows
218abcc9e5
Fixed #14567 -- Made ModelMultipleChoiceField return EmptyQuerySet as empty value
2012-10-03 20:47:35 +03:00
Adrien Lemaire
2c8267bf3d
Fixed #17899 -- Rewrote [Ee]-mail to [Ee]mail
2012-09-26 14:14:51 +02:00
Tim Graham
837425b425
Fixed #18934 - Removed versionadded/changed annotations for Django 1.3
2012-09-20 19:06:55 -04:00
Tim Graham
a73838fde3
Fixed #11185 - Expanded docs on customizing widgets; thanks fadeev for the draft patch.
2012-09-15 06:22:00 -04:00
Claude Paroz
f1bdfbd24b
Document and test 'type' usage in Widget attrs
...
Refs #16630 .
2012-09-10 19:31:11 +02:00
Tim Graham
fa8fb2b383
Fixed #18490 - Updated DateField input formats; thanks dloewenherz for the draft patch.
2012-09-07 19:49:38 -04:00
James Bennett
46249061d6
Merge pull request #333 from brad/ticket_18917
...
clarify clean_<field> docs, ticket #18917
2012-09-07 12:00:01 -07:00
Alex Gaynor
6a5a12ea3e
Fixed #17888 -- no longer silence exceptions inside of check_test. Thanks to brutasse for the patch.
2012-09-07 14:37:21 -04:00
Brad Pitcher
c634375e9c
clarify clean_<field> docs, ticket #18917
2012-09-07 10:43:55 -04:00
Claude Paroz
121fd109de
Fixed #5524 -- Do not remove cleaned_data when a form fails validation
...
cleaned_data is no longer deleted when form validation fails but only
contains the data that did validate.
Thanks to the various contributors to this patch (see ticket).
2012-08-04 14:22:23 +02:00
Aymeric Augustin
5e94ef293c
Fixed #18374 -- Explained "corrupt image" error
...
Thanks fabian and charettes.
2012-07-08 11:53:45 +02:00
Tim Saylor
f8ef93a657
Fixed a documentation typo on the widget page.
2012-06-19 10:37:53 +02:00
Aymeric Augustin
33999d9871
Fixed #18445 -- Added a links in the docs.
...
Thanks Audrey Roy for the patch.
2012-06-07 22:11:24 +02:00
Claude Paroz
4a103086d5
Fixed #18269 -- Applied unicode_literals for Python 3 compatibility.
...
Thanks Vinay Sajip for the support of his django3 branch and
Jannis Leidel for the review.
2012-06-07 18:08:47 +02:00
Aymeric Augustin
c28e700c7e
Removed references to changes made in 1.2.
...
Thanks Florian Apolloner for the patch.
2012-06-07 15:02:35 +02:00
Jacob Kaplan-Moss
7edf231d46
Replaced documentation snippets using "gender" with less sensitive examples.
2012-06-06 13:52:53 +02:00
Aymeric Augustin
73f7d34699
Fixed #17950 -- Warned about usability limits of ModelChoiceField.
...
Thanks poirier for the report.
2012-05-10 22:01:11 +02:00
Claude Paroz
596cb9c7e2
Replaced print statement by print function (forward compatibility syntax).
2012-04-30 20:45:03 +02:00
Alex Gaynor
3c5ff9d703
Fixed #5893 -- Added a flag to FilePathField to allow listing folders, in addition to regular files. Thank you to Brian Rosner, for encouraging me to first contribute to Django 4 years ago.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17925 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-04-22 14:44:08 +00:00
Aymeric Augustin
9ed6e08ff9
Removed deprecated URLField.verify_exists.
...
The deprecation schedule was slightly accelerated because of possible security ramifications.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17847 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-03-31 13:55:03 +00:00
Jannis Leidel
52d72a5a3e
Fixed #17182 -- Changed best practice documentation for Form.clean to use super() instead of relying on self.cleaned_data. Thanks, DrMeers.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17433 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-02-04 16:05:30 +00:00
Adrian Holovaty
08bec4fbc1
Changed BoundField.subwidgets() to return SubWidget objects instead of rendered strings. This means we can access individual radio buttons' properties in the template (see new docs)
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17175 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-12-07 23:08:27 +00:00
Adrian Holovaty
fc90c09efd
Made BoundFields iterable, so that you can iterate over individual radio buttons of a RadioSelect in a template
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17173 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-12-07 22:31:39 +00:00
Luke Plant
d1e5c55258
Fixed many more ReST indentation errors, somehow accidentally missed from [16955]
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16983 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-14 00:12:01 +00:00
Julien Phalip
ca1e670499
Fixed some improper quotes in the form fields reference doc.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16821 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-12 07:15:47 +00:00
Julien Phalip
4e47df9de2
Fixed #16291 -- Documented that TypedChoiceField does not coerce empty_value. Thanks to vanschelven and taavi223.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16820 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-12 07:12:28 +00:00
Carl Meyer
84e0055e8d
Corrected documentation inconsistencies regarding deprecation of URLField.verify_exists.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16776 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-10 03:26:13 +00:00
Russell Keith-Magee
5f287f75f2
Altered the behavior of URLField to avoid a potential DOS vector, and to avoid potential leakage of local filesystem data. A security announcement will be made shortly.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16760 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-10 00:47:00 +00:00
Ramiro Morales
932b1b8d6d
Converted links to external topics so they use intersphinx extension markup.
...
This allows to make these links more resilent to changes in the target URLs.
Thanks Jannis for the report and Aymeric Augustin for the patch.
Fixes #16586 .
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16720 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-04 21:17:30 +00:00
Timo Graham
24a45a5fda
Fixed #16602 - Added forms.widgets TOC links to docs; thanks kencochrane.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16633 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-21 11:51:48 +00:00
Gabriel Hurley
40c8a603c3
Fixed #16591 -- Fixed some mismatched variable names in a widgets reference example. Thanks to santi.romero, el barto, and julien.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16626 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-18 22:39:20 +00:00