Anssi Kääriäinen
a4e97cf315
Fixed #19707 -- Reset transaction state after requests
2013-02-10 13:55:54 +02:00
Claude Paroz
718afcafc2
Added tests for some sql_* management commands
2013-02-09 16:34:22 +01:00
Claude Paroz
f44922c795
Fixed #18906 -- Ignored to-be-deleted forms in formset validate_unique
...
Thanks c.pollock at bangor.ac.uk for the report.
2013-02-08 21:35:19 +01:00
Julien Phalip
db09a2de6e
Cleaned up some lingering signals in the test suite that were causing spurious failures with Pypy and Postgres.
2013-02-08 12:12:03 -08:00
Ramiro Morales
b5391515cd
Changed test assertion strategy used in 04d9730
.
2013-02-07 16:51:27 -03:00
Ramiro Morales
04d9730b12
Fixed #13085 -- Don't fail on creation of model with GFK to a model with __len__() returning zero.
...
Also, according to the comments on the ticket and its duplicates, added
tests execising saving an instance of a model with a GFK to:
* An unsaved object -- This actually doesn't generate the same failure
but another ORM-level exception. The test verifies it's the case.
* An instance of a model with a __nonzero__() method thant returns False
for it. This doesn't fail because that code path isn't executed.
* An instance of a model with a CharField PK and an empty value for it.
This doesn't fail.
2013-02-07 16:05:54 -03:00
Aymeric Augustin
720888a146
Fixed #15808 -- Added optional HttpOnly flag to the CSRF Cookie.
...
Thanks Samuel Lavitt for the report and Sascha Peilicke for the patch.
2013-02-07 09:48:08 +01:00
Julien Phalip
6afc85af47
Fixed a typo in the test suite that was causing some spurious failures with pypy.
2013-02-06 22:10:13 -08:00
Alexey Boriskin
d18f796a48
Fixed #19704 -- Make use of new ungettext_lazy function at appropriate places
2013-02-06 22:01:55 +01:00
Claude Paroz
d7504a3d7b
Improved regex in strip_tags
...
Thanks Pablo Recio for the report. Refs #19237 .
2013-02-06 21:20:43 +01:00
Simon Charette
5449240c54
Fixed #9800 -- Allow "isPermaLink" attribute in <guid> element of an RSS item.
...
Thanks @rtnpro for the patch!
2013-02-06 05:28:05 -05:00
Simon Charette
a097ee32d8
Fixed #17683 -- Make sure `BaseModelFormSet` respects defined widgets.
2013-02-05 05:39:35 -05:00
Simon Charette
ec469ade2b
Fixed #19689 -- Renamed `Model._meta.module_name` to `model_name`.
2013-02-05 04:16:07 -05:00
Claude Paroz
40260bc30b
Fixed error message test assertions under Python 3.3
...
Thanks Florian Apolloner for testing.
2013-02-04 18:00:19 +01:00
Claude Paroz
7c5b244826
Fixed #17061 -- Factored out importing object from a dotted path
...
Thanks Carl Meyer for the report.
2013-02-04 16:38:25 +01:00
Ramiro Morales
869c9ba306
Fixed #19730 -- Don't validate importability of settings by using i18n in management commands.
...
They are handled independently now and the latter can be influenced by
the new BaseCommand.leave_locale_alone internal option.
Thanks chrischambers for the report, Claude, lpiatek, neaf and gabooo for
their work on a patch, originally on refs. #17379 .
2013-02-03 23:40:38 -03:00
Anssi Kääriäinen
f556df90be
Fixed #19645 -- Added tests for TransactionMiddleware
2013-02-03 16:26:46 +02:00
Julien Phalip
bc7a219b1e
Fixed Python 3.2 compatibility for a test.
2013-02-02 20:57:38 -08:00
Julien Phalip
293f7a2114
Fixed #17797 -- Enabled support for PATCH requests in the dummy test client. Thanks to pfarmer for the suggestion and initial patch.
2013-02-02 18:22:40 -08:00
Ramiro Morales
08dc90bccf
Fixed #14305 -- Switched inspectdb to create unmanaged models.
...
Thanks Ian Kelly for the report and initial patch.
2013-02-02 21:11:32 -03:00
Nick Sandford
0694d2196f
Fixed #19445 -- Skip admin fieldsets validation when the ModelAdmin.get_form() method is overridden.
2013-02-02 14:53:46 -08:00
Aymeric Augustin
ace9d4efc3
Made ungettext_lazy usable for messages that do not contain the count.
...
Fixed #19160 (again). Thanks Alexey Boriskin.
2013-02-02 10:58:31 +01:00
Aymeric Augustin
db5049c9f7
Fixed the test introduced in 2ca37af6
under Python 3.
2013-02-02 10:42:01 +01:00
Ramiro Morales
2ca37af621
Added test to demonstrate issue 11387 isn't there anymore.
...
Thanks adurdin for the report and patch. Fixes #11387 .
2013-02-01 23:30:50 -03:00
Ramiro Morales
c4b6659269
Added test to demonstrate issue 11263 isn't there anymore.
...
Thanks veena for the report and jaklaassen for the patch. Fixes #11263 .
2013-02-01 23:30:50 -03:00
Claude Paroz
04141c525d
Fixed #19663 -- Allowed None in colorize() text parameter
...
Thanks Jonathan Liuti for the report and the initial patch, and
Simon Charette for the review.
2013-02-01 22:53:18 +01:00
Matt Robenolt
393c268e72
Fixed #19715 -- Simplified findstatic output when verbosity set to 0
2013-02-01 11:55:05 +01:00
Simon Charette
339944491c
Renamed inspectdb field names for clarity
2013-02-01 09:16:29 +01:00
Claude Paroz
7bbd17bf20
Fixed #19341 -- Detected NullBooleanField when introspecting models
...
Thanks Tim Bowden for the report.
2013-01-31 20:55:00 +01:00
Claude Paroz
3c0a81aaf0
Fixed #19709 -- Fixed TimeField introspection on MySQL
...
Thanks Eugene Grachev for the report.
2013-01-31 20:41:57 +01:00
Claude Paroz
eb03fe1642
Added introspection tests for most of Django model fields
2013-01-31 20:41:57 +01:00
Ramiro Morales
7947c9e3a6
Deprecated undocumented warnings manipulation testing tools.
2013-01-31 14:57:45 -03:00
Aymeric Augustin
9a4a1ce323
Fixed #19708 -- Exception in timezone.override(None).
...
Thanks rafales.
2013-01-31 16:01:50 +01:00
Aymeric Augustin
89cb771be7
Fixed #19692 -- Completed deprecation of mimetype in favor of content_type.
...
Thanks Tim for the report and initial patch.
2013-01-31 13:54:40 +01:00
Aymeric Augustin
3895ebc734
Added file forgotten in 23e319d7
.
2013-01-30 22:11:53 +01:00
Aymeric Augustin
23e319d729
Fixed #19076 -- Added content_type attribute to TemplateView.
...
Thanks Gavin Wahl.
2013-01-30 21:26:17 +01:00
Aymeric Augustin
3f1a0c0040
Fixed #19160 -- Made lazy plural translations usable.
...
Many thanks to Alexey Boriskin, Claude Paroz and Julien Phalip.
2013-01-30 20:28:16 +01:00
Ramiro Morales
47ddd6a408
Fixed #19552 -- Enhanced makemessages handling of ``{# #}``-style template comments.
...
They are simply ignored now. This allows for a more correct behavior when
they are placed before translatable constructs on the same line.
Previously, the latter were wrongly ignored because the former were
preserved when converting template code to the internal Python-syntax
form later fed to xgettext but Python has no ``/* ... */``-style
comments.
Also, special comments directed to translators are now only taken in
account when they are located at the end of a line. e.g.::
{# Translators: ignored #}{% trans "Literal A" %}{# Translators: valid, associated with "Literal B" below #}
{% trans "Literal B" %}
Behavior of ``{% comment %}...{% endcomment %}``tags remains unchanged.
Thanks juneih at redpill-linpro dot com for the report and Claude for
his work on the issue.
2013-01-29 19:13:23 -03:00
Tim Graham
ee26797cff
Fixed typos in docs and comments
2013-01-29 10:55:55 -07:00
Claude Paroz
f7394d2c32
Added HTML5 url input type
...
Refs #16630 .
2013-01-28 22:11:00 +01:00
Claude Paroz
4f16376274
Added HTML5 email input type
...
Refs #16630 .
2013-01-28 22:10:50 +01:00
Aymeric Augustin
c47fa3b481
Fixed #19676 -- Supported 'self' foreign keys in inspectdb.
...
Thanks Georgy Kutsurua for the report and Simon Charette for the patch.
2013-01-28 10:21:07 +01:00
Aymeric Augustin
f46d7314b5
Fixed #19677 -- Introspection of recursive foreign keys under SQLite.
...
Thanks Simon Charette.
2013-01-28 10:17:56 +01:00
Claude Paroz
4b3f7110ae
Fixed #16123 -- Ensured strptime receive proper string type
...
strptime generates an UnicodeEncodeError when using a non-ascii
unicode string on Python 2.
2013-01-26 20:53:09 +01:00
Aymeric Augustin
6605ac331a
Fixed #17158 -- Used a non-ambiguous representation of SQL queries
...
when a correct representation cannot be obtained.
2013-01-26 17:51:44 +01:00
Aymeric Augustin
55416e235d
Fixed #19589 -- assertRegexpMatches is deprecated in Python 3.3.
2013-01-26 13:47:11 +01:00
Aymeric Augustin
424eb67867
Fixed validation of email addresses when the local part contains an @.
...
See also BaseUserManager.normalize_email -- it uses rsplit.
Refs #4833 .
2013-01-26 12:20:57 +01:00
Claude Paroz
ebb504db69
Moved has_changed logic from widget to form field
...
Refs #16612 . Thanks Aymeric Augustin for the suggestion.
2013-01-25 20:50:46 +01:00
Ramiro Morales
ce27fb198d
Revert "Patch by Claude for #16084."
...
This reverts commit 2babab0bb3
.
2013-01-25 13:58:37 -03:00
Ramiro Morales
2babab0bb3
Patch by Claude for #16084 .
2013-01-25 13:23:33 -03:00
Claude Paroz
b9c8bbf372
Fixed #19665 -- Ensured proper stderr output for Command.run_from_argv
...
Thanks Stefan Koegl for the report and Simon Charette for the review.
2013-01-25 14:56:41 +01:00
Ramiro Morales
57d439e2d4
More i18n makemessages tests tweaks.
2013-01-24 07:51:14 -03:00
Claude Paroz
9893fa12b7
Fixed #19125 -- The startproject command should validate the name earlier
...
Thanks Łukasz Rekucki for the report and the patch.
2013-01-24 09:26:13 +01:00
Nick Sandford
93e79b45bc
Fixed #17416 -- Added widgets argument to inlineformset_factory and modelformset_factory
2013-01-24 08:58:17 +01:00
Ramiro Morales
456f9b9847
Simplified a i18n test.
2013-01-21 23:22:18 -03:00
Claude Paroz
8ce1e392fa
Fixed error introduced when testing patch for 013db6ba85
...
Shame on me.
2013-01-21 22:42:47 +01:00
Claude Paroz
013db6ba85
Fixed #18051 -- Allowed admin fieldsets to contain lists
...
Thanks Ricardo di Virgilio for the report, Mateus Gondim for the
patch and Nick Sandford for the review.
2013-01-21 22:34:36 +01:00
Claude Paroz
c6e0dedbdb
Fixed #19637 -- Ensured AdminEmailHandler fails silently
...
Thanks lsaffre for the report. Refs #19325 .
2013-01-21 20:32:36 +01:00
Anssi Kääriäinen
7aa538357c
Cleaned up testing models.py added for earliest()
...
The main cleanup was removal of non-necessary __unicode__ method. The
tests didn't break on py3 as the string representation was never used
in the tests.
Refs #17813 . Thanks to Simon Charette for spotting this issue.
2013-01-20 08:53:45 +02:00
Nick Sandford
fe54377dae
Fixed #17813 -- Added a .earliest() method to QuerySet
...
Thanks a lot to everybody participating in developing this feature.
The patch was developed by multiple people, at least Trac aliases
tonnzor, jimmysong, Fandekasp and slurms.
Stylistic changes added by committer.
2013-01-20 06:39:35 +02:00
Craig Blaszczyk
6158c79dbe
Made (make|compile)messages commands accept multiple locales at once.
...
Thanks Craig Blaszczyk for the initial patch. Refs #17181 .
2013-01-17 00:53:17 -03:00
Ramiro Morales
295650bd01
Simplified i18n commands tests.
2013-01-17 00:35:46 -03:00
Ramiro Morales
248aee1606
Modified makemessages so it creates .pot files once per invocation.
...
It creates a `locale/django.pot` file once instead of one
`locale/<locale_code>/django.pot` file for every locale involved.
Thanks Michal Čihař for the report and patch.
2013-01-16 20:48:06 -03:00
Ramiro Morales
eee865257a
Fixed #17008 -- Added makemessages option to not remove .pot files.
...
Thanks airstrike for the report and initial patch, Julien for an
enhanced patch and Jannis for reviewing.
2013-01-16 20:29:06 -03:00
Aymeric Augustin
50a985b09b
Fixed #19099 -- Split broken link emails out of common middleware.
2013-01-15 17:41:45 +01:00
Alex Gaynor
984e91e28f
Removed some uses of the deprecated assertEquals
2013-01-15 07:51:33 -08:00
David Cramer
a7ed09d13d
Improve test to ensure that post_delete was actually called
2013-01-14 13:34:55 -08:00
David Cramer
6045efa029
Move signal disconnect into finally block
2013-01-14 13:15:47 -08:00
David Cramer
272de9eb6b
Send post_delete signals immediately
...
In a normal relational construct, if you're listening for an event
that signals a child was deleted, you dont expect that the parent
was deleted already.
This change ensures that post_delete signals are fired immediately
after objects are deleted in the graph.
2013-01-14 13:15:47 -08:00
Claude Paroz
0171ba65db
Fixed #17574 -- Implemented missing get_key_columns in PostgreSQL backend
2013-01-12 21:46:08 +01:00
Claude Paroz
bcdb4898ca
Fixed #19488 -- Made i18n_patterns redirect work with non-slash-ending paths
...
Thanks Daniel Gerzo for the report and the initial patch.
2013-01-11 21:27:51 +01:00
Claude Paroz
f08e739bc2
Fixed #19585 -- Fixed loading cookie value as a dict
...
This regression was introduced by the 'unicode_literals' patch.
2013-01-11 21:09:33 +01:00
Claude Paroz
4e2e8f39d1
Fixed #4833 -- Validate email addresses with localhost as domain
2013-01-11 20:45:46 +01:00
Nick Sandford
eb6c107624
Fixed #19360 -- Raised an explicit exception for aggregates on date/time fields in sqlite3
...
Thanks lsaffre for the report and Chris Medrela for the initial
patch.
2013-01-11 18:10:28 +01:00
Claude Paroz
2e55cf580e
Adapted test assertion against yaml dump
...
Fixes #12914 (again).
2013-01-11 17:52:53 +01:00
Loic Raucy
62f842e2e5
Fixed #19581 -- ensure unique html ids with CheckboxSelectMultiple widgets
...
ID check is now done the same way as MultipleHiddenInput.
2013-01-09 16:06:56 -08:00
Florian Apolloner
ce580dd8ea
Fixed lockups in jenkins, refs #19546 .
2013-01-09 23:32:51 +01:00
Claude Paroz
e6949373b0
Skipped deprecation warning test on Python 2.6
...
Refs #19546 . On Python 2.6, DeprecationWarnings are visible by
default.
2013-01-09 20:02:09 +01:00
Preston Holmes
cfa70d0c94
Fixed #19546 - ensure that deprecation warnings are shown during tests
...
refs #18985
2013-01-09 08:19:22 -08:00
Anssi Kääriäinen
55da775ce1
Fixed #17541 -- Fixed non-saved/nullable fk querying
2013-01-08 21:02:38 +02:00
Claude Paroz
34ee7d9875
Updated deprecated test assertions
2013-01-08 19:08:15 +01:00
Anssi Kääriäinen
23ca3a0194
Fixed #16759 -- Remove use of __deepcopy__ in qs.clone()
...
The original problem was that queryset cloning was really expensive
when filtering with F() clauses. The __deepcopy__ went too deep copying
_meta attributes of the models used. To fix this the use of
__deepcopy__ in qs cloning was removed.
This commit results in some speed improvements across the djangobench
benchmark suite. Most query_* tests are 20-30% faster, save() is 50%
faster and finally complex filtering situations can see 2x to order
of magnitude improvments.
Thanks to Suor, Alex and lrekucki for valuable feedback.
2013-01-08 19:17:13 +02:00
Claude Paroz
c698c55966
Created special PostgreSQL text indexes when unique is True
...
Refs #19441 .
2013-01-07 17:54:30 +01:00
Anssi Kääriäinen
69a46c5ca7
Tests for various emptyqs tickets
...
The tickets are either about different signature between qs.none() and
qs or problems with subclass types (either EmptyQS overrided the custom
qs class, or EmptyQS was overridden by another class - values() did
this).
Fixed #15959 , fixed #17271 , fixed #17712 , fixed #19426
2013-01-06 19:18:29 +02:00
Anssi Kääriäinen
a2396a4c8f
Fixed #19173 -- Made EmptyQuerySet a marker class only
...
The guarantee that no queries will be made when accessing results is
done by new EmptyWhere class which is used for query.where and having.
Thanks to Simon Charette for reviewing and valuable suggestions.
2013-01-06 19:18:28 +02:00
Claude Paroz
b740da3504
Fixed #19192 -- Allowed running tests with dummy db backend
...
Thanks Simon Charette for the initial patch, and Jan Bednařík for
his work on the ticket.
2013-01-04 13:55:20 +01:00
Claude Paroz
ffa50ca352
Fixed #19382 -- Stopped smtp backend raising exception when already closed
...
Thanks Sebastian Noack for the report and the initial patch.
2013-01-03 20:41:45 +01:00
Claude Paroz
1b3f832ab7
Fixed #19134 -- Allowed closing smtp backend when the server is stopped
...
Thanks Sebastian Noack for the report and the initial patch.
2013-01-03 18:49:00 +01:00
Simon Charette
3fc43c964e
Fixed #19545 -- Make sure media/is_multipart work with empty formsets
2013-01-03 15:16:23 +01:00
Aymeric Augustin
a7b7efe78d
Minor fixes in the known_related_objects tests.
...
* Fixed JSON indentation.
* Avoided relying on implicit ordering.
2013-01-02 22:21:46 +01:00
Aymeric Augustin
07fbc6ae0e
Fixed #19547 -- Caching of related instances.
...
When &'ing or |'ing querysets, wrong values could be cached, and crashes
could happen.
Thanks Marc Tamlyn for figuring out the problem and writing the patch.
2013-01-02 22:21:46 +01:00
Aymeric Augustin
feb41c3246
Modernized middleware tests.
...
* Used override_settings consistently -- changes to DEBUG could leak.
* Took advantage of assertRaisesRegexp.
* Fixed indentation -- some code was indented at 2 spaces.
2013-01-01 23:00:34 +01:00
Anton Baklanov
3aa4b8165d
Fixed #19457 -- ImageField size detection failed for some files.
...
This was caused by PIL raising a zlib truncated stream error since we fed
the parser with chunks instead of the whole image.
2013-01-01 11:54:56 +01:00
Aymeric Augustin
bacb097ac3
Fixed #19519 again -- Regression in LiveServerTestCase after fd1279a4
.
2013-01-01 10:14:11 +01:00
Julien Phalip
9180146d21
Fixed #19453 -- Ensured that the decorated function's arguments are obfuscated in the @sensitive_variables decorator's frame, in case the variables associated with those arguments were meant to be obfuscated from the decorated function's frame.
...
Thanks to vzima for the report.
2012-12-31 09:34:08 -08:00
Aymeric Augustin
acc5396e6d
Fixed #19519 -- Fired request_finished in the WSGI iterable's close().
2012-12-31 12:47:34 +01:00
Claude Paroz
d11038acb2
Fixed #19537 -- Made CheckboxInput._has_changed handle 'False' string
...
Thanks dibrovsd@gmail.com for the report.
2012-12-31 10:18:59 +01:00
Julien Phalip
cee40c7d79
Added further flexibility to ModelAdmin for controlling post-save redirections.
...
Refs #19505 .
2012-12-30 21:33:21 -08:00
Aymeric Augustin
4e5369a596
Silenced warnings in the tests of deprecated features.
2012-12-29 22:32:07 +01:00
Aymeric Augustin
ef017a5f00
Advanced pending deprecation warnings.
...
Also added stacklevel argument, fixed #18127 .
2012-12-29 21:59:07 +01:00
Aymeric Augustin
2ecf56ea3f
Removed legacy ways of calling cache_page.
2012-12-29 21:59:07 +01:00
Aymeric Augustin
9f9a4cdecd
Removed truncate_words and truncate_html_words.
2012-12-29 21:59:07 +01:00
Aymeric Augustin
4a6490a4a0
Removed HttpRequest.raw_post_data.
2012-12-29 21:59:07 +01:00
Aymeric Augustin
d1c72d9e01
Removed django.core.management.setup_environ and execute_manager.
2012-12-29 21:59:07 +01:00
Aymeric Augustin
f27a4ee327
Removed django.contrib.localflavor.
...
Each localflavor lives on as a separate app.
2012-12-29 21:59:06 +01:00
Aymeric Augustin
052271168b
Removed django.contrib.databrowse.
...
RIP -- you served us well.
2012-12-29 21:58:12 +01:00
Aymeric Augustin
02f3daadd6
Removed interpolation of post_url_continue in the admin.
2012-12-29 21:58:12 +01:00
Aymeric Augustin
fb9f1b9bfb
Removed backwards-compatibility shim for #16288 .
...
Also unit-tested django.utils.log.RequireDebugTrue for consistency.
2012-12-29 21:58:12 +01:00
Anssi Kääriäinen
13a2b11425
Avoided having an indexed TextField installed unless using postgres
...
An index on TextField results in a warning message when running tests
on MySQL or SQLite, and the test using the TextField was PostgreSQL
only in any case.
2012-12-29 16:30:17 +02:00
Anssi Kääriäinen
ba4331f177
Fixed autopk issue in tests
2012-12-29 16:25:24 +02:00
Aymeric Augustin
e9c24bef74
Fix #19524 -- Incorrect caching of parents of unsaved model instances.
...
Thanks qcwxezdas for the report. Refs #13839 .
2012-12-28 23:34:54 +01:00
Aymeric Augustin
db278c3bf9
Fixed #19525 -- Reverted dcd4383107
and 05d333ba3b
.
...
Refs #9893 , #18515 .
Thanks Russell for the report.
2012-12-27 09:37:57 +01:00
Ramiro Morales
ad769efa85
Expanded tests added when fixing #14529 .
...
To make sure changes in 35d1cd0
don't break anything. Refs #19505 .
2012-12-24 17:48:48 -03:00
Aymeric Augustin
1c8be95a86
Prevented caching of streaming responses.
...
The test introduced in 4b278131
accidentally passed because of a
limitation of Python < 3.3.
Refs #17758 , #7581 .
2012-12-24 20:28:07 +01:00
Julien Phalip
35d1cd0b28
Fixed #19505 -- A more flexible implementation for customizable admin redirect urls.
...
Work by Julien Phalip.
Refs #8001 , #18310 , #19505 . See also 0b908b92a2
.
2012-12-24 15:44:19 -03:00
Aymeric Augustin
e8f07f0378
Fixed a randomly failing test under Python 3.
...
Refs #17758 .
2012-12-24 11:25:58 +01:00
Luke Plant
1ae64e96c1
Fixed a dependence on set-ordering in tests
2012-12-24 01:33:44 +00:00
Luke Plant
c31c2c92b8
Made admin generated changelist URLs independent of dict ordering
2012-12-24 01:33:24 +00:00
Ian Clelland
b9fc70141a
Don't rely on dictionary ordering in tests
2012-12-24 00:45:58 +00:00
Ian Clelland
585aa11d23
Use HTML parser to compare html snippets
2012-12-24 00:26:09 +00:00
Ian Clelland
8d35fd4c32
Use new TestCase methods for equality comparisons
2012-12-24 00:24:14 +00:00
Aymeric Augustin
1e4a27d087
Fixed #19468 -- Decoded request.path correctly on Python 3.
...
Thanks aliva for the report and claudep for the feedback.
2012-12-22 13:32:39 +01:00
Anssi Kääriäinen
d407164c04
Fixed #18854 -- Join promotion in disjunction cases
...
The added promotion logic is based on promoting any joins used in only
some of the childs of an OR clause unless the join existed before the
OR clause addition.
2012-12-20 21:45:15 +02:00
Anssi Kääriäinen
3dcd435a0e
Fixed #19500 -- Solved a regression in join reuse
...
The ORM didn't reuse joins for direct foreign key traversals when using
chained filters. For example:
qs.filter(fk__somefield=1).filter(fk__somefield=2))
produced two joins.
As a bonus, reverse onetoone filters can now reuse joins correctly
The regression was caused by the join() method refactor in commit
68847135bc
Thanks for Simon Charette for spotting some issues with the first draft
of the patch.
2012-12-20 21:27:00 +02:00
Russell Keith-Magee
c04c03daa3
Fixed #19401 -- Ensure that swappable model references are case insensitive.
...
This is necessary because get_model() checks are case insensitive, and if the swapable check isn't, the
swappable logic gets tied up in knots with models that are partially swapped out.
Thanks to chris@cogdon.org for the report and extensive analysis, and Preston for his work on the draft patch.
2012-12-20 16:10:19 +08:00
Patryk Zawadzki
3989ce52ef
Fixed #18172 -- Made models with __iter__ usable in ModelMultipleChoiceField
...
Thanks to Patryk Zawadzki for the patch.
2012-12-19 22:51:12 +02:00
Claude Paroz
55972ee5c7
Fixed #19441 -- Created PostgreSQL varchar index when unique=True
...
Thanks Dylan Verheul for the report and Anssi Kääriäinen for the
review.
2012-12-18 09:56:30 +01:00
Anssi Kääriäinen
85712a5355
Made sure connections are actually closed in backends tests
2012-12-16 23:26:16 +02:00
Claude Paroz
ed711c4bd5
Fixed #19483 -- Improved import error message in contrib.comments
...
Thanks Valentin Lorentz for the report and the suggested fix.
2012-12-16 21:12:45 +01:00
Anssi Kääriäinen
69597e5bcc
Fixed #10790 -- Refactored sql.Query.setup_joins()
...
This is a rather large refactoring. The "lookup traversal" code was
splitted out from the setup_joins. There is now names_to_path() method
which does the lookup traveling, the actual work of setup_joins() is
calling names_to_path() and then adding the joins found into the query.
As a side effect it was possible to remove the "process_extra"
functionality used by genric relations. This never worked for left
joins. Now the extra restriction is appended directly to the join
condition instead of the where clause.
To generate the extra condition we need to have the join field
available in the compiler. This has the side-effect that we need more
ugly code in Query.__getstate__ and __setstate__ as Field objects
aren't pickleable.
The join trimming code got a big change - now we trim all direct joins
and never trim reverse joins. This also fixes the problem in #10790
which was join trimming in null filter cases.
2012-12-16 17:23:26 +02:00
Russell Keith-Magee
9facca28b6
Corrected tests depending on the error message on the AuthenticationForm.
...
Refs #19368 , and the fix introduced in 27f8129d64
.
2012-12-16 07:18:45 +08:00
Anssi Kääriäinen
7eba5fbc02
Fixed a couple of stale tests caused by patch for #19462
...
Commit was 088d3bc2f8
2012-12-13 15:02:08 +02:00
Anssi Kääriäinen
088d3bc2f8
Fixed #19462 -- Made assertQuerysetEqual detect undefined ordering
...
If there are more than one values to compare against and the qs isn't
ordered then assertQuerysetEqual will raise a ValueError.
2012-12-13 13:33:11 +02:00
Claude Paroz
6ed6a18a03
Fixed #19432 -- Provided better error message for get_object_or_404
...
Thanks Kit Sunde for the report and Brian Holdefehr for the initial
patch.
2012-12-12 22:05:00 +01:00
Florian Apolloner
7e97f4f510
Fixed an order dependant test failure.
2012-12-11 16:25:47 +01:00
Florian Apolloner
1eb0da1c5b
Fixed a test failure in the comment tests.
2012-12-10 23:34:51 +01:00
Florian Apolloner
27560924ec
Fixed a security issue in get_host.
...
Full disclosure and new release forthcoming.
2012-12-10 22:11:40 +01:00
Florian Apolloner
a2f2a39956
Fixed #18856 -- Ensured that redirects can't be poisoned by malicious users.
2012-12-10 22:11:39 +01:00
Claude Paroz
0cdfa76e68
Amended an SQL test fixture to not include an id value
...
Some backends might need special handling for auto-increment values.
This was introduced in 5fa5621f57
. Thanks Michael Manfre for spotting
the issue.
2012-12-10 17:49:04 +01:00
Aymeric Augustin
49519328b4
Fixed #19392 -- Improved error for old-style url tags with dashes.
...
Thanks dloewenherz for the report.
2012-12-09 16:17:56 +01:00
Claude Paroz
8248d14029
Removed US localflavor-specific tests from core
...
Also fixes #9045 .
2012-12-08 21:07:59 +01:00
Claude Paroz
04e6542b5a
Fixed #19423 -- Prevented ModelAdmin sharing widgets due to formfield_overrides
...
Thanks joebuyer at manycycles.com for the report and Simon Charette
for the review.
2012-12-08 12:41:11 +01:00
Claude Paroz
c91667338a
Fixed #19357 -- Allow non-ASCII chars in filesystem paths
...
Thanks kujiu for the report and Aymeric Augustin for the review.
2012-12-08 11:13:52 +01:00
Andreas Hug
66dfcc10b3
Fixed #18574 -- Make BaseFormSet.is_valid call its underlying forms' is_valid
...
Thanks Simon Charette for the report and the initial patch.
2012-12-06 20:00:56 +01:00
Claude Paroz
34dcf51e06
Fixed #19367 -- Fixed saving ContentFile in filesystem storage
...
This was not working properly when ContentFile was initialized with
an unicode string.
Thanks Alexey Boriskin for the report and the test.
2012-12-06 17:14:44 +01:00
Marc Aymerich
553838a285
Fixed #19429 -- Applied linebreaksbr to read-only fields in inlines
...
Applied to inlines what ec9d6b1122
did for main fieldsets.
2012-12-06 09:52:02 +01:00
Anssi Kääriäinen
632cf32b43
Fixed #19391 -- Oracle specific failure in tests
...
The failure was caused by using None as a choice for a CharField. To
avoid Oracle's "" <-> NULL handling the field type was changed to
IntegerField.
2012-12-04 22:49:02 +02:00
Julien Phalip
c196e01100
Fixed the admin_filters tests for Postgres.
2012-12-04 10:36:56 -08:00
Claude Paroz
795ac7deda
Fixed #19378 -- Ensured get_success_url returns a non-lazy URL
2012-12-04 13:22:42 +01:00
Andrew Godwin
501c7a221c
Merge pull request #573 from tominsam/master
...
Fixed #19070 : urlize template filter raises exception in some cases
2012-12-04 02:18:10 -08:00