934acf1126
Fixed keep-alive support in manage.py runserver.
...
Ticket #25619 changed the default protocol to HTTP/1.1 but did not
properly implement keep-alive. As a "fix" keep-alive was disabled in
ticket #28440 to prevent clients from hanging (they expect the server to
send more data if the connection is not closed and there is no content
length set).
The combination of those two fixes resulted in yet another problem:
HTTP/1.1 by default allows a client to assume that keep-alive is
supported unless the server disables it via 'Connection: close' -- see
RFC2616 8.1.2.1 for details on persistent connection negotiation. Now if
the client receives a response from Django without 'Connection: close'
and immediately sends a new request (on the same tcp connection) before
our server closes the tcp connection, it will error out at some point
because the connection does get closed a few milli seconds later.
This patch fixes the mentioned issues by always sending 'Connection:
close' if we cannot determine a content length. The code is inefficient
in the sense that it does not allow for persistent connections when
chunked responses are used, but that should not really cause any
problems (Django does not generate those) and it only affects the
development server anyways.
Refs #25619 , #28440 .
2018-11-10 13:54:45 +01:00
523e04dfeb
Captured logging in tests with self.assertLogs().
2018-05-07 09:34:02 -04:00
607970f31c
Replaced django.test.utils.patch_logger() with assertLogs().
...
Thanks Tim Graham for the review.
2018-05-07 09:34:00 -04:00
32ade78c55
Refs #28440 -- Fixed server connection closing test on macOS.
2017-10-13 13:29:29 -04:00
cfff2af02b
Fixed #27857 -- Dropped support for Python 3.4.
2017-09-25 17:11:03 -04:00
ac756f16c5
Fixed #28440 -- Fixed WSGIServer hang on responses without a Content-Length.
...
Disabled keep-alive to fix the regression in
e6065c7b83
2017-09-12 10:41:28 -04:00
a0f8c52ae2
Fixed ResourceWarnings in tests/servers/tests.py.
...
e.g. ResourceWarning: unclosed <socket.socket [closed] fd=6, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6>
2017-06-05 09:56:51 -04:00
b6d4b6e544
Fixed #28212 -- Allowed customizing the port that LiveServerTestCase uses.
...
Forwardport of 877d7b71ae
2017-05-30 18:49:10 -04:00
21046e7773
Fixed #28249 -- Removed unnecessary dict.keys() calls.
...
iter(dict) is equivalent to iter(dict.keys()).
2017-05-27 19:08:46 -04:00
d611a89238
Decreased max_length for char fields unless absolutely needed. ( #8485 )
2017-05-10 17:33:46 +02:00
e6065c7b83
Fixed #25619 -- Made runserver serve with HTTP 1.1 protocol
...
Thanks Tim Graham for the review.
2017-02-23 09:04:53 +01:00
bece837829
Fixed #20238 -- Added threading support to LiveServerTestCase.
2017-02-09 19:08:32 -05:00
500532c95d
Refs #23919 -- Removed default 'utf-8' argument for str.encode()/decode().
2017-02-09 09:03:47 -05:00
fee42fd99e
Refs #23919 -- Replaced usage of django.utils.http utilities with Python equivalents
...
Thanks Tim Graham for the review.
2017-01-26 19:49:03 +01:00
d6eaf7c018
Refs #23919 -- Replaced super(ClassName, self) with super().
2017-01-25 12:23:46 -05:00
042b7350a0
Refs #23919 -- Removed unneeded str() calls
2017-01-20 14:13:55 +01:00
4e729feaa6
Refs #23919 -- Removed django.utils._os.upath()/npath()/abspathu() usage.
...
These functions do nothing on Python 3.
2017-01-20 08:01:02 -05:00
9695b14982
Refs #23919 -- Removed str() conversion of type and method __name__.
2017-01-19 11:31:07 -05:00
5320fa77c3
Refs #23919 -- Removed obsolete contextlib.closing() calls (for Python 2).
2017-01-19 08:50:28 -05:00
cecc079168
Refs #23919 -- Stopped inheriting from object to define new style classes.
2017-01-19 08:39:46 +01:00
2b281cc35e
Refs #23919 -- Removed most of remaining six usage
...
Thanks Tim Graham for the review.
2017-01-18 21:33:28 +01:00
7b2f2e74ad
Refs #23919 -- Removed six.<various>_types usage
...
Thanks Tim Graham and Simon Charette for the reviews.
2017-01-18 20:18:46 +01:00
d7b9aaa366
Refs #23919 -- Removed encoding preambles and future imports
2017-01-18 09:55:19 +01:00
321e94fa41
Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings.
2016-11-10 21:30:21 -05:00
f6cd669ff2
Fixed #22414 -- Ensured that LiveServerTestCase closes connections.
2016-08-19 12:47:41 -04:00
35225e2ade
Refs #27025 -- Fixed a servers test on Python 3.6.
...
After https://hg.python.org/cpython/rev/4ea79767ff75/ ,
test_strips_underscore_headers fails with:
'Stub' object has no attribute 'sendall'.
2016-08-08 16:50:48 -04:00
81cdcb66bc
Fixed #26791 -- Replaced LiveServerTestCase port ranges with binding to port 0.
2016-06-23 12:04:05 -04:00
ea34426ae7
Fixed flake8 2.6 warnings.
2016-06-16 09:12:50 -04:00
f0a84112ba
Refs #25684 -- Silenced logging output in servers tests.
2016-02-08 11:14:27 -05:00
0bc5cd6280
Fixed #25684 -- Made runserver use logging for request/response output.
...
Thanks andreif for the contributing to the patch.
2016-01-11 07:35:17 -05:00
b551eda9c5
Refs #26011 -- Fixed AttributeError in test_port_bind test.
2016-01-02 11:03:24 -05:00
c87540cee5
Fixed #26011 -- Prevented random LiveServerTestCase test failures on Windows.
...
Prevented LiveServerTestCase from stealing ports used by concurrent
processes on Windows.
2015-12-31 10:57:03 -05:00
1a76257b1b
Fixed #25204 -- Added missing space in runserver logging.
2015-08-01 08:01:24 -04:00
6e3fe089dd
Replaced six.BytesIO with io.BytesIO
2015-07-20 08:19:47 -04:00
b40c551fdf
Fixed some unclosed objects in tests
2015-07-06 10:10:40 -04:00
296919e7a5
Fixed #24965 -- Made LiveServerTestCase.live_server_url accessible from class
2015-06-12 17:44:54 -04:00
be67400b47
Refs #24652 -- Used SimpleTestCase where appropriate.
2015-05-20 13:46:13 -04:00
c8074d62f8
Fixed typo in error message in the test.
2015-02-19 19:36:20 -05:00
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
316b8d4974
Stripped headers containing underscores to prevent spoofing in WSGI environ.
...
This is a security fix. Disclosure following shortly.
Thanks to Jedediah Smith for the report.
2015-01-13 13:03:05 -05:00
6dbe979b4d
Fixed #23930 -- Added copies of captured_std* managers from CPython's test.support.
...
StringIO import was adapted for compatibility with Python 2.
2014-11-29 11:21:58 -05:00
d89f56dc4d
Fixed #21281 -- Made override_settings act at class level when used as a TestCase decorator.
2014-11-03 14:14:39 -05:00
c53f2451a8
Fixed #23398 -- Added helpful error message when runserver is accessed via HTTPS
2014-09-09 12:29:30 -04:00
cd914e31c9
Fixed #21977 -- Deprecated SimpleTestCase.urls
2014-04-06 17:33:43 -04:00
d73d0e071c
Fixed #22218 -- Deprecated django.conf.urls.patterns.
...
Thanks Carl Meyer for the suggestion and Alex Gaynor and Carl for reviews.
2014-04-03 07:28:10 -04:00
0d91225892
Fixed many typos in comments and docstrings.
...
Thanks Piotr Kasprzyk for help with the patch.
2014-03-03 07:38:09 -05:00
e32095616c
Imported override_settings from its new location.
2013-12-23 21:37:56 +01:00
6e895f9e06
Removed superfluous models.py files.
...
Added comments in the three empty models.py files that are still needed.
Adjusted the test runner to add applications corresponding to test
labels to INSTALLED_APPS even when they don't have a models module.
2013-12-17 11:16:48 +01:00
c3791463a5
Fixing E302 Errors
...
Signed-off-by: Jason Myers <jason@jasonamyers.com>
2013-11-02 23:48:47 -05:00
2ca00faa91
Fixed "Address already in use" from liveserver.
...
Our WSGIServer rewrapped the socket errors from server_bind into
WSGIServerExceptions, which is used later on to provide nicer
error messages in runserver and used by the liveserver to see if
the port is already in use. But wrapping server_bind isn't enough since
it only binds to the socket, socket.listen (which is called from
server_activate) could also raise "Address already in use".
Instead of overriding server_activate too I chose to just catch socket
errors, which seems to make more sense anyways and should be more robust
against changes in wsgiref.
2013-09-22 22:02:59 +02:00
Florian Apolloner
Claude Paroz
Tom
Tim Graham
Jon Dufresne
Robert Rollins
Florian Apolloner
Nadège Michel
chillaranand
Simon Charette
Simon Charette
za
Chris Jerdonek
Flavio Curella
Marten Kenbeek
Andriy Sokolovskiy
Moritz Sichert
Carl Meyer
wrwrwr
Thomas Chaumeny
Anubhav Joshi
Rodolfo Carvalho
Aymeric Augustin
Jason Myers