Commit Graph

10017 Commits

Author SHA1 Message Date
Carlton Gibson afddabf842 [2.2.x] Fixed CVE-2019-12308 -- Made AdminURLFieldWidget validate URL before rendering clickable link.
Backport of deeba6d920 from master.
2019-06-03 11:37:28 +02:00
Tom Forbes 7089502b98 [2.2.x] Fixed #30523 -- Fixed updating file modification times on seen files in auto-reloader when using StatReloader.
Previously we updated the file mtimes if the file has not been seen
before - i.e on the first iteration of the loop.

If the mtime has been changed we triggered the notify_file_changed()
method which in all cases except the translations will result in the
process being terminated. To be strictly correct we need to update the
mtime for either branch of the conditional.

Regression in 6754bffa2b.

Backport of 480492fe70 from master
2019-05-29 09:43:10 +02:00
Tom Forbes ace0bec804 [2.2.x] Fixed #30516 -- Fixed crash of autoreloader when re-raising exceptions with custom signature.
Regression in c8720e7696.

Backport of 0344565179 from master
2019-05-29 08:30:22 +02:00
Caio Ariede 1172f078eb [2.2.x] Fixed #30315 -- Fixed crash of ArrayAgg and StringAgg with ordering when used in Subquery.
Backport of a3f91891d2 from master.
2019-05-28 10:39:28 +02:00
Tom Forbes 5bf2c87ece [2.2.x] Fixed #30479 -- Fixed detecting changes in manage.py by autoreloader when using StatReloader.
Regression in c8720e7696.

Backport of b2790f74d4 from master
2019-05-28 09:01:29 +02:00
Thomasina Lee 3d4e53bcb1 [2.2.x] Fixed #30488 -- Removed redundant Coalesce call in SQL generated by SearchVector.
Regression in 405c836336.

Backport of c38e7a79f4 from master
2019-05-20 09:12:32 +02:00
ruchit2801 db7d7901ee [2.2.x] Fixed #30463 -- Fixed crash of deprecation message when Meta.ordering contains expressions.
Regression in 1b1f64ee5a.

Backport of 04042b2b44 from master
2019-05-18 20:05:31 +02:00
Claude Paroz 34a357d519 [2.2.x] Fixed #30459 -- Delegated hide/show JS toggle to parent div.
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>

Backport of e286987a27 from master
2019-05-17 08:04:59 +02:00
can 58391b4d16 [2.2.x] Fixed #30412 -- Fixed crash when adding check constraints with OR'ed condition on Oracle and SQLite.
Backport of 719b746620 from master
2019-04-30 13:43:02 +02:00
Simon Charette f36239fa19 [2.2.x] Fixed #30408 -- Fixed crash when adding check constraints with LIKE operator on Oracle and PostgreSQL.
The LIKE operator wildcard generated for contains, startswith, endswith and
their case-insensitive variant lookups was conflicting with parameter
interpolation on CREATE constraint statement execution.

Ideally we'd delegate parameters interpolation in DDL statements on backends
that support it but that would require backward incompatible changes to the
Index and Constraint SQL generating methods.

Thanks David Sanders for the report.

Backport of a8b3f96f6a from master
2019-04-30 08:54:30 +02:00
Tom Forbes d326c743ef [2.2.x] Fixed #30323 -- Fixed detecting changes by autoreloader when using StatReloader.
Backport of 6754bffa2b from master
2019-04-29 12:18:29 +02:00
Carlton Gibson 4f8ebdd098 [2.2.x] Fixed #30351 -- Handled pre-existing permissions in proxy model permissions data migration.
Regression in 181fb60159.

Backport of 98296f86b3 from master
2019-04-27 21:08:46 +02:00
Jacob Green e45763193f [2.2.x] Fixed #30361 -- Increased the default timeout of watchman client to 5 seconds and made it customizable.
Made the default timeout of watchman client customizable via
DJANGO_WATCHMAN_TIMEOUT environment variable.

Backport of ed3c59097a from master
2019-04-26 13:35:47 +02:00
Aarni Koskela a4095dadc4 [2.2.x] Fixed #30312 -- Relaxed admin check from django.contrib.sessions to SessionMiddleware subclasses.
Backport of efeceba589 from master
2019-04-26 11:51:28 +02:00
Alasdair Nicol 3c3df7db8e [2.2.x] Fixed #30318 -- Added check for importability of arguments of custom error handler views.
Thanks to Jon on Stack Overflow for reporting the issue.

Backport of a5accc0368 from master
2019-04-25 11:38:35 +02:00
Simon Charette 88bf635c35 [2.2.x] Fixed #30385 -- Restored SearchVector(config) immutability.
Regression in 1a28dc3887.

The usage of CONCAT to allow SearchVector to deal with non-text fields
made the generated expression non-IMMUTABLE which prevents a functional
index to be created for it.

Using a combination of COALESCE and ::text makes sure the expression
preserves its immutability.

Refs #29582. Thanks Andrew Brown for the report, Nick Pope for the
review.

Backport of 405c836336 from master
2019-04-23 08:32:36 +02:00
Scott Fitsimones 95811c3de9 [2.2.x] Fixed #30328 -- Fixed crash of IntegerField.validators when limit_value in a custom validator is callable.
Backport of a14c0fda15 from master
2019-04-19 08:21:29 +02:00
Mariusz Felisiak bb54a2daee
[2.2.x] Removed unused imports. 2019-04-18 07:49:35 +02:00
can e85317d731 [2.2.x] Fixed #30335, #29139 -- Fixed crash when ordering or aggregating over a nested JSONField key transform.
Backport of d87bd29c4f from master.
2019-04-18 07:37:48 +02:00
Tobias Kunze 5289d4faec [2.2.x] Refs #30325 -- Added tests for using count()/exists() with custom managers and reverse M2M relations.
Backport of 9ac8520fcd from master
2019-04-15 12:39:56 +02:00
Mariusz Felisiak e8de1cc94c [2.2.x] Fixed #30325 -- Reverted "Fixed #29725 -- Removed unnecessary join in QuerySet.count() and exists() on a many-to-many relation."
This reverts commit 1299421cad due to
a regression with custom managers.

Backport of 5f7991c42c from master
2019-04-15 12:39:42 +02:00
Florian Apolloner 896cc71901
[2.2.x] Fixed #30350 -- Prevented recreation of migration for operations with a range object.
Thanks to Mariusz Felisiak for helping with the patch.

Backport of 2e38f2015a from master.
2019-04-14 12:58:34 +02:00
Florian Apolloner b88ffef7ea [2.2.x] Fixed #30330 -- Fixed setting of primary key to None during fast-delete.
Regression in bc7dd8490b.

Backport of afc708cf6d from master
2019-04-08 21:44:17 +02:00
Simone Pellizzari 268ed9cd8a [2.2.x] Fixed #30332 -- Fixed crash of ordering by expressions with params in ArrayAgg and StringAgg.
Backport of d0315584b5 from master.
2019-04-06 15:15:40 +02:00
Nick Pope 9da25fb832 [2.2.x] Fixed #30324 -- Forced utf-8 encoding when loading the template for the technical 500 debug page.
Regression in 50b8493.
Related to ea542a9.

Backport of efb257a017 from master
2019-04-05 16:37:22 +02:00
msg 1279fb4a00 [2.2.x] Fixed #30307 -- Fixed incorrect quoting of database user password when using dbshell on Oracle.
Regression in acfc650f2a.

Backport of 755673e1bc from master
2019-04-04 10:07:57 +02:00
Tim Graham 917aa556a9 [2.2.x] Fixed #30289 -- Prevented admin inlines for a ManyToManyField's implicit through model from being editable if the user only has the view permission.
Backport of 8335d59200 from master.
2019-03-30 17:44:58 -04:00
sage 4a6d3f2580 [2.2.x] Fixed #30295 -- Fixed max_lengths.tests.MaxLengthORMTests when run in isolation.
Backport of 5a92bb0725 from master.
2019-03-28 12:05:57 -04:00
Matthias Kestenholz a86ffb3e0f [2.2.x] Fixed #30280 -- Restored Model.get_FIELD_display()'s coercion of lazy strings.
Reverted cc79c7ee63.

Backport of ea071870f9 from master.
2019-03-22 13:01:15 -04:00
oliver 8cff329802 [2.2.x] Used QuerySet.bulk_create() in a couple of postgres tests.
Follow up to 0ce2ad9ca4.
Backport of 2aaabe2004 from master.
2019-03-21 18:05:42 -04:00
Nick Pope cb36ca4a0f [2.2.x] Corrected settings names in SecurityMiddleware tests.
Backport of 413d50b5ff from master.
2019-03-20 20:15:59 -04:00
Tim Graham abd6fb1656 [2.2.x] Fixed serializers test crash if PyYAML isn't installed.
Follow up to a57c783dd4.

Backport of 55490ac746 from master
2019-03-20 16:07:36 +01:00
Mariusz Felisiak 505785a71d
[2.2.x] Fixed #30264 -- Fixed crash of test_parsing_year_less_than_70() on 32-bit systems.
Thanks Andreas Beckmann and Chris Lamb for the report.
Backport of c9888bc8ec from master
2019-03-20 13:46:31 +01:00
Simon Charette 883d87074d [2.2.x] Fixed #30258 -- Adjusted postgres schema value quoting of ranges.
Thanks Tilman Koschnick for the report and patch.

Backport of 386d89ab55 from master
2019-03-18 09:32:09 +01:00
Paveł Tyślacki 2a92e2e3c1 [2.2.x] Refs #30172 -- Prevented removing a model Meta's index/unique_together from removing Meta constraints/indexes.
Backport of 5c17c273ae from master.
2019-03-17 21:28:49 -04:00
Paveł Tyślacki 3dd5e71752 [2.2.x] Refs #30172 -- Prevented removing a field's check or unique constraint from removing Meta constraints.
Backport of 4bb859e246 from master.
2019-03-17 21:28:36 -04:00
Paveł Tyślacki 40b0a58f5f [2.2.x] Fixed #30183 -- Added introspection of inline SQLite constraints.
Backport of 782d85b6df from master.
2019-03-15 20:01:36 -04:00
Jon Dufresne 87fad5a392 [2.2.x] Cleaned up exception message checking in some tests.
Backport of 95b7699ffc from master.
2019-03-15 19:28:13 -04:00
Matt Westcott 985e6c224b [2.2.x] Fixed #30254 -- Allowed model metaclasses to access the attribute dict in __init__().
Regression in a68ea23101.

Backport of 58ad030d05 from master.
2019-03-14 21:23:19 -04:00
Herman S d8704a4d4f [2.2.x] Fixed #30237 -- Made Authentication/SessionMiddleware and ModelBackend admin checks allow subclasses.
Backport of f976ab1b11 from master.
2019-03-14 20:36:11 -04:00
Mariusz Felisiak b150d99460 [2.2.x] Simplified test_transform()s in db_functions.math.
Backport of 258110d6cd from master.
2019-03-14 19:42:21 -04:00
Mariusz Felisiak a9ce7e2bcd
[2.2.x] Fixed serializers tests for PyYAML 5.1+.
Backport of a57c783dd4 from master
2019-03-14 18:37:46 +01:00
Mariusz Felisiak cf903c4c0b
[2.2.x] Reverted "Fixed relative paths imports per isort 4.3.5."
This reverts commit 463fe11bc8 due to
restore of relative paths sorting from isort < 4.3.5 in isort 4.3.10.
Backport of b435f82939 from master
2019-03-03 19:35:37 +01:00
Matthias Kestenholz 459f7c804d [2.2.x] Fixed #30179 -- Fixed form Media merging when pairwise merging is insufficient.
Thanks gasman for the tests, and codingjoe and timgraham for the review.

Backport of 231b513926 from master.
2019-02-27 17:16:58 -05:00
Matthias Kestenholz 77e53da127 [2.2.x] Refs #30179 -- Moved topological sort functions to django.utils.
Backport of e04209e181 from master.
2019-02-27 17:16:48 -05:00
shiningfm 4dac17ac93 [2.2.x] Fixed #30215 -- Fixed autoreloader crash for modules without __spec__.
Regression in c8720e7696.
Backport of 99cfb28e99 from master.
2019-02-27 10:35:45 -05:00
Mariusz Felisiak 370a145996
[2.2.x] Fixed relative paths imports per isort 4.3.5.
Backport of 463fe11bc8 from master
2019-02-25 19:50:12 +01:00
Tim Graham 9a5f87a69c [2.2.x] Fixed a failure when running tests on systems with SQLite < 3.8.3.
Backport of 36300ef336 from master.
2019-02-21 16:39:42 -05:00
Simon Charette 7f25344c2e [2.2.x] Fixed #30193, Refs #28478 -- Avoided PostgreSQL connection health checks on initialization.
This addressed a regression introduced by a96b901932 as identified by Ran Benita.
Backport of 7071f8f272 from master
2019-02-20 11:01:03 +01:00
Jon Dufresne 37cc6a9dce [2.2.x] Fixed #30171 -- Fixed DatabaseError in servers tests.
Made DatabaseWrapper thread sharing logic reentrant. Used a reference
counting like scheme to allow nested uses.

The error appeared after 8c775391b7.
Backport of 76990cbbda from master.
2019-02-14 10:05:13 -05:00