f9844f4841
Fixed #28748 -- Made model field choices check more strict for named groups.
2018-01-24 10:34:24 -05:00
8cdeb8acfc
Added more tests for model field choices validation.
2018-01-24 10:27:27 -05:00
a38ae914d8
Fixed #28996 -- Simplified some boolean constructs and removed trivial continue statements.
2018-01-12 12:44:50 -05:00
cc6bcc6ff5
Fixed #28867 -- Added system check for a model property that clashes with a related field accessor.
2018-01-03 10:34:31 -05:00
b0a2a2b07e
Made a few cleanups to invalid_models_tests.test_models.
2017-12-29 10:32:01 -05:00
f1aa58479c
Fixed #28714 -- Added system checks for invalid model field names in Meta.indexes.
...
Thanks Gabriel for the report and Adam Johnson for the review.
2017-12-27 18:56:24 -05:00
f816ceedf1
Made assertions in invalid_models_tests consistent.
2017-07-11 13:12:17 -04:00
21046e7773
Fixed #28249 -- Removed unnecessary dict.keys() calls.
...
iter(dict) is equivalent to iter(dict.keys()).
2017-05-27 19:08:46 -04:00
538bf43458
Fixed #27859 -- Ignored db_index for TextField/BinaryField on Oracle and MySQL.
...
Thanks Zubair Alam for the initial patch and Tim Graham for the review.
2017-05-23 17:02:40 +02:00
9f2e8b5bb7
Fixed #28120 -- Checked that CharField.max_length is not a boolean.
2017-04-24 18:49:31 -04:00
a452dddb25
Fixed #27904 -- Added a system check that Field.validators are callable.
2017-03-11 12:27:29 -05:00
29f607927f
Fixed spelling of "nonexistent".
2017-02-03 08:01:45 -05:00
7aba69145d
Refs #23919 -- Removed django.test.mock Python 2 compatibility shim.
2017-01-20 08:17:20 -05:00
9695b14982
Refs #23919 -- Removed str() conversion of type and method __name__.
2017-01-19 11:31:07 -05:00
cecc079168
Refs #23919 -- Stopped inheriting from object to define new style classes.
2017-01-19 08:39:46 +01:00
c716fe8782
Refs #23919 -- Removed six.PY2/PY3 usage
...
Thanks Tim Graham for the review.
2017-01-18 16:21:28 +01:00
d7b9aaa366
Refs #23919 -- Removed encoding preambles and future imports
2017-01-18 09:55:19 +01:00
9d0e8c1e7f
Refs #26320 -- Removed implicit OneToOnField parent_link per deprecation timeline.
2017-01-17 20:52:04 -05:00
bcf3532ede
Refs #26154 -- Removed deprecated CommaSeparatedIntegerField.
2017-01-17 20:52:02 -05:00
ddd3268975
Refs #21127 -- Required on_delete for ForeignKey/OneToOneField.
...
Per deprecation timeline.
2017-01-17 14:09:28 -05:00
391c450fba
Refs #25415 -- Made MySQL backend skip field validation of unsupported models.
2016-12-29 12:01:48 -05:00
e3e80da7a5
Fixed #27651 -- Allowed M2M to concrete and proxy through model.
2016-12-28 12:48:17 -05:00
1a9bd75bfa
Refs #27358 -- Fixed system check crash with an empty FileField.upload_to.
2016-11-30 10:07:42 -05:00
7cddd8a02e
Fixed #27358 -- Added a system check to prevent FileField's upload_to from starting with a slash.
...
Thanks Frank Bijlsma for the initial patch.
2016-11-29 16:12:24 -05:00
f62abfc03d
Fixed #27295 -- Added a system check to prohibit model names that start or end with an underscore or contain double underscores.
2016-11-22 10:14:10 -05:00
321e94fa41
Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings.
2016-11-10 21:30:21 -05:00
ec9ed07488
Fixed #27188 -- Allowed using unique=True with FileField.
...
Thanks Tim Graham for the initial patch.
2016-10-28 20:11:03 -04:00
e7abb5ba86
Fixed #27204 -- Made clashing m2m intermediary table checks ignore unmanaged models.
2016-09-09 19:18:37 -04:00
02c276623d
Moved model_validation tests to invalid_models_tests.
2016-08-16 15:22:58 -04:00
17a0a6667c
Refs #26796 -- Fixed ManyToManyField's limit_choices_to warning without a through model.
2016-07-21 14:29:03 -04:00
ba53da894f
Fixed #26796 -- Added a system check for m2m fields with ignored limit_choices_to.
2016-07-08 19:37:40 -04:00
baff4dd37d
Fixed #25292 -- Fixed crash in ManyToManyField.through_fields check.
2016-06-30 08:53:38 -04:00
0bce2f102c
Fixed #12810 -- Added a check for clashing ManyToManyField.db_table names.
2016-06-10 10:57:22 -04:00
686a593aaa
Fixed #26648 -- Added a system check for invalid related_query_name's containing underscores.
2016-06-09 11:57:32 -04:00
21130ce1a9
Fixed #26718 -- Added system check for existence of the fields specified by ForeignKey.to_field.
2016-06-09 10:19:09 -04:00
87338198e9
Fixed #26320 -- Deprecated implicit OneToOnField parent_link.
2016-04-22 12:59:41 -04:00
92053acbb9
Fixed E128 flake8 warnings in tests/.
2016-04-08 10:12:33 -04:00
004ba0f99e
Removed unneeded hint=None/obj=None in system check messages.
2016-02-12 13:01:25 -05:00
dca8b916ff
Fixed #26154 -- Deprecated CommaSeparatedIntegerField
2016-02-10 17:57:43 -05:00
a325fb1f9b
Fixed #26162 -- Checked query name clashes of hidden relationships.
...
Although reverse accessor clashes should be skipped query name can't be hidden.
Thanks to Ian Foote and Tim Graham for the review.
2016-02-08 09:59:27 -05:00
253adc2b8a
Refs #26022 -- Used context manager version of assertRaisesMessage in tests.
2016-01-29 13:03:39 -05:00
a08fda2111
Fixed #25746 -- Isolated inlined test models registration.
...
Thanks to Tim for the review.
2016-01-06 20:00:07 -05:00
a856555df2
Fixed #25981 -- Added need to update migrations to on_delete deprecation warning.
2015-12-24 08:08:22 -05:00
93452a70e8
Fixed many spelling mistakes in code, comments, and docs.
2015-12-03 12:48:24 -05:00
c550beb0cc
Fixed #25723 -- Made related field checks lookup against their local apps.
2015-11-11 19:33:54 -05:00
976bd519a8
Revert "Fixed #25417 -- Added a field check for invalid default values."
...
This reverts commit 71ebcb85b9
2015-10-27 11:02:35 -04:00
c1b6a8a98b
Fixed #25560 -- Made empty string related_name invalid.
...
Thanks to Ali Lotfi for the initial report and patch
and Tim Graham for the review.
2015-10-16 14:22:15 -04:00
c7aff31397
Refs #25535 -- Minor edits to ForeignObject check changes.
2015-10-14 05:21:08 -07:00
80dac8c33e
Fixed #25535 -- Made ForeignObject checks less strict.
...
Check that the foreign object `from_fields` are a subset of any unique
constraints on the foreign model.
2015-10-12 18:00:59 -04:00
914167abf1
Fixed #25503 -- Fixed system check crash on ForeignKey to abstract model.
2015-10-06 19:22:37 -04:00
71ebcb85b9
Fixed #25417 -- Added a field check for invalid default values.
2015-09-18 14:31:36 -04:00
b1e33ceced
Fixed #23395 -- Limited line lengths to 119 characters.
2015-09-12 11:40:50 -04:00
4bc00defd0
Fixed #14217 -- Added validation for field name collision when using model inheritance.
2015-08-25 16:16:54 -04:00
0cc059cd10
Fixed #25172 -- Fixed check framework to work with multiple databases.
2015-08-12 18:00:26 -04:00
c2e70f0265
Fixed #21127 -- Started deprecation toward requiring on_delete for ForeignKey/OneToOneField
2015-07-27 18:28:13 -04:00
f9c3587b51
Fixed #25055 -- Made m2m long name testing friendlier for 3rd party databases.
2015-07-03 09:00:08 -04:00
d3e12c9017
Fixed #25016 -- Reallowed non-ASCII values for ForeignKey.related_name on Python 3.
2015-06-26 08:30:05 -04:00
be67400b47
Refs #24652 -- Used SimpleTestCase where appropriate.
2015-05-20 13:46:13 -04:00
d091b75eef
Fixed #24818 -- Prevented models.CharField from accepting a string as max_length
2015-05-19 08:06:39 -04:00
f2e4d39a71
Switched to use assertEqual instead of assertEquals.
2015-03-22 10:56:51 -04:00
966a29c2b8
Fixed #24479 -- Added system check to prevent both ordering and order_wrt.
2015-03-21 08:16:28 -04:00
e144e0e237
Removed unnecessary parentheses in model check messages.
2015-02-09 08:53:58 -05:00
4d73303ee9
Fixed #24249 -- Improved field shadowing validation in model multi-inheritance.
2015-02-09 08:37:55 -05:00
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
33457cd3b0
Removed IPAddressField per deprecation timeline; refs #20439 .
2015-01-19 11:12:57 -05:00
3b570dbcdb
Removed BaseDatabaseValidation.validate_field() per deprecation timeline.
2015-01-17 14:58:09 -05:00
e9d1f1182a
Fixed #23801 -- Added warning when max_length is used with IntegerField
2014-11-26 18:41:54 -05:00
e118e3af37
Fixed #23761 -- Added test for MySQL validator and db_type is None.
...
The issue was fixed on master in e9103402c02d12a59938
2014-11-13 11:06:59 +01:00
6c79d32977
Fixed #23684 -- Used correct package name for Pillow in Error hint.
2014-10-19 13:46:46 +07:00
1e5e2a4707
Fixed #22064 -- Add check for related_name
...
Validates that related_name is a valid Python id or ends with a '+' and
it's not a keyword. Without a check it passed silently leading to
unpredictable problems.
Thanks Konrad Świat for the initial work.
2014-10-04 20:47:26 -03:00
dd9b3312d0
Fixed name of database connection feature
2014-07-14 19:23:57 +03:00
011abb7d96
Fixed #19671 -- Added warnings that null and validators are ignored for ManyToManyField.
...
Thanks Loic Bistuer and Tim Graham for help and review.
2014-07-09 16:01:09 -04:00
865bc71783
Added a unit test to ensure models cannot be ordered by a M2M field.
2014-07-08 09:19:08 -04:00
1c50d6ae2b
Fixed problem introduced with #refs 13711.
2014-06-23 19:36:40 +03:00
91f1b6dcdc
Fixed #13711 -- Model check added to ensure that auto-generated column name is within limits of the database.
...
Thanks russellm for report and Tim Graham for review.
2014-06-17 16:16:02 -04:00
d04e730224
Fixed #22711 -- Adjusted ordering checks to allow implicit relation fields.
...
refs #19195 .
2014-06-01 15:36:25 -04:00
b6b873d2ad
Fixed several flake8 errors, including one where a test wouldn't be run
2014-05-17 09:54:34 -07:00
9d8c73f6a1
Fixed #21905 -- Add info message if DateField or TimeField use a fixed value
2014-05-16 18:59:31 +02:00
2c176eb95c
Refs #21798 - Modified error number to provide room for future expansion.
2014-05-16 15:41:17 +02:00
cb15231888
Fixed #21798 -- Added check for DateTime mutually exclusive options
...
Added DateTimeCheckMixin to avoid the use of default, auto_now, and
auto_now_add options together. Added the fields.E151 Error that is raised
if one or more of these options are used together.
2014-05-16 05:57:19 -04:00
0bcc92c691
Fixed #22356 -- Added a check to make sure unique_together fields are local.
2014-04-14 16:49:40 -04:00
4965a77407
Removed PIL compatability layer per deprecation timeline.
...
refs #19934 .
2014-03-21 10:54:53 -04:00
fc79c3fb3d
Flake8 corrections
2014-03-12 20:34:05 +02:00
aaad3e27ac
Fixed #22217 - ManyToManyField.through_fields fixes.
...
- Docs description of arguments mix up.
- Keep it from erroneously masking E332 check.
- Add checks E338 and E339, tweak message of E337.
2014-03-11 19:33:04 -03:00
c627da0ccc
Fixed #14549 - Removed restriction of single FKs on intermediary tables
...
Thanks to Loic Bistuer for review. Minor changes to error messages
done by committer.
2014-03-05 22:33:58 +02:00
82ac389486
Edited model and field checks for grammar and consistency.
2014-03-03 18:18:39 +08:00
bc4dc6e99c
Edited model check messages for grammar and consistency.
2014-03-03 15:35:42 +08:00
f7587b20da
Edited MySQL-specific check messages for grammar and consistency.
2014-03-03 14:31:55 +08:00
bb2ca9fe6c
Fixed #22172 -- Allowed index_together to be a single list (rather than list of lists)..
...
Thanks EmilStenstrom for the suggestion.
2014-03-01 15:44:42 -05:00
d0133504e5
Fixed #22047 -- detecting related_name clash with inheritance
...
Thanks to mondone for fruitful colaboration.
2014-02-15 17:24:05 +01:00
ee9fcb1672
Fixed #17673 -- Forbid field shadowing.
...
Thanks Anssi Kääriäinen for the suggestion.
2014-02-10 10:04:19 -05:00
ee25ea0daf
Removed a stray new line which upset flake8
2014-01-20 09:57:35 -06:00
056be4358d
Fixed two test failures under Oracle
2014-01-20 13:01:14 +02:00
a029efca44
Removed an inactive system check for upload_to.
...
Thanks to Simon Charette for the eagle eyes.
2014-01-20 12:31:35 +08:00
d818e0c9b2
Fixed #16905 -- Added extensible checks (nee validation) framework
...
This is the result of Christopher Medrela's 2013 Summer of Code project.
Thanks also to Preston Holmes, Tim Graham, Anssi Kääriäinen, Florian
Apolloner, and Alex Gaynor for review notes along the way.
Also: Fixes #8579 , fixes #3055 , fixes #19844 .
2014-01-20 10:45:21 +08:00
e5bcd1d455
Changed get_validation_errors to use an app config.
2013-12-29 21:48:58 +01:00
1716b7ce5a
Renamed AppCache to Apps.
...
Also renamed app_cache to apps and "app cache" to "app registry".
Deprecated AppCache.app_cache_ready() in favor of Apps.ready().
2013-12-24 12:25:17 +01:00
da16bb30ff
Dropped AppCache._empty, _with_app and _without_app.
...
It's now easier to achieve the same effect with modify_settings or
override_settings.
2013-12-23 21:37:56 +01:00
2fef9e5375
Moved apps back in the toplevel django namespace.
...
Reverted 4a56a93cc4
2013-12-22 11:39:55 +01:00
f25fa9d859
Deprecated load_app().
...
Adjusted several tests that used it to add apps to the app cache and
then attempted to remove them by manipulating attributes directly.
Also renamed invalid_models to invalid_models_tests to avoid clashing
application labels between the outer and the inner invalid_models
applications.
2013-12-22 11:39:17 +01:00
François Freitag
Дилян Палаузов
shanghui
Adam Johnson
Jon Dufresne
Mariusz Felisiak
Carles Pina Estany
Tim Graham
Simon Charette
Simon Charette
Claude Paroz
Adam Chainz
Lex Berezhny
Henry Dang
Quentin Fulsher
za
Michael Scott
Kevan Swanberg
Anderson Resende
Andrew Nester
Berker Peksag
Michal Petrucha
Sergey Fedoseev
Brobin
Hasan
Luis San Pablo
Josh Soref
Antoine Catton
Dražen Odobašić
sarthakmeh
Ion Scerbatiuc
Flavio Curella
Michael Manfre
薛丞宏
Alasdair Nicol
Aron Podrigal
MattBlack85
Adam DePue
Nicholas Serra
André Ericson
Shai Berger
Anubhav Joshi
Daniel Pyrathon
Vincent-Vega
Alex Gaynor
Markus Holtermann
Russell Keith-Magee
Marc Egli
Akis Kesoglou
Akis Kesoglou
Christopher Medrela
Aymeric Augustin