Simon Charette
7f63b894c0
Adjusted code style of a few test data setup methods.
...
Thanks Mariusz for suggesting it.
2018-11-27 09:48:22 -05:00
Simon Charette
84e7a9f4a7
Switched setUp() to setUpTestData() where possible in Django's tests.
2018-11-27 09:35:17 -05:00
Tim Graham
405ec5b9c6
Fixed typo in tests/admin_views/tests.py.
2018-11-16 15:09:22 -05:00
Sergey Fedoseev
747db4018b
Simplified AdminFieldExtractionMixin.get_admin_form_fields().
2018-09-25 11:06:41 -04:00
Tim Graham
d311124be5
Fixed #29682 -- Fixed admin change form crash if a view-only model's form has an extra field.
2018-08-20 11:14:20 -04:00
Jon Dufresne
09ee3b6fe3
Fixed #29663 -- Made admin change view redirect to changelist with view permission.
2018-08-17 11:13:06 -04:00
Jon Dufresne
f5e7506cff
Refs #27804 -- Used subTest in AdminViewPermissionsTest.
2018-08-12 21:27:19 -04:00
luz.paz
97e637a87f
Fixed typos in comments and docs.
2018-08-01 16:09:22 -04:00
Claude Paroz
0adfba968e
Fixed #29578 -- Made numberformat.format() honor forced l10n usage.
...
Thanks Sassan Haradji for the report.
2018-07-19 16:44:40 -04:00
Tim Graham
5d98d53fab
Refs #27398 -- Simplified some tests with assertRedirects().
2018-06-20 14:08:56 -04:00
Carlton Gibson
5b73317181
Fixed #29502 -- Allowed users with the view permission to use autocomplete_fields.
2018-06-18 15:36:20 -04:00
Carlton Gibson
958c7b301e
Fixed #29419 -- Allowed permissioning of admin actions.
2018-06-18 15:07:29 -04:00
Paulo
553617e613
Fixed #29487 -- Accounted for object level permissions when calculating change view's read-only fields.
...
Thanks Matthew Frazier for the report and fix.
2018-06-15 21:54:22 -04:00
Ramiro Morales
f40e71a957
Fixed #29417 -- Corrected two admin page titles for view-only users.
2018-05-23 11:02:37 -04:00
olivierdalang
825f0beda8
Fixed #8936 -- Added a view permission and a read-only admin.
...
Co-authored-by: Petr Dlouhy <petr.dlouhy@email.cz>
Co-authored-by: Olivier Dalang <olivier.dalang@gmail.com>
2018-05-16 06:44:55 -04:00
Tim Graham
49a1736c2e
Added assertion for admin change form's "save and continue editing" message.
2018-05-15 20:17:02 -04:00
Morgan Aubert
704443acac
Fixed #29363 -- Added SimpleTestCase.assertWarnsMessage().
2018-05-09 11:40:28 -04:00
Claude Paroz
607970f31c
Replaced django.test.utils.patch_logger() with assertLogs().
...
Thanks Tim Graham for the review.
2018-05-07 09:34:00 -04:00
Faheel Ahmad
5d4d62bf4f
Fixed #29248 -- Renamed admin CSS class field-box to fieldBox.
2018-04-05 10:55:36 -04:00
Jon Dufresne
167d98528a
Refs #27728 -- Fixed BytesWarning in admin_views tests.
2018-04-03 10:11:35 -04:00
Tim Graham
5fa4f40f45
Fixed #29227 -- Allowed BooleanField to be null=True.
...
Thanks Lynn Cyrin for contributing to the patch, and Nick Pope for review.
2018-03-20 12:10:10 -04:00
Mariusz Felisiak
362813d628
Fixed hanging indentation in various code.
2018-03-16 10:54:34 +01:00
Josh Schneier
b60e5fdbb7
Fixed #28959 -- Fixed 'No, take me back' button on admin's inline popup.
2018-03-15 20:47:18 -04:00
Tim Graham
4c02e3cda3
Refs #27728 -- Made cosmetic edits to admin template tag template overriding.
2018-03-01 11:45:08 -05:00
Raffaele Salmaso
5cc28dc752
Fixed #27728 -- Allowed overriding admin templatetags templates.
2018-02-28 08:49:40 +01:00
Becky Smith
8116e588db
Fixed #17962 -- Added ModelAdmin.get_deleted_objects().
2018-02-24 20:41:43 -05:00
Tim Graham
0fa6ab8c18
Tested the admin's delete_selected action when it receives nonexistent pks.
2018-02-24 09:21:13 -05:00
a8568730
ba37ee9ef8
Fixed #28635 -- Fixed admin's preserved filters if the URL contains non-ASCII characters.
2018-02-23 15:40:11 -05:00
Andreas Pelme
e307ff29d2
Fixed #27810 -- Allowed query expressions in admin_order_field.
2018-02-15 21:00:31 -05:00
Haki Benita
98dd943893
Added tests for the date_hierarchy template tag.
2018-02-14 13:36:10 -05:00
Alexander Gaevsky
ef2512b2ff
Fixed #25790 -- Allowed disable column sorting in the admin changelist.
...
Thanks Ramiro Morales for completing the patch.
2018-02-07 17:46:28 -05:00
Tim Graham
fa75b2cb51
Refs #27795 -- Removed force_bytes/text() usage in tests.
2018-02-07 14:20:04 -05:00
Tim Graham
d0a42a14c0
Fixed imports per isort 4.3.1.
...
Partially reverted 9bcf73d788
.
2018-02-02 14:44:07 -05:00
Tim Graham
af33fb250e
Fixed CVE-2018-6188 -- Fixed information leakage in AuthenticationForm.
...
Reverted 359370a8b8
(refs #28645 ).
This is a security fix.
2018-02-01 09:05:14 -05:00
Mariusz Felisiak
9bcf73d788
Fixed imports per isort 4.3.0.
2018-02-01 09:29:46 +01:00
Jon Dufresne
7d607127e3
Refs #21221 -- Deprecated staticfiles and admin_static template tag libraries.
2018-01-23 10:30:10 -05:00
Jon Dufresne
ff05de760c
Fixed #29038 -- Removed closing slash from HTML void tags.
2018-01-21 02:09:10 -05:00
Vasilis Aggelou
777f216d55
Fixed #15522 -- Added ModelAdmin.delete_queryset() to customize "delete selected objects" deletion.
2018-01-05 18:28:45 -05:00
Paulo
d1286a8a68
Fixed #28517 -- Fixed admin delete confirmation view crash when related models don't have a delete permission.
2018-01-04 19:07:46 -05:00
Mariusz Felisiak
83a36ac49a
Removed unnecessary trailing commas and spaces in various code.
2017-12-28 21:07:29 +01:00
Tim Graham
7664fe2759
Refs #28871 -- Fixed admin_views selenium test failure.
2017-12-02 09:54:31 -05:00
Tim Graham
81057645f6
Fixed #28871 -- Fixed initialization of autocomplete widgets in "Add another" inlines.
...
Also allowed autocomplete widgets to work on AdminSites with a name other
than 'admin'.
2017-12-01 22:14:32 -05:00
Tim Graham
474bd7a5d4
Used a separate admin site for autocomplete tests.
2017-12-01 21:57:05 -05:00
shanghui
ebb998976e
Fixed #28751 -- Corrected the error message for inactive users in AdminAuthenticationForm.
...
Thanks SeungWon Kang for the report and Tim Graham for the review.
2017-11-08 09:39:12 -05:00
Claude Paroz
0cf00769ad
Fixed #28585 -- Calculated admin's change form multipart context variable from forms and formsets
...
Thanks Tim Graham for the review.
2017-11-07 19:06:32 -05:00
Tim Graham
8b9a163afa
Refs #28688 -- Updated a selenium test for admin's URLify.js change.
...
English words aren't removed if non-ASCII chars are present.
2017-10-24 11:03:36 -04:00
Tim Graham
48d57788ee
Refs #26447 -- Removed the USE_ETAGS setting per deprecation timeline.
2017-09-22 12:51:18 -04:00
Johannes Hoppe
94cd8efc50
Fixed #14370 -- Allowed using a Select2 widget for ForeignKey and ManyToManyField in the admin.
...
Thanks Florian Apolloner and Tim Graham for review and
contributing to the patch.
2017-09-18 13:48:02 -04:00
Anton Samarchyan
a469e158a9
Added tests for PermissionDenied in admin's delete_selected() view.
2017-06-19 16:01:48 -04:00
Tim Graham
7d52de31af
Moved admin's action view tests to a separate file.
2017-06-19 16:00:06 -04:00
Anton Samarchyan
57f4b3ce37
Added tests for AdminSite's add/disable/get action methods.
2017-06-19 15:53:51 -04:00
Lincoln Smith
15b465c584
Fixed #27998 -- Made ManyToManyField changes logged in admin's object history.
2017-06-14 13:07:06 -04:00
Collin Anderson
7c9cb1ed37
Refs #27953 -- Removed hardcoded uses of Model.__str__() in tests.
2017-06-09 13:28:50 -04:00
Paulo
4ad2f86284
Fixed #28202 -- Fixed FieldListFilter.get_queryset() crash on invalid input.
2017-06-06 07:54:31 -04:00
Paulo
b7f99f84bc
Fixed #28262 -- Fixed incorrect DisallowedModelAdminLookup when a nested reverse relation is in list_filter.
2017-06-05 10:29:54 -04:00
Tim Graham
0841a31baf
Fixed admin_views IntegrityError test failure.
...
Regression in 38a5a23c32
.
2017-06-02 14:59:01 -04:00
Tim Graham
38a5a23c32
Fixed admin_views test when run in reverse.
...
Modifying self.s1 created in setUpTestData() leaked state.
Regression in 45585d3cbb
.
2017-06-02 13:35:03 -04:00
Tim Graham
45585d3cbb
Removed pk hardcoding in admin_views tests.
2017-06-02 10:01:41 -04:00
Jon Dufresne
2c69824e5a
Refs #23968 -- Removed unnecessary lists, generators, and tuple calls.
2017-06-01 19:08:59 -04:00
Bruno Alla
6092ea8fa6
Refs #27804 -- Used subTest() in several tests.
2017-05-24 08:36:34 -04:00
Tim Graham
6b4f018b2b
Replaced type-specific assertions with assertEqual().
...
Python docs say, "it's usually not necessary to invoke these methods directly."
2017-03-17 07:51:48 -04:00
Anton Samarchyan
e88d2dfcf4
Fixed #27475 -- Fixed NonExistentTimeError crash in ModelAdmin.date_hierarchy.
2017-03-06 12:01:31 -05:00
chillaranand
d6eaf7c018
Refs #23919 -- Replaced super(ClassName, self) with super().
2017-01-25 12:23:46 -05:00
Jon Dufresne
0d74c41981
Replaced dict() usage with dict literals.
...
Literals are faster and more idiomatic.
2017-01-23 19:13:49 -05:00
Tim Graham
d170c63351
Refs #23919 -- Removed misc references to Python 2.
2017-01-21 20:02:00 -05:00
Tim Graham
7aba69145d
Refs #23919 -- Removed django.test.mock Python 2 compatibility shim.
2017-01-20 08:17:20 -05:00
Tim Graham
4e729feaa6
Refs #23919 -- Removed django.utils._os.upath()/npath()/abspathu() usage.
...
These functions do nothing on Python 3.
2017-01-20 08:01:02 -05:00
Simon Charette
cecc079168
Refs #23919 -- Stopped inheriting from object to define new style classes.
2017-01-19 08:39:46 +01:00
Claude Paroz
2b281cc35e
Refs #23919 -- Removed most of remaining six usage
...
Thanks Tim Graham for the review.
2017-01-18 21:33:28 +01:00
Claude Paroz
7b2f2e74ad
Refs #23919 -- Removed six.<various>_types usage
...
Thanks Tim Graham and Simon Charette for the reviews.
2017-01-18 20:18:46 +01:00
Claude Paroz
f3c43ad1fd
Refs #23919 -- Removed python_2_unicode_compatible decorator usage
2017-01-18 13:44:34 +01:00
Claude Paroz
d7b9aaa366
Refs #23919 -- Removed encoding preambles and future imports
2017-01-18 09:55:19 +01:00
Tim Graham
d67a46e104
Refs #25135 -- Removed support for the contrib.admin allow_tags attribute.
...
Per deprecation timeline.
2017-01-17 20:52:01 -05:00
Adam Chainz
cd86f03591
Refs #26961 -- Fixed invalid ModelAdmins in tests.
2017-01-07 10:06:51 -05:00
Tim Graham
8ea541e6a2
Refs #2856 -- Removed redundant escaping in admin's "Perhaps it was deleted?" message.
2017-01-04 10:22:17 -05:00
Karen Tracey
27267afc41
Fixed #2856 -- Replaced some 404s with messages in admin.
...
Instead of a 404, return a redirect to admin index page with a message
indicating that the requested object does not exist. This avoids the
admin returning 404 from "Recent Actions" links for deleted objects.
2017-01-03 11:31:05 -05:00
Preston Timmons
b52c73008a
Fixed #15667 -- Added template-based widget rendering.
...
Thanks Carl Meyer and Tim Graham for contributing to the patch.
2016-12-27 17:50:10 -05:00
Adonys Alea Boffill
8ba01d1e42
Fixed #26543 -- Prevented "confirm form submission" browser prompt when reloading after an admin actions failure.
2016-12-23 17:29:24 -05:00
Claude Paroz
1206d7fa57
Refs #25753 -- Reset l10n cache when format settings change
...
Thanks Jaap Roes for the initial patch.
2016-12-21 17:40:08 +01:00
Michael Scott
1e629928e9
Fixed #27313 -- Allowed overriding admin popup response template.
2016-12-14 18:10:56 -05:00
Tim Graham
b5f0b3478d
Fixed #27579 -- Added aliases for Python 3's assertion names in SimpleTestCase.
2016-12-07 17:42:31 -05:00
Ramin Farajpour Cami
967be82443
Fixed E305 flake8 warnings.
2016-11-14 12:30:46 -05:00
Jacob Rief
b3162cab94
Fixed #27386 -- Wrapped admin's readonly fields in <div> rather than <p>.
2016-11-12 10:02:57 -05:00
za
321e94fa41
Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings.
2016-11-10 21:30:21 -05:00
Halil Kaya
2027d6acf7
Fixed #26954 -- Prevented ModelAdmin.has_module_permission()=False from blocking access to the app index page.
2016-10-13 09:11:36 -04:00
Denis Cornehl
a840710e1e
Fixed #26447 -- Deprecated settings.USE_ETAGS in favor of ConditionalGetMiddleware.
2016-10-10 14:55:59 -04:00
Tim Graham
6f3c78dbe6
Fixed #27266 -- Allowed using assertFormError()/assertFormsetError() in admin forms and formsets.
...
Thanks Diego Andrés Sanabria Martín for the report and review.
2016-09-27 09:56:19 -04:00
Jon Dufresne
2c716c1dc7
Fixed #27256 -- Changed Select widget's selected attribute to use HTML5 boolean syntax.
2016-09-21 15:12:13 -07:00
Tim Graham
8119b679eb
Refs #27025 -- Fixed "invalid escape sequence" warnings in Python 3.6.
...
http://bugs.python.org/issue27364
2016-09-17 15:44:06 -04:00
Jibodeah
9459ec82aa
Fixed #26170 -- Made ModelAdmin views run transactions on the correct database.
...
Thanks juntatalor for the initial patch.
2016-09-14 16:06:39 -04:00
Jon Dufresne
8b050cf9dc
Refs #26524 -- Added a test for a <OneToOneField>_id reference in ModelAdmin.list_display.
2016-09-12 19:20:35 -07:00
Jon Dufresne
e24c0a2d7c
Fixed #26524 -- Fixed crash in admin change view when displaying many to many forward refs.
...
Thanks Tim Graham for the regression test.
2016-09-12 19:20:35 -07:00
Alexander Gaevsky
2d26b4637f
Fixed #27207 -- Replaced <p> tag with <div> in admin help texts.
2016-09-10 16:54:10 -04:00
Tim Graham
ef021412d5
Normalized spelling of ETag.
2016-09-09 11:00:21 -04:00
Stanislav Karpov
b387189d86
Fixed #26919 -- Added the action form's media in the changelist view.
2016-08-11 19:35:31 -04:00
Adam Chainz
a757c68129
Fixed admin_views clashing field check error.
...
admin_views.Recommendation.recommender: (models.E006) The field 'recommender'
clashes with the field 'recommender' from model 'admin_views.title'.
2016-08-10 15:54:29 -04:00
Tim Graham
93c538694e
Fixed XSS in admin's add/change related popup.
...
This is a security fix.
2016-07-18 11:17:01 -04:00
Kenneth
2f587737d7
Fixed #26872 -- Fixed text overflow in ModelAdmin.list_filter.
2016-07-09 08:06:42 -04:00
Tim Graham
c9ae09addf
Replaced use of TestCase.fail() with assertRaises().
...
Also removed try/except/fail antipattern that hides exceptions.
2016-06-28 11:21:26 -04:00
Shabda Raaj
b0acb1e73e
Fixed #26779 -- Added extra_context parameter to admin's i18n_javascript view.
2016-06-27 15:37:32 -04:00