Tim Graham
a170dac887
Fixed too many parentheses in inspectdb Meta.unique_together output.
...
Regression in c76d87427d
.
2018-03-21 10:39:36 -04:00
Mads Jensen
bb79e480e1
Increased test coverage for i18n template tags.
2018-03-21 08:38:07 -04:00
Tim Graham
c76d87427d
Refs #23919 -- Removed obsolete comments about u'' prefixes.
2018-03-21 08:15:07 -04:00
Tim Graham
6421bd702f
Refs #29227 -- Made inspectdb generate BooleanField(null=True) rather than NullBooleanField.
2018-03-20 12:10:10 -04:00
Tim Graham
5fa4f40f45
Fixed #29227 -- Allowed BooleanField to be null=True.
...
Thanks Lynn Cyrin for contributing to the patch, and Nick Pope for review.
2018-03-20 12:10:10 -04:00
Astral
a0c03c62a8
Fixed #29229 -- Fixed column mismatch crash when combining two annotated values_list() querysets with union(), difference(), or intersection().
...
Regression in 7316720603821ebb64dfe8fa592ba6edcef5f3e.
2018-03-19 21:05:43 -04:00
Mariusz Felisiak
cede5111bb
Refs #28643 -- Added LPad and RPad database functions.
...
Thanks Tim Graham for the review.
2018-03-19 17:35:16 +01:00
Hasan Ramezani
274e3e27f3
Fixed #29184 -- Made TabularInline respect model form's Meta.labels and help_texts.
2018-03-17 20:51:24 -04:00
Claude Paroz
3c4ff21763
Fixed #29103 -- Removed bad 'b'-prefix added by MySQL's SchemaEditor.quote_value().
2018-03-17 16:36:54 -04:00
Claude Paroz
aa0ee372cd
Added tests for MySQL's SchemaEditor.quote_value().
2018-03-17 16:36:50 -04:00
Tim Graham
f8b98f0edc
Removed DatabaseFeatures.can_introspect_null.
...
The only known usage is in the unmaintained django-pymssql project.
2018-03-16 11:43:41 -04:00
Mariusz Felisiak
362813d628
Fixed hanging indentation in various code.
2018-03-16 10:54:34 +01:00
Mattia Procopio
aeb8c38178
Fixed #29206 -- Fixed PasswordResetConfirmView crash when the URL contains a non-UUID where one is expected.
2018-03-15 21:33:15 -04:00
Josh Schneier
b60e5fdbb7
Fixed #28959 -- Fixed 'No, take me back' button on admin's inline popup.
2018-03-15 20:47:18 -04:00
Mariusz Felisiak
9421aee35e
Refs #28643 -- Added LTrim, RTrim, and Trim database functions.
...
Thanks Tim Graham and Mads Jensen for reviews.
2018-03-15 20:57:23 +01:00
Artem Tabolin
a2f7433adc
Fixed #29221 -- Corrected admin's autocomplete widget to add a space after custom classes.
2018-03-15 10:55:34 -04:00
Mariusz Felisiak
ba3078c92d
Refs #29155 -- Fixed LookupTests.test_pattern_lookups_with_substr() crash on Oracle.
...
Test introduced in feb683c4c2
revealed
unexpected behavior on Oracle that allows concatenating NULL with string.
2018-03-15 09:54:24 -04:00
Tim Graham
87dc0844a6
Fixed #29200 -- Fixed label rendering when using RadioSelect and CheckboxSelectMultiple with MultiWidget.
2018-03-15 09:10:23 -04:00
Tim Graham
fb8fd535c0
Moved SchemaLoggingTest to tests/schema.
2018-03-14 10:24:34 -04:00
Mariusz Felisiak
feb683c4c2
Fixed #29155 -- Fixed crash when database functions are used with pattern lookups.
...
Thanks Tim Graham and Sergey Fedoseev for reviews.
2018-03-14 10:00:07 +01:00
Mariusz Felisiak
acfc650f2a
Fixed #29199 -- Fixed crash when database user password contains @ sign on Oracle.
...
Thanks Shane Allgeier for the report and Tim Graham for the review.
2018-03-13 19:06:40 +01:00
dzhuang
e17088a108
Fixed #29213 -- Fixed autocomplete widget's translations for zh-hans/zh-hant.
2018-03-13 10:58:34 -04:00
robwa
4ab027b944
Fixed #28988 -- Fixed queries when a GenericRelation is used with multi-table inheritance.
2018-03-12 22:42:48 -04:00
Sergey Fedoseev
d696fccae6
Fixed #29209 -- Fixed Cast() with TextField on MySQL and Oracle.
2018-03-12 21:57:14 -04:00
Mariusz Felisiak
c3a1337dfa
Refs #29004 -- Optimized InspectDBTransactionalTests.test_include_views() by limiting introspected tables.
2018-03-12 11:22:57 -04:00
Tim Graham
25b97ee170
Added functions for inspectdb table filtering in tests.
2018-03-12 11:15:13 -04:00
Carlton Gibson
5b083a824e
Fixed #29180 -- Fixed a regression where migrations already in the plan were readded.
...
Regression in a38ae914d8
.
2018-03-09 08:59:57 +01:00
Alex Stovbur
2d9ec4d735
Fixed #29188 -- Fixed ContentFile.size after a write().
2018-03-08 14:07:29 -05:00
Simon Charette
277ed07209
Fixed #29195 -- Fixed Exists.output_field resolution on single-valued queries.
...
The Subquery class which Exists inherits from defaulted to using single-valued
querie's field if no output_field was explicitly specified on initialization
which was bypassing the Exists.output_field defined at the class level.
Moving Subquery's dynamic output_field resolution to _resolve_output_field
should make sure the fallback logic is only performed if required.
Regression in 08654a99bb
.
Thanks Oli Warner for the detailed report.
2018-03-08 13:30:41 -05:00
Fabrizio Ettore Messina
10c0fe528a
Fixed #29178 -- Allowed Index.fields to accept a tuple.
2018-03-08 10:56:55 -05:00
Tim Graham
911af0d24b
Added more tests for django.utils.html.urlize().
2018-03-06 08:30:41 -05:00
Tim Graham
97b7dd59bb
Fixed CVE-2018-7537 -- Fixed catastrophic backtracking in django.utils.text.Truncator.
...
Thanks James Davis for suggesting the fix.
2018-03-06 08:30:40 -05:00
Tim Graham
8618271caa
Fixed CVE-2018-7536 -- Fixed catastrophic backtracking in urlize and urlizetrunc template filters.
...
Thanks Florian Apolloner for assisting with the patch.
2018-03-06 08:30:40 -05:00
Alex Stovbur
d171843f57
Fixed #28981 -- Added an exception if GeoIP database can't be loaded from the path.
2018-03-05 12:20:30 -05:00
Sergey Fedoseev
4ff29a53e6
Refs #17476 -- Removed obsolete simplification of timezone names in cache key generation.
2018-03-03 14:56:39 -05:00
Almad
3d8fadad0f
Added model name to AutoField error message.
2018-03-03 13:22:00 -05:00
Patryk Zawadzki
a20aae414e
Fixed #29144 -- Made untranslated strings for territorial language variants use translations from the generic language variant.
2018-03-03 12:08:24 -05:00
Alex Tomic
a1a3e51561
Fixed #29133 -- Fixed call_command() crash if a required option is passed in options.
2018-03-02 12:25:08 -05:00
Christophe Mehay
40bac28faa
Fixed #29176 -- Fixed AbstractBaseUser.normalize_username() crash if username isn't a string.
2018-03-02 11:32:53 -05:00
François Freitag
a2e97abd81
Fixed #29159 -- Made ModelChoiceIterator reuse QuerySet result cache.
...
When __len__() is called (e.g. when casting to list or tuple), the
QuerySet is evaluated and the result cache populated. iterator()
shouldn't be called on the QuerySet after that, as it would reset the
result cache and trigger a second query.
2018-03-01 14:17:56 -05:00
François Freitag
40f0aa9885
Fixed #29158 -- Fixed len(choices) crash if ModelChoiceField's queryset is a manager.
...
Removing all() in __iter__() prevents a duplicate query when choices are
cast to a list and there's a prefetch_related().
2018-03-01 14:12:14 -05:00
François Freitag
06172d7bc2
Consolidated ModelChoiceField tests.
2018-03-01 14:05:35 -05:00
Tim Graham
4c02e3cda3
Refs #27728 -- Made cosmetic edits to admin template tag template overriding.
2018-03-01 11:45:08 -05:00
Tomáš Ehrlich
fa352626c2
Fixed #29172 -- Fixed crash with Window expression in a subquery.
2018-03-01 10:24:14 -05:00
Mariusz Felisiak
54f80430be
Fixed #29166 -- Fixed crash in When() expression with a list argument.
...
Thanks Matthew Pava for the report and Tim Graham and Carlton Gibson for
reviews.
Regression in 19b2dfd1bf
.
2018-02-28 18:05:23 +01:00
Tim Graham
3fb718f17d
Eliminated the need to modify a model forms test when new test files are added.
2018-02-28 10:26:26 -05:00
Raffaele Salmaso
5cc28dc752
Fixed #27728 -- Allowed overriding admin templatetags templates.
2018-02-28 08:49:40 +01:00
Tim Graham
5b589a47b9
Fixed #29161 -- Removed BCryptPasswordHasher from PASSWORD_HASHERS.
2018-02-26 09:05:18 -05:00
Becky Smith
8116e588db
Fixed #17962 -- Added ModelAdmin.get_deleted_objects().
2018-02-24 20:41:43 -05:00
Tim Graham
0fa6ab8c18
Tested the admin's delete_selected action when it receives nonexistent pks.
2018-02-24 09:21:13 -05:00
a8568730
ba37ee9ef8
Fixed #28635 -- Fixed admin's preserved filters if the URL contains non-ASCII characters.
2018-02-23 15:40:11 -05:00
Sebastian Sangervasi
7905815510
Fixed #27449 -- Added django.utils.translation.get_supported_language_variant().
2018-02-23 14:49:00 -05:00
Hasan Ramezani
5033999153
Fixed #29154 -- Corrected examples in pluralize docstring and added tests.
2018-02-23 14:20:00 -05:00
bobort
f82de6bfb1
Refs #28643 -- Added Ord, Chr, Left, and Right database functions.
2018-02-23 10:23:22 -05:00
Matthew Schinckel
c412926a2e
Fixed #29142 -- Fixed crash when OuterRef is used with an operator.
2018-02-23 09:38:16 -05:00
Mikhail Porokhovnichenko
14e34dcf8c
Fixed #29132 -- Avoided connecting update_last_login() handler if User.last_login isn't a field.
2018-02-21 10:36:31 -05:00
Sebastian Sangervasi
5c4c87e55c
Changed "language-code" to the more commonly used "language code".
2018-02-21 09:31:05 -05:00
Tom Forbes
33ac036a6b
Fixed #28398 -- Added suggestions for mistyped management commands.
2018-02-21 09:00:49 -05:00
Sebastian Sangervasi
f7b46f0b58
Removed unneeeded inner import in i18n tests.
2018-02-21 08:59:31 -05:00
Oliver Sauder
6f0b8c1c9e
Fixed #28442 -- Fixed crash with nested OuterRefs that reference AutoField.
2018-02-20 21:58:43 -05:00
Chillar Anand
e8e0cfa9e5
Fixed #28755 -- Made check_for_language() include apps' locale directories.
2018-02-20 21:34:40 -05:00
Williams Mendez
2691ed7ba1
Fixed #29140 -- Fixed EmailMessage crash when body is None.
2018-02-20 09:34:01 -05:00
Tim Graham
548f78ba46
Removed redundant lookup name in register_lookup() calls.
2018-02-19 13:12:13 -05:00
dizballanze
eb002e7892
Fixed #29135 -- Prevented get_object/list_or_404() from hiding AttributeError raised by QuerySet filtering.
2018-02-19 10:51:15 -05:00
Dylan Verheul
9b1125bfc7
Fixed #28379 -- Made AccessMixin raise Permissiondenied for authenticated users.
2018-02-16 13:58:55 -05:00
Andreas Pelme
e307ff29d2
Fixed #27810 -- Allowed query expressions in admin_order_field.
2018-02-15 21:00:31 -05:00
Herbert Parentes Fortes Neto
d368784bac
Fixed #28171 -- Added an exception if Form's empty_permitted and use_required_attribute arguments conflict.
2018-02-15 13:44:26 -05:00
Tim Graham
e917ea6bec
Fixed #29126 -- Doc'd the behavior of QuerySet.update_or_create() with manually specified pks.
2018-02-15 13:17:37 -05:00
Tomer Chachamu
7ec0fdf62a
Fixed #28693 -- Fixed crash in CsrfViewMiddleware when an HTTPS request has an invalid host.
2018-02-14 20:24:01 -05:00
Haki Benita
ff5517988a
Fixed #28933 -- Improved the efficiency of ModelAdmin.date_hierarchy queries.
2018-02-14 19:15:41 -05:00
Haki Benita
98dd943893
Added tests for the date_hierarchy template tag.
2018-02-14 13:36:10 -05:00
Sanyam Khurana
5a669ae2f4
Fixed #29106 -- Made DiscoverRunner display selected test tags.
2018-02-13 12:56:31 -05:00
Denys Duchier
cb7860cced
Fixed #24607 -- Serialized natural keys in multi-table inheritance models.
...
Thanks João Paulo Melo de Sampaio for the test.
2018-02-12 21:15:04 -05:00
Tim Graham
9ba3df8240
Refs #29125 -- Made Q.deconstruct() omit 'query_utils' in the path and _connector='AND' since it's a default value.
2018-02-12 15:23:41 -05:00
Tim Graham
b95c49c954
Fixed #29125 -- Made Q.deconstruct() deterministic with multiple keyword arguments.
2018-02-12 14:52:32 -05:00
Tim Graham
a6fb81750a
Added a test for Client.generic() data coercion.
...
The smart_str() call (now force_bytes()) added in
e73838b6dd
is otherwise untested.
2018-02-12 12:53:02 -05:00
Tim Graham
4206765a5b
Refs #20530 -- Added a test for test client query string encoding.
...
7bb6279360
is only tested in
django-contrib-comments.
2018-02-12 10:20:53 -05:00
Snow_Poijio
7a715b3881
Fixed typo in tests/one_to_one/tests.py docstring.
2018-02-12 08:44:49 -05:00
Stanislav Karpov
6d794fb762
Fixed #28960 -- Added GEOSGeometry.buffer_with_style().
2018-02-10 19:45:58 -05:00
Matthew Wilkes
2162f0983d
Fixed #24747 -- Allowed transforms in QuerySet.order_by() and distinct(*fields).
2018-02-10 19:08:55 -05:00
Raphael Gaschignard
bf26f66029
Fixed #29118 -- Fixed crash with QuerySet.order_by(Exists(...)).
2018-02-10 18:35:57 -05:00
Manatsawin Hanmongkolchai
1a1264f149
Fixed #29109 -- Fixed the admin time picker widget for the Thai locale.
2018-02-10 16:05:41 -05:00
Tim Graham
b832de869e
Added tests for utils.html.urlize() (lazy string inputs were untested).
2018-02-10 15:45:57 -05:00
Tim Graham
d4373b6da4
Switched test requirement to new psycopg2-binary package.
2018-02-08 20:02:35 -05:00
Simon Charette
d61fe24601
Fixed #29108 -- Fixed crash in aggregation of distinct+ordered+sliced querysets.
...
Regression in 4acae21846
.
Thanks Stephen Brooks for the report.
2018-02-08 09:59:25 -05:00
Jonas Haag
8c709d79cb
Fixed #17419 -- Added json_tag template filter.
2018-02-07 18:38:12 -05:00
Alexander Gaevsky
ef2512b2ff
Fixed #25790 -- Allowed disable column sorting in the admin changelist.
...
Thanks Ramiro Morales for completing the patch.
2018-02-07 17:46:28 -05:00
Tim Graham
fa75b2cb51
Refs #27795 -- Removed force_bytes/text() usage in tests.
2018-02-07 14:20:04 -05:00
Mariusz Felisiak
34b52f8572
Renamed the allow_sliced_subqueries database feature to allow_sliced_subqueries_with_in.
...
After 0899d583bd
this database feature is
false only on MySQL which doesn't support sliced subqueries only with
IN/ALL/ANY/SOME.
2018-02-07 08:27:47 +01:00
Nick Sarbicki
47268242b0
Fixed #29082 -- Allowed the test client to encode JSON request data.
2018-02-06 18:29:04 -05:00
shanghui
d968788b57
Fixed #28833 -- Prevented CacheMiddleware from caching responses with "Cache-Control: private".
2018-02-06 09:42:05 -05:00
Tom
272f685794
Fixed #27999 -- Added test client support for HTTP 307 and 308 redirects.
2018-02-06 09:03:43 -05:00
Raymond Hettinger
aba9763b51
Refs #28814 -- Imported from collections.abc to fix Python 3.7 deprecation warnings.
...
https://bugs.python.org/issue25988
2018-02-05 11:42:47 -05:00
Jon Dufresne
8b21878357
Refs #28723 -- Fixed stale prefetch_related cache after add/remove.
...
Regression in 514b2c989a
.
2018-02-05 11:02:57 -05:00
Jon Dufresne
f0658ff818
Made prefetch_related tests use assertCountEqual() for unordered sequences.
2018-02-05 10:00:57 -05:00
Raffaele Salmaso
da3df5b878
Fixed #8500 -- Allowed overriding the default admin site instance.
2018-02-03 18:51:10 -05:00
Tim Graham
d0a42a14c0
Fixed imports per isort 4.3.1.
...
Partially reverted 9bcf73d788
.
2018-02-02 14:44:07 -05:00
Mariusz Felisiak
75e45a45e7
Simplified aggregation.tests.
2018-02-02 08:47:32 +01:00
Tim Graham
af33fb250e
Fixed CVE-2018-6188 -- Fixed information leakage in AuthenticationForm.
...
Reverted 359370a8b8
(refs #28645 ).
This is a security fix.
2018-02-01 09:05:14 -05:00
Tim Graham
552abffab1
Fixed #29094 -- Fixed crash when entering an invalid uuid in ModelAdmin.raw_id_fields.
...
Regression in 2f9861d823
.
Thanks Carel Burger for the report and fix.
2018-02-01 08:36:36 -05:00