Tom Forbes
8a902b7ee6
Fixed #31716 -- Fixed detection of console scripts in autoreloader on Windows.
2020-06-18 13:04:10 +02:00
David Smith
10df5b7177
Refs #31670 -- Removed whitelist/blacklist terminology in docs and comments.
2020-06-17 13:15:56 +02:00
Hasan Ramezani
47651eadb8
Fixed #30583 -- Fixed handling JSONFields in XML serializer.
...
Co-authored-by: Chason Chaffin <chason@gmail.com>
2020-06-17 11:12:18 +02:00
Mariusz Felisiak
82da72b748
Refs #28077 -- Added opclasses to Index.__repr__().
...
This also removes unnecessary commas between attributes.
2020-06-17 10:32:43 +02:00
Florian Apolloner
1621f06051
Fixed #30472 -- Made Argon2PasswordHasher use Argon2id.
2020-06-17 08:10:41 +02:00
Florian Apolloner
ee49cf4f35
Added test for old Argon2i hashes with version attribute.
2020-06-17 08:10:41 +02:00
Mariusz Felisiak
78c811334c
Refs #30190 -- Minor edits to JSONL serializer.
...
Follow up to e29637681b
.
2020-06-17 07:59:40 +02:00
Mariusz Felisiak
e36028fb9c
Reverted "Pinned asgiref == 3.2.7 in test requirements."
...
This reverts commit dcb4d79ef7
.
2020-06-17 07:08:51 +02:00
Ali Vakilzade
e29637681b
Fixed #30190 -- Added JSONL serializer.
2020-06-16 16:51:58 +02:00
Simon Charette
ea3beb4f5a
Refs #30446 -- Defined default output_field of text database functions.
...
This prevented the default behavior of
BaseExpression._resolve_output_field from error'ing out when such
functions accepted both expressions from mixed types
(e.g. SubStr(CharField, IntegerField, IntegerField)).
2020-06-16 10:08:02 +02:00
Hannes Ljungberg
0d6d4e78b1
Fixed #31709 -- Added support for opclasses in ExclusionConstraint.
2020-06-16 08:16:14 +02:00
Mariusz Felisiak
dcb4d79ef7
Pinned asgiref == 3.2.7 in test requirements.
2020-06-16 07:54:41 +02:00
Hannes Ljungberg
7edc6e53a7
Fixed #31702 -- Added support for PostgreSQL opclasses in UniqueConstraint.
2020-06-16 07:19:00 +02:00
John Parton
a8473b4d34
Fixed #31691 -- Added ordering support to JSONBAgg.
2020-06-13 00:06:29 +02:00
Hannes Ljungberg
e0cdd0fcf5
Fixed #31649 -- Added support for covering exclusion constraints on PostgreSQL 12+.
2020-06-12 23:23:21 +02:00
Hasan Ramezani
9e8edc1e55
Fixed #31491 -- Allowed 'password' option in DATABASES['OPTIONS'] on MySQL.
2020-06-12 12:07:43 +02:00
Chinmoy Chakraborty
2928019e0c
Fixed #31645 -- Enhanced the migration warning for migrate commmand.
...
Added the list of apps with changes not reflected in migrations.
2020-06-12 10:26:06 +02:00
Mariusz Felisiak
aeb8996a67
Fixed #31659 -- Made ExpressionWrapper preserve output_field for combined expressions.
...
Regression in df32fd42b8
.
Thanks Simon Charette for the review.
2020-06-12 07:20:06 +02:00
Adam Johnson
5776a1660e
Fixed #31667 -- Made __in lookup ignore None values.
2020-06-11 12:12:26 +02:00
Michael Brown
36db4dd937
Fixed #28132 -- Made MultiPartParser ignore filenames with trailing slash.
2020-06-11 08:46:59 +02:00
Hasan Ramezani
037a624120
Fixed #31657 -- Fixed ordering by attnames of self-referential ForeignKeys.
2020-06-10 11:14:26 +02:00
Hasan Ramezani
c1f7de8acc
Refs #31657 -- Added test for ordering by self-referential ForeignKeys.
2020-06-10 11:11:20 +02:00
Hasan Ramezani
a59de6e89e
Fixed #31675 -- Added warning to ExceptionReporter when exception chain has a cycle.
2020-06-10 09:23:33 +02:00
Joshua Massover
92309e53d9
Fixed #31594 -- Added ASGIStaticFilesHandler.get_response_async().
2020-06-08 12:52:26 +02:00
Nicolas Baccelli
b38d44229f
Fixed #31664 -- Reallowed using non-expressions having filterable attribute as rhs in queryset filters.
...
Regression in 4edad1ddf6
.
2020-06-08 08:17:23 +02:00
Mariusz Felisiak
78ad4b4b02
Fixed #31660 -- Fixed queryset crash when grouping by m2o relation.
...
Regression in 3a941230c8
.
Thanks Tomasz Szymański for the report.
2020-06-08 07:21:54 +02:00
davidchorpash
07506a6114
Fixed #31661 -- Removed period in makemigrations history check warning.
2020-06-08 06:46:23 +02:00
Sasha Pachev
38a21f2d9e
Fixed #31663 -- Made DecimalField.to_python() handle non-numeric invalid values.
2020-06-05 21:13:36 +02:00
David Smith
433dd737f9
Fixed #20347 -- Allowed customizing the maximum number of instantiated forms in formsets.
...
Co-authored-by: ethurgood <ethurgood@gmail.com>
2020-06-05 12:01:32 +02:00
David Smith
b5aa9cb20f
Refs #20347 -- Added test for formset_factory()'s absolute_max default.
...
Co-authored-by: ethurgood <ethurgood@gmail.com>
2020-06-05 10:00:25 +02:00
Mariusz Felisiak
926148ef01
Fixed #31654 -- Fixed cache key validation messages.
2020-06-05 07:21:52 +02:00
Mariusz Felisiak
f83b44075d
Refs #30913 -- Added system checks for covering indexes and unique constraints support.
2020-06-04 12:26:25 +02:00
Hannes Ljungberg
8c7992f658
Fixed #30913 -- Added support for covering indexes on PostgreSQL 11+.
2020-06-04 12:26:22 +02:00
Jon Dufresne
f47d5aac62
Refs #27804 -- Used subTest() in tests.utils_tests.test_text.
2020-06-04 11:16:21 +02:00
Claude Paroz
9e57b1efb5
Fixed #30134 -- Ensured unlocalized numbers are string representation in templates.
2020-06-04 10:34:54 +02:00
Claude Paroz
51250d2f12
Refs #30134 -- Added test for {% localize off %} tag with format settings.
2020-06-04 10:34:54 +02:00
Tim Graham
a7b4a04d6c
Refs #31630 -- Added CharField and IntegerField to DatabaseFeatures.introspected_field_types.
...
CockroachDB introspects CharField as TextField and IntegerField as
BigIntegerField.
2020-06-04 08:46:06 +02:00
Tim Graham
e24b63fe85
Refs #31630 -- Removed DatabaseFeatures.can_introspect_autofield.
2020-06-04 08:27:46 +02:00
Hasan Ramezani
e198beadad
Fixed #31630 -- Replaced introspection features with DatabaseFeatures.introspected_field_types.
2020-06-04 08:27:42 +02:00
David Smith
dbdc192ca3
Preferred usage of among/while to amongst/whilst.
2020-06-03 21:02:48 +02:00
Mariusz Felisiak
229c9c6653
Refs CVE-2020-13254 -- Fixed cache.tests when KEY_PREFIX is defined.
...
Follow up to 2c82414914
.
2020-06-03 13:00:37 +02:00
Dan Palmer
2c82414914
Fixed CVE-2020-13254 -- Enforced cache key validation in memcached backends.
2020-06-03 09:24:26 +02:00
Jon Dufresne
2dd4d110c1
Fixed CVE-2020-13596 -- Fixed potential XSS in admin ForeignKeyRawIdWidget.
2020-06-03 09:23:00 +02:00
Thodoris Sotiropoulos
df32fd42b8
Fixed #31651 -- Made ExpressionWrapper use grouping columns from wrapped expression.
2020-06-03 07:29:41 +02:00
Adam Johnson
22a59c01c0
Refs #31615 -- Added EXISTS clauses to extension operations.
2020-06-03 07:02:48 +02:00
Carles Pina
e46c2326c8
Fixed #31536 -- Fixed rendering of disabled AdminFileWidget and ClearableFileInput.
2020-06-01 12:25:25 +02:00
René Fleschenberg
578b3046e3
Reverted "Refs #23919 -- Removed obsolete __init__.py files in management command directories."
...
This reverts commit ccc25bfe4f
.
https://groups.google.com/d/topic/django-developers/GVHMH2ciAnk/discussion
2020-06-01 10:55:41 +02:00
Carlton Gibson
dd1ca50b09
Fixed #31570 -- Corrected translation loading for apps providing territorial language variants with different plural equations.
...
Regression in e3e48b0012
.
Thanks to Shai Berger for report, reproduce and suggested fix.
2020-06-01 08:38:54 +02:00
David Smith
0382ecfe02
Fixed #28694 -- Made django.utils.text.slugify() strip dashes and underscores.
2020-05-29 06:47:51 +02:00
David Smith
dde05e192c
Added more tests for slugify().
2020-05-29 06:28:57 +02:00
Adam Johnson
fa58450a9a
Fixed #31468 -- Allowed specifying migration filename in Operation.
...
This adds also suggested filename for many built-in operations.
2020-05-28 11:42:53 +02:00
Adam Johnson
5bd585a82d
Refs #31468 -- Added tests for MigrationAutodetector.suggest_name().
2020-05-28 11:24:58 +02:00
Tom Carrick
780473d756
Refs #31034 -- Improved accessibility of admin navigation sidebar.
2020-05-28 10:16:20 +02:00
Mariusz Felisiak
42de52affe
Fixed isolation of test_migrate_fake_initial.
2020-05-28 09:32:43 +02:00
Scott Cranfill
62f1655a64
Fixed #11157 -- Stopped removing stop words in admin's prepopulated_fields.
...
Co-Authored-By: Andy Chosak <andy@chosak.org>
2020-05-27 12:32:56 +02:00
Frantisek Holop
d693a086de
Fixed #31615 -- Made migrations skip extension operations if not needed.
...
- Don't try to create an existing extension.
- Don't try to drop a nonexistent extension.
2020-05-27 10:48:44 +02:00
Frantisek Holop
73216aaaa9
Used not installed extension in CreateExtension() tests.
...
uuid-ossp was already installed.
2020-05-27 10:46:22 +02:00
Ahmad A. Hussein
7c947f0f5a
Fixed #31494 -- Preserved query strings when following HTTP 307/308 redirects in test client.
2020-05-27 10:36:52 +02:00
Ahmad A. Hussein
6425fd3124
Refs #31494 -- Added test for query strings for GET/HEAD requests when following HTTP 307/308 redirects in test client.
2020-05-27 10:36:52 +02:00
Mariusz Felisiak
f4bab0982a
Refs #31614 -- Added test for ordering by OrderBy() of combined queryset with not selected columns.
2020-05-27 09:03:53 +02:00
Ryan Heard
587b179d41
Fixed #31606 -- Allowed using condition with lookups in When() expression.
2020-05-27 07:32:23 +02:00
Laurent Tramoy
2aac176e86
Fixed #31614 -- Fixed aliases ordering by OrderBy() expressions of combined queryset.
2020-05-26 21:14:45 +02:00
Laurent Tramoy
51ad767d0b
Refs #31614 -- Added test for aliases ordering on combined querysets.
2020-05-26 21:14:40 +02:00
Laurent Tramoy
50f71ccb36
Used operator.attrgetter() in test_qs_combinators.
2020-05-26 21:14:40 +02:00
Nan Liu
33c365781a
Fixed #31416 -- Made autodetector find dependencies for MTI model creation on base fields removal.
...
Removing a base field must take place before adding a new inherited
model that has a field with the same name.
2020-05-26 07:26:07 +02:00
Hasan Ramezani
18759b2209
Fixed #31616 -- Added hint about middleware ordering for SessionMiddleware admin check.
2020-05-25 21:14:32 +02:00
Claude Paroz
adf58311b8
Fixed #29078 -- Made serializers respect prefetch_related() for m2m fields.
2020-05-25 10:45:16 +02:00
Claude Paroz
b547c42661
Improved HTTPSitemapTests.test_localized_priority.
...
Override setting instead of skipping.
Use translation override context manager to avoid language leaking.
2020-05-25 09:07:50 +02:00
Simon Charette
972000420e
Fixed #31624 -- Avoided subquery usage on QuerySet.all().delete().
...
Thanks Adam Johnson for the report.
Regression in 7acef095d7
.
2020-05-25 08:14:49 +02:00
Jon Dufresne
dfb9ae1d23
Refs #30400 -- Improved typography in admin_doc/missing_docutils.html.
2020-05-23 12:02:10 +02:00
Hasan Ramezani
c60524c658
Fixed #31546 -- Allowed specifying list of tags in Command.requires_system_checks.
2020-05-21 12:34:54 +02:00
Manuel Weitzman
a4e6030904
Fixed #30375 -- Added FOR NO KEY UPDATE support to QuerySet.select_for_update() on PostgreSQL.
2020-05-21 10:51:10 +02:00
Jon Dufresne
81d69568a6
Made test_once a keyword argument in template_tests.utils.setup().
...
Replaces the kwargs.get(...) pattern. Helps avoid typos by providing a
better error message in case of misuse.
2020-05-21 08:09:19 +02:00
Fran Hrzenjak
4484bc1b2f
Fixed #31597 , #31603 -- Corrected admin clear all filters link behavior.
...
- Show "Clear all filters" only when any filter is selected.
- Preserve query string not related with filters.
Co-Authored-By: Hasan Ramezani <hasan.r67@gmail.com>
2020-05-20 21:08:47 +02:00
Hasan Ramezani
3c7bf39e23
Fixed #31410 -- Added system checks for invalid model field names in UniqueConstraint.
2020-05-20 10:56:55 +02:00
David Smith
e875fac886
Removed unused variable in test_datetimefield_clean_input_formats.
2020-05-20 06:02:28 +02:00
Mariusz Felisiak
a125da6a7c
Fixed #31607 -- Fixed evaluated Subquery equality.
...
Regression in 691def10a0
.
2020-05-19 22:44:57 +02:00
Mariusz Felisiak
b739f2e91d
Refs #30727 -- Added tests for Subquery with queryset in kwargs pickle without evaluating it.
2020-05-19 22:44:57 +02:00
Mariusz Felisiak
20a8a443f0
Fixed #31578 -- Dropped support for MySQL 5.6.
2020-05-19 10:56:39 +02:00
wtkm11
9756c33429
Fixed #31504 -- Allowed calling makemigrations without an active database connection.
2020-05-19 10:24:23 +02:00
Hannes Ljungberg
952afc166c
Fixed #31601 -- Fixed SearchHeadlineTests on PostgresSQL 9.6.18+, 10.13+, 11.8+, and 12.3+.
2020-05-19 07:46:22 +02:00
Jon Dufresne
3b1cb78063
Used assertIs(…, True) in model_forms.tests.ValidationTest.
2020-05-18 09:25:26 +02:00
Jon Dufresne
7070d46114
Updated docutils link to HTTPS and new location.
2020-05-18 08:45:31 +02:00
Tim Graham
f59a2b7306
Refs #12990 -- Added DatabaseFeatures.has_json_operators.
...
CockroachDB also has them.
2020-05-18 08:12:20 +02:00
Simon Charette
94f63b926f
Refs #31395 -- Relied on setUpTestData() test data isolation in various tests.
2020-05-15 20:22:56 +02:00
Simon Charette
3cf80d3fcf
Fixed #31395 -- Made setUpTestData enforce in-memory data isolation.
...
Since it's introduction in Django 1.8 setUpTestData has been suffering
from a documented but confusing caveat due to its sharing of attributes
assigned during its execution with all test instances.
By keeping track of class attributes assigned during the setUpTestData
phase its possible to ensure only deep copies are provided to test
instances on attribute retreival and prevent manual setUp gymnastic to
work around the previous lack of in-memory data isolation.
Thanks Adam Johnson for the extensive review.
2020-05-15 20:22:52 +02:00
Simon Charette
1dd96f731d
Refs #13227 -- Adjusted a test to avoid making a shared test model unpickable.
...
This allowed the Note model to be used in setUpTestData() which requires
assigned model instances to be copy.deepcopy()'able.
2020-05-15 20:22:51 +02:00
Paolo Melchiorre
0e3b0da2e3
Fixed #31552 -- Added support for LZMA and XZ fixtures to loaddata.
2020-05-15 11:30:28 +02:00
François Freitag
2e48cf6bd9
Fixed fixtures loading isolation in tests.
...
fixture1.json and fixture2.json exist in both "fixtures" and
"fixtures_model_package". Both apps are listed in "INSTALLED_APPS". The
loaddata management command loads from installed apps, thus loads both
fixtures when a test runs loaddata with any of these fixtures.
2020-05-15 09:14:05 +02:00
kjpc-tech
099bce1bf0
Fixed #31590 -- Fixed ModelAdmin.date_hierarchy crash with an empty QuerySet.
...
Regression in 55cdf6c52d
.
2020-05-15 06:35:10 +02:00
Jon Dufresne
81ffedaacc
Fixed #31524 -- Removed minified static assets from the admin.
2020-05-14 16:07:56 +02:00
Carlton Gibson
6c19c2ca51
Corrected indentation in test case.
2020-05-14 15:32:36 +02:00
Jon Dufresne
129193328e
Added Selenium test coverage for actions.js.
2020-05-14 15:32:36 +02:00
Mariusz Felisiak
3a941230c8
Fixed #31584 -- Fixed crash when chaining values()/values_list() after Exists() annotation and aggregation on Oracle.
...
Oracle requires the EXISTS expression to be wrapped in a CASE WHEN in
the GROUP BY clause.
Regression in efa1908f66
.
2020-05-14 15:07:08 +02:00
David Smith
03537e2458
Completed lorem tag test coverage.
2020-05-14 12:36:38 +02:00
Jon Dufresne
d522b51c40
Fixed #31575 -- Added system check for admin sidebar request context processor dependency.
...
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2020-05-14 11:00:51 +02:00
Simon Charette
adfbf653dc
Fixed #31568 -- Fixed alias reference when aggregating over multiple subqueries.
...
691def10a0
made all Subquery() instances
equal to each other which broke aggregation subquery pushdown which
relied on object equality to determine which alias it should select.
Subquery.__eq__() will be fixed in an another commit but
Query.rewrite_cols() should haved used object identity from the start.
Refs #30727 , #30188 .
Thanks Makina Corpus for the report.
2020-05-14 09:31:15 +02:00
Simon Charette
42c08ee465
Fixed #31566 -- Fixed aliases crash when chaining values()/values_list() after annotate() with aggregations and subqueries.
...
Subquery annotation references must be resolved if they are excluded
from the GROUP BY clause by a following .values() call.
Regression in fb3f034f1c
.
Thanks Makina Corpus for the report.
2020-05-14 08:16:16 +02:00
Mariusz Felisiak
e536fa5ce1
Fixed #31579 -- Dropped support for PostgreSQL 9.5 and PostGIS 2.2.
2020-05-14 06:33:00 +02:00
Mariusz Felisiak
18eb852874
Fixed #31576 -- Fixed selenium tests with headless mode.
...
Horizontal scrollbar doesn't appear with the headless mode on small
windows, that's why window.scrollTo() is not an option for these
tests.
Tests changed after adding a navigation sidebar in
46fe506445
.
2020-05-13 15:07:21 +02:00
Hasan Ramezani
01a381cc17
Fixed #31580 -- Added error messages on distinct() following union(), intersection(), and difference().
2020-05-13 14:44:10 +02:00
François Freitag
49ae7ce50a
Removed redundant assertions in fixtures tests.
2020-05-13 13:07:15 +02:00
Claude Paroz
d4c5ef3ebb
Renamed PROJ.4 to PROJ.
2020-05-13 10:30:30 +02:00
François Freitag
f9d13a1b5a
Removed unused fixture2.xml from fixtures_model_package tests.
2020-05-13 09:13:02 +02:00
François Freitag
c8bebbd541
Disabled management commands output with verbosity 0 in various tests.
2020-05-13 09:12:43 +02:00
Mariusz Felisiak
f2187a227f
Increased the default PBKDF2 iterations for Django 3.2.
2020-05-13 09:07:51 +02:00
Mariusz Felisiak
d106d07f73
Advanced deprecation warnings for Django 3.2.
2020-05-13 09:07:51 +02:00
Claude Paroz
58f1b07e49
Fixed #30678 -- Added support for GDAL 3.
2020-05-12 09:06:06 +02:00
Mariusz Felisiak
0668164b4a
Fixed E128, E741 flake8 warnings.
2020-05-12 08:52:23 +02:00
Tom Carrick
d24ba1be7a
Fixed #31034 -- Added a navigation sidebar to the admin.
...
Co-authored-by: elky <elky@users.noreply.github.com>
Co-authored-by: Goetz <goetz.buerkle@gmail.com>
2020-05-11 18:16:38 +02:00
Jon Dufresne
d6aff369ad
Refs #30116 -- Simplified regex match group access with Match.__getitem__().
...
The method has been available since Python 3.6. The shorter syntax is
also marginally faster.
2020-05-11 12:01:28 +02:00
Adam Johnson
a8b2db1cae
Optimized Model and QuerySet pickling version comparison.
2020-05-11 09:50:11 +02:00
Jon Dufresne
72a170b4c3
Fixed #25236 -- Deprecated {% ifequal %} and {% ifnotequal %} template tags.
...
The {% if %} tag provides all features of these tags.
Since Django 1.2 (May 17, 2010), the docs have hinted that
{% ifequal %} and {% ifnotequal %} will be deprecated in a future
Django version. Time to make it official.
2020-05-11 09:07:33 +02:00
Jon Dufresne
d8cb8fdf40
Switched unittest.TestCase to SimpleTestCase in template_tests/test_nodelist.py.
2020-05-11 07:56:11 +02:00
Yash Saini
ccb1cfb64e
Fixed #31548 -- Fixed URLValidator crash on non-strings.
2020-05-08 20:53:05 +02:00
Yash Saini
bda6ade7b7
Added URLValidator test for missing scheme.
2020-05-08 20:50:25 +02:00
Hasan Ramezani
87faeee4e0
Fixed #31528 -- Made collectstatic management command run staticfiles checks.
2020-05-08 12:47:57 +02:00
François Freitag
01f8d19ef9
Fixed tests isolation in logging_tests.
...
The SetupConfigureLogging test case does not restore the logging config
after its execution. It leaves the logger django.request with an empty
handlers array.
This also removes the last use of LOGGING_CONFIG, introduced in
43503b093a
.
2020-05-08 10:49:34 +02:00
dbxnr
fc0f7f6c15
Fixed #31157 -- Fixed displaying read-only JSONField values in admin.
2020-05-08 09:44:42 +02:00
dbxnr
675ce4dd35
Refs #31157 -- Added tests for display_for_field() with empty JSONField.
2020-05-08 09:37:49 +02:00
Paolo Melchiorre
2e0f04507b
Added tests for loaddata with gzip/bzip2 compressed fixtures.
...
Co-authored-by: Adam Johnson <me@adamj.eu>
2020-05-08 08:16:50 +02:00
sage
6789ded0a6
Fixed #12990 , Refs #27694 -- Added JSONField model field.
...
Thanks to Adam Johnson, Carlton Gibson, Mariusz Felisiak, and Raphael
Michel for mentoring this Google Summer of Code 2019 project and
everyone else who helped with the patch.
Special thanks to Mads Jensen, Nick Pope, and Simon Charette for
extensive reviews.
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2020-05-08 07:23:31 +02:00
Mariusz Felisiak
f97f71f592
Refs #12990 -- Bumped mysqlclient requirement to >= 1.4.0.
...
MySQLdb.constants.FIELD_TYPE.JSON was added in mysqlclient 1.4.0rc2.
2020-05-08 06:14:42 +02:00
Mariusz Felisiak
106e8dc91a
Completed test coverage for ExclusionConstraint.
...
Dropping exclusion constraints was untested.
2020-05-07 10:02:14 +02:00
Carlton Gibson
92507bf3ea
Fixed #31515 -- Made ASGIHandler dispatch lifecycle signals with thread sensitive.
2020-05-06 09:42:02 +02:00
Adam Johnson
1c2c6f1b51
Fixed a/an typos in "SQL" usage.
2020-05-06 06:35:26 +02:00
Mariusz Felisiak
fb52176a6f
Made DateTimePickerShortcutsSeleniumTests.test_date_time_picker_shortcuts() less flaky.
...
Moved picking the current time closer to the actual click.
2020-05-05 11:00:05 +02:00
Mariusz Felisiak
b73e66e758
Fixed #31538 -- Fixed Meta.ordering validation lookups that are not transforms.
...
Regression in 440505cb2c
.
Thanks Simon Meers for the report.
2020-05-05 09:08:29 +02:00
David Smith
2522559d1a
Fixed #31534 -- Deprecated django.conf.urls.url().
2020-05-05 07:34:34 +02:00
Adam Johnson
d17b380653
Refs #30573 -- Rephrased "Of Course" and "Obvious(ly)" in documentation and comments.
2020-05-04 12:10:47 +02:00
Rasmus Wriedt Larsen
f6d0bd208a
Corrected opts argument of colorize in TermColorTests.test_colorize_empty_text().
2020-05-04 11:34:08 +02:00
Tom Forbes
c00bc27945
Refs #30372 -- Stopped watching built-in Django translation files by auto-reloader.
2020-05-04 09:13:47 +02:00
Nick Pope
8f10ceaa90
Changed `'%s' % value` pattern to `str(value)`.
2020-05-04 08:27:18 +02:00
François Freitag
a0df5dea33
Removed unnecessary inner methods in CreatesuperuserManagementCommandTestCase.
2020-05-01 20:51:44 +02:00
Ian Foote
b4068bc656
Fixed #31455 -- Added support for deferrable exclusion constraints on PostgreSQL.
2020-05-01 09:08:36 +02:00
Ian Foote
c226c6cb32
Fixed #20581 -- Added support for deferrable unique constraints.
2020-04-30 10:43:50 +02:00
Mariusz Felisiak
555e3a848e
Removed unused __str__() methods in tests models.
...
Follow up to 6461583b6c
.
2020-04-30 09:13:23 +02:00
Hasan Ramezani
f121621073
Fixed #31521 -- Skipped test_parsing_rfc850 test on 32-bit systems.
2020-04-30 06:51:47 +02:00
Mariusz Felisiak
54646a423b
Refs #27468 -- Made user sessions use SHA-256 algorithm.
2020-04-29 16:45:00 +02:00
Jon Dufresne
0dafadadb9
Refs #30400 -- Improved typography of user facing strings in admin changelist.
2020-04-29 07:01:46 +02:00
Jon Dufresne
bdff97d373
Added tests for saving with pending actions in admin changelist.
2020-04-29 07:01:41 +02:00
Hasan Ramezani
68fc21b378
Fixed #29249 -- Made JSON and YAML serializers use Unicode by default.
2020-04-28 11:11:39 +02:00
Hasan Ramezani
8970bb4cfd
Refs #29249 -- Added tests for serializing Unicode data with XML serializer.
2020-04-28 11:11:39 +02:00
François Freitag
9ef4a18dbe
Changed django.forms.ValidationError imports to django.core.exceptions.ValidationError.
...
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2020-04-28 10:49:00 +02:00
Richard Campen
67b334fbaf
Fixed #31517 -- Fixed HashedFilesMixin.hashed_name() if hash of the file is None.
2020-04-28 08:25:07 +02:00
François Freitag
f19bb54fb1
Added test for squashmigrations' output.
2020-04-28 06:32:43 +02:00
François Freitag
abea86f9e4
Removed unnecessary tuple wrapping of single format string argument.
2020-04-27 08:30:16 +02:00
François Freitag
687cb38a05
Removed unnecessary capturing/hiding of stdout/stderr in various tests.
2020-04-27 08:06:12 +02:00
François Freitag
a8d175c297
Disabled management commands output with verbosity 0 in test_regression_22823_unmigrated_fk_to_migrated_model.
2020-04-27 07:43:09 +02:00
François Freitag
da606513db
Removed unnecessary capturing of stdout in test_makemigrations_non_interactive_not_null_addition.
2020-04-25 20:53:53 +02:00
Tim Schilling
a92cc84b4a
Refs #31369 -- Deprecated models.NullBooleanField in favor of BooleanField(null=True).
2020-04-24 10:10:45 +02:00
David Wobrock
533b208775
Fixed #29224 -- Fixed removing index_together indexes if exists unique_together constraint on the same fields.
2020-04-23 12:28:51 +02:00
Hannes Ljungberg
447980e72a
Fixed #31500 -- Fixed detecting of unique fields in QuerySet.in_bulk() when using Meta.constraints.
...
Detection of unique fields now takes into account non-partial unique
constraints.
2020-04-23 08:07:08 +02:00
Jon Dufresne
d15d824deb
Refs #29892 -- Fixed selenium test test_inline_formset_error_input_border on Firefox.
...
Firefox does not include shorthand properties, such as "border", in the
computed CSS properties object. This is documented at MDN:
https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle
> The returned CSSStyleDeclaration object contains active values for CSS
> property longhand names. For example, border-bottom-width instead of
> the border-width and border shorthand property names. It is safest to
> query values with only longhand names like font-size. Shorthand names
> like font will not work with most browsers.
This difference between Firefox and Chrome is also discussed in the
stackoverflow thread at:
https://stackoverflow.com/a/32296604
2020-04-22 12:32:35 +02:00
David Smith
9a015f4e0d
Completed test coverage for forms.RegexField.
2020-04-22 10:50:35 +02:00
Simon Charette
06889d6206
Fixed #31499 -- Stored ModelState.fields into a dict.
...
This allows the removal of its O(n) .get_field_by_name method and many
other awkward access patterns.
While fields were initially stored in a list to preserve the initial
model definiton field ordering the auto-detector doesn't take field
ordering into account and no operations exists to reorder fields of a
model.
This makes the preservation of the field ordering completely superflous
because field reorganization after the creation of the model state
wouldn't be taken into account.
2020-04-22 07:10:00 +02:00
Simon Charette
696024fb73
Refs #31499 -- Ignored field ordering to determine ModelState equality.
2020-04-22 06:20:54 +02:00
Mariusz Felisiak
d5898db50e
Fixed backends.oracle.test_operations.
...
Using unittest.TestCase doesn't work properly when we perform db
queries. Moreover introspection is extremely slow on Oracle without
limiting models to a "backends" app.
Follow up to 8bcca47e83
.
2020-04-21 15:46:18 +02:00
Jon Dufresne
75866b93cc
Fixed #31479 -- Added support to reset sequences on SQLite.
2020-04-21 10:41:47 +02:00
Simon Charette
5220ca8d8a
Refs #30591 -- Adjusted table rebuild for non-pk relationship on SQLite.
...
The existing code was only accounting for primary key changes and not
all unique key fields that can be referenced.
2020-04-21 08:37:47 +02:00
Simon Charette
a548280857
Fixed #31064 -- Recreated auto-created many-to-many tables on primary key data type change on SQLite.
...
Both local and remote auto-created many-to-many relationships were
affected.
2020-04-21 08:37:40 +02:00
Simon Charette
2ba55b2905
Removed redundant import in tests/migrations/test_operations.py.
2020-04-21 08:37:37 +02:00
Jon Dufresne
505fec6bad
Capitalized Unicode in docs, strings, and comments.
2020-04-20 12:10:33 +02:00
Jon Dufresne
3152146e3a
Added assertions for an empty stdout to CoreCommandsNoOutputTests.
2020-04-20 11:32:03 +02:00
Hasan Ramezani
35a67b3731
Fixed #31474 -- Made QuerySet.delete() not return the number of deleted objects if it's zero.
2020-04-20 09:51:54 +02:00
François Freitag
c86201b6ed
Disabled management commands output with verbosity 0 in various tests.
...
Instead of capturing the command output and discard it immediately,
tell the command not to log.
2020-04-20 09:09:26 +02:00
François Freitag
45e96b4d9d
Removed unnecessary capturing of stdout/stderr in auth_tests.test_management.
2020-04-20 09:08:43 +02:00
Jon Dufresne
5673d4b102
Fixed #31477 -- Removed "using" argument from DatabaseOperations.execute_sql_flush().
2020-04-20 07:49:35 +02:00
Tom Forbes
141ab6bc6d
Refs #29069 -- Added test for calling request_finished signal by static file responses.
...
Fixed in 41a3b3d186
.
2020-04-20 06:17:57 +02:00
Jon Dufresne
537d422942
Simplified LongNameTest.test_sequence_name_length_limits_flush() with execute_sql_flush().
2020-04-18 20:48:30 +02:00
hashlash
dfbd9ca065
Fixed #30311 -- Restored ability to override global admin actions.
2020-04-17 20:23:00 +02:00
Jon Dufresne
75410228df
Fixed #31473 -- Made sql_flush() use RESTART IDENTITY to reset sequences on PostgreSQL.
...
The sql_flush() positional argument sequences is replaced by the boolean
keyword-only argument reset_sequences. This ensures that the old
function signature can't be used by mistake when upgrading Django. When
the new argument is True, the sequences of the truncated tables will
reset. Using a single boolean value, rather than a list, allows making a
binary yes/no choice as to whether to reset all sequences rather than a
working on a completely different set.
2020-04-17 11:57:24 +02:00
Jon Dufresne
8bcca47e83
Added test coverage for DatabaseOperations.sql_flush().
2020-04-17 09:52:43 +02:00
Mariusz Felisiak
4c9886085b
Refs #31351 -- Made partial constraints tests use required_db_features.
...
This will notably silence the warnings issued when running the test
suite on MySQL and MariaDB.
2020-04-17 07:45:52 +02:00
Hasan Ramezani
7b31ba541f
Fixed #29329 -- Made datetime logging from runserver more consistent.
...
Setting default_msec_format=None will make it the same, unfortunately
it's not supported by Python, see https://bugs.python.org/issue40300 .
2020-04-16 12:55:53 +02:00
Hasan Ramezani
96c6f9c61c
Fixed #31441 -- Ensured TabluarInline expands when child inputs have errors.
2020-04-16 12:17:49 +02:00
Hasan Ramezani
b4e7bf5284
Refs #31441 -- Added red border to inputs with errors for TabluarInline.
2020-04-16 12:17:49 +02:00
Author: Mads Jensen
6461583b6c
Removed unused __str__() methods in tests models.
...
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Co-Authored-By: Hasan Ramezani <hasan.r67@gmail.com>
2020-04-15 20:20:32 +02:00
Claude Paroz
71c4fb7beb
Refs #27468 -- Changed default Signer algorithm to SHA-256.
2020-04-15 12:49:14 +02:00
Adam Johnson
4bb33bb074
Fixed #31459 -- Fixed handling invalid indentifiers in URL path conversion.
...
This patch adjusted existing tests that used invalid identifiers.
2020-04-15 11:29:35 +02:00
sobolevn
578c03b276
Fixed #31223 -- Added __class_getitem__() to Manager and QuerySet.
2020-04-15 11:26:11 +02:00
Ichlasul Affan
3e7c39f710
Fixed #31451 -- Made settings cleansing work with list and tuple settings.
2020-04-15 09:18:40 +02:00
007
d51c50d836
Fixed #31462 -- Allowed overriding autocomplete/raw_id_fields/filter widgets for ManyToManyFields with formfield_overrides.
2020-04-15 08:33:40 +02:00
Adam Johnson
5b884d45ac
Fixed #29501 -- Allowed dbshell to pass options to underlying tool.
2020-04-14 14:02:51 +01:00
Adam Johnson
8e8c3f964e
Refs #29501 -- Allowed customizing exit status for management commands.
2020-04-14 13:22:47 +02:00
Mariusz Felisiak
8189976663
Refs #29501 -- Added test for missing dbshell executable.
2020-04-14 13:22:46 +02:00
Claude Paroz
a6b4c07b6e
Refs #31196 -- Installed postgis_raster extension on PostGIS 3+.
2020-04-14 09:34:01 +02:00
Ichlasul Affan
53d229ff63
Fixed #31351 -- Added system checks for partial indexes and unique constraints support.
2020-04-10 12:00:27 +02:00
Mariusz Felisiak
e8d3088925
Refs #31055 -- Allowed database queries in invalid_models_tests.test_models.FieldNamesTests.
2020-04-10 11:54:14 +02:00
David Smith
c8c9dbfc63
Completed test coverage for BoundField.css_classes().
2020-04-10 07:37:54 +02:00
David Smith
a350bfa6f4
Fixed #13009 -- Added BoundField.widget_type property.
2020-04-10 07:11:14 +02:00
Carlton Gibson
ed274a4ae4
Fixed #31407 -- Fixed unawaited coroutine warning for Python 3.8+.
...
Co-authored-by: Mark Korput <dr.theman@gmail.com>
2020-04-09 12:35:19 +02:00
Daniel Hahler
377018b6ff
Fixed #30779 -- Improved selection of filenames in technical 500 debug page.
2020-04-09 11:28:26 +02:00
Simon Charette
8069526ce3
Made Operation.references_model/references_field require app_label.
...
This will allow them to drop a ton of logic to deal with null
app_label.
2020-04-09 10:08:06 +02:00
Simon Charette
25bf15c0da
Refs #22608 -- Made app_label required when optimizing migrations.
...
This paved the way for the removal of lot of logic when app_label was
not specified.
2020-04-09 10:08:02 +02:00
David Smith
911545da1d
Increased test coverage for forms.ImageField.to_python().
2020-04-09 08:45:31 +02:00
Carlton Gibson
4bbe8261c4
Fixed #31437 -- Corrected tests to show abstract multiple inheritance system check error.
...
Added minimal multiple inheritance test case showing error.
Removed obsolete diamond-inheritance case, originally added in
85ef98dc6e
.
2020-04-08 20:29:48 +02:00
Mariusz Felisiak
537b0c5edf
Fixed typo in tests/backends/base/test_operations.py.
2020-04-08 20:06:31 +02:00
Carlton Gibson
94b32a20ef
Refs #28184 -- Added test for FileField storage default.
...
Co-authored-by: miigotu <miigotu@gmail.com>
2020-04-08 11:26:17 +02:00
miigotu
210657b791
Fixed #28184 -- Allowed using a callable for FileField and ImageField storage.
2020-04-08 11:26:17 +02:00
Mariusz Felisiak
db6933a032
Refs #30966 -- Added test for reloading related model state on non-relational changes.
...
Thanks Markus Holtermann for initial test.
Fixed in 1d16c5d562
.
2020-04-08 10:43:38 +02:00
Matthijs Kooijman
4f216e4f8e
Fixed #31051 -- Allowed dumpdata to handle circular references in natural keys.
...
Since #26291 forward references in natural keys are properly handled by
loaddata, so sorting depenencies in dumpdata doesn't need to break on
cycles. This patch allows circular references in natural keys by
breaking sort_depenencies() on loops.
2020-04-07 20:41:59 +02:00
Mark
590957a0eb
Fixed #31407 -- Adjusted test to avoid coroutine never awaited warning.
2020-04-07 20:32:54 +02:00
Matthijs Kooijman
26799c6503
Refs #26291 -- Added tests for dumpdata/loaddata with forward references without natural keys.
2020-04-07 15:40:19 +02:00
Matthijs Kooijman
fca36f3c98
Refs #26291 -- Added tests for dumpdata with forward references in natural keys.
2020-04-07 15:40:14 +02:00
Matthijs Kooijman
481d8fc324
Refs #31051 -- Added test for loaddata/dumpdata with circular references without natural keys.
2020-04-07 12:01:19 +02:00
Mariusz Felisiak
cf21fc9bf0
Enforced uniqueness of natural keys used in tests.
2020-04-07 10:54:19 +02:00
Simon Charette
1d16c5d562
Refs #27666 -- Ensured relationship consistency on delayed reloads.
...
Delayed reloads of state models broke identity based relationships
between direct and non-direct ancestors.
Basing models.Options related objects map of model labels instead of
their identity ensured relationship consistency is maintained.
Refs #30966 .
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
2020-04-07 09:20:46 +02:00
François Freitag
e03eb8db93
Fixed #31428 -- Allowed empty message in management command self.stdout/err proxies.
2020-04-07 08:45:11 +02:00
David Smith
5fbc0e07a9
Completed test coverage for forms.DurationField.to_python().
2020-04-07 06:20:43 +02:00
David Smith
be9dd70931
Fixed typo in tests/forms_tests/field_tests/test_imagefield.py test names.
2020-04-07 06:04:51 +02:00
Simon Charette
513948735b
Fixed #31426 -- Added proper field validation to QuerySet.order_by().
...
Resolve the field reference instead of using fragile regex based string
reference validation.
2020-04-06 10:19:49 +02:00
Simon Charette
98ea4f0f46
Refs #7098 -- Deprecated passing raw column aliases to order_by().
...
Now that order_by() has expression support passing RawSQL() can achieve
the same result.
This was also already supported through QuerySet.extra(order_by) for
years but this API is more or less deprecated at this point.
2020-04-06 10:01:02 +02:00
Hasan Ramezani
4237050684
Fixed #31420 -- Fixed crash when filtering subquery annotation against a SimpleLazyObject.
...
Thanks Simon Charette for the solution and analysis.
2020-04-06 07:11:29 +02:00
Hasan Ramezani
6fbce45b03
Fixed #31415 -- Fixed crash when nested OuterRef is used with operators or in database functions.
2020-04-04 20:16:00 +02:00
Matthijs Kooijman
289d0ec6fd
Refs #31051 -- Fixed reloading the database with circular related objects and natural keys for tests.
...
Made deserialize_db_from_string() do not sort dependencies.
deserialize_db_from_string() doesn't use natural keys, so there is no
need to sort dependencies in serialize_db_to_string(). Moreover,
sorting models cause issues for circular dependencies.
2020-04-02 11:35:33 +02:00
Matthijs Kooijman
12e6f573ad
Refs #26552 -- Added test for reloading the database with self-referential objects.
2020-04-02 09:17:41 +02:00
hashlash
4a6f2b63d7
Fixed #31380 -- Added deployment system check for DJANGO_ALLOW_ASYNC_UNSAFE environment variable.
2020-04-01 12:51:11 +02:00
Mariusz Felisiak
195e0cb170
Refs #31040 -- Used 402 HTTP status in middleware_exceptions tests.
...
HTTP status code 418 - "I'm a Teaport" was added to http.HTTPStatus in
Python 3.9.0a5 [1] that caused failures in middleware_exceptions tests.
This changes HTTP status used in middleware_exceptions tests to 402,
which exists in all supported versions of Python.
[1] https://docs.python.org/3.9/whatsnew/3.9.html#http
2020-03-31 12:09:17 +02:00
Hasan Ramezani
8aa71f4e87
Fixed #31375 -- Made contrib.auth.hashers.make_password() accept only bytes or strings.
2020-03-31 10:52:56 +02:00
Hasan Ramezani
b3ab92cc5a
Refs #31375 -- Added test for contrib.auth.hashers.make_password() bytes support.
2020-03-31 10:49:39 +02:00
Gordon Pendleton
d0da2820ca
Fixed #31402 -- Added migrate --check option.
...
Command exits with non-zero status if unapplied migrations exist.
2020-03-26 20:12:39 +01:00
Hasan Ramezani
55cdf6c52d
Fixed #29724 -- Fixed timezone handling in ModelAdmin.date_hierarchy queries.
...
Thanks Alexander Holmbäck for the initial patch.
2020-03-25 21:03:41 +01:00
Alexander Holmbäck
e43c34d10d
Added tests for date_hierarchy template tag with models.DateTimeField.
2020-03-25 21:03:23 +01:00
Mariusz Felisiak
ab5720ad80
Removed unnecessary assertions in ExpressionOperatorTests.
...
These tests don't modify Number.float field.
2020-03-25 13:12:32 +01:00
Adam Johnson
9e1b6b8a66
Fixed #23916 -- Allowed makemigrations to handle related model name case changes.
...
Made autodetector ignore related model name case changes so unnecessary
migrations are not created.
2020-03-25 10:39:34 +01:00
Hannes Ljungberg
f3da09df0f
Fixed #31396 -- Added binary XOR operator to F expressions.
2020-03-25 10:16:30 +01:00
Carlton Gibson
39e1c88de6
Fixed intermittent SeleniumTests.test_prepopulated_fields failure.
...
Element would occasionally be outside of frame.
2020-03-25 09:58:57 +01:00
Hasan Ramezani
10866a10fe
Fixed #31377 -- Disabled grouping by aliases on QuerySet.values()/values_list() when they collide with field names.
...
Regression in fb3f034f1c
.
Thanks Holovashchenko Vadym for the report.
2020-03-25 09:13:46 +01:00
Mariusz Felisiak
895f28f9cb
Reverted "Pinned asgiref == 3.2.5 in test requirements."
...
This reverts commit aa21020218
.
Regression was fixed by
e4367c571f
.
2020-03-24 20:52:05 +01:00
David Smith
27746ab28a
Fixed #7664 -- Allowed customizing suffixes of MultiWidget.widgets' names.
2020-03-24 20:05:18 +01:00
Mariusz Felisiak
aa21020218
Pinned asgiref == 3.2.5 in test requirements.
2020-03-24 08:52:21 +01:00
Hannes Ljungberg
0b51a4f894
Fixed #28194 -- Added support for normalization and cover density to SearchRank.
2020-03-23 11:00:55 +01:00
Adam Johnson
4ed534758c
Fixed #19878 -- Deprecated TemplateView passing URL kwargs into context.
2020-03-23 08:11:14 +01:00
Tim Graham
e21788121b
Added missing Meta.apps to a schema model.
2020-03-23 06:09:10 +01:00
Adam Johnson
ffde4d5da8
Normalized check framework test pattern.
2020-03-21 20:14:02 +01:00
Hasan Ramezani
53b6a466d8
Refs #29724 -- Added is_dst parameter to QuerySet.datetimes().
...
Thanks Simon Charette for the review and Mariusz Felisiak for tests.
2020-03-20 12:55:33 +01:00
Rohit
2695ac8e04
Fixed #31144 -- Relaxed system check for max_length of CharFields on MySQL/MariaDB by turning into a warning.
2020-03-20 12:28:10 +01:00
Jon Dufresne
c1c361677d
Made BaseCacheTests skip culling tests if culling is not supported.
2020-03-19 15:34:16 +01:00
Jon Dufresne
013147fae2
Fixed #31285 -- Fixed inherited Meta.ordering of "-pk".
2020-03-19 12:57:07 +01:00
gowthamk63
142ab6846a
Fixed #31123 -- Added --include-stale-apps option to the remove_stale_contenttypes management command.
...
Co-Authored-By: Javier Buzzi <buzzi.javier@gmail.com>
2020-03-19 11:48:10 +01:00
Mariusz Felisiak
6e026aec5f
Refs #29548 -- Mentioned MariaDB in database system checks.
2020-03-19 09:42:04 +01:00
Andrew Godwin
fc0fa72ff4
Fixed #31224 -- Added support for asynchronous views and middleware.
...
This implements support for asynchronous views, asynchronous tests,
asynchronous middleware, and an asynchronous test client.
2020-03-18 19:59:12 +01:00
Mariusz Felisiak
3f7e4b16bf
Removed redundant get_max_column_name_length() calls in invalid_models_tests.test_models.FieldNamesTests.
2020-03-18 18:41:40 +01:00
Mariusz Felisiak
5c8441a0b8
Refs #31055 -- Made long column names checks support databases aware.
2020-03-18 18:41:40 +01:00
Baptiste Mispelon
3baf92cf82
Fixed #31340 -- Allowed query expressions in SearchQuery.value and __search lookup.
2020-03-16 10:27:23 +01:00
jay20162016
924c01ba09
Fixed #31363 -- Added support for negative integers to intword template filter.
2020-03-16 08:44:43 +01:00
Jon Dufresne
3857a08bdb
Fixed #31361 -- Fixed invalid action="" in admin forms.
...
The attribute action="" (empty string) on the <form> element is invalid
HTML5. The spec (https://html.spec.whatwg.org/#attr-fs-action ) says:
> The action and formaction content attributes, if specified, must have
> a value that is a valid non-empty URL potentially surrounded by
> spaces.
Emphasis on non-empty. The action attribute is allowed to be omitted, in
which case the current URL is used which is the same behavior as now.
2020-03-16 07:31:19 +01:00
Jon Dufresne
b7093860df
Added novalidate HTML attribute to ModelAdmin.add_view() and change_view() tests.
2020-03-16 06:36:45 +01:00
Mariusz Felisiak
e2417010da
Refs #31304 -- Added tests for using __search lookup with combined SearchQuerys with the same config.
2020-03-13 12:06:28 +01:00
Baptiste Mispelon
dd704c6705
Refs #31340 -- Simplified SearchQuery by making it subclass Func.
2020-03-13 11:38:43 +01:00
Mariusz Felisiak
8725d04764
Fixed random auth_tests.test_tokens.TokenGeneratorTest.test_timeout failures.
...
Random failures depended on the current timestamp.
Thanks Matthijs Kooijman for the review.
2020-03-12 10:56:38 +01:00
David Smith
ccf32aca44
Fixed #8760 -- Changed ModelMultipleChoiceField to use invalid_list as a error message key.
2020-03-12 09:36:01 +01:00
Mariusz Felisiak
7d8cdad6b7
Fixed MiddlewareNotUsedTests.test_do_not_log_when_debug_is_false().
...
This test didn't test anything without a middleware that raises an
exception.
2020-03-12 07:37:14 +01:00
Mariusz Felisiak
35c7fe8334
Completed test coverage for BaseHandler.process_exception_by_middleware().
2020-03-12 07:37:14 +01:00
Claude Paroz
e663f695fb
Fixed #31359 -- Deprecated get_random_string() calls without an explicit length.
2020-03-11 13:16:44 +01:00
David Smith
5cc2c63f90
Fixed typo in tests/forms_tests/widget_tests/test_clearablefileinput.py docstring.
2020-03-11 08:50:51 +01:00
Claude Paroz
e3e48b0012
Fixed #30439 -- Added support for different plural forms for a language.
...
Thanks to Michal Čihař for review.
2020-03-10 15:56:32 +01:00
Hasan Ramezani
591e2270dc
Fixed #26513 -- Added tests for <Backend>GeometryColumns.geom_col_name().
2020-03-10 12:22:35 +01:00
Mariusz Felisiak
c48a7d3a8a
Fixed typos in tolerance gis_tests.
2020-03-10 07:55:31 +01:00
Jon Dufresne
eb77e80de0
Fixed #31349 -- Used :nth-child() CSS pseudo-class to style alternative rows in admin.
2020-03-09 12:34:32 +01:00
Hasan Ramezani
ec292f261d
Fixed #31347 -- Checked allow_migrate() in CreateExtension operation.
2020-03-09 12:13:18 +01:00
David Wobrock
d88365708c
Fixed #31318 -- Allowed sqlmigrate to inspect squashed migrations.
2020-03-09 08:42:30 +01:00
David Wobrock
b88ad1d356
Refs #31318 -- Added tests for inspecting squashed migrations and ambiguous names in sqlmigrate.
2020-03-09 08:21:34 +01:00
Mariusz Felisiak
9358da704e
Refs #30489 -- Fixed RasterFieldTest.test_deserialize_with_pixeltype_flags() when run without numpy.
2020-03-07 22:46:13 +01:00
Mariusz Felisiak
a3917c323f
Replaced deprecated assertEquals() with assertEqual() in RasterFieldTest.
2020-03-07 22:46:13 +01:00
Simon Charette
7c8b043a03
Refs #31304 -- Made __search lookup default to its rhs' config.
...
This make the SearchLookup lookup more coherent with its
SearchVectorExact base which configures its rhs SearchQuery with its
lhs' config.
2020-03-06 10:23:39 +01:00
shankarj67
df4d622cac
Fixed #31345 -- Added BaseDatabaseIntrospection.get_relations().
2020-03-06 08:53:32 +01:00
Andrew Godwin
17009e9105
Refs #31224 -- Added autoconversion of test async methods.
2020-03-05 14:29:21 +01:00
Abhijeet Viswa
babd412685
Fixed #29129 -- Skipped UPDATE when adding a model instance with inherited primary key that has a default.
2020-03-05 12:08:38 +01:00
Hasan Ramezani
7e15795bf0
Fixed #30489 -- Fixed RasterField deserialization with pixeltype flags.
...
Thanks Ivor Bosloper for the original patch.
2020-03-05 09:44:44 +01:00
Jon Dufresne
769cee5252
Fixed #31327 -- Deprecated providing_args argument for Signal.
2020-03-05 09:38:52 +01:00
Mariusz Felisiak
5ca76baa72
Fixed GeoQuerySetTest.test_unionagg_tolerance() test on Oracle 18c.
2020-03-05 08:55:34 +01:00
aryan
427a7e419b
Fixed #31333 -- Added BaseDatabaseIntrospection.get_table_description().
2020-03-04 12:26:31 +01:00
Mariusz Felisiak
6dea42feba
Added tests for BaseDatabaseIntrospection's stub methods.
2020-03-04 12:25:17 +01:00
Mariusz Felisiak
6695d29b1c
Fixed CVE-2020-9402 -- Properly escaped tolerance parameter in GIS functions and aggregates on Oracle.
...
Thanks to Norbert Szetei for the report.
2020-03-04 09:04:50 +01:00
Hannes Ljungberg
65ab4f9f03
Fixed #31147 -- Added SearchHeadline to django.contrib.postgres.
2020-03-03 15:39:52 +01:00
Mariusz Felisiak
aee0bebc2f
Refs #31331 -- Checked ONLY_FULL_GROUP_BY mode in AggregateTestCase.test_aggregation_subquery_annotation_multivalued().
2020-03-03 11:25:37 +01:00
Mariusz Felisiak
a19505eb2e
Refs #31331 -- Added DatabaseWrapper.sql_mode to MySQL.
2020-03-03 11:25:37 +01:00
Mariusz Felisiak
7b8fa1653f
Fixed #31150 -- Included subqueries that reference related fields in GROUP BY clauses.
...
Thanks Johannes Hoppe for the report.
Regression in fb3f034f1c
.
Co-authored-by: Simon Charette <charette.s@gmail.com>
2020-03-03 11:25:37 +01:00
Claude Paroz
d4fff711d4
Fixed #31274 -- Used signing infrastructure in SessionBase.encode()/decode().
...
Thanks Mariusz Felisiak and Florian Apolloner for the reviews.
2020-03-02 12:16:48 +01:00
007
e65fea9292
Fixed #31293 -- Allowed MultiPartParser to handle double-quoted encoded headers.
2020-02-28 14:43:16 +01:00
Hans Aarne Liblik
a21f7b91db
Fixed #31301 -- Fixed crash of QuerySet.bulk_create() with mixed empty and set ForeignKeys to AutoFields on Oracle.
2020-02-28 12:56:03 +01:00
Cristobal Mackenzie
984531f96e
Fixed #31314 -- Raised CommandError when locale is not specified in makemessages.
...
Regression in 0707b824fe
.
2020-02-28 10:11:19 +01:00
Matheus Cunha Motta
e908eb6287
Fixed #31310 -- Fixed hints in checks for using intermediate model with ambiguous foreign key.
...
symmetrical=False is not required since
87b1ad6e73
.
2020-02-28 08:38:57 +01:00
Matheus Cunha Motta
308fab9241
Refs #31310 -- Added test for check for using intermediate model with ambiguous foreign key from model.
2020-02-28 08:26:41 +01:00
Rohit
486786c4c4
Fixed #31251 -- Disabled grouping by OuterRef() annotation.
2020-02-27 13:02:49 +01:00
Valze
5bf28ac2ed
Fixed #31185 -- Fixed detecting of unique fields in ForeignKey/ForeignObject checks when using Meta.constraints.
2020-02-27 10:53:29 +01:00
Simon Charette
41ebe60728
Fixed #31312 -- Properly ordered temporal subtraction params on MySQL.
...
Regression in 9bcbcd599a
.
Thanks rick2ricks for the report.
2020-02-27 08:50:55 +01:00
Colton Hicks
f283ffaa84
Fixed #28699 -- Fixed CSRF validation with remote user middleware.
...
Ensured process_view() always accesses the CSRF token from the session
or cookie, rather than the request, as rotate_token() may have been called
by an authentication middleware during the process_request() phase.
2020-02-26 17:25:20 +01:00
Hasan Ramezani
bc1c034076
Fixed #28280 -- Prevented numberformat.format() from formatting large/tiny floats in scientific notation.
2020-02-26 16:02:53 +01:00
aryan
fba5d3b6e6
Fixed #31289 -- Added hint for USERNAME_FIELD/REQUIRED_FIELDS system check.
2020-02-26 08:40:36 +01:00
Simon Charette
d0f1c03331
Refs #31211 -- Prevented SearchConfig nesting in SearchVector and SearchQuery init.
...
Passing a SearchConfig instance directly to SearchVector and
SearchQuery would result in nested SearchConfig instance.
2020-02-26 08:03:46 +01:00
Ram Rachum
5b09354954
Fixed #31291 -- Renamed salt to mask for CSRF tokens.
2020-02-25 14:16:19 +01:00
Taoup
271fdab8b7
Fixed #31286 -- Made database specific fields checks databases aware.
...
Follow up to 0b83c8cc4d
.
2020-02-24 14:23:46 +01:00
Mariusz Felisiak
94d4bd3a09
Fixed backends tests on Oracle.
...
Using Person in test_introspection caused removing constraints in
intermediate table for ManyToManyField in
VeryLongModelNameZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ that were
expected by other transaction tests. A model without any constraints
was used to prevent isolation issues.
2020-02-24 14:21:50 +01:00
Diederik van der Boor
84e35f4679
Fixed #31292 -- Fixed django.contrib.gis.gdal.gdal_full_version() crash.
2020-02-24 13:28:51 +01:00
Diederik van der Boor
975eb42036
Added test for django.contrib.gis.gdal.gdal_version().
2020-02-24 13:15:35 +01:00
Jon Dufresne
f02c1fcf4c
Corrected typo in test docstring.
2020-02-20 09:12:09 +01:00
Jon Dufresne
94d1d4a71b
Captured logging in DebugViewTests with assertLogs().
2020-02-20 09:07:15 +01:00
Mariusz Felisiak
4261907ff3
Fixed tests when run in reverse.
...
Regression in 98f23a8af0
.
2020-02-19 14:48:26 +01:00
Fabio Sangiovanni
b457068cf2
Fixed #31187 -- Fixed detecting of existing total ordering in admin changelist when using Meta.constraints.
...
Detection of existing total ordering in admin changelist now takes into
account non-partial unique constraints.
2020-02-19 09:36:23 +01:00
Fabio Sangiovanni
73a34f3fa8
Removed duplicate tests in ChangeListTests.test_total_ordering_optimization().
2020-02-19 07:43:50 +01:00
Yoo In Keun
4ef107e34f
Fixed typos in docs and a test comment.
2020-02-19 07:08:23 +01:00
Claude Paroz
4d973f5939
Refs #26601 -- Deprecated passing None as get_response arg to middleware classes.
...
This is the new contract since middleware refactoring in Django 1.10.
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2020-02-18 20:03:44 +01:00
Carlton Gibson
a34cb5a6d4
Refs #31282 -- Clarified M2O add/remove/set with PK behaviour.
...
Improved error message for remove() and added tests.
2020-02-18 19:54:29 +01:00
Mariusz Felisiak
2a038521c4
Fixed #31271 -- Preserved ordering when unifying query parameters on Oracle.
...
This caused misplacing parameters in logged SQL queries.
Regression in 79065b55a7
.
Thanks Hans Aarne Liblik for the report.
2020-02-18 11:45:12 +01:00
Taoup
cbb6531e5b
Fixed #31228 -- Reallowed aggregates to be used with multiple expressions and no DISTINCT on SQLite.
...
Regression in bc05547cd8
.
Thanks Andy Terra for the report.
2020-02-18 10:32:23 +01:00
Keshav Kumar
f37d548ede
Fixed #20995 -- Added support for iterables of template names to {% include %} template tag.
...
Thanks Adam Johnson for the review.
2020-02-18 06:56:05 +01:00
Xavier Francisco
8690878507
Fixed #31277 -- Relaxed system check of m2m intermediary tables for db_table collision when database routers are installed.
...
Turned the error into a warning when database routers are installed.
2020-02-17 13:53:45 +01:00
Matthijs Kooijman
98f23a8af0
Fixed #26552 -- Deferred constraint checks when reloading the database with data for tests.
...
deserialize_db_from_string() loads the full serialized database
contents, which might contain forward references and cycles. That
caused IntegrityError because constraints were checked immediately.
Now, it loads data in a transaction with constraint checks deferred
until the end of the transaction.
2020-02-14 13:18:06 +01:00
Mariusz Felisiak
b330b918e9
Removed unused and incorrect PossessedCar.__str__() method in test_utils.
...
PossessedCar doesn't have a color.
2020-02-14 13:16:17 +01:00
Claude Paroz
cd2d508707
Removed redundant MiddlewareTest.test_old_style_request() test.
...
CurrentSiteMiddleware.process_request() is already covered by
MiddlewareTest.test_request().
2020-02-14 10:35:58 +01:00
Claude Paroz
6fba85b766
Removed unused cache.tests.CacheUtils._set_cache().
...
Unused since its introduction in 71a03e01aa
.
2020-02-13 13:53:12 +01:00
yura
54b7af7eb4
Fixed #31250 -- Ignored processing instructions in assertXMLEqual()/assertXMLNotEqual().
2020-02-13 11:03:54 +01:00
Dennis Schwertel
4070d6ceb0
Fixed #31267 -- Added tests cases with empty username or password for URLValidator.
...
Follow up to cdcf4164be
.
2020-02-13 08:32:20 +01:00
Hasan Ramezani
49275c5488
Fixed #30261 -- Prevented Form._html_output() from mutating errors if hidden fields have errors.
2020-02-13 08:12:44 +01:00
Claude Paroz
da4923ea87
Refs #27468 -- Made PasswordResetTokenGenerator use SHA-256 algorithm.
2020-02-12 21:46:56 +01:00
Claude Paroz
27f67317da
Removed unnecessary token regex in auth_tests URLs.
...
All URLs in django.contrib.auth use a "<uidb64>/<token>" pattern.
2020-02-12 10:45:53 +01:00
Abhijeet Viswa
1712a76b9d
Fixed #31246 -- Fixed locking models in QuerySet.select_for_update(of=()) for related fields and parent link fields with multi-table inheritance.
...
Partly regression in 0107e3d105
.
2020-02-11 20:43:57 +01:00
Florian Apolloner
41a3b3d186
Fixed #31240 -- Properly closed FileResponse when wsgi.file_wrapper is used.
...
Thanks to Oskar Persson for the report.
2020-02-11 20:39:12 +01:00
Florian Apolloner
549445519c
Reverted "Fixed #30565 -- Closed HttpResponse when wsgi.file_wrapper closes file-like object."
...
This reverts commit cce47ff65a
.
2020-02-11 20:39:12 +01:00
Jon Dufresne
e3f6e18513
Fixed #31253 -- Fixed data loss possibility when using caching from async code.
...
Case missed in a415ce70be
.
2020-02-11 09:09:25 +01:00
=Pratik Kumar
20ba3ce4ac
Fixed #30846 -- Made PostGIS backend respect Index's name argument.
2020-02-10 13:25:32 +01:00
Hannes Ljungberg
adcf1a7308
Fixed #31248 -- Added missing space before USING SQL on PostGIS.
2020-02-10 11:20:45 +01:00
Adam Johnson
382af9b141
Fixed #31003 -- Doc'd and tested return value of QuerySet.bulk_create().
2020-02-10 08:36:50 +01:00
Mariusz Felisiak
708c534e0b
Refs #31055 -- Fixed Model.check() call in ConstraintsTests.test_check_constraints_required_db_features().
2020-02-08 17:23:35 +01:00
Hasan Ramezani
fc4f45ebdc
Used assertRaisesMessage() in various tests.
2020-02-07 12:46:23 +01:00
Simon Charette
71756bdfed
Fixed #31055 -- Made constraint checks support databases aware.
2020-02-07 11:03:53 +01:00
Simon Charette
0b83c8cc4d
Refs #31055 -- Added --database option to the check management command.
...
This avoids enabling the ``database`` checks unless they are explicitly
requested and allows to disable on a per-alias basis which is required
when only creating a subset of the test databases.
This also removes unnecessary BaseCommand._run_checks() hook.
2020-02-07 11:01:31 +01:00
Jon Dufresne
3259983f56
Fixed #31233 -- Closed database connections and cursors after use.
2020-02-06 15:35:23 +01:00
Jon Dufresne
f48f671223
Refs #31233 -- Changed DatabaseWrapper._nodb_connection to _nodb_cursor().
...
It is now a method instead of a property and returns a context manager
that yields a cursor on entry and closes the cursor and connection upon
exit.
2020-02-06 15:29:38 +01:00
Nikita Sobolev
2d55cb5c4a
Fixed typo in tests/model_inheritance/tests.py.
2020-02-06 14:20:02 +01:00
Jon Dufresne
2905b41670
Refs #31233 -- Added "error" filter for RuntimeWarning during tests.
2020-02-06 09:46:59 +01:00
adamb70
4c6ab1f2aa
Fixed #28528 -- Allowed combining SearchVectors with different configs.
2020-02-06 07:52:50 +01:00
Adam Johnson
72b97a5b1e
Fixed #31232 -- Changed default SECURE_REFERRER_POLICY to 'same-origin'.
2020-02-05 14:39:01 +01:00
Mariusz Felisiak
7fa1a93c6c
Refs #28214 -- Added test for escaping JSONField key lookups.
...
Thanks mrsanders for the report.
Fixed in 7deeabc7c7
.
2020-02-05 14:31:30 +01:00
Hasan Ramezani
da79ee472d
Fixed #26813 -- Prevented empty choice in ModelChoiceField with RadioSelect for fields with blank=False.
2020-02-05 10:27:01 +01:00
Mariusz Felisiak
1d5fb35e6a
Refs #26813 -- Added test for ModelChoiceField.choices when using RadioSelect widget.
2020-02-05 09:21:38 +01:00
Nick Pope
335c9c94ac
Simplified imports from django.db and django.contrib.gis.db.
2020-02-04 13:20:06 +01:00
Claude Paroz
8ae84156d6
Fixed #27604 -- Used the cookie signer to sign message cookies.
...
Co-authored-by: Craig Anderson <craiga@craiga.id.au>
2020-02-04 08:05:02 +01:00
Simon Charette
eb31d84532
Fixed CVE-2020-7471 -- Properly escaped StringAgg(delimiter) parameter.
2020-02-03 08:49:13 +01:00
Mariusz Felisiak
6b178a3e93
Fixed #31217 -- Made QuerySet.values()/values_list() group by not selected annotations with aggregations used in order_by().
...
Regression in 59b4e99dd0
.
Thanks Jon Dufresne for the report and Simon Charette for the review.
2020-02-03 07:48:11 +01:00
Mariusz Felisiak
a260001a2d
Refs #30943 -- Fixed postgres_tests on PostgreSQL 9.5.
...
Bloom extension is available on PostgreSQL 9.6+.
2020-01-31 20:42:16 +01:00
Mariusz Felisiak
2e6dc72d83
Used temporary directory in FileFieldTests.test_pickle().
...
Using the current directory caused a PermissionError.
2020-01-31 20:33:48 +01:00
Claude Paroz
e7d62e97eb
Refs #22426 -- Removed pre-Django 1.5 messages compatibility code and test.
...
This reverts commit f286721f7f
.
2020-01-31 11:11:24 +01:00
Hasan Ramezani
a97111eabf
Fixed 31207 -- Prevented references to non-local remote fields in ForeignKey.to_field.
...
Thanks Simon Charette for the initial patch and review.
2020-01-31 10:19:12 +01:00
Matthias Kestenholz
4e8d89020c
Fixed #31219 -- Fixed object deletion crash for nested protected related objects.
2020-01-31 09:07:58 +01:00
Claude Paroz
8c0c0235b6
Added tests for signing non-string values and updated docs.
2020-01-30 11:58:39 +01:00
Hasan Ramezani
579f33eb79
Replaced assertWarns() with SimpleTestCase.assertWarnsMessage() in tests.
2020-01-30 11:19:50 +01:00
Hasan Ramezani
4ca5c565f4
Refs #27852 -- Fixed object deletion to show all restricted related objects rather than just the first one.
2020-01-29 09:02:23 +01:00
Jon Dufresne
f791673537
Made token tests in auth_tests use assertIs() rather than assertTrue/False().
2020-01-29 09:01:18 +01:00
Hasan Ramezani
2633c5341e
Fixed #22261 -- Fixed resolving namespaced URLs for flatpages.
2020-01-28 13:14:23 +01:00
Mariusz Felisiak
e2fab0b679
Refs #22261 -- Added missing trailing slash to the flatpages_tests urls.
2020-01-28 13:01:08 +01:00
Hannes Ljungberg
7edd06a9cf
Improved SearchVectorCombinable and SearchQueryCombinable error messages.
2020-01-27 15:09:47 +01:00
Claude Paroz
50cf183d21
Refs #27468 -- Added algorithm parameter to django.utils.crypto.salted_hmac().
2020-01-27 12:42:21 +01:00
Mariusz Felisiak
c00b863ac6
Made OnDeleteTests.test_protect() assert more specific ProtectedError.
2020-01-27 12:21:02 +01:00
Hasan Ramezani
ab3cbd8b9a
Refs #27852 -- Fixed object deletion to show all protected related objects rather than just the first one.
...
Thanks Anton Samarchyan for the initial patch.
2020-01-27 12:21:02 +01:00
Claude Paroz
e348ab0d43
Fixed #30997 -- Deprecated HttpRequest.is_ajax().
2020-01-27 08:54:32 +01:00
Claude Paroz
7fa0fa45c5
Refs #30997 -- Removed HttpRequest.is_ajax() usage.
2020-01-27 08:52:40 +01:00
Claude Paroz
d66d72f956
Refs #30997 -- Added HttpRequest.accepts().
2020-01-24 14:24:59 +01:00
Hasan Ramezani
b94764e178
Fixed #27888 -- Added link to clear all filters in the admin changelist view.
2020-01-23 14:14:54 +01:00
Michael Mulholland
5a68a223c7
Fixed #31200 -- Added system checks for permissions codenames max length.
2020-01-23 12:22:59 +01:00
Mariusz Felisiak
b423873cb7
Refs #31197 -- Added tests for combined expressions in CheckConstraint.check.
...
Thanks Adam Johnson for the report.
Fixed in 306b687520
.
2020-01-23 10:28:36 +01:00
Eugene Hatsko
0b013564ef
Fixed #31190 -- Fixed prefetch_related() crash for GenericForeignKey with custom ContentType foreign key.
...
Regression in dffa3e1992
.
2020-01-22 07:54:16 +01:00
Sergey Fedoseev
31e2ab345b
Fixed #31195 -- Relaxed GeometryDistance test for PROJ 5.2+.
2020-01-21 22:16:23 +01:00
Sergey Fedoseev
f2a725fba3
Fixed #30274 -- Prevented segmentation fault on LineString iteration.
...
This reverts commit 138a78ec8c
and adds
a test for the regression.
2020-01-21 21:46:47 +01:00
Christopher G Johnson
33ec01caaf
Refs #29095 -- Added test for using QuerySet.count() with window expressions ordered by related fields.
...
Fixed in 3f32154f40
.
2020-01-21 10:43:21 +01:00
Tim Graham
227d0c7365
Fixed #31183 -- Added a feature flag for "<db> only supports UNBOUNDED together with PRECEDING and FOLLOWING".
2020-01-20 20:03:35 +01:00
Matthijs Kooijman
2a2ea4ee18
Refs #31117 -- Made various tests properly handle unexpected databases aliases.
...
- Used selected "databases" instead of django.db.connections.
- Made routers in tests.migrations skip migrations on unexpected
databases.
- Added DiscoverRunnerGetDatabasesTests.assertSkippedDatabases() hook
which properly asserts messages about skipped databases.
2020-01-20 14:39:02 +01:00
Matthijs Kooijman
b64b1b2e1a
Fixed #31117 -- Isolated backends.base.test_creation.TestDbCreationTests.
...
Previously, this test could modify global state by changing
connection.settings_dict. This dict is a reference to the same dict as
django.db.connections.databases['default'], which is thus also changed.
The cleanup of this test would replace connection.settings_dic` with a
saved copy, which would leave the dict itself modified.
Additionally, create_test_db() would also modify these same dicts, as
well as settings.databases['default']['NAME'] by adding a "test_"
prefix, which is what can cause problems later.
This patch:
- makes a complete copy of the connection and work on that, to improve
isolation.
- calls destroy_test_db() to let that code clean up anything done by
create_test_db().
2020-01-20 11:00:17 +01:00
Mariusz Felisiak
f34be5294d
Refs #31117 -- Moved get_connection_copy() test hook to a module level.
2020-01-20 11:00:05 +01:00
Sergey Fedoseev
a920c0b852
Fixed #31142 -- Fixed MakeValid.output_field when geometry type is changed.
...
Regression in 2ef4b4795e
.
2020-01-20 08:59:45 +01:00
Mariusz Felisiak
7d8df4ad03
Fixed field default in dates tests.
2020-01-18 20:07:25 +01:00
Pavel Lysak
13e4abf83e
Fixed #30752 -- Allowed using ExceptionReporter subclasses in error reports.
2020-01-16 15:25:49 +01:00
Mariusz Felisiak
266c853e10
Fixed #31162 -- Prevented error logs when using WKT strings in lookups.
...
Thanks dbxnr for the initial patch.
Regression in 6f44f714c9
.
2020-01-16 14:34:54 +01:00
Flavio Curella
d08d4f464a
Fixed #30765 -- Made cache_page decorator take precedence over max-age Cache-Control directive.
2020-01-16 13:39:16 +01:00
Mariusz Felisiak
bf77669453
Fixed #29998 -- Allowed multiple OneToOneFields to the parent model.
...
We assumed that any OneToOneField's in a child model must be the
parent link and raised an error when parent_link=True was not
specified. This patch allows to specify multiple OneToOneField's to
the parent model.
OneToOneField's without a custom related_name will raise fields.E304
and fields.E305 so this should warn users when they try to override
the auto-created OneToOneField.
2020-01-16 08:06:16 +01:00
Carlton Gibson
29c126bb34
Fixed #31124 -- Fixed setting of get_FOO_display() when overriding inherited choices.
...
Regression in 2d38eb0ab9
2020-01-15 15:35:22 +01:00
Claude Paroz
b5a62bd17d
Refs #27468 -- Added explicit tests for django.utils.crypto.salted_hmac()
2020-01-15 12:53:21 +01:00
Mariusz Felisiak
59b4e99dd0
Refs #31136 -- Made QuerySet.values()/values_list() group only by selected annotation.
...
Regression in 0f843fdd5b
.
2020-01-15 09:32:42 +01:00
chetan22
63e6ee1f99
Fixed #29871 -- Allowed setting pk=None on a child model to create a copy.
...
Thanks Simon Charette and Tim Graham for the initial patch.
2020-01-15 08:28:30 +01:00
Mariusz Felisiak
6f7998adc7
Fixed #31155 -- Fixed a system check for the longest choice when a named group contains only non-string values.
...
Regression in b6251956b6
.
Thanks Murat Guchetl for the report.
2020-01-11 19:47:36 +01:00
Adam Donaghy
8b3e714ecf
Fixed #30980 -- Improved error message when checking uniqueness of admin actions' __name__.
...
Thanks Keshav Kumar for the initial patch.
2020-01-10 14:00:28 +01:00
Carlton Gibson
e2d9d66a22
Fixed #23004 -- Added request.META filtering to SafeExceptionReporterFilter.
...
Co-authored-by: Ryan Castner <castner.rr@gmail.com>
2020-01-10 11:35:41 +01:00
Carlton Gibson
581ba5a948
Refs #23004 -- Allowed exception reporter filters to customize settings filtering.
...
Thanks to Tim Graham for the original implementation idea.
Co-authored-by: Daniel Maxson <dmaxson@ccpgames.com>
2020-01-10 11:21:23 +01:00
Adam Johnson
5166097d7c
Fixed #31154 -- Added support for using enumeration types in templates.
...
Enumeration helpers are callables, so the template system tried to call
them with no arguments.
Thanks Rupert Baker for helping discover this.
2020-01-10 07:52:06 +01:00
Carlton Gibson
4c1b401e82
Added file cleanup in FileFieldTests.test_pickle().
2020-01-09 20:47:45 +01:00
Jack Cushman
eb629f4c02
Fixed #30995 -- Allowed converter.to_url() to raise ValueError to indicate no match.
2020-01-09 14:41:41 +01:00
Hasan Ramezani
eef3ea847e
Fixed #31148 -- Added error messages on update()/delete() operations following union(), intersection(), and difference().
2020-01-09 12:20:54 +01:00
Hasan Ramezani
f600e3fad6
Fixed #21238 -- Fixed restoring attributes when pickling FileField and ImageField.
2020-01-09 09:37:59 +01:00
Hasan Ramezani
aaea9deac4
Refs #21238 -- Added more tests for pickling FileField and ImageField.
2020-01-09 09:18:53 +01:00
Hasan Ramezani
66e16dcc99
Removed unused lines in ImageFieldTests.test_pickle().
2020-01-09 08:44:39 +01:00
Jack Cushman
07f6ff09e4
Added tests for using the same name for multiple URL patterns.
2020-01-08 10:55:53 +01:00
Shubham singh
ffcf1a8ebf
Fixed #31118 -- Made FileInput to avoid the required attribute when initial data exists.
2020-01-08 09:15:31 +01:00
Mariusz Felisiak
53d8646f79
Fixed #31141 -- Relaxed system check of translation settings for sublanguages.
...
Regression in 4400d8296d
.
Thanks Enrique Matías Sánchez for the report.
2020-01-08 08:05:43 +01:00
Mariusz Felisiak
8be477be5c
Fixed timezones tests for PyYAML 5.3+.
2020-01-07 09:54:22 +01:00
Adam Johnson
2ea3fb3e63
Removed "Don't do that" from docs and error messages.
...
It's slightly aggressive and doesn't explain itself.
2020-01-06 13:50:43 +01:00
Claude Paroz
1487f16f2d
Fixed #11385 -- Made forms.DateTimeField accept ISO 8601 date inputs.
...
Thanks José Padilla for the initial patch, and Carlton Gibson for the
review.
2020-01-06 10:52:09 +01:00
Mariusz Felisiak
0f843fdd5b
Fixed #31136 -- Disabled grouping by aliases on QuerySet.values()/values_list().
...
Regression in fb3f034f1c
.
Thanks Sigurd Ljødal for the report.
2020-01-04 20:49:11 +01:00
Claude Paroz
495d7a1ddf
Reorganized forms.DateTimeField tests.
2020-01-03 10:36:58 +01:00
Simon Charette
9bcbcd599a
Fixed #31133 -- Fixed crash when subtracting against a subquery annotation.
...
The subtract_temporals() database operation was not handling expressions
returning SQL params in mixed database types.
Regression in 3543129822
.
Thanks Reupen Shah for the report.
2020-01-03 10:35:08 +01:00
Federico Jaramillo Martínez
372eaa395f
Fixed #28991 -- Added EmptyFieldListFilter class in admin.filters.
...
Thanks Simon Charette and Carlton Gibson for reviews.
Co-Authored-By: Jonas Haag <jonas@lophus.org>
Co-Authored-By: Christophe Baldy <christophe.baldy@polyconseil.fr>
2020-01-03 07:58:04 +01:00
Mariusz Felisiak
1960d55f8b
Refs #31040 -- Fixed crypt.crypt() call in test_hashers.py.
...
An empty string is invalid salt in Python 3 and raises exception since
Python 3.9, see https://bugs.python.org/issue38402 .
2020-01-03 07:47:04 +01:00
Patrick Seebauer
e3d546a1d9
Fixed #31128 -- Fixed TemplateSyntaxError in simple_tag() and inclusion_tag() for kwargs.
2020-01-02 10:44:07 +01:00
Jon Dufresne
9762617a03
Improved tests assertions in cache tests.
...
Added assertions to compare results of .add(), .delete(), .touch(),
.incr(), .decr(), and .get_or_set() methods.
Made tests use assertIs() rather than assertTrue/False().
2019-12-31 12:49:36 +01:00
Mariusz Felisiak
c159baceba
Refs #31117 -- Isolated backends.sqlite.test_creation.TestDbSignatureTests.
2019-12-31 12:09:50 +01:00
David Wobrock
2f565f84ac
Fixed #31097 -- Fixed crash of ArrayAgg and StringAgg with filter when used in Subquery.
2019-12-31 10:35:43 +01:00
David Wobrock
7d44aeb388
Refs #31097 -- Added tests for filter in ArrayAgg and StringAgg.
2019-12-31 10:35:39 +01:00
Sjbrgsn
b2bd08bb7a
Fixed #30892 -- Fixed slugify() and admin's URLify.js for "İ".
...
Thanks Luis Nell for the implementation idea and very detailed report.
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2019-12-30 20:47:22 +01:00
Simon Charette
5779cc938a
Fixed #31071 -- Disabled insert optimization for primary keys with defaults when loading fixtures.
...
Model.save_base() is called directly when loading fixtures and assumes
existing rows will be updated. Branching of "raw" allows to maintain
the optimization introduced in #29260 while supporting this edge case.
Regression in 85458e94e3
.
Thanks Reupen Shah for the report.
2019-12-30 07:49:10 +01:00
Mariusz Felisiak
5a68f02498
Fixed random models_fields.test_uuid.TestQuerying failures.
...
Random failures depended on a generated UUID.
2019-12-27 15:25:50 +01:00
Mads Jensen
62727e65fb
Increased test coverage of django.utils.inspect.
2019-12-27 10:08:24 +01:00
Jon Dufresne
e42b68debf
Fixed #31114 -- Fixed HttpRequest.build_absolute_uri() crash with reverse_lazy() locations.
2019-12-27 09:19:56 +01:00
Claude Paroz
5660267e5b
Fixed #31121 -- Cleared Site cache in SitesFrameworkTests.
...
Thanks Matthijs Kooijman for the report and analysis.
2019-12-27 08:57:34 +01:00
Mariusz Felisiak
22ce5d0031
Fixed #31106 -- Fixed migrations crash on PostgreSQL 10+ when adding FK constraints inline and changing data.
...
This allows adding foreign key constraints inline and changing data in
the same migration on PostgreSQL 10+.
Regression in 738faf9da2
.
Thanks Janne Rönkkö for the report and Simon Charette for the
implementation idea and review.
2019-12-23 23:28:59 +01:00
Mariusz Felisiak
45bcc6feac
Refs #31115 -- Added test for nested subquery that references related fields.
...
Thanks Dmitriy Gunchenko for the report and Simon Charette for the
analysis and tests.
Regression in 5a4d7285bd
.
Fixed in 5a4d7285bd
.
2019-12-23 12:17:56 +01:00
Jon Dufresne
67ea35df52
Fixed #30998 -- Added ModelChoiceIteratorValue to pass the model instance to ChoiceWidget.create_option().
2019-12-23 10:34:50 +01:00
Simon Charette
720de4d044
Fixed #31109 -- Disabled grouping by aliases on QuerySet.exists().
...
Clearing the SELECT clause in Query.has_results was orphaning GROUP BY
references to it.
Thanks Thierry Bastian for the report and Baptiste Mispelon for the
bisect.
Regression in fb3f034f1c
.
2019-12-23 09:24:03 +01:00
Nick Pope
a2d894b2e4
Refs #28954 -- Removed remaining Jython-specific code from dispatch tests.
...
Missed in 23b21db31b
.
2019-12-19 16:42:12 +01:00
Hasan Ramezani
a3fc24f014
Fixed #31095 -- Made RelatedManager.set() preserve existing m2m relations with an invalid type.
2019-12-19 13:33:05 +01:00
Simon Charette
5a4d7285bd
Fixed #31094 -- Included columns referenced by subqueries in GROUP BY on aggregations.
...
Thanks Johannes Hoppe for the report.
Regression in fb3f034f1c
.
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2019-12-19 10:04:56 +01:00
Simon Charette
a0f34d8fef
Refs #31094 -- Added test for not using aliases in GROUP BY clauses.
2019-12-19 09:12:29 +01:00
Mike Hansen
35d36d9462
Refs #30585 -- Updated project templates and tests to use (block)translate tags.
2019-12-18 13:15:38 +01:00
Mike Hansen
d291c72bf2
Fixed #30585 -- Added {% translate %} and {% blocktranslate %} template tags.
2019-12-18 13:15:38 +01:00
Simon Charette
5b1fbcef7a
Fixed CVE-2019-19844 -- Used verified user email for password reset requests.
...
Co-Authored-By: Florian Apolloner <florian@apolloner.eu>
2019-12-18 09:11:39 +01:00
Shubham singh
f4647179cc
Fixed #31086 -- Improved error message for admin model inlines with more than one foreign key to the same parent.
2019-12-17 09:15:01 +01:00
James Turk
ff00a05347
Fixed #31088 -- Added support for websearch searching in SearchQuery.
2019-12-16 14:59:59 +01:00
Zeynel Özdemir
9d40b6bbf4
Fixed #31076 -- Fixed dbshell crash on Windows with Python < 3.8.
...
subprocess.run()'s args parameter accepts path-like objects on Windows
since Python 3.8.
2019-12-16 11:20:41 +01:00
Baptiste Mispelon
4161e35048
Refs #12679 -- Added test for using property as ModelAdmin.inlines.
...
Fixed in 1d8eb0cae5
.
2019-12-14 21:15:44 +01:00
Baptiste Mispelon
738e9e615d
Fixed #26743 -- Fixed UnboundLocalError crash when deserializing m2m fields and value isn't iterable.
2019-12-13 11:38:09 +01:00
Osaetin Daniel
b33bfc3839
Fixed #30862 -- Allowed setting SameSite cookies flags to 'none'.
...
Thanks Florian Apolloner and Carlton Gibson for reviews.
2019-12-12 10:52:31 +01:00
Baptiste Mispelon
200cd8803d
Refs #25361 -- Added test for pickling queryset of abstract-inherited models with Meta.ordering.
...
Fixed in 67cf5efa31
.
2019-12-12 09:01:47 +01:00
Jon Dufresne
8ea3ff155e
Fixed typo in tests/cache/tests.py docstring.
2019-12-11 17:39:21 +01:00
Jon Dufresne
8d087f9a17
Fixed typo in ModelChoiceFieldTests.
...
The subindex and attrs arguments should be passed through to the parent,
not overridden as None.
2019-12-11 15:15:12 +01:00
Jon Dufresne
e703b93a65
Fixed #31080 -- Removed redundant type="text/javascript" attribute from <script> tags.
2019-12-11 09:49:54 +01:00
Baptiste Mispelon
d8e2333528
Fixed #31077 -- Made debug decorators raise TypeError if they're not called.
...
Django will raise an error if you forget to call the decorator.
2019-12-10 13:34:28 +01:00
Peter Andersen
02eff7ef60
Fixed #31073 -- Prevented CheckboxInput.get_context() from mutating attrs.
2019-12-10 12:27:50 +01:00
Mariusz Felisiak
3fb7c12158
Refs #23433 -- Fixed test_django_admin_py.DeprecationTest tests failures on Windows and Python < 3.8.
...
subprocess.run()'s args parameter accepts a path-like object on Windows
since Python 3.8.
2019-12-10 11:17:50 +01:00
Baptiste Mispelon
3df3c5e670
Fixed #26480 -- Fixed crash of contrib.auth.authenticate() on decorated authenticate() methods of authentication backends.
...
The Signature API (PEP 362) has better support for decorated functions
(by default, it follows the __wrapped__ attribute set by
functools.wraps for example).
2019-12-10 09:36:30 +01:00
Mariusz Felisiak
d6505273cd
Refs #31044 -- Fixed error message when using Prefetch with a values_list() queryset.
2019-12-09 15:45:53 +01:00
Hasan Ramezani
4540842bc3
Fixed #31044 -- Errored nicely when using Prefetch with a raw() queryset.
2019-12-09 15:45:18 +01:00
Baptiste Mispelon
9e565386d3
Fixed #27430 -- Added -b/--buffer option to DiscoverRunner.
2019-12-09 13:47:12 +01:00
Mariusz Felisiak
f464526388
Refs #30676 -- Added test for invalid --pdb and --parallel usage in DiscoverRunner.
2019-12-09 11:12:06 +01:00
Alex Aktsipetrov
bf12273db4
Fixed #31060 -- Reallowed window expressions to be used in conditions outside of queryset filters.
...
Regression in 4edad1ddf6
.
Thanks utapyngo for the report.
2019-12-06 13:52:16 +01:00
Jon Dufresne
5708327c37
Fixed #23433 -- Deprecated django-admin.py entry point in favor of django-admin.
...
Unify on the entry point created by setuptools entry_points feature.
2019-12-06 12:11:44 +01:00
Jon Dufresne
8eb0f73eed
Refs #23433 -- Removed script argument from AdminScriptTestCase.run_test().
2019-12-06 10:33:54 +01:00
Jon Dufresne
8aefe11137
Removed unnecessary __init__.py creation in admin_scripts.tests.
2019-12-06 09:57:09 +01:00
Mariusz Felisiak
82a88d2f48
Fixed #31061 -- Ignored positional args in django.urls.resolve() when all optional named parameters are missing.
...
Regression in 76b993a117
.
Thanks Claude Paroz for the report and Carlton Gibson for reviews.
2019-12-06 09:32:51 +01:00
Hasan Ramezani
5d674eac87
Fixed #31039 -- Added support for contained_by lookup with AutoFields, SmallIntegerField, and DecimalField.
2019-12-05 15:50:39 +01:00