From 85b5a156fc32b6ee932f2260b385fad198c254a6 Mon Sep 17 00:00:00 2001
From: Shay Nehmad <shay.nehmad@guardicore.com>
Date: Tue, 12 May 2020 10:16:04 +0300
Subject: [PATCH] Fixed code review comments - JS linting and readability

---
 .../security/BreachedServers.js                 |  6 +++---
 .../report-components/security/PostBreach.js    | 10 +++++-----
 .../security/ScannedServers.js                  | 17 ++++++++++-------
 3 files changed, 18 insertions(+), 15 deletions(-)

diff --git a/monkey/monkey_island/cc/ui/src/components/report-components/security/BreachedServers.js b/monkey/monkey_island/cc/ui/src/components/report-components/security/BreachedServers.js
index 1b2efcd06..3ea23a075 100644
--- a/monkey/monkey_island/cc/ui/src/components/report-components/security/BreachedServers.js
+++ b/monkey/monkey_island/cc/ui/src/components/report-components/security/BreachedServers.js
@@ -1,6 +1,6 @@
 import React from 'react';
-import ReactTable from 'react-table'
-import Pluralize from "pluralize";
+import ReactTable from 'react-table';
+import Pluralize from 'pluralize';
 
 let renderArray = function (val) {
   return <div>{val.map(x => <div>{x}</div>)}</div>;
@@ -38,7 +38,7 @@ class BreachedServersComponent extends React.Component {
       <>
         <p>
           The Monkey successfully breached <span
-          className="label label-danger">{this.props.data.length}</span> {Pluralize('machines', this.props.data.length)}:
+          className="label label-danger">{this.props.data.length}</span> {Pluralize('machine', this.props.data.length)}:
         </p>
         <div className="data-table-container">
           <ReactTable
diff --git a/monkey/monkey_island/cc/ui/src/components/report-components/security/PostBreach.js b/monkey/monkey_island/cc/ui/src/components/report-components/security/PostBreach.js
index 2aa772db5..c482fb992 100644
--- a/monkey/monkey_island/cc/ui/src/components/report-components/security/PostBreach.js
+++ b/monkey/monkey_island/cc/ui/src/components/report-components/security/PostBreach.js
@@ -1,6 +1,6 @@
 import React from 'react';
-import ReactTable from 'react-table'
-import Pluralize from 'pluralize'
+import ReactTable from 'react-table';
+import Pluralize from 'pluralize';
 
 let renderArray = function (val) {
   return <span>{val.map(x => <span key={x}> {x}</span>)}</span>;
@@ -63,13 +63,13 @@ class PostBreachComponent extends React.Component {
     });
     let defaultPageSize = pbaMachines.length > pageSize ? pageSize : pbaMachines.length;
     let showPagination = pbaMachines > pageSize;
-    const howManyPBAs = pbaMachines.reduce((accumulated, pbaMachine) => accumulated+pbaMachine["pba_results"].length,0)
+    const pbaCount = pbaMachines.reduce((accumulated, pbaMachine) => accumulated+pbaMachine["pba_results"].length, 0);
     return (
       <>
         <p>
           The Monkey performed <span
-          className="label label-danger">{howManyPBAs}</span> post-breach {Pluralize('actions', howManyPBAs)} on <span
-          className="label label-warning">{pbaMachines.length}</span> {Pluralize('machines', pbaMachines.length)}:
+          className="label label-danger">{pbaCount}</span> post-breach {Pluralize('action', pbaCount)} on <span
+          className="label label-warning">{pbaMachines.length}</span> {Pluralize('machine', pbaMachines.length)}:
         </p>
         <div className="data-table-container">
           <ReactTable
diff --git a/monkey/monkey_island/cc/ui/src/components/report-components/security/ScannedServers.js b/monkey/monkey_island/cc/ui/src/components/report-components/security/ScannedServers.js
index f68415a3a..644d77f54 100644
--- a/monkey/monkey_island/cc/ui/src/components/report-components/security/ScannedServers.js
+++ b/monkey/monkey_island/cc/ui/src/components/report-components/security/ScannedServers.js
@@ -1,6 +1,6 @@
 import React from 'react';
-import ReactTable from 'react-table'
-import Pluralize from 'pluralize'
+import ReactTable from 'react-table';
+import Pluralize from 'pluralize';
 
 let renderArray = function (val) {
   return <div>{val.map(x => <div>{x}</div>)}</div>;
@@ -37,16 +37,19 @@ class ScannedServersComponent extends React.Component {
     let defaultPageSize = this.props.data.length > pageSize ? pageSize : this.props.data.length;
     let showPagination = this.props.data.length > pageSize;
 
-    const howManyScannedMachines = this.props.data.length;
+    const scannedMachinesCount = this.props.data.length;
     const reducerFromScannedServerToServicesAmount = (accumulated, scannedServer) => accumulated + scannedServer["services"].length;
-    const howManyScannedServices = this.props.data.reduce(reducerFromScannedServerToServicesAmount, 0);
+    const scannedServicesAmount = this.props.data.reduce(reducerFromScannedServerToServicesAmount, 0);
 
     return (
       <>
         <p>
-          The Monkey discovered <span
-          className="label label-danger">{howManyScannedServices}</span> open {Pluralize('services', howManyScannedServices)} on <span
-          className="label label-warning">{howManyScannedMachines}</span> {Pluralize('machines', howManyScannedMachines)}:
+          The Monkey discovered
+          <span className="label label-danger">{scannedServicesAmount}</span>
+          open {Pluralize('service', scannedServicesAmount)}
+          on
+          <span className="label label-warning">{scannedMachinesCount}</span>
+          {Pluralize('machine', scannedMachinesCount)}:
         </p>
         <div className="data-table-container">
           <ReactTable