Fixed some errors poined out in PR

This commit is contained in:
VakarisZ 2019-01-27 14:21:39 +02:00
parent 4f0606d6fb
commit bf26ed8881
3 changed files with 15 additions and 3 deletions

View File

@ -51,12 +51,23 @@ class NetworkRange(object):
address_str = address_str.strip()
if not address_str: # Empty string
return None
if -1 != address_str.find('-'):
if NetworkRange.check_if_range(address_str):
return IpRange(ip_range=address_str)
if -1 != address_str.find('/'):
return CidrRange(cidr_range=address_str)
return SingleIpRange(ip_address=address_str)
@staticmethod
def check_if_range(address_str):
if -1 != address_str.find('-'):
ips = address_str.split('-')
try:
ipaddress.ip_address(ips[0]) and ipaddress.ip_address(ips[1])
except ValueError as e:
return False
return True
return False
@staticmethod
def _ip_to_number(address):
return struct.unpack(">L", socket.inet_aton(address))[0]

View File

@ -4,7 +4,7 @@ __author__ = 'itamar'
class VictimHost(object):
def __init__(self, ip_addr, domain_name=''):
self.ip_addr = ip_addr
self.domain_name = domain_name
self.domain_name = str(domain_name)
self.os = {}
self.services = {}
self.monkey_exe = None

View File

@ -6,6 +6,7 @@ import cc.services.log
from cc.database import mongo
from cc.services.edge import EdgeService
from cc.utils import local_ip_addresses
import socket
__author__ = "itay.mizeretz"
@ -267,7 +268,7 @@ class NodeService:
def get_monkey_island_node():
island_node = NodeService.get_monkey_island_pseudo_net_node()
island_node["ip_addresses"] = local_ip_addresses()
island_node["domain_name"] = ""
island_node["domain_name"] = socket.gethostname()
return island_node
@staticmethod