Island: Refactor test_encryption_skipped_if_no_directory()

The old implementation tightly coupled the test to the specific
implementation of the ransomware payload. Since the ransomware payload
provides insight into its actions in the form of telemetry, it should be
sufficient to test whether or not any telemetries were sent in order to
determine whether or not encryption was skipped. This way, the test can
remain decoupled from the internal workings of the ransomware payload.
This commit is contained in:
Mike Salvatore 2021-07-07 19:14:45 -04:00
parent 0db85ae407
commit ecb20dc99a
1 changed files with 1 additions and 7 deletions

View File

@ -170,15 +170,9 @@ def test_encryption_skipped_if_no_directory(
ransomware_payload_config["encryption"]["directories"]["linux_target_dir"] = ""
ransomware_payload_config["encryption"]["directories"]["windows_target_dir"] = ""
def _file_encryption_method_mock(*args, **kwargs):
raise Exception(
"Ransomware payload attempted to "
"encrypt files even though no directory was provided!"
)
ransomware_payload = RansomwarePayload(ransomware_payload_config, telemetry_messenger_spy)
monkeypatch.setattr(ransomware_payload, "_encrypt_files", _file_encryption_method_mock)
ransomware_payload.run_payload()
assert len(telemetry_messenger_spy.telemetries) == 0
def test_telemetry_success(ransomware_payload, telemetry_messenger_spy):