From f526933d848e8d59621f56898dae3d97ac7909c2 Mon Sep 17 00:00:00 2001 From: Mike Salvatore Date: Thu, 17 Feb 2022 06:18:44 -0500 Subject: [PATCH] Agent: Add TODO comment regarding OS checks in credential collectors --- .../credential_collectors/mimikatz_collector/pypykatz_handler.py | 1 + .../credential_collectors/ssh_collector/ssh_handler.py | 1 + 2 files changed, 2 insertions(+) diff --git a/monkey/infection_monkey/credential_collectors/mimikatz_collector/pypykatz_handler.py b/monkey/infection_monkey/credential_collectors/mimikatz_collector/pypykatz_handler.py index 98377bc86..25e02f5e1 100644 --- a/monkey/infection_monkey/credential_collectors/mimikatz_collector/pypykatz_handler.py +++ b/monkey/infection_monkey/credential_collectors/mimikatz_collector/pypykatz_handler.py @@ -24,6 +24,7 @@ PypykatzCredential = NewType("PypykatzCredential", Dict) def get_windows_creds() -> List[WindowsCredentials]: + # TODO: Remove this check when this is turned into a plugin. if not is_windows_os(): logger.debug("Skipping pypykatz because the operating system is not Windows") return [] diff --git a/monkey/infection_monkey/credential_collectors/ssh_collector/ssh_handler.py b/monkey/infection_monkey/credential_collectors/ssh_collector/ssh_handler.py index 89f3c34fc..ce3b17311 100644 --- a/monkey/infection_monkey/credential_collectors/ssh_collector/ssh_handler.py +++ b/monkey/infection_monkey/credential_collectors/ssh_collector/ssh_handler.py @@ -16,6 +16,7 @@ DEFAULT_DIRS = ["/.ssh/", "/"] def get_ssh_info(telemetry_messenger: ITelemetryMessenger) -> Iterable[Dict]: + # TODO: Remove this check when this is turned into a plugin. if is_windows_os(): logger.debug( "Skipping SSH credentials collection because the operating system is not Linux"