code refactor

conf/input.exec/exec.toml

@@ -1,11 +1,11 @@
 # # collect interval
 # interval = 15
 
-[[instances]]
+# [[instances]]
-# commands, support glob
+# # commands, support glob
-commands = [
+# commands = [
-    "/opt/categraf/scripts/*.sh"
+#     "/opt/categraf/scripts/*.sh"
-]
+# ]
 
 # # timeout for each command to complete
 # timeout = 5

conf/input.oracle/oracle.toml

@@ -1,14 +1,14 @@
 # # collect interval
 # interval = 15
 
-[[instances]]
+# [[instances]]
-address = "10.1.2.3:1521/orcl"
+# address = "10.1.2.3:1521/orcl"
-username = "monitor"
+# username = "monitor"
-password = "123456"
+# password = "123456"
-is_sys_dba = false
+# is_sys_dba = false
-is_sys_oper = false
+# is_sys_oper = false
-disable_connection_pool = false
+# disable_connection_pool = false
-max_open_connections = 5
+# max_open_connections = 5
 # # interval = global.interval * interval_times
 # interval_times = 1
 # labels = { region="cloud" }

inputs/exec/exec.go

@@ -58,6 +58,10 @@ func (e *Exec) GetInterval() config.Duration {
 }
 
 func (e *Exec) Init() error {
+	if len(e.Instances) == 0 {
+		return fmt.Errorf("exec instances empty")
+	}
+
 	for i := 0; i < len(e.Instances); i++ {
 		if e.Instances[i].DataFormat == "" || e.Instances[i].DataFormat == "influx" {
 			e.Instances[i].parser = influx.NewSeriesParser()

inputs/oracle/oracle.go

@@ -76,6 +76,9 @@ func (o *Oracle) Init() error {
 	o.dbconnpool = make(map[string]*sqlx.DB)
 	for i := 0; i < len(o.Instances); i++ {
 		dbConf := o.Instances[i]
+		if dbConf.Address == "" {
+			return fmt.Errorf("some oracle address is blank")
+		}
 		connString := getConnectionString(dbConf)
 		db, err := sqlx.Open("godror", connString)
 		if err != nil {