code refactor

This commit is contained in:
Ulric Qin 2022-04-25 16:49:37 +08:00
parent 11ead55c91
commit 84bcff5987
3 changed files with 34 additions and 6 deletions

View File

@ -0,0 +1,11 @@
package mysql
import (
"database/sql"
"github.com/toolkits/pkg/container/list"
)
func (m *MySQL) gatherGlobalStatus(slist *list.SafeList, ins *Instance, db *sql.DB, globalTags map[string]string) {
}

View File

@ -0,0 +1,11 @@
package mysql
import (
"database/sql"
"github.com/toolkits/pkg/container/list"
)
func (m *MySQL) gatherGlobalVariables(slist *list.SafeList, ins *Instance, db *sql.DB, globalTags map[string]string) {
}

View File

@ -147,13 +147,19 @@ func (m *MySQL) gatherOnce(slist *list.SafeList, ins *Instance) {
return
}
slist.PushFront(inputs.NewSample("up", 1, tags))
defer db.Close()
db.SetMaxOpenConns(1)
db.SetMaxIdleConns(1)
db.SetConnMaxLifetime(time.Minute)
if err = db.Ping(); err != nil {
slist.PushFront(inputs.NewSample("up", 0, tags))
log.Println("E! failed to ping mysql:", err)
}
slist.PushFront(inputs.NewSample("up", 1, tags))
m.gatherGlobalStatus(slist, ins, db, tags)
}
func (m *MySQL) gatherGlobalStatus(slist *list.SafeList, ins *Instance, db *sql.DB, globalTags map[string]string) {
m.gatherGlobalVariables(slist, ins, db, tags)
}