p17860254
/
monkey
forked from p15670423/monkey
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ui: simplify compareOptions() with boolean arithmetic

This commit is contained in:
Mike Salvatore 2021-01-29 10:52:14 -05:00
parent 117678f91a
commit 06685b14cf
1 changed files with 6 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
monkey/monkey_island/cc/ui/src/components/ui-components/AdvancedMultiSelect.js
View File

@ -51,23 +51,14 @@ class AdvancedMultiSelect extends React.Component {
// Sort options alphabetically. "Unsafe" options float to the bottom"
compareOptions = (a, b) => {
if (!this.isSafe(a.value) && this.isSafe(b.value)) {
return 1;
// Apparently, you can use additive operators with boolean types. Ultimately,
// the ToNumber() abstraction operation is called to convert the booleans to
// numbers: https://tc39.es/ecma262/#sec-tonumeric
if (this.isSafe(b.value) - this.isSafe(a.value) !== 0) {
return this.isSafe(b.value) - this.isSafe(a.value);
}
if (this.isSafe(a.value) && !this.isSafe(b.value)) {
return -1;
}
if (a.value < b.value) {
return -1
}
if (a.value > b.value) {
return 1
}
return 0;
return a.value.localeCompare(b.value);
}
onMasterCheckboxClick = () => {