From 13ca4b6f8c0f071fc6ba7bfe40545a7bdd536d8d Mon Sep 17 00:00:00 2001 From: Mike Salvatore Date: Wed, 27 Apr 2022 13:19:16 -0400 Subject: [PATCH] Island: Add comment about seemingly duplicate endpoints --- monkey/monkey_island/cc/resources/pba_file_upload.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/monkey/monkey_island/cc/resources/pba_file_upload.py b/monkey/monkey_island/cc/resources/pba_file_upload.py index cc6826f01..233cf9e67 100644 --- a/monkey/monkey_island/cc/resources/pba_file_upload.py +++ b/monkey/monkey_island/cc/resources/pba_file_upload.py @@ -26,8 +26,10 @@ class FileUpload(flask_restful.Resource): def __init__(self, file_storage_service: IFileStorageService): self._file_storage_service = file_storage_service - # TODO: Add comment explaining why this is basically a duplicate of the endpoint in the - # PBAFileDownload resource. + # This endpoint is basically a duplicate of PBAFileDownload.get(). They serve slightly different + # purposes. This endpoint is authenticated, whereas the one in PBAFileDownload can not be (at + # the present time). In the future, consider whether or not they should be merged, or if they + # serve truly distinct purposes @jwt_required def get(self, target_os): """