From 44795531b850e419f1b6496bc1fca03aa945688e Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 21 Jun 2022 15:04:34 +0200 Subject: [PATCH] Island: Remove logging TODOs for pba_file upload/download Resources should log the errors --- monkey/monkey_island/cc/resources/pba_file_download.py | 1 - monkey/monkey_island/cc/resources/pba_file_upload.py | 1 - 2 files changed, 2 deletions(-) diff --git a/monkey/monkey_island/cc/resources/pba_file_download.py b/monkey/monkey_island/cc/resources/pba_file_download.py index 3b7e92047..39acb5d2c 100644 --- a/monkey/monkey_island/cc/resources/pba_file_download.py +++ b/monkey/monkey_island/cc/resources/pba_file_download.py @@ -26,7 +26,6 @@ class PBAFileDownload(AbstractResource): # `send_file()` handles the closing of the open file. return send_file(file, mimetype="application/octet-stream") except repository.FileNotFoundError as err: - # TODO: Do we need to log? Or will flask handle it when we `make_response()`? logger.error(str(err)) return make_response({"error": str(err)}, 404) diff --git a/monkey/monkey_island/cc/resources/pba_file_upload.py b/monkey/monkey_island/cc/resources/pba_file_upload.py index 833086998..5f46273c4 100644 --- a/monkey/monkey_island/cc/resources/pba_file_upload.py +++ b/monkey/monkey_island/cc/resources/pba_file_upload.py @@ -59,7 +59,6 @@ class FileUpload(AbstractResource): # `send_file()` handles the closing of the open file. return send_file(file, mimetype="application/octet-stream") except repository.FileNotFoundError as err: - # TODO: Do we need to log? Or will flask handle it when we `make_response()`? logger.error(str(err)) return make_response({"error": str(err)}, 404)