p17860254
/
monkey
forked from p15670423/monkey
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Island: Remove logging TODOs for pba_file upload/download 

Resources should log the errors
This commit is contained in:
Ilija Lazoroski 2022-06-21 15:04:34 +02:00
parent cd34cd5eae
commit 44795531b8
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
monkey/monkey_island/cc/resources/pba_file_download.py
View File

@ -26,7 +26,6 @@ class PBAFileDownload(AbstractResource):
# `send_file()` handles the closing of the open file. # `send_file()` handles the closing of the open file.
return send_file(file, mimetype="application/octet-stream") return send_file(file, mimetype="application/octet-stream")
except repository.FileNotFoundError as err: except repository.FileNotFoundError as err:
# TODO: Do we need to log? Or will flask handle it when we `make_response()`?
logger.error(str(err)) logger.error(str(err))
return make_response({"error": str(err)}, 404) return make_response({"error": str(err)}, 404)

1
monkey/monkey_island/cc/resources/pba_file_upload.py
View File

@ -59,7 +59,6 @@ class FileUpload(AbstractResource):
# `send_file()` handles the closing of the open file. # `send_file()` handles the closing of the open file.
return send_file(file, mimetype="application/octet-stream") return send_file(file, mimetype="application/octet-stream")
except repository.FileNotFoundError as err: except repository.FileNotFoundError as err:
# TODO: Do we need to log? Or will flask handle it when we `make_response()`?
logger.error(str(err)) logger.error(str(err))
return make_response({"error": str(err)}, 404) return make_response({"error": str(err)}, 404)