p17860254
/
monkey
forked from p15670423/monkey
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ui: sort unsafe options first so they're less likely to be hidden

This commit is contained in:
Mike Salvatore 2021-02-25 20:09:12 -05:00
parent 88e2ccb30a
commit 68e835433a
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
monkey/monkey_island/cc/ui/src/components/ui-components/AdvancedMultiSelect.js
View File

@ -48,13 +48,14 @@ class AdvancedMultiSelect extends React.Component {
};
}
// Sort options alphabetically. "Unsafe" options float to the bottom"
// Sort options alphabetically. "Unsafe" options float to the top so that they
// do not get selected and hidden at the bottom of the list.
compareOptions = (a, b) => {
// Apparently, you can use additive operators with boolean types. Ultimately,
// the ToNumber() abstraction operation is called to convert the booleans to
// numbers: https://tc39.es/ecma262/#sec-tonumeric
if (this.isSafe(b.value) - this.isSafe(a.value) !== 0) {
return this.isSafe(b.value) - this.isSafe(a.value);
if (this.isSafe(a.value) - this.isSafe(b.value) !== 0) {
return this.isSafe(a.value) - this.isSafe(b.value);
}
return a.value.localeCompare(b.value);