From 69fa4adf1fa7eaf4c1dfaa24bc18719e023e53c8 Mon Sep 17 00:00:00 2001
From: Mike Salvatore <mike.s.salvatore@gmail.com>
Date: Tue, 8 Feb 2022 09:04:59 -0500
Subject: [PATCH] Island: Add comment describing
_translate_fingerprinter_name()
---
monkey/monkey_island/cc/services/config.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/monkey/monkey_island/cc/services/config.py b/monkey/monkey_island/cc/services/config.py
index ba37d357c..f113c437e 100644
--- a/monkey/monkey_island/cc/services/config.py
+++ b/monkey/monkey_island/cc/services/config.py
@@ -557,6 +557,10 @@ class ConfigService:
@staticmethod
def _translate_fingerprinter_name(name: str) -> str:
+ # This translates names like "HTTPFinger" to "http". "HTTPFinger" is an old classname on the
+ # agent-side and is therefore unnecessarily couples the island to the fingerprinter's
+ # implementation within the agent. For the time being, fingerprinters will have names like
+ # "http", "ssh", "elastic", etc. This will be revisited when fingerprinters become plugins.
return re.sub(r"Finger", "", name).lower()
@staticmethod