p17860254
/
monkey
forked from p15670423/monkey
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

UT: Properly group arrange/assert/act steps

This commit is contained in:
Kekoa Kaaikala 2022-09-29 19:36:18 +00:00
parent c632b9b77b
commit c1dcb285ae
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
monkey/tests/unit_tests/monkey_island/cc/agent_event_handlers/test_handle_ping_scan_event.py
View File

@ -131,11 +131,11 @@ def test_handle_ping_scan_event__target_machine_not_exists(
): ):
machine_repository.get_machine_by_id = MagicMock(side_effect=machine_from_id) machine_repository.get_machine_by_id = MagicMock(side_effect=machine_from_id)
machine_repository.get_machines_by_ip = MagicMock(side_effect=UnknownRecordError) machine_repository.get_machines_by_ip = MagicMock(side_effect=UnknownRecordError)
handler(EVENT) handler(EVENT)
expected_machine = Machine(id=SEED_ID, network_interfaces=[IPv4Interface(EVENT.target)]) expected_machine = Machine(id=SEED_ID, network_interfaces=[IPv4Interface(EVENT.target)])
expected_machine.operating_system = EVENT.os expected_machine.operating_system = EVENT.os
machine_repository.upsert_machine.assert_called_with(expected_machine) machine_repository.upsert_machine.assert_called_with(expected_machine)
@ -145,11 +145,11 @@ def test_handle_ping_scan_event__target_machine_already_exists(
): ):
machine_repository.get_machine_by_id = MagicMock(side_effect=machine_from_id) machine_repository.get_machine_by_id = MagicMock(side_effect=machine_from_id)
machine_repository.get_machines_by_ip = MagicMock(side_effect=machines_from_ip) machine_repository.get_machines_by_ip = MagicMock(side_effect=machines_from_ip)
handler(EVENT) handler(EVENT)
expected_machine = TARGET_MACHINE.copy() expected_machine = TARGET_MACHINE.copy()
expected_machine.operating_system = OperatingSystem.LINUX expected_machine.operating_system = OperatingSystem.LINUX
machine_repository.upsert_machine.assert_called_with(expected_machine) machine_repository.upsert_machine.assert_called_with(expected_machine)
@ -160,6 +160,7 @@ def test_handle_ping_scan_event__upserts_node(
): ):
machine_repository.get_machine_by_id = MagicMock(side_effect=machine_from_id) machine_repository.get_machine_by_id = MagicMock(side_effect=machine_from_id)
machine_repository.get_machines_by_ip = MagicMock(return_value=[TARGET_MACHINE]) machine_repository.get_machines_by_ip = MagicMock(return_value=[TARGET_MACHINE])
handler(EVENT) handler(EVENT)
node_repository.upsert_communication.assert_called_with( node_repository.upsert_communication.assert_called_with(