agent: Add TODOs regarding string templates.

This commit is contained in:
Mike Salvatore 2021-04-28 11:00:53 -04:00
parent d4e277c70b
commit e5935e43c1
2 changed files with 6 additions and 0 deletions

View File

@ -143,6 +143,8 @@ class MonkeyDrops(object):
) )
if OperatingSystem.Windows == SystemInfoCollector.get_os(): if OperatingSystem.Windows == SystemInfoCollector.get_os():
# TODO: Replace all of this string templating with a function that accepts
# the necessary parameters and returns a list of arguments.
monkey_cmdline = ( monkey_cmdline = (
MONKEY_CMDLINE_WINDOWS % {"monkey_path": self._config["destination_path"]} MONKEY_CMDLINE_WINDOWS % {"monkey_path": self._config["destination_path"]}
+ monkey_options + monkey_options
@ -164,6 +166,8 @@ class MonkeyDrops(object):
dest_path = self._config["destination_path"] dest_path = self._config["destination_path"]
# In Linux, we need to change the directory first, which is done # In Linux, we need to change the directory first, which is done
# using thw `cwd` argument in `subprocess.Popen` below # using thw `cwd` argument in `subprocess.Popen` below
# TODO: Replace all of this string templating with a function that accepts
# the necessary parameters and returns a list of arguments.
monkey_cmdline = ( monkey_cmdline = (
MONKEY_CMDLINE_LINUX % {"monkey_filename": dest_path.split("/")[-1]} MONKEY_CMDLINE_LINUX % {"monkey_filename": dest_path.split("/")[-1]}
+ monkey_options + monkey_options

View File

@ -46,6 +46,8 @@ class WindowsUpgrader(object):
opts.parent, opts.tunnel, opts.server, opts.depth opts.parent, opts.tunnel, opts.server, opts.depth
) )
# TODO: Replace all of this string templating with a function that accepts
# the necessary parameters and returns a list of arguments.
monkey_cmdline = ( monkey_cmdline = (
MONKEY_CMDLINE_WINDOWS % {"monkey_path": WormConfiguration.dropper_target_path_win_64} MONKEY_CMDLINE_WINDOWS % {"monkey_path": WormConfiguration.dropper_target_path_win_64}
+ monkey_options + monkey_options