p20319658
/
monkey
forked from p34709852/monkey
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Zero Trust finding saving method refactored to remove code duplication between children

This commit is contained in:
VakarisZ 2021-02-11 16:53:19 +02:00
parent e96ee305fb
commit 25704b74c9
3 changed files with 6 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
monkey/monkey_island/cc/models/zero_trust/finding.py
View File

@ -5,8 +5,6 @@ Define a Document Schema for Zero Trust findings.
from __future__ import annotations from __future__ import annotations
import abc
from mongoengine import Document, GenericLazyReferenceField, StringField from mongoengine import Document, GenericLazyReferenceField, StringField
import common.common_consts.zero_trust_consts as zero_trust_consts import common.common_consts.zero_trust_consts as zero_trust_consts
@ -45,9 +43,11 @@ class Finding(Document):
details = GenericLazyReferenceField(required=True) details = GenericLazyReferenceField(required=True)
# Creation methods # Creation methods
@staticmethod @classmethod
@abc.abstractmethod def save_finding(cls,
def save_finding(test: str, test: str,
status: str, status: str,
detail_ref) -> Finding: detail_ref) -> Finding:
pass finding = cls(test=test, status=status, details=detail_ref)
finding.save()
return finding

10
monkey/monkey_island/cc/models/zero_trust/monkey_finding.py
View File

@ -6,13 +6,3 @@ from monkey_island.cc.models.zero_trust.monkey_finding_details import MonkeyFind
class MonkeyFinding(Finding): class MonkeyFinding(Finding):
details = LazyReferenceField(MonkeyFindingDetails, required=True) details = LazyReferenceField(MonkeyFindingDetails, required=True)
@staticmethod
def save_finding(test: str,
status: str,
detail_ref: MonkeyFindingDetails) -> Finding:
monkey_finding = MonkeyFinding(test=test,
status=status,
details=detail_ref)
monkey_finding.save()
return monkey_finding

10
monkey/monkey_island/cc/models/zero_trust/scoutsuite_finding.py
View File

@ -6,13 +6,3 @@ from monkey_island.cc.models.zero_trust.scoutsuite_finding_details import ScoutS
class ScoutSuiteFinding(Finding): class ScoutSuiteFinding(Finding):
details = LazyReferenceField(ScoutSuiteFindingDetails, required=True) details = LazyReferenceField(ScoutSuiteFindingDetails, required=True)
@staticmethod
def save_finding(test: str,
status: str,
detail_ref: ScoutSuiteFindingDetails) -> Finding:
scoutsuite_finding = ScoutSuiteFinding(test=test,
status=status,
details=detail_ref)
scoutsuite_finding.save()
return scoutsuite_finding