p20319658
/
monkey
forked from p34709852/monkey
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

UT: Remove patch_get_agent_id() 

1. This fixture was never actually executing
2. get_agent_id() always returns the same value (per process). This
   means that _get_ping_scan_event() and the ping scanner will receive
   the same value for any given test. In other words, mocking it is
   unnecessary.
This commit is contained in:
Mike Salvatore 2022-09-29 07:39:57 -04:00
parent 03ebdd461f
commit 2ab86fa428
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
monkey/tests/unit_tests/infection_monkey/network_scanning/test_ping_scanner.py
View File

@ -1,7 +1,6 @@
import math import math
import subprocess import subprocess
from unittest.mock import MagicMock from unittest.mock import MagicMock
from uuid import UUID
import pytest import pytest
@ -56,11 +55,6 @@ ttl=2d2!
""" """
@pytest.fixture(scope="module")
def patch_get_agent_id(monkeypatch):
monkeypatch.setattr("get_agent_id", lambda: UUID("9919520c-8650-4a39-aa1e-b2f4d1445159"))
TIMESTAMP = 123.321 TIMESTAMP = 123.321