Agent: Add TODO to Propagator

This commit is contained in:
Mike Salvatore 2021-12-13 14:21:04 -05:00
parent 2dc6e0600d
commit 7e3945dd02
1 changed files with 4 additions and 0 deletions

View File

@ -90,6 +90,10 @@ class Propagator:
@staticmethod
def _process_fingerprinter_results(victim_host: VictimHost, fingerprint_data: FingerprintData):
for fd in fingerprint_data.values():
# TODO: This logic preserves the existing behavior prior to introducing IMaster and
# IPuppet, but it is possibly flawed. Different fingerprinters may detect
# different os types or versions, and this logic isn't sufficient to handle those
# conflicts. Reevaluate this logic when we overhaul our scanners/fingerprinters.
if fd.os_type is not None:
victim_host.os["type"] = fd.os_type