From 4bbac5341866a2c0c72b218cebff55911d08bec1 Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 10:09:33 +0100 Subject: [PATCH 01/16] Swimm: Remove add to configuration unit --- .swm/AzD8XysWg1BBXCjCDkfq.swm | 67 ----------------------------------- 1 file changed, 67 deletions(-) delete mode 100644 .swm/AzD8XysWg1BBXCjCDkfq.swm diff --git a/.swm/AzD8XysWg1BBXCjCDkfq.swm b/.swm/AzD8XysWg1BBXCjCDkfq.swm deleted file mode 100644 index 3339f5178..000000000 --- a/.swm/AzD8XysWg1BBXCjCDkfq.swm +++ /dev/null @@ -1,67 +0,0 @@ -{ - "id": "AzD8XysWg1BBXCjCDkfq", - "name": "Add a new configuration setting to the Agent ⚙", - "task": { - "dod": "Make the max victim number that Monkey will find before stopping configurable by the user instead of constant.", - "tests": [], - "hints": [ - "Look for `victims_max_exploit` - it's rather similar." - ] - }, - "content": [ - { - "type": "text", - "text": "# Make something configurable\n\nIn this unit, you will learn how to add a configuration option to Monkey and how to use it in the Monkey Agent code. \n\n![computer fire](https://media.giphy.com/media/7J4P7cUur2DlErijp3/giphy.gif \"computer fire\")\n\n## Why is this important?\n\nEnabling users to configure the Monkey's behaviour gives them a lot more freedom in how they want to use the Monkey and enables more use cases.\n\n## What is \"Max victims to find\"?\n\nThe Monkey has a function which finds \"victim\" machines on the network for the Monkey to try and exploit. It's called `get_victim_machines`. This function accepts an argument which limits how many machines the Monkey should find.\n\nWe want to make that value editable by the user instead of constant in the code.\n\n## Manual testing\n\n1. After you've performed the required changes, reload the Server and check your value exists in the Internal tab of the config (see image).\n\n![](https://i.imgur.com/e0XAxuV.png)\n\n2. Set the new value to 1, and run Monkey locally (from source). See that the Monkey only scans one machine." - }, - { - "type": "snippet", - "path": "monkey/infection_monkey/config.py", - "comments": [], - "firstLineNumber": 103, - "lines": [ - " exploiter_classes = []", - " system_info_collector_classes = []", - " ", - "* # how many victims to look for in a single scan iteration", - "* victims_max_find = 100", - " ", - " # how many victims to exploit before stopping", - " victims_max_exploit = 100" - ] - }, - { - "type": "snippet", - "path": "monkey/monkey_island/cc/services/config_schema/internal.py", - "comments": [], - "firstLineNumber": 28, - "lines": [ - " \"title\": \"Monkey\",", - " \"type\": \"object\",", - " \"properties\": {", - "* \"victims_max_find\": {", - "* \"title\": \"Max victims to find\",", - "* \"type\": \"integer\",", - "* \"default\": 100,", - "* \"description\": \"Determines the maximum number of machines the monkey is \"", - "* \"allowed to scan\",", - "* },", - " \"victims_max_exploit\": {", - " \"title\": \"Max victims to exploit\",", - " \"type\": \"integer\"," - ] - }, - { - "type": "text", - "text": "* When changing config schema by adding or deleting keys, you need to update the Blackbox Test configurations as well [here](https://github.com/guardicore/monkey/tree/develop/envs/monkey_zoo/blackbox/config_templates)." - } - ], - "symbols": {}, - "file_version": "2.0.3", - "meta": { - "app_version": "0.6.6-2", - "file_blobs": { - "monkey/infection_monkey/config.py": "8f4984ba6563564343282765ab498efca5d89ba8", - "monkey/monkey_island/cc/services/config_schema/internal.py": "86318eaf19b9991a8af5de861a3eb085238e17a4" - } - } -} From 4eca5b5a97f1861180940abd9e99aa2f70752366 Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 10:11:46 +0100 Subject: [PATCH 02/16] Agent: Remove max victims to find option --- monkey/infection_monkey/config.py | 3 --- monkey/infection_monkey/example.conf | 1 - 2 files changed, 4 deletions(-) diff --git a/monkey/infection_monkey/config.py b/monkey/infection_monkey/config.py index 557ecdf0f..9cde95491 100644 --- a/monkey/infection_monkey/config.py +++ b/monkey/infection_monkey/config.py @@ -103,9 +103,6 @@ class Configuration(object): exploiter_classes = [] system_info_collector_classes = [] - # how many victims to look for in a single scan iteration - victims_max_find = 100 - # how many victims to exploit before stopping victims_max_exploit = 100 diff --git a/monkey/infection_monkey/example.conf b/monkey/infection_monkey/example.conf index 8468b1422..d057b07a6 100644 --- a/monkey/infection_monkey/example.conf +++ b/monkey/infection_monkey/example.conf @@ -74,7 +74,6 @@ 8088 ], "victims_max_exploit": 100, - "victims_max_find": 100, "post_breach_actions": [] custom_PBA_linux_cmd = "" custom_PBA_windows_cmd = "" From ba34f775aed1c52f75bb02b630eed056aa8d5d73 Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 10:12:29 +0100 Subject: [PATCH 03/16] Island: Remove max victims to find option --- monkey/monkey_island/cc/services/config_schema/internal.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/monkey/monkey_island/cc/services/config_schema/internal.py b/monkey/monkey_island/cc/services/config_schema/internal.py index 5b6f44660..1a2e938d4 100644 --- a/monkey/monkey_island/cc/services/config_schema/internal.py +++ b/monkey/monkey_island/cc/services/config_schema/internal.py @@ -21,13 +21,6 @@ INTERNAL = { "title": "Monkey", "type": "object", "properties": { - "victims_max_find": { - "title": "Max victims to find", - "type": "integer", - "default": 100, - "description": "Determines the maximum number of machines the monkey is " - "allowed to scan", - }, "victims_max_exploit": { "title": "Max victims to exploit", "type": "integer", From f0e06274c6e28000cb0a62e8b214a0af90591315 Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 10:13:02 +0100 Subject: [PATCH 04/16] UT: Remove max victims to find option from configs --- monkey/tests/data_for_tests/monkey_configs/flat_config.json | 3 +-- .../data_for_tests/monkey_configs/monkey_config_standard.json | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/monkey/tests/data_for_tests/monkey_configs/flat_config.json b/monkey/tests/data_for_tests/monkey_configs/flat_config.json index 0b9f63b84..61f601bca 100644 --- a/monkey/tests/data_for_tests/monkey_configs/flat_config.json +++ b/monkey/tests/data_for_tests/monkey_configs/flat_config.json @@ -123,6 +123,5 @@ 8088 ], "user_to_add": "Monkey_IUSER_SUPPORT", - "victims_max_exploit": 100, - "victims_max_find": 100 + "victims_max_exploit": 100 } diff --git a/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json b/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json index 3f875009a..d2550567f 100644 --- a/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json +++ b/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json @@ -47,7 +47,6 @@ "keep_tunnel_open_time": 60 }, "monkey": { - "victims_max_find": 100, "victims_max_exploit": 100, "alive": true, "aws_keys": { From b02d277e55d3697a4ff6dc58bf6f059167937145 Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 11:34:51 +0100 Subject: [PATCH 05/16] Agent: Remove max victims to exploit option --- monkey/infection_monkey/config.py | 3 --- monkey/infection_monkey/example.conf | 1 - 2 files changed, 4 deletions(-) diff --git a/monkey/infection_monkey/config.py b/monkey/infection_monkey/config.py index 9cde95491..356a15979 100644 --- a/monkey/infection_monkey/config.py +++ b/monkey/infection_monkey/config.py @@ -103,9 +103,6 @@ class Configuration(object): exploiter_classes = [] system_info_collector_classes = [] - # how many victims to exploit before stopping - victims_max_exploit = 100 - # depth of propagation depth = 2 max_depth = None diff --git a/monkey/infection_monkey/example.conf b/monkey/infection_monkey/example.conf index d057b07a6..6d0780456 100644 --- a/monkey/infection_monkey/example.conf +++ b/monkey/infection_monkey/example.conf @@ -73,7 +73,6 @@ 7001, 8088 ], - "victims_max_exploit": 100, "post_breach_actions": [] custom_PBA_linux_cmd = "" custom_PBA_windows_cmd = "" From 9fa489b0467f7a2c004c26cf4e6f8bc28a6c87c2 Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 11:35:57 +0100 Subject: [PATCH 06/16] Island: Remove max victims to find options --- .../cc/services/config_schema/internal.py | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/monkey/monkey_island/cc/services/config_schema/internal.py b/monkey/monkey_island/cc/services/config_schema/internal.py index 1a2e938d4..f7e9f12f1 100644 --- a/monkey/monkey_island/cc/services/config_schema/internal.py +++ b/monkey/monkey_island/cc/services/config_schema/internal.py @@ -1,5 +1,3 @@ -from monkey_island.cc.services.utils.typographic_symbols import WARNING_SIGN - INTERNAL = { "title": "Internal", "type": "object", @@ -21,17 +19,6 @@ INTERNAL = { "title": "Monkey", "type": "object", "properties": { - "victims_max_exploit": { - "title": "Max victims to exploit", - "type": "integer", - "default": 100, - "description": "Determines the maximum number of machines the monkey" - " is allowed to successfully exploit. " - + WARNING_SIGN - + " Note that setting this value too high may result in the " - "monkey propagating to " - "a high number of machines", - }, "alive": { "title": "Alive", "type": "boolean", From ea08e2c420577c28d9615a1d1921f3dc35c3ff9e Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 11:36:22 +0100 Subject: [PATCH 07/16] UT: Remove max victims to exploit from configs --- monkey/tests/data_for_tests/monkey_configs/flat_config.json | 3 +-- .../data_for_tests/monkey_configs/monkey_config_standard.json | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/monkey/tests/data_for_tests/monkey_configs/flat_config.json b/monkey/tests/data_for_tests/monkey_configs/flat_config.json index 61f601bca..a6ec1dcd4 100644 --- a/monkey/tests/data_for_tests/monkey_configs/flat_config.json +++ b/monkey/tests/data_for_tests/monkey_configs/flat_config.json @@ -122,6 +122,5 @@ 7001, 8088 ], - "user_to_add": "Monkey_IUSER_SUPPORT", - "victims_max_exploit": 100 + "user_to_add": "Monkey_IUSER_SUPPORT" } diff --git a/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json b/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json index d2550567f..ac3af0f23 100644 --- a/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json +++ b/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json @@ -47,7 +47,6 @@ "keep_tunnel_open_time": 60 }, "monkey": { - "victims_max_exploit": 100, "alive": true, "aws_keys": { "aws_access_key_id": "", From b9219e37839f610faa83f07abccb7a2ae664c57e Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 11:53:24 +0100 Subject: [PATCH 08/16] Agent: Remove tcp scan interval option --- monkey/infection_monkey/config.py | 1 - monkey/infection_monkey/example.conf | 1 - monkey/infection_monkey/network/network_scanner.py | 4 ---- 3 files changed, 6 deletions(-) diff --git a/monkey/infection_monkey/config.py b/monkey/infection_monkey/config.py index 356a15979..49f2b0c71 100644 --- a/monkey/infection_monkey/config.py +++ b/monkey/infection_monkey/config.py @@ -136,7 +136,6 @@ class Configuration(object): tcp_target_ports = [22, 2222, 445, 135, 3389, 80, 8080, 443, 8008, 3306, 9200] tcp_target_ports.extend(HTTP_PORTS) tcp_scan_timeout = 3000 # 3000 Milliseconds - tcp_scan_interval = 0 # in milliseconds tcp_scan_get_banner = True # Ping Scanner diff --git a/monkey/infection_monkey/example.conf b/monkey/infection_monkey/example.conf index 6d0780456..322171399 100644 --- a/monkey/infection_monkey/example.conf +++ b/monkey/infection_monkey/example.conf @@ -57,7 +57,6 @@ "exploit_ssh_keys": [], "local_network_scan": false, "tcp_scan_get_banner": true, - "tcp_scan_interval": 0, "tcp_scan_timeout": 10000, "tcp_target_ports": [ 22, diff --git a/monkey/infection_monkey/network/network_scanner.py b/monkey/infection_monkey/network/network_scanner.py index c7e39909e..340763957 100644 --- a/monkey/infection_monkey/network/network_scanner.py +++ b/monkey/infection_monkey/network/network_scanner.py @@ -1,5 +1,4 @@ import logging -import time from multiprocessing.dummy import Pool from common.network.network_range import NetworkRange @@ -108,9 +107,6 @@ class NetworkScanner(object): if victims_count >= max_find: logger.debug("Found max needed victims (%d), stopping scan", max_find) return - if WormConfiguration.tcp_scan_interval: - # time.sleep uses seconds, while config is in milliseconds - time.sleep(WormConfiguration.tcp_scan_interval / float(1000)) @staticmethod def _is_any_ip_in_subnet(ip_addresses, subnet_str): From c2e76b6462bdc78f07e44e6f0881e32b2089fd4f Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 11:55:03 +0100 Subject: [PATCH 09/16] Island: Remove tcp scan interval option --- monkey/monkey_island/cc/services/config_schema/internal.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/monkey/monkey_island/cc/services/config_schema/internal.py b/monkey/monkey_island/cc/services/config_schema/internal.py index f7e9f12f1..7c5777476 100644 --- a/monkey/monkey_island/cc/services/config_schema/internal.py +++ b/monkey/monkey_island/cc/services/config_schema/internal.py @@ -96,12 +96,6 @@ INTERNAL = { "description": "List of TCP ports the monkey will check whether " "they're open", }, - "tcp_scan_interval": { - "title": "TCP scan interval", - "type": "integer", - "default": 0, - "description": "Time to sleep (in milliseconds) between scans", - }, "tcp_scan_timeout": { "title": "TCP scan timeout", "type": "integer", From 210e981f7e01d939a6163f9d44ce20d8e3f120c5 Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 11:55:53 +0100 Subject: [PATCH 10/16] UT: Remove tcp scan interval option from configs --- monkey/tests/data_for_tests/monkey_configs/flat_config.json | 1 - .../data_for_tests/monkey_configs/monkey_config_standard.json | 1 - 2 files changed, 2 deletions(-) diff --git a/monkey/tests/data_for_tests/monkey_configs/flat_config.json b/monkey/tests/data_for_tests/monkey_configs/flat_config.json index a6ec1dcd4..e6f70929f 100644 --- a/monkey/tests/data_for_tests/monkey_configs/flat_config.json +++ b/monkey/tests/data_for_tests/monkey_configs/flat_config.json @@ -106,7 +106,6 @@ "MimikatzCollector" ], "tcp_scan_get_banner": true, - "tcp_scan_interval": 0, "tcp_scan_timeout": 3000, "tcp_target_ports": [ 22, diff --git a/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json b/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json index ac3af0f23..f64a348e5 100644 --- a/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json +++ b/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json @@ -86,7 +86,6 @@ 7001, 8088 ], - "tcp_scan_interval": 0, "tcp_scan_timeout": 3000, "tcp_scan_get_banner": true }, From c78b89d43d999cd3883b8bec33b0de66bea3b433 Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 12:15:25 +0100 Subject: [PATCH 11/16] Agent: Remove tcp scan get banner option --- monkey/infection_monkey/config.py | 1 - monkey/infection_monkey/example.conf | 1 - monkey/infection_monkey/network/tools.py | 7 +++---- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/monkey/infection_monkey/config.py b/monkey/infection_monkey/config.py index 49f2b0c71..81c6a9996 100644 --- a/monkey/infection_monkey/config.py +++ b/monkey/infection_monkey/config.py @@ -136,7 +136,6 @@ class Configuration(object): tcp_target_ports = [22, 2222, 445, 135, 3389, 80, 8080, 443, 8008, 3306, 9200] tcp_target_ports.extend(HTTP_PORTS) tcp_scan_timeout = 3000 # 3000 Milliseconds - tcp_scan_get_banner = True # Ping Scanner ping_scan_timeout = 1000 diff --git a/monkey/infection_monkey/example.conf b/monkey/infection_monkey/example.conf index 322171399..6c2bc3235 100644 --- a/monkey/infection_monkey/example.conf +++ b/monkey/infection_monkey/example.conf @@ -56,7 +56,6 @@ "exploit_ntlm_hash_list": [], "exploit_ssh_keys": [], "local_network_scan": false, - "tcp_scan_get_banner": true, "tcp_scan_timeout": 10000, "tcp_target_ports": [ 22, diff --git a/monkey/infection_monkey/network/tools.py b/monkey/infection_monkey/network/tools.py index 9d6878cb9..4bb9f8020 100644 --- a/monkey/infection_monkey/network/tools.py +++ b/monkey/infection_monkey/network/tools.py @@ -76,14 +76,13 @@ def check_tcp_port(ip, port, timeout=DEFAULT_TIMEOUT, get_banner=False): return True, banner -def check_tcp_ports(ip, ports, timeout=DEFAULT_TIMEOUT, get_banner=False): +def check_tcp_ports(ip, ports, timeout=DEFAULT_TIMEOUT): """ Checks whether any of the given ports are open on a target IP. :param ip: IP of host to attack :param ports: List of ports to attack. Must not be empty. :param timeout: Amount of time to wait for connection - :param get_banner: T/F if to get first packets from server - :return: list of open ports. If get_banner=True, then a matching list of banners. + :return: List of open ports. """ sockets = [socket.socket(socket.AF_INET, socket.SOCK_STREAM) for _ in range(len(ports))] [s.setblocking(False) for s in sockets] @@ -130,7 +129,7 @@ def check_tcp_ports(ip, ports, timeout=DEFAULT_TIMEOUT, get_banner=False): % (str(ip), ",".join([str(s[0]) for s in connected_ports_sockets])) ) banners = [] - if get_banner and (len(connected_ports_sockets) != 0): + if len(connected_ports_sockets) != 0: readable_sockets, _, _ = select.select( [s[1] for s in connected_ports_sockets], [], [], 0 ) From 79362dd0660997c75dd2a40a427c79bf6c1e924a Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 12:16:12 +0100 Subject: [PATCH 12/16] Island: Remove tcp scan get banner checkbox --- monkey/monkey_island/cc/services/config_schema/internal.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/monkey/monkey_island/cc/services/config_schema/internal.py b/monkey/monkey_island/cc/services/config_schema/internal.py index 7c5777476..4f40a2ee9 100644 --- a/monkey/monkey_island/cc/services/config_schema/internal.py +++ b/monkey/monkey_island/cc/services/config_schema/internal.py @@ -103,13 +103,6 @@ INTERNAL = { "description": "Maximum time (in milliseconds) " "to wait for TCP response", }, - "tcp_scan_get_banner": { - "title": "TCP scan - get banner", - "type": "boolean", - "default": True, - "description": "Determines whether the TCP scan should try to get the " - "banner", - }, }, }, "ping_scanner": { From 746d46c326980b2b3094b2fb9b07c3d15650e7f9 Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 12:17:00 +0100 Subject: [PATCH 13/16] UT: Remove tcp_scan_get_banner option from config --- monkey/tests/data_for_tests/monkey_configs/flat_config.json | 1 - .../data_for_tests/monkey_configs/monkey_config_standard.json | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/monkey/tests/data_for_tests/monkey_configs/flat_config.json b/monkey/tests/data_for_tests/monkey_configs/flat_config.json index e6f70929f..977bed817 100644 --- a/monkey/tests/data_for_tests/monkey_configs/flat_config.json +++ b/monkey/tests/data_for_tests/monkey_configs/flat_config.json @@ -105,7 +105,6 @@ "ProcessListCollector", "MimikatzCollector" ], - "tcp_scan_get_banner": true, "tcp_scan_timeout": 3000, "tcp_target_ports": [ 22, diff --git a/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json b/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json index f64a348e5..fc9f2bb05 100644 --- a/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json +++ b/monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json @@ -86,8 +86,7 @@ 7001, 8088 ], - "tcp_scan_timeout": 3000, - "tcp_scan_get_banner": true + "tcp_scan_timeout": 3000 }, "ping_scanner": { "ping_scan_timeout": 1000 From 252bb4fcf8966b3b52b84106a88b39e1e0da6be6 Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 13:56:54 +0100 Subject: [PATCH 14/16] Island: Remove monkey tab from configuration internal --- .../ui/src/components/configuration-components/InternalConfig.js | 1 - 1 file changed, 1 deletion(-) diff --git a/monkey/monkey_island/cc/ui/src/components/configuration-components/InternalConfig.js b/monkey/monkey_island/cc/ui/src/components/configuration-components/InternalConfig.js index 70f1e86fa..d7d13db54 100644 --- a/monkey/monkey_island/cc/ui/src/components/configuration-components/InternalConfig.js +++ b/monkey/monkey_island/cc/ui/src/components/configuration-components/InternalConfig.js @@ -4,7 +4,6 @@ import {Nav} from 'react-bootstrap'; const sectionOrder = [ 'network', - 'monkey', 'island_server', 'logging', 'exploits', From 654ff38ea0ce0e95189a8eeb87f81a916a22b706 Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 14:03:37 +0100 Subject: [PATCH 15/16] Changelog: Add entry for removing unneeded options in internal config. --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 02f2301a6..4d0c05451 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,7 @@ Changelog](https://keepachangelog.com/en/1.0.0/). - MITRE ATT&CK configuration screen. #1532 - Propagation credentials from "GET /api/monkey/" endpoint. #1538 - "GET /api/monkey_control/check_remote_port/" endpoint. #1635 +- Max victims to find/exploit, TCP scan interval and TCP scan get banner internal options. #1597 - MySQL fingerprinter. #1648 ### Fixed From 0bf7067cea29403d44597daa91db442dec79a16f Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Tue, 14 Dec 2021 15:19:59 +0100 Subject: [PATCH 16/16] UI: Remove monkey section from UI schema --- .../src/components/configuration-components/UiSchema.js | 8 -------- .../cc/ui/src/styles/pages/ConfigurationPage.scss | 4 ---- 2 files changed, 12 deletions(-) diff --git a/monkey/monkey_island/cc/ui/src/components/configuration-components/UiSchema.js b/monkey/monkey_island/cc/ui/src/components/configuration-components/UiSchema.js index cd24fc040..39bb47827 100644 --- a/monkey/monkey_island/cc/ui/src/components/configuration-components/UiSchema.js +++ b/monkey/monkey_island/cc/ui/src/components/configuration-components/UiSchema.js @@ -123,14 +123,6 @@ export default function UiSchema(props) { 'ui:widget': AdvancedMultiSelect } }, - monkey: { - alive: { - classNames: 'config-field-hidden' - }, - aws_keys: { - classNames: 'config-field-hidden' - } - }, exploits: { exploit_lm_hash_list:{ items: { diff --git a/monkey/monkey_island/cc/ui/src/styles/pages/ConfigurationPage.scss b/monkey/monkey_island/cc/ui/src/styles/pages/ConfigurationPage.scss index 18e09d37b..22f396b56 100644 --- a/monkey/monkey_island/cc/ui/src/styles/pages/ConfigurationPage.scss +++ b/monkey/monkey_island/cc/ui/src/styles/pages/ConfigurationPage.scss @@ -49,10 +49,6 @@ font-size: 1.2em; } -.config-field-hidden { - display: none; -} - .field-description { white-space: pre-wrap; }