From a11d1d5f1e424586c944ed85f9ab5a830eaf013a Mon Sep 17 00:00:00 2001 From: Ilija Lazoroski Date: Wed, 6 Oct 2021 18:10:46 +0200 Subject: [PATCH] Agent: Changed note message for proxy schema --- monkey/infection_monkey/control.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/monkey/infection_monkey/control.py b/monkey/infection_monkey/control.py index ec153f418..f026584ca 100644 --- a/monkey/infection_monkey/control.py +++ b/monkey/infection_monkey/control.py @@ -121,9 +121,12 @@ class ControlClient(object): @staticmethod def set_proxies(proxy_find): """ - Note: Proxy schema changes! When upgrading to newer python version or - when urllib3 and requests are updated there is possibility that the proxy - schema is changed. + Note: Proxy schema changes which causes the machine to not open a tunnel back. + If we get "ValueError: check_hostname requires server_hostname" or + "Proxy URL had not schema, should start with http:// or https://" errors, + the proxy schema needs to be changed. + Keep this in mind when upgrading to newer python version or when urllib3 and + requests are updated there is possibility that the proxy schema is changed. https://github.com/psf/requests/issues/5297 https://github.com/psf/requests/issues/5855 """