p20319658
/
monkey
forked from p34709852/monkey
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Moved handle close to finally block

This commit is contained in:
Shay Nehmad 2019-09-16 14:54:02 +03:00
parent b8f48d3542
commit bc94e5854a
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
monkey/infection_monkey/post_breach/actions/communicate_as_new_user.py
View File

@ -106,10 +106,6 @@ class CommunicateAsNewUser(PBA):
time.sleep(1) time.sleep(1)
self.send_ping_result_telemetry(ping_exit_code, commandline, username) self.send_ping_result_telemetry(ping_exit_code, commandline, username)
win32api.CloseHandle(process_handle) # Process handle
win32api.CloseHandle(thread_handle) # Thread handle
except Exception as e: except Exception as e:
# TODO: if failed on 1314, we can try to add elevate the rights of the current user with the # TODO: if failed on 1314, we can try to add elevate the rights of the current user with the
# "Replace a process level token" right, using Local Security Policy editing. Worked, but only # "Replace a process level token" right, using Local Security Policy editing. Worked, but only
@ -118,6 +114,12 @@ class CommunicateAsNewUser(PBA):
# 2. need to find how to do this using python... # 2. need to find how to do this using python...
PostBreachTelem(self, ( PostBreachTelem(self, (
"Failed to open process as user {}. Error: {}".format(username, str(e)), False)).send() "Failed to open process as user {}. Error: {}".format(username, str(e)), False)).send()
finally:
try:
win32api.CloseHandle(process_handle)
win32api.CloseHandle(thread_handle)
except Exception as err:
logger.error("Close handle error: " + str(err))
except subprocess.CalledProcessError as err: except subprocess.CalledProcessError as err:
PostBreachTelem(self, ( PostBreachTelem(self, (
"Couldn't create the user '{}'. Error output is: '{}'".format(username, str(err)), "Couldn't create the user '{}'. Error output is: '{}'".format(username, str(err)),