From c16c6456aa33dd6c4e15f9ff1b89de36f70cb354 Mon Sep 17 00:00:00 2001 From: Shreya Malviya Date: Tue, 6 Sep 2022 19:41:59 +0530 Subject: [PATCH] Island: Remove unneeded comments from PyPubSubIslandEventQueue --- .../cc/event_queue/pypubsub_island_event_queue.py | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/monkey/monkey_island/cc/event_queue/pypubsub_island_event_queue.py b/monkey/monkey_island/cc/event_queue/pypubsub_island_event_queue.py index 478228d72..e18c12f2a 100644 --- a/monkey/monkey_island/cc/event_queue/pypubsub_island_event_queue.py +++ b/monkey/monkey_island/cc/event_queue/pypubsub_island_event_queue.py @@ -16,22 +16,9 @@ class PyPubSubIslandEventQueue(IIslandEventQueue): def subscribe(self, topic: IslandEventTopic, subscriber: IslandEventSubscriber): topic_name = topic.name # needs to be a string for pypubsub - - # NOTE: The subscriber's signature needs to match the MDS (message data specification) of - # the topic, otherwise, errors will arise. The MDS of a topic is set when the topic - # is created, which in our case is when a subscriber subscribes to a topic which - # is new (hasn't been subscribed to before). If the topic is being subscribed to by - # a subscriber for the first time, the topic's MDS will automatically be set - # according to that subscriber's signature. self._pypubsub_publisher_wrapped.subscribe(topic_name, subscriber) def publish(self, topic: IslandEventTopic, event: Any = None): topic_name = topic.name # needs to be a string for pypubsub - logger.debug(f"Publishing {topic_name} event") - - # NOTE: `event_data` needs to match the MDS (message data specification) of the topic, - # otherwise, errors will arise. The MDS of a topic is set when the topic is created, - # which in our case is when a subscriber subscribes to a topic (in `subscribe()`) - # which is new (hasn't been subscribed to before). self._pypubsub_publisher_wrapped.publish(topic_name, event)